kfree(p);
if you used devm_, you can remove kfree() / free_irq() / iounmap() here
> +err0:
> + return ret;
> +}
> +
> +static int intc_irqpin_remove(struct platform_device *pdev)
> +{
> + struct intc_irqpin_priv *p = platform_get_drvdata(pdev);
> + int k;
> +
&
e
> make[1]: *** [drivers/thermal/rcar_thermal.o] Error 1
> make: *** [drivers/thermal/rcar_thermal.o] Error 2
>
> with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
>
> Signed-off-by: Devendra Naga
> ---
Acked-by: Kuninori Morimoto
Best regards
---
Kuninori Morimoto
--
To
obe() warn: variable dereferenced\
before check 'pdata' (see line 292)
drivers/gpio/gpio-pcf857x.c:421 pcf857x_remove() error: we previously\
assumed 'pdata' could be null (see line 410)
This patch fixes it
Reported-by: Fengguang Wu
Signed-off-by: Kuninori Mo
devm_kfree and devm_iounmap should not have to be explicitly used
Signed-off-by: Kuninori Morimoto
---
This patch is based on Devendra's
[PATCH] thermal: solve compilation errors in rcar_thermal
drivers/thermal/rcar_thermal.c | 18 ++
1 file changed, 2 insertions(+
Hi all
These are "resend" of genirq export patches.
Kuninori Morimoto (2):
genirq: export irq_set_chip_and_handler_name()
genirq: export dummy_irq_chip
>
> Hi Thomas
>
> Could you please teach me current status of these patches ?
>
> Kuninori
s a module.
Signed-off-by: Kuninori Morimoto
---
kernel/irq/chip.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index eebd6d5..57d86d0 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -671,6 +671,7 @@ irq_set_chip_and_ha
.ko] undefined!
when gpio-pcf857x.c is being built as a module.
Signed-off-by: Kuninori Morimoto
---
kernel/irq/dummychip.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c
index b5fcd96..988dc58 100644
--- a/kernel/irq/dum
&rcar_thermal_zone_ops, 0, 0);
> if (IS_ERR(zone)) {
> dev_err(&pdev->dev, "thermal zone device is NULL\n");
> --
> 1.7.9.5
>
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: sen
From: Devendra Naga
following were the errors reported
drivers/thermal/rcar_thermal.c: In function ‘rcar_thermal_probe’:
drivers/thermal/rcar_thermal.c:214:10: warning: passing argument 3 of
‘thermal_zone_device_register’ makes integer from pointer without a cast
[enabled by default]
include/l
ch applied, unless Kuninori has some objections.
Acked-by: Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
re about it (block/non-block),
and caller don't care it, is nice point of this function...
For example, SSI device have many ports (0-8),
but ADG is only 1 device.
On this driver, all devices are using rsnd_write/read() to
access register.
I can re-check it, but it will be next week
Thank y
threaded_irq
> gpio: pcf857x: remove the irq_demux_work and gpio->irq
> gpio: pcf857x: call the gpio user handler iff gpio_to_irq is done
>
> drivers/gpio/gpio-pcf857x.c | 53
> ++---
> 1 file changed, 26 insertions(+), 27 deletion
that regmap_filelds is good naming or not.
Please let me know if you have good naming idea.
These are based on below branchs
regmap/for-next + asoc/for-next
Kuninori Morimoto (4):
regmap: add regmap_field_update_bits()
regmap: Add regmap_fields APIs
ASoC: rsnd: gen: rsnd_ge
Current regmap_field is supporting read/write functions.
This patch adds new update_bits function for it.
Signed-off-by: Kuninori Morimoto
---
drivers/base/regmap/regmap.c | 20
include/linux/regmap.h |2 ++
2 files changed, 22 insertions(+)
diff --git a
API needs many regmap_field for such device,
but it is not good.
This patch adds new regmap_fileds API which can care
about multi port/offset access via regmap.
Signed-off-by: Kuninori Morimoto
---
drivers/base/regmap/internal.h |3 ++
drivers/base/regmap/regmap.c | 97
Current rsnd_gen_ops didn't care about .probe and .remove
functions, but it was not good sense.
This patch tidyup it
Signed-off-by: Kuninori Morimoto
---
sound/soc/sh/rcar/gen.c | 41 -
1 file changed, 24 insertions(+), 17 deletions(-)
diff --
Current Linux kernel is supporting regmap/regmap_field,
and, it is good match for Renesas Sound Gen1/Gen2 register mapping.
This patch uses regmap instead of original method for register access
Signed-off-by: Kuninori Morimoto
---
sound/soc/sh/rcar/core.c | 45 -
sound/soc/sh/rcar
t-controller;
> #interrupt-cells = <2>;
I'm not sure detail,
but does above "exchange interrupt-parent" and "using
devm_request_threaded_irq()"
have any relationship ?
Separate patch seems nice ?
Best regards
---
Kuninori Morimoto
--
To unsubscribe from
access is
> only its address offset.
>
> Current API needs many regmap_field for such device,
> but it is not good.
> This patch adds new regmap_fileds API which can care
> about multi port/offset access via regmap.
>
> Signed-off-by: Kuninori Morimoto
I noticed that this
e let me know if you have good naming idea.
The difference between v1 <-> v2 is EXPORT_SYMBOL_GPL() naming
on regmap_filelds
these are based on below branchs
regmap/for-next + asoc/for-next
Kuninori Morimoto (4):
regmap: add regmap_field_update_bits()
regmap: Add regmap_
Current regmap_field is supporting read/write functions.
This patch adds new update_bits function for it.
Signed-off-by: Kuninori Morimoto
---
v1 -> v2
- fixup EXPORT_SYMBOL_GPL() naming
drivers/base/regmap/regmap.c | 20
include/linux/regmap.h |2 ++
2 fi
needs many regmap_field for such device,
but it is not good.
This patch adds new regmap_fileds API which can care
about multi port/offset access via regmap.
Signed-off-by: Kuninori Morimoto
---
v1 -> v2
- fixup EXPORT_SYMBOL_GPL() naming
drivers/base/regmap/internal.h |3 ++
drivers/b
Current rsnd_gen_ops didn't care about .probe and .remove
functions, but it was not good sense.
This patch tidyup it
Signed-off-by: Kuninori Morimoto
---
v1 -> v2
- no change
sound/soc/sh/rcar/gen.c | 41 -
1 file changed, 24 insertion
Current Linux kernel is supporting regmap/regmap_field,
and, it is good match for Renesas Sound Gen1/Gen2 register mapping.
This patch uses regmap instead of original method for register access
Signed-off-by: Kuninori Morimoto
---
v1 -> v2
- exchange macro naming (RSND_GEN1_S_
> +++--
> 1 file changed, 26 insertions(+), 25 deletions(-)
Basically, I have no objection about these patches,
but I have 2 opinions
- I guess we can merge #1 and #2 patches ?
("as is" is very OK for me though)
- we don't need gpio->
heck
> something in the module structure rather than asking regmap.
OK, new patch uses only "fields" access by using offset = 0.
then, un-needed rsnd_priv_read/write/bset() are removed by 1st patch.
Kuninori Morimoto (2):
ASoC: rsnd: remove rsnd_priv_read/write/bset()
ASoC: rs
Current Linux kernel is supporting regmap/regmap_field,
and, it is good match for Renesas Sound Gen1/Gen2 register mapping.
This patch uses regmap instead of original method for register access
Signed-off-by: Kuninori Morimoto
---
sound/soc/sh/rcar/core.c | 45 --
sound/soc/sh/rcar
adg.c only used rsnd_priv_read/write/bset()
which is the only user of NULL mod.
but, it can be removed.
Signed-off-by: Kuninori Morimoto
---
sound/soc/sh/rcar/adg.c | 10 +++---
sound/soc/sh/rcar/rsnd.h |4
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc
cumentation and implementation in one patch,
and dts in other patch, are normal style IMO
I mean
4/6 + 5/6's implementation part,
5/6's dts part
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a messag
#x27;
Signed-off-by: Devendra Naga
Signed-off-by: Kuninori Morimoto
---
for linus/master branch
drivers/thermal/rcar_thermal.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index b13fe5d..762f637 100644
--- a/dr
on too.
This patch is tested on kzm9g board
Reported-by: ENGELMAYER Christian christian.engelma...@frequentis.com
Signed-off-by: Kuninori Morimoto
---
>> Simon
This patch modify kzm9g board settings.
Please give your acked-by on this patch
arch/arm/mach-shmobile/board-kzm9g.c |2 +-
drive
Hi
> According to its documentation, clk_get() returns a "valid IS_ERR() condition
> containing errno", so we should call IS_ERR() rather than a NULL check.
>
> Signed-off-by: Cyril Roelandt
Acked-by: Kuninori Morimoto
> ---
> drivers/spi/spi-sh-hspi.c |
Hi Vinod, and all
Cc Guennadi
I need your opinion
Now, my USB driver is using DMAEngine,
but, in "data receive" case, it doesn't know the exact received data size
before DMA starting, since USB device doesn't know how many data will be sent.
Then, (I think) USB driver is using enough size buffer
sh_desc->hw.tcr is controlling data size,
and register TCR is controlling data transfer count
which was xmit_shift'ed value of hw.tcr.
Current sh_dmae_get_partial() is calculating in different unit.
This patch fixes it.
Cc: Guennadi Liakhovetski
Signed-off-by: Kuninori Morimoto
---
>
undants
> error message.
>
> Signed-off-by: Wei Yongjun
> ---
Acked-by: Kuninori Morimoto
> sound/soc/sh/rcar/gen.c | 17 -
> 1 file changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/sound/soc/sh/rcar/gen.c b/sound/soc/sh/rcar/gen.c
> index 5e
gest and difficult is 1) I think.
It needs more discussion how to do 1) ?
But someone (I forgot who is) is already trying to implement it ?
I'm not sure...
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
sh_desc->hw.tcr is controlling real data size,
and, register TCR is controlling data transfer count
which was xmit_shifted value of hw.tcr.
Current sh_dmae_get_partial() is calculating in different unit.
This patch fixes it.
Signed-off-by: Kuninori Morimoto
---
>> Guennadi
Could y
Signed-off-by: Yusuke Goda
Signed-off-by: Kuninori Morimoto
---
drivers/mtd/devices/m25p80.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 5b6b072..058172c 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd
Dear Linus
> > From: Nikolay Balandin
> >
> >
> > Signed-off-by: Nikolay Balandin
>
> Tentatively applied.
>
> Kuninoro, does this look OK?
>
> Yours,
> Linus Walleij
Acked-by: Kuninori Morimoto
Best regards
--
Kuninori Morimoto
--
rcaar_thermal: tidyup thermal_zone_device_register()
parameter
From: Kuninori Morimoto
Date: Tue, 7 Aug 2012 13:32:14 +0900
c56f5c0342dfee11a1a13d2f5bb7618de5b17590
(Thermal: Make Thermal trip points writeable)
added "mask", and
062f7fed5c79b3d2f7274fcd6f05f8c8f2fa5674
(Thermal: Re
s ?
>
> Hm Thomas has to answer to that (and merge the patches, if he
> likes them).
Now, these fixup patches were accepted.
http://git.kernel.org/tip/17d83127d4c2b322dd8f217e0ac08c66eb403779
http://git.kernel.org/tip/b3ae66f209e8929db62b5a5f874ab2cdcf5ef1d4
Could you please re
Yes! I've applied it. Check that it lands nicely in -next.
Thank you !
It works on my board.
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Hi Thomas
Could you please teach me current status of these patches ?
Kuninori Morimoto (2):
genirq: export irq_set_chip_and_handler_name()
genirq: export dummy_irq_chip
At Mon, 9 Jul 2012 22:34:23 +0200,
Linus Walleij wrote:
>
> On Mon, Jul 9, 2012 at 4:04 AM, Kuninori Mo
Hi all
> These are "resend" of genirq export patches.
>
> Kuninori Morimoto (2):
> genirq: export irq_set_chip_and_handler_name()
> genirq: export dummy_irq_chip
get_maintainer.pl showed me that Thomas is the maintainer
of ${LINUX}/kernel/irq/,
but am I wr
This patch add basic Renesas R-Car thermal sensor support.
It was tested on R-Car H1 Marzen board.
Signed-off-by: Kuninori Morimoto
---
drivers/thermal/Kconfig|8 ++
drivers/thermal/Makefile |3 +-
drivers/thermal/rcar_thermal.c | 239
This patch add basic Renesas R-Car thermal sensor support.
It was tested on R-Car H1 Marzen board.
Signed-off-by: Kuninori Morimoto
---
v1 -> v2
- used spin_lock
- added explain of udelay(300)
- used a single space before "="
drivers/thermal/Kconfig|8 ++
dr
c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Acked-by: Kuninori Morimoto
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://v
s the second patch from your patch set.
> >
> > OK. I will, but it will be next week.
> > And could you please show me where is your repository/branch ?
>
> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary
> branch devel/for-next
In my check,
dler_name" \
[drivers/gpio/gpio-pcf857x.ko] undefined!
when gpio-pcf857x.c is being built as a module.
Signed-off-by: Kuninori Morimoto
---
kernel/irq/chip.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index eebd6d5..
.ko] undefined!
when gpio-pcf857x.c is being built as a module.
Signed-off-by: Kuninori Morimoto
---
kernel/irq/dummychip.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c
index b5fcd96..988dc58 100644
--- a/kernel/irq/dum
Hi Khiem-san
Thank you for your patch
> +int _linear_temp_converter(struct equation_coefs coef,
> + int temp_code)
> +{
> + int temp, temp1, temp2;
> +
> + temp1 = MCELSIUS((CODETSD(temp_code) - coef.b1)) / coef.a1;
> + temp2 = MCELSIUS((CODETSD(te
From: Kuninori Morimoto
Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()
Signed-off-by: Kuninori Morimoto
Reviewed-by: Geert Uytterhoeven
---
drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/dr
From: Kuninori Morimoto
rcar-thermal is supporting both thermal_zone_of_sensor_register() and
thermal_zone_device_register(). But thermal_zone_of_sensor_register()
doesn't enable hwmon as default.
This patch enables it to keep compatibility
Signed-off-by: Kuninori Morimoto
---
>&g
headphones are attached.
> - simple-audio-card,mic-det-gpio : Reference to GPIO that signals when
> a microphone is attached.
> +- simple-audio-card,aux-devs : List of phandles pointing to
> auxiliary devices, such
> + as amplifiers, to be added to the
> sound card.
>
> Optional subnodes:
I think it is very helpful if this document has above sample
Best regards
---
Kuninori Morimoto
ed-off-by: Arnd Bergmann
> ---
Sorry about that
Acked-by: Kuninori Morimoto
Hi Jose
Cc: Mark, Thierry, Daniel
> > From: Kuninori Morimoto
> >
> > Current dw-hdmi is supporting sound via AHB bus, but it has
> > I2S audio feature too. This patch adds I2S audio support to dw-hdmi.
> > This HDMI I2S is supported by using ALSA SoC
ta(rtd->dev, rtd);
...
}
But, ASoC has snd_soc_pcm_set/get_drvdata() to set rtd->dev.
It will overwrite existing data and will break system.
This patch tries to solve this issue.
Intel haswell and qcom is using these functions.
** Note **
I don't have these boards, thus, I did c
From: Kuninori Morimoto
snd_soc_pcm_set_drvdata() will set driver data to rtd->dev,
but driver data of rtd->dev is already used as "rtd" on
soc_post_component_init().
static int soc_post_component_init(xxx)
{
...
dev_set_drvda
From: Kuninori Morimoto
snd_soc_pcm_set_drvdata() will set driver data to rtd->dev,
but driver data of rtd->dev is already used as "rtd" on
soc_post_component_init().
static int soc_post_component_init(xxx)
{
...
dev_set_drvda
ta(rtd->dev, rtd);
...
}
To remove confusion, snd_soc_pcm_set/get_drvdata() should be
removed soon. This patch is for it.
intel/haswell/sst-haswell-pcm.c is using snd_soc_pcm_set(),
but no one use it on this driver. Let's remove it.
Signed-off-by: Kuninori Morimoto
---
** Note **
I did c
Hi
> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig build) failed like this:
>
> sound/soc/generic/simple-card.c: In function 'asoc_simple_card_dai_link_of':
> sound/soc/generic/simple-card.c:350:8: error: implicit declaration of
> function 'asoc_simple_ca
Hi Sekhar
> > An ASoC driver using simple-card, when built as a module gets the
> > following error at module load time:
> >
> > [ 23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt
> > (err 0)
> > [ 23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name
Hi Mark
> > snd_soc_pcm_set_drvdata() will set driver data to rtd->dev,
> > but driver data of rtd->dev is already used as "rtd" on
> > soc_post_component_init().
>
> This doesn't apply against current code, please check and resend.
Thanks.
It seems current your branch already has same patch.
T
Hi Zhang
> > > From: Kuninori Morimoto
> > >
> > > rcar-thermal is supporting both thermal_zone_of_sensor_register()
> > > and
> > > thermal_zone_device_register(). But
> > > thermal_zone_of_sensor_register()
> > > doesn
Hi Zhang
> > > > > From: Kuninori Morimoto
> > > > >
> > > > > rcar-thermal is supporting both
> > > > > thermal_zone_of_sensor_register()
> > > > > and
> > > > > thermal_zone_device_register().
> match them.
>
> Signed-off-by: Nicolas Iooss
> ---
Acked-by: Kuninori Morimoto
From: Kuninori Morimoto
This driver's Copyright is under Renesas Solutions Corp
Signed-off-by: Kuninori Morimoto
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-au
linux/sound/soc/fsl/mpc5200_dma.c:305:18: warning: unused variable \
psc_dma’ [-Wunused-variable]
Signed-off-by: Kuninori Morimoto
---
sound/soc/fsl/mpc5200_dma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c
index 93885d9
From: Kuninori Morimoto
SYS/RT/Audio DMAC have both TCR/TCRB register.
Its difference is transfer counter value of read (= TCR)
or write (= TCRB). The relationship is like below.
TCR TCRB
[SOURCE] -> [DMAC] -> [DESTINATION]
Thus, we want to read TCRB instead of TCR for r
; >
> > Thus, we want to read TCRB instead of TCR for residue.
> > Otherwise, Sound Capture has noise after PluseAudio support
> > (= 07b7acb51d2 ("ASoC: rsnd: update pointer more accurate"))
> >
> > Signed-off-by: Hiroyuki Yokoyama
> > [Kuninori: adde
accurate"))
> >> >
> >> > Signed-off-by: Hiroyuki Yokoyama
> >> > [Kuninori: added detail information in log]
> >> > Signed-off-by: Kuninori Morimoto
> > (snip)
> >> However, shouldn't the register to use depend on the DMA directi
From: Kuninori Morimoto
SYS/RT/Audio DMAC have both TCR/TCRB.
Its difference is transfer counter value of read (= TCR)
or write (= TCRB). The relationship is like below.
TCR TCRB
[SOURCE] -> [DMAC] -> [DESTINATION]
Thus, for residue calculation, we want to read
TCR
or all case.
In any case, "completed" information should be used.
But in MEM_TO_DEV case, I thought if is OK if data was read from MEM
(= the data will be send to DEV automatically, I didn't care about interruption)
But yes, your opinion is correct I think.
I think MEM_TO_MEM should use TCRB.
I think logic is same as your MEM_TO_DEV explanation ?
Anyway, in all case I can use TCRB in v3 patch,
and it needs abouve explanation.
Best regards
---
Kuninori Morimoto
; and it needs abouve explanation.
If so, I think v1 is enough... ?
"transfer completed count is important for all case" is no doubt... ?
Best regards
---
Kuninori Morimoto
;m happy to create v3 patch which includes detail reason
which is explained by Laurent if you want.
Best regards
---
Kuninori Morimoto
r large serial console input situation?
I will ask this to HW guys.
Thanks
Best regards
---
Kuninori Morimoto
ps the code should use the minimum of both registers instead?
TCR(= read) happen 1st, and TCRB (= write) happen next.
"TCRB always contains 0x20" means, DMA didn't transfer data for some reason ?
"use minimum" idea can't guarantee data transfering, same as previous topic I
guess.
Best regards
---
Kuninori Morimoto
x27;d be happier with v3 :-)
Oops, I didn't explain this.
This DMAC has buffer. thus it will take a while for TCR and TCRB to
become equal. I will add this to log in v3
Best regards
---
Kuninori Morimoto
residue counter which indicates transferred
from sound device, but in reality the data was not yet put to memory
and recorder will record it.
Signed-off-by: Hiroyuki Yokoyama
[Kuninori: added detail information in log]
Signed-off-by: Kuninori Morimoto
---
v2 -> v3
- Code is back to same as v1
* see
+* rsnd_ssi_config_init()
+*/
+ rsnd_mod_write(mod, SSI_MODE,
+ rsnd_runtime_is_ssi_tdm(io) ? 0x1 : 0x0);
if (rsnd_ssi_use_busif(io)) {
rsnd_mod_write(mod, SSI_BUSIF_ADINR,
Best regards
---
Kuninori Morimoto
rsnd_runtime_is_ssi_tdm(io) ? 0x1 : 0x0);
>
> Thanks for your suggestion,
> I will do some test for this change,
> if it works fine, I will submit ver2 with it
Thanks
Best regards
---
Kuninori Morimoto
Hi Simon
Thank you for your feedback
> > From: Nobuhiro Iwamatsu
> >
> > The reg variable used when setting PCIECAR register need to be masked by
> > 0xFC
> > by restriction of the corresponding register.
> > This adds PCIE_CONF_REGNO are macros for masking changes that
> > PCIE_CONF_REGNO
>
Hi
Masanari Iida wrote:
>
> s/SUR/SRU/g
>
> Signed-off-by: Masanari Iida
> ---
Acked-by: Kuninori Morimoto
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kerne
Hi again
> Masanari Iida wrote:
> >
> > s/SUR/SRU/g
> >
> > Signed-off-by: Masanari Iida
> > ---
>
> Acked-by: Kuninori Morimoto
I sent Acked-by, but I think below is better Subject
- ASoc: sh: Fit typo in Kconfig
+ ASoC: rsnd: Fix SRU typo in Kconfig
And requested clock requests this clock too.
Thus, these clocks have dead lock on probe time
cs2000: clk_multiplier@4f {
...
clocks = <&rcar_sound 0>, ...
...
};
&rcar_sound {
...
assigned-clocks = &l
From: Kuninori Morimoto
This patch adds CS2000 Fractional-N driver as clock provider.
Signed-off-by: Kuninori Morimoto
---
v4 -> v5
- remove "clock-frequency"
- use dev on clk_register()
- remove CLK_IS_BASIC
- .enable -> .prepare since it is using I2C
. .disabe -> .un
Hi Vinod, Mark
> > > > > 5fa422c ("dmaengine: move drivers/of/dma.c -> drivers/dma/of-dma.c")
> > > > > moved OF base DMAEngine code to of-dma.c, then it based on
> > > > > CONFIG_DMA_OF.
> > > > > But, OF base DMAEngine API on of_dma.h still based on CONFIG_OF now.
> > > > > So, current kernel c
Hi Stephen
Thank you for your review
> > + init.parent_names = parent_names;
> > + init.num_parents= ARRAY_SIZE(parent_names);
> > +
> > + priv->hw.init = &init;
> > +
> > + clk = clk_register(NULL, &priv->hw);
>
> How about using devm_clk_register() and passing the i2c de
ivers. E.g. on
> Colibri T20 this lead to the following spew upon boot with sound/touch
> being broken:
Oops, my bad...
The platform_driver name is not important,
how about simply rename back it to "wm9712-codec" ?
Best regards
---
Kuninori Morimoto
t;
> if (hd->cnt >= ARRAY_SIZE(hdmi_dai_name)) {
> - dev_err(dev, "too many hdmi codec are deteced\n");
> + dev_err(dev, "too many hdmi codec are detected\n");
> return -EINVAL;
> }
Thank you for your pat
From: Kuninori Morimoto
panel-lvds.c is for LVDS Panel Driver,
not R-Car Display Unit CRTCs
Reported-by: Koji Matsuoka
Signed-off-by: Kuninori Morimoto
---
drivers/gpu/drm/panel/panel-lvds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel
ormation). However we should
> be screaming loudly about the fact that the I/O we tried to do fails,
> that clearly shouldn't be being ignored.
I'm sorry that my patch breaks your drivers.
It seems removing .read/.write callback was too much aggressive.
I hope your driver will be OK by using regmap.
In worst case, we can back .read/.write, but it will be component driver side.
Best regards
---
Kuninori Morimoto
>
> So to fix the regression, let's just do a partial revert adding back
> the read and write function pointers. Note that other non-regmap
> ASoC drivers may need similar patches.
>
> Fixes: 3bb0f7c31b1a ("ASoC: don't use snd_soc_write/read on twl4030")
>
From: Kuninori Morimoto
Now we can replace Codec to Component. Let's do it.
Note:
xxx_codec_xxx() -> xxx_component_xxx()
.idle_bias_off = 0 -> .idle_bias_on = 1
.ignore_pmdown_time = 0 -> .use_p
Hi Greg, Rob, Frank
We are using {kobject_/of_node_}get/put() for increment/decrement
counter. But, because we don't have counter read() function,
confirming it (mainly for debug purpose) is a little bit difficult.
These patches add read() function for it.
Kuninori Morimoto (2):
kobject
From: Kuninori Morimoto
We are counting of node by using of_node_get/put(), but
not have of_node_read() which can be used to check count.
Let's add it
Signed-off-by: Kuninori Morimoto
---
drivers/of/dynamic.c | 14 ++
include/linux/of.h | 5 +
2 files change
From: Kuninori Morimoto
We are counting kobject by using kobject_get/put(), but
not have kobject_read() which can be used to check count.
Let's add
Signed-off-by: Kuninori Morimoto
---
include/linux/kobject.h | 1 +
lib/kobject.c | 18 ++
2 files change
Hi Jernej
Thank you for your hard work
> I found the issue. Commit be7ee5f32a9a ("ASoC: soc-generic-dmaengine-pcm:
> replace platform to component") changes struct dmaengine_pcm:
>
> struct dmaengine_pcm {
> struct dma_chan *chan[SNDRV_PCM_STREAM_LAST + 1];
> const struct snd_dmae
Hi Mark,Jernej
> > Ahh.. indeed. Good catch !
> > How about to add such flag ?
> > This is just idea. No tested, No compiled, but can help you ?
>
> I think this makes sense as a patch. We might want to disallow
> allocating components as part of a bigger struct so everything is more
> consiste
Hi Jiada
Cc: linux-renesas-soc ML
Thank you for your patch
> From: Jiada Wang
>
> Currently ssi driver only request dma channel for SSI_0,
> which is used to transfer data to/from busif0.
>
> But since busif1 to busif7 also maybe used, dedicated dma channels
> are request for data transfer b
1 - 100 of 887 matches
Mail list logo
