Re: [PATCH 11/42] ARM: shmobile: Register PFC platform device

2012-11-27 Thread Laurent Pinchart
Hi Simon, On Tuesday 27 November 2012 11:26:28 Simon Horman wrote: > On Mon, Nov 26, 2012 at 11:34:36AM +0100, Laurent Pinchart wrote: > > On Monday 26 November 2012 10:02:05 Simon Horman wrote: > > > On Wed, Nov 21, 2012 at 01:43:15PM +0100, Laurent Pinchart wrote: >

Re: [PATCH 1/5] backlight: Add GPIO-based backlight driver

2012-11-27 Thread Laurent Pinchart
Hi Jingoo, On Tuesday 27 November 2012 01:10:36 Jingoo Han wrote: > On Saturday, November 24, 2012 1:35 AM, Laurent Pinchart wrote > > > > > Signed-off-by: Laurent Pinchart > > --- > > > > drivers/video/backlight/Kconfig |7 ++ > > drive

Re: [PATCH v2] UVC: use GFP_ATOMIC under spin lock.

2012-11-27 Thread Laurent Pinchart
o->ep, req, GFP_KERNEL)) < 0) { > + ret = usb_ep_queue(video->ep, req, GFP_ATOMIC); > + if (ret < 0) { > printk(KERN_INFO "Failed to queue request (%d)\n", ret); > usb_ep_set_halt(video->ep); >

Re: [PATCHv9 1/3] Runtime Interpreted Power Sequences

2012-11-27 Thread Laurent Pinchart
busses for display hardware are DSI, DBI, I2C, SPI and plain GPIOs. The last three control busses are well supported in the Linux kernel, I've implemented DBI support as part of the CDF RFC, and DSI support is missing. If you look at the DBI bus implementation the amount of code isn't ov

Re: [PATCHv9 1/3] Runtime Interpreted Power Sequences

2012-11-27 Thread Laurent Pinchart
problem with adding small Tegra specific panel drivers > for the time being, with the intention of converting to common panel > framework when that's available. I'm fine with that, but using the CDF would be even better :-) > Of course, the DT side is an issue. If you now create DT b

Re: [PATCHv9 1/3] Runtime Interpreted Power Sequences

2012-11-27 Thread Laurent Pinchart
> > drivers/video/omap2/displays/panel-generic-dpi.c). > > > > I don't see any problem with adding small Tegra specific panel drivers > > for the time being, with the intention of converting to common panel > > framework when that's available. > > I can take a look at how such a driver could be implemented, but again, > I'm a bit reluctant to add something ad-hoc now when maybe we can have > it supported in a proper framework not too far away in the future. > > > Of course, the DT side is an issue. If you now create DT bindings for a > > temporary model, and need to change it again later, you'll have some > > headaches trying managing that without breaking the old bindings... This > > is why I haven't pushed DT bindings for OMAP, as I know I have to change > > them in the near future. > > We're already keeping back on this and none of the patches that define > the bindings have been merged yet. Although bindings have been known to > change every once in a while even for code that is already in mainline. -- Regards, Laurent Pinchart signature.asc Description: This is a digitally signed message part.

Re: [PATCHv9 1/3] Runtime Interpreted Power Sequences

2012-11-27 Thread Laurent Pinchart
Hi Tomi, On Tuesday 27 November 2012 17:19:05 Tomi Valkeinen wrote: > On 2012-11-27 17:08, Laurent Pinchart wrote: > > On Wednesday 21 November 2012 14:04:17 Tomi Valkeinen wrote: > >> On 2012-11-21 13:40, Thierry Reding wrote: > > [snip] > > > >>>

Re: [PATCH v3 9/9] davinci: vpfe: Add documentation and TODO

2012-11-28 Thread Laurent Pinchart
y code reaches mainline, in which case I believe we will lose some of them in the process, including major vendors such as TI, or if we can make the mainline learning curve and experience a bit more smooth by accepting such code in staging. I would vote for the second option, with a very clear rul

Re: [PATCH v3 0/9] Media Controller capture driver for DM365

2012-11-29 Thread Laurent Pinchart
o be provided when this media controller aware driver will move out of staging to drivers/media/ and replace the existing driver, Acked-by: Laurent Pinchart > Mauro/Greg, > The below series of patches have gone through good amount of reviews, and > agreed by Laurent, Hans and Sakari to

Re: [PATCH 00/03] gpio: Renesas R-Car GPIO driver update

2013-03-19 Thread Laurent Pinchart
Hi Magnus, On Tuesday 19 March 2013 12:36:52 Magnus Damm wrote: > On Thu, Mar 14, 2013 at 10:13 PM, Laurent Pinchart wrote: > > On Thursday 14 March 2013 13:23:46 Magnus Damm wrote: > >> On Wed, Mar 13, 2013 at 9:58 PM, Laurent Pinchart wrote: > >> > On Wednesday

Re: [PATCH RFC v2] media: tvp514x: add OF support

2013-02-03 Thread Laurent Pinchart
need separate property I will change it please let me know on this. If there's any difference between the chips that need to be handled in the driver, using two compatible properties is a good practice. Your driver will then be able to easily differentiate between the two chips, and ther

Re: [PATCH v2] ADP1653 board code for Nokia RX-51

2013-04-04 Thread Laurent Pinchart
Hi Sakari, On Thursday 04 April 2013 01:22:28 Sakari Ailus wrote: > On Tue, Mar 26, 2013 at 12:07:01AM +0100, Laurent Pinchart wrote: > > On Sunday 24 March 2013 23:46:01 Sakari Ailus wrote: > > > Pali Rohár wrote: > > > > On Thursday 07 March 2013 23:18:27 Sakar

Re: [PATCH RFC] media: tvp514x: add OF support

2013-01-24 Thread Laurent Pinchart
tvp514x driver. > > Signed-off-by: Lad, Prabhakar > Cc: Hans Verkuil > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Guennadi Liakhovetski > --- > This patch is on top of following patches: > 1: https://patchwork.kernel.org/patch/1930941/ > 2: http://pa

Re: [PATCH] gpio: Renesas R-Car GPIO driver

2013-03-12 Thread Laurent Pinchart
Hi Magnus, On Tuesday 12 March 2013 14:27:25 Magnus Damm wrote: > On Sun, Mar 10, 2013 at 3:16 AM, Laurent Pinchart wrote: > > Hi Magnus, > > > > Thank you for the patch. > > Thanks for your review! You're welcome. > > On Tuesday 05 March 2013 09:32:1

[PATCH] pinctrl: Print the correct information in debugfs pinconf-state file

2013-03-12 Thread Laurent Pinchart
A bad copy&paste resulted in the debugfs pinconf-state file printing the pin name instead of the state name. Fix it. Signed-off-by: Laurent Pinchart --- drivers/pinctrl/pinconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinconf.c b/drivers/pin

Re: [PATCH 00/03] gpio: Renesas R-Car GPIO driver update

2013-03-13 Thread Laurent Pinchart
devm functions > > This series updates the R-Car GPIO driver with various > changes kindly suggested by Laurent Pinchart. > > Patch [01/03] is a drop in replacement for V1 of the R-Car > GPIO driver. The flag in patch [02/03] is kept out of [01/03] > to avoid changing the be

Re: [PATCH 01/03] gpio: Renesas R-Car GPIO driver V2

2013-03-13 Thread Laurent Pinchart
> + irq_set_chip_data(virq, h->host_data); > + irq_set_chip_and_handler(virq, &p->irq_chip, handle_level_irq); > + set_irq_flags(virq, IRQF_VALID); /* kill me now */ What is that comment about ? > + return 0; > +} -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 00/03] gpio: Renesas R-Car GPIO driver update

2013-03-14 Thread Laurent Pinchart
Hi Magnus, On Thursday 14 March 2013 13:23:46 Magnus Damm wrote: > On Wed, Mar 13, 2013 at 9:58 PM, Laurent Pinchart wrote: > > On Wednesday 13 March 2013 20:32:03 Magnus Damm wrote: > >> gpio: Renesas R-Car GPIO driver update > >> > >> [PATCH 01/03

Re: [PATCH 4/5] video:omap3isp:fix up ENOIOCTLCMD error handling

2012-09-13 Thread Laurent Pinchart
Hi Wanlong, Thanks for the patch. On Monday 27 August 2012 15:23:15 Wanlong Gao wrote: > At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be > translated as ENOTTY to user mode. > > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: linux-me...@vger.kernel.o

Re: [PATCH v2] media: v4l2-ctrls: add control for test pattern

2012-09-13 Thread Laurent Pinchart
> > > > add V4L2_CID_TEST_PATTERN of type menu, which determines > > > > the internal test pattern selected by the device. > > > > > > > > Signed-off-by: Lad, Prabhakar > > > > Signed-off-by: Manjunath Hadli > > > > Cc: S

Re: [PATCH v4] media: v4l2-ctrls: add control for dpcm predictor

2012-09-13 Thread Laurent Pinchart
s preferred for 10-8-10 conversion, and the advanced predictor for 10-7-10 and 10-6-10 conversion. > The main difference between the simple and the advanced predictors is > image quality, with advanced predictor supposed to produce better > quality images as a result. Simple predicto

Re: [PATCH v3] media: v4l2-ctrl: add a helper function to modify the menu

2012-09-13 Thread Laurent Pinchart
; Cc: Hans Verkuil > Cc: Sakari Ailus > Cc: Sylwester Nawrocki > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Hans de Goede > Cc: Kyungmin Park > Cc: Guennadi Liakhovetski > Cc: Rob Landley > --- > Changes for v3: > 1: Fixed style/grammer issu

Re: [PATCH v5] media: mt9p031/mt9t001/mt9v032: use V4L2_CID_TEST_PATTERN for test pattern control

2012-10-03 Thread Laurent Pinchart
t; Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath Hadli > Acked-by: Laurent Pinchart > Cc: Sakari Ailus > Cc: Paul Gortmaker > Cc: Jean Delvare Should I push this patch through my tree ? If so I'll wait until the V4L2_CID_TEST_PATTERN control patch hits Mauro'

[PATCH 0/2] USB webcam gadget driver fix for linux-next

2012-10-03 Thread Laurent Pinchart
Hi, The first patch in this series should fix the UVC gadget compilation errors in linux-next. The second patch should make sure I'll be notified next time a patch tries to break it :-) Both patches are based on Linus' tree. Laurent Pinchart (2): usb: gadget: Make webcam gad

[PATCH 1/2] usb: gadget: Make webcam gadget select USB_LIBCOMPOSITE

2012-10-03 Thread Laurent Pinchart
Composite gadget support is now available as a library instead of being built with each gadget. Composite drivers need to select USB_LIBCOMPOSITE. Signed-off-by: Laurent Pinchart --- drivers/usb/gadget/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb

[PATCH 2/2] MAINTAINERS: Add maintainer entry for the USB webcam gadget

2012-10-03 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d919e3d..b118b23 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7392,6 +7392,13 @@ S: Maintained F: Documentation/video4linux

Re: [PATCH RFC] media: v4l2-ctrl: Add digital gain controls

2012-10-04 Thread Laurent Pinchart
h Hadli > Cc: Sakari Ailus > Cc: Laurent Pinchart > Cc: Guennadi Liakhovetski > Cc: Sylwester Nawrocki > Cc: Hans Verkuil > Cc: Hans de Goede hdego...@redhat.com > Cc: Chris MacGregor ch...@cybermato.com > Cc: Rob Landley > Cc: Mauro Carvalho Chehab > --- >

Re: [PATCH 01/23] uvc: Replace memcpy with struct assignment

2012-10-24 Thread Laurent Pinchart
implified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > identifier struct_name; > struct struct_name to; > struct struct_name from; > expression E; > @@ > -memcpy(&(to), &(from), E); >

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-24 Thread Laurent Pinchart
Hi Simon, On Monday 22 October 2012 12:49:51 Simon Haggett wrote: > On 22/10/12 11:47, Laurent Pinchart wrote: > > On Monday 22 October 2012 03:33:19 Li Yang-R58472 wrote: > >> On Saturday, October 20, 2012 1:37 AM Felipe Balbi wrote: > >>> On Fri, Oct 19, 2012 at 0

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-24 Thread Laurent Pinchart
Hi Felipe, On Monday 22 October 2012 13:56:01 Felipe Balbi wrote: > On Mon, Oct 22, 2012 at 12:47:21PM +0200, Laurent Pinchart wrote: > > On Monday 22 October 2012 03:33:19 Li Yang-R58472 wrote: > > > On Saturday, October 20, 2012 1:37 AM Felipe Balbi wrote: > > > >

Re: [PATCH v2] media: davinci: vpbe: fix build warning

2012-10-25 Thread Laurent Pinchart
iomem * instead of a unsigned long." > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath Hadli > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab Acked-by: Laurent Pinchart > --- > Changes for v2: > 1: Made the base addr to void __iomem * instead of

Re: [PATCH v2 4/4] fbdev: sh_mobile_lcdc: use dma_mmap_coherent if available

2012-07-26 Thread Laurent Pinchart
> enabled. dma_mmap_coherent() maps the address correctly. It is > available on ARM platforms. > > Signed-off-by: Hideki EIRAKU Acked-by: Laurent Pinchart -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH] [media] davinci: vpfe: Add documentation

2012-07-27 Thread Laurent Pinchart
Hi Manjunath, On Friday 27 July 2012 05:49:24 Hadli, Manjunath wrote: > On Thu, Jul 26, 2012 at 05:55:31, Laurent Pinchart wrote: > > On Tuesday 17 July 2012 10:43:54 Hadli, Manjunath wrote: > > > On Sun, Jul 15, 2012 at 18:16:25, Laurent Pinchart wrote: > > > > On W

Re: [PATCH 1/1] [media] uvcvideo: Add 10,12bit and alternate 8bit greyscale

2012-07-28 Thread Laurent Pinchart
, 0x00, 0x00, 0x10, 0x00, \ > + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} > +#define UVC_GUID_FORMAT_Y10 \ > + { 'Y', '1', '0', ' ', 0x00, 0x00, 0x10, 0x00, \ > + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} > +#define UVC

Re: [PATCH 5/5] drivers/media/platform/omap3isp/isp.c: fix error return code

2012-09-24 Thread Laurent Pinchart
tform/omap3isp/isp.c > > +++ b/drivers/media/platform/omap3isp/isp.c > > @@ -2102,8 +2102,10 @@ static int __devinit isp_probe(struct > > platform_device *pdev)> > > if (ret < 0) > > goto error; > > > > - if (__oma

Re: [PATCH v5] media: v4l2-ctrl: add a helper function to add standard control with driver specific menu

2012-09-24 Thread Laurent Pinchart
; Cc: Hans Verkuil > Cc: Sakari Ailus > Cc: Sylwester Nawrocki > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Hans de Goede > Cc: Kyungmin Park > Cc: Guennadi Liakhovetski > Cc: Rob Landley Thank you for not giving up despite the many change requests yo

Re: [PATCH] media: davinci: vpif: set device capabilities

2012-09-25 Thread Laurent Pinchart
TPUT | V4L2_CAP_STREAMING | > > + V4L2_CAP_READWRITE; > > + cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS; > > > > strlcpy(cap->driver, "vpif display", sizeof(cap->driver)); > > vpif_driver > > > strlcpy(cap->bus_info, "Platform", sizeof(cap->bus_info)); > > Ditto: "platform:vpif_driver". > > > strlcpy(cap->card, config->card_name, sizeof(cap->card)); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] v4l: change path of video drivers

2012-09-25 Thread Laurent Pinchart
th Hadli > Cc: Mauro Carvalho Chehab > Cc: Hans Verkuil > Cc: Laurent Pinchart > Cc: Sakari Ailus > Cc: Rob Landley For the omap3isp part and the V4L2 core, Acked-by: Laurent Pinchart > --- > Documentation/video4linux/CQcam.txt |2 +- > Documen

Re: [PATCH] media: davinci: vpif: set device capabilities

2012-09-25 Thread Laurent Pinchart
On Tuesday 25 September 2012 15:48:10 Hans Verkuil wrote: > On Tue 25 September 2012 15:26:11 Prabhakar Lad wrote: > > On Tue, Sep 25, 2012 at 5:24 PM, Hans Verkuil wrote: > > > On Tue 25 September 2012 13:49:16 Laurent Pinchart wrote: > > >> Hi Hans, > > >

Re: [PATCH] media: mt9p031/mt9t001/mt9v032: use V4L2_CID_TEST_PATTERN for test pattern control

2012-09-25 Thread Laurent Pinchart
.min= 4, > .max= 1023, > .step = 1, > - .def = 0, > + .def= 4, > .flags = 0, > } > }; > @@ -741,7 +755,7 @@ static int mt9v032_pro

Re: [PATCH v2] media: mt9p031/mt9t001/mt9v032: use V4L2_CID_TEST_PATTERN for test pattern control

2012-09-26 Thread Laurent Pinchart
Hi Prabhakar, Thanks for the patch. On Wednesday 26 September 2012 12:05:10 Prabhakar wrote: > From: Lad, Prabhakar > > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath Hadli > Cc: Laurent Pinchart > Cc: Sakari Ailus > Cc: Paul Gortmaker > Cc: Jean Delvare

Re: [PATCH] drm: platform: Don't initialize driver-private data

2012-10-26 Thread Laurent Pinchart
. If you want to push drivers that way, you should get rid of the pci_set_drvdata() call in core DRM as well. This would push device driver data handling down to all drivers, so I'm not convinced it would actually make things simpler. > Signed-off-by: Thierry Reding Tested-by: Laure

Re: [PATCH] drm: platform: Don't initialize driver-private data

2012-10-31 Thread Laurent Pinchart
Hi Thierry, On Wednesday 31 October 2012 09:26:07 Thierry Reding wrote: > On Fri, Oct 26, 2012 at 04:06:27PM +0200, Laurent Pinchart wrote: > > On Monday 15 October 2012 20:03:42 Thierry Reding wrote: > > > Platform device drivers usually use the driver-private data for their

Re: [PATCH v2 3/3] gpio: pcf857x: Add OF support

2013-08-24 Thread Laurent Pinchart
Hi Tomasz, On Saturday 24 August 2013 16:13:11 Tomasz Figa wrote: > On Saturday 24 of August 2013 02:54:07 Laurent Pinchart wrote: > > On Saturday 24 August 2013 02:41:59 Tomasz Figa wrote: > > > On Tuesday 20 of August 2013 01:04:54 Laurent Pinchart wrote: > > > > A

[PATCH v3] gpio: pcf857x: Add OF support

2013-08-24 Thread Laurent Pinchart
Add DT bindings for the pcf857x-compatible chips and parse the device tree node in the driver. Signed-off-by: Laurent Pinchart --- .../devicetree/bindings/gpio/gpio-pcf857x.txt | 71 ++ drivers/gpio/gpio-pcf857x.c| 57 ++--- 2 files

Re: [PATCH] DMA: let filter functions of of_dma_simple_xlate possible check of_node

2013-08-26 Thread Laurent Pinchart
tches the DMA providing device's of_node handle. > > > > Filter function is called in dmaengine core code, independent of dt. > > The core code can still check if a dmaengine's driver was instantiated > from DT and take additional actions in that case. > > > A

Re: [PATCH] DMA: let filter functions of of_dma_simple_xlate possible check of_node

2013-08-26 Thread Laurent Pinchart
Hi Richard, (Dropping Dan Williams from the CC list as his e-mail address doesn't seem to be valid anymore) On Monday 26 August 2013 20:55:57 Richard Zhao wrote: > On Mon, Aug 26, 2013 at 02:17:43PM +0200, Laurent Pinchart wrote: > > On Friday 23 August 2013 09:57:43 Stephe

Re: [PATCH v3] gpio: pcf857x: Add OF support

2013-08-26 Thread Laurent Pinchart
Hi Sylwester, On Sunday 25 August 2013 10:16:40 Sylwester Nawrocki wrote: > On 08/25/2013 02:26 AM, Laurent Pinchart wrote: > > Add DT bindings for the pcf857x-compatible chips and parse the device > > tree node in the driver. > > > > Sign

[PATCH v4] gpio: pcf857x: Add OF support

2013-08-26 Thread Laurent Pinchart
Add DT bindings for the pcf857x-compatible chips and parse the device tree node in the driver. Signed-off-by: Laurent Pinchart --- .../devicetree/bindings/gpio/gpio-pcf857x.txt | 71 ++ drivers/gpio/gpio-pcf857x.c| 54 +--- 2 files

[PATCH v5] gpio: pcf857x: Add OF support

2013-08-27 Thread Laurent Pinchart
Add DT bindings for the pcf857x-compatible chips and parse the device tree node in the driver. Signed-off-by: Laurent Pinchart --- .../devicetree/bindings/gpio/gpio-pcf857x.txt | 71 ++ drivers/gpio/gpio-pcf857x.c| 44 +++--- 2 files

Re: [PATCH v2 3/3] gpio: pcf857x: Add OF support

2013-08-27 Thread Laurent Pinchart
Hi Mark, On Tuesday 27 August 2013 11:39:49 Mark Rutland wrote: > On Sat, Aug 24, 2013 at 03:13:11PM +0100, Tomasz Figa wrote: > > On Saturday 24 of August 2013 02:54:07 Laurent Pinchart wrote: > > > On Saturday 24 August 2013 02:41:59 Tomasz Figa wrote: > > > > On T

Re: [PATCH v5] gpio: pcf857x: Add OF support

2013-08-27 Thread Laurent Pinchart
Hi Tomasz, On Tuesday 27 August 2013 13:55:00 Tomasz Figa wrote: > On Tuesday 27 of August 2013 14:00:24 Archit Taneja wrote: > > On Tuesday 27 August 2013 01:44 PM, Tomasz Figa wrote: > > > On Tuesday 27 of August 2013 10:02:39 Laurent Pinchart wrote: > > >> A

Re: [PATCH 1/5] mfd: asic3: Remove .set_pwr() callback

2013-08-28 Thread Laurent Pinchart
sic3.c:724:2: warning: (near initialization for > 'asic3_mmc_data.capabilities' [enabled by default] My bad, it looks like I've overlooked a few users of the .set_pwr() field :-/ Sorry about that. > Signed-off-by: Jingoo Han > Cc: Laurent Pinchart > Cc: Guennadi Liak

Re: [PATCH 1/5] mfd: asic3: Remove .set_pwr() callback

2013-08-28 Thread Laurent Pinchart
> revert 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() callback from platform > > data" instead. > > No need to revert it, as it's not in Mainline yet. Just request for it > to be removed from Chris' tree. I spupose it depends on whether Chris has provided a stable

Re: [PATCH v5] gpio: pcf857x: Add OF support

2013-08-28 Thread Laurent Pinchart
table. Linus, I'd like to get this in v3.12 if it's not too late. Could you please provide your input ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More maj

Re: [PATCH 1/5] mfd: asic3: Remove .set_pwr() callback

2013-08-29 Thread Laurent Pinchart
Hi Chris, On Thursday 29 August 2013 07:42:26 Kevin Hilman wrote: > On Wed, Aug 28, 2013 at 12:51 AM, Laurent Pinchart wrote: > > On Wednesday 28 August 2013 08:41:26 Lee Jones wrote: > >> > > Since 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() callback from >

Re: [PATCH 4/6] ARM: shmobile: emev2: Define SMU clock DT bindings

2013-10-01 Thread Laurent Pinchart
he clock tree > > + c32ki -> pll3_fo -> usia_u0_sclkdiv -> usia_u0_sclk > > + > > +smu { > > + compatible = "renesas,emev2-smu"; > > + reg = <0xe011 0x1>; > > + #address-cells = <2>; > > + #size-cells = <0>; > &

Re: [PATCH 5/6] clk: emev2: Add support for emev2 SMU clocks with DT

2013-10-01 Thread Laurent Pinchart
CLK), y) > > +obj-$(CONFIG_ARCH_EMEV2) += clk-emev2.o > > +endif > > I don't think you would need the above ifeq/endif wrapper if you only > used CONFIG_ARCH_SHMOBILE_MULTI above. > > Apart from that it looks good to me. And, yes, I have tested this on > my KZM

Re: [PATCH 05/26] omap3isp: Make isp_video_buffer_prepare_user() use get_user_pages_fast()

2013-10-02 Thread Laurent Pinchart
Hi Jan, Thank you for the patch. On Wednesday 02 October 2013 16:27:46 Jan Kara wrote: > CC: Laurent Pinchart > CC: linux-me...@vger.kernel.org > Signed-off-by: Jan Kara Acked-by: Laurent Pinchart Could you briefly explain where you're headed with this ? The V4L2 subsystem ha

Re: [PATCH] fbdev: sh_mobile_hdmi: Use devm_kzalloc()

2013-10-03 Thread Laurent Pinchart
Hi Sangjung, Thank you for the patch. On Thursday 03 October 2013 23:04:27 Sangjung Woo wrote: > Use devm_kzalloc() instead of kzalloc() in order to be free > automatically. This makes cleanup paths more simple. > > Signed-off-by: Sangjung Woo Acked-by: Laurent Pinchart Tom

Re: i2c: introduce i2c helper i2c_find_client_by_name()

2013-07-12 Thread Laurent Pinchart
r, so they now use notifiers > to know when the slaves are in place. Something like this should > probably be done here, too, instead of unregistering and re-registering. This will be available in v3.11 in drivers/media/v4l2-core/v4l2-async.c. -- Regards, Laurent Pinchart signature.asc Description: This is a digitally signed message part.

Re: i2c: introduce i2c helper i2c_find_client_by_name()

2013-07-12 Thread Laurent Pinchart
t; > Yes, seems right way to go. > I think ACPI case can use V4L2 async API somehow, though it has its > own event model. > I'll talk to Sakari Ailus to sync. Do you have any pointer to the relevant parts of the ACPI specification ? -- Regards, Laurent Pinchart

Re: [PATCH] [media] media/v4l2: VIDEO_RENESAS_VSP1 should depend on HAS_DMA

2013-09-16 Thread Laurent Pinchart
Hi Geert, On Friday 06 September 2013 19:07:50 Geert Uytterhoeven wrote: > On Fri, Sep 6, 2013 at 5:20 PM, Laurent Pinchart wrote: > > On Friday 06 September 2013 14:43:56 Geert Uytterhoeven wrote: > >> If NO_DMA=y: > >> > >> warning: (... &

Re: [PATCH v4 0/3] cleanup of gpio_pcf857x.c

2013-09-17 Thread Laurent Pinchart
> make sure it works. > > > Note: these patches were made after applying [1]. > > [1] - [PATCH v5] gpio: pcf857x: Add OF support - > > https://lkml.org/lkml/2013/8/27/70 > > Well that patch is not finished, but by rebasing patch 2 with > patch -p1 < patch2.p

Re: PCF857x and 16-bit GPIO expanders

2013-09-18 Thread Laurent Pinchart
. I can try toggling I/O 15, but that will need to wait until next week as I'm currently travelling without access to the hardware. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...

Re: [PATCH] [media] media/v4l2: VIDEO_RENESAS_VSP1 should depend on HAS_DMA

2013-09-06 Thread Laurent Pinchart
c has been discussed before though. If that's not possible, > Signed-off-by: Geert Uytterhoeven Acked-by: Laurent Pinchart > --- > drivers/media/platform/Kconfig |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/Kconfig b/d

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-06 Thread Laurent Pinchart
Hi Linus, Sorry for the late reply. On Thursday 22 August 2013 00:02:39 Linus Walleij wrote: > On Tue, Aug 20, 2013 at 12:04 AM, Laurent Pinchart wrote: > > On Wednesday 31 July 2013 01:44:53 Linus Walleij wrote: > >> I don't see how sharing works here, or how another

Re: [PATCH] SHMOBILE: DRM: Fix backlight_device register and unregister undefined errors.

2013-10-08 Thread Laurent Pinchart
ight_device_unregister" > [drivers/gpu/drm/shmobile/shmob-drm.ko] undefined! make[1]: *** [__modpost] > Error 1 > make: *** [modules] Error 2 > > Signed-off-by: Manjunath Goudar > Cc: David Airlie > Cc: Laurent Pinchart > Cc: Sascha Hauer > Cc: dri-de...@lists.f

Re: [PATCH v5] gpio: pcf857x: Add OF support

2013-08-29 Thread Laurent Pinchart
Hi Linus, On Thursday 29 August 2013 20:24:32 Linus Walleij wrote: > On Wed, Aug 28, 2013 at 1:58 PM, Laurent Pinchart wrote: > > On Tuesday 27 August 2013 19:18:55 Wolfram Sang wrote: > >> > The driver should support the same chip models reardless of whether > >>

Re: [PATCH v5] gpio: pcf857x: Add OF support

2013-08-29 Thread Laurent Pinchart
On Friday 30 August 2013 01:44:50 Laurent Pinchart wrote: > On Thursday 29 August 2013 20:24:32 Linus Walleij wrote: > > On Wed, Aug 28, 2013 at 1:58 PM, Laurent Pinchart wrote: > > > On Tuesday 27 August 2013 19:18:55 Wolfram Sang wrote: > > >> > The driver sh

Re: [PATCH v4] gpio: pcf857x: Add OF support

2013-08-29 Thread Laurent Pinchart
Hi Linus, On Thursday 29 August 2013 14:16:59 Linus Walleij wrote: > On Mon, Aug 26, 2013 at 3:45 PM, Laurent Pinchart wrote: > > Add DT bindings for the pcf857x-compatible chips and parse the device > > tree node in the driver. > > > > Signed-off-by: Laurent Pinchart

Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor.

2013-08-29 Thread Laurent Pinchart
Hi Joseph, Thank you for the patch. On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote: > BugLink: http://bugs.launchpad.net/bugs/1217957 > > Add quirk for Dell SP2008WFP monitor: 05a9:2641 > > Signed-off-by: Joseph Salisbury > Tested-by: Christopher Townsend >

Re: [PATCH v4] gpio: pcf857x: Add OF support

2013-08-30 Thread Laurent Pinchart
On Friday 30 August 2013 10:07:23 Linus Walleij wrote: > On Fri, Aug 30, 2013 at 2:05 AM, Laurent Pinchart wrote: > > On Thursday 29 August 2013 14:16:59 Linus Walleij wrote: > >> On Mon, Aug 26, 2013 at 3:45 PM, Laurent Pinchart wrote: > >> > >> Don't we

Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor.

2013-08-30 Thread Laurent Pinchart
Hi Greg, On Thursday 29 August 2013 21:00:21 Greg KH wrote: > On Fri, Aug 30, 2013 at 02:41:17AM +0200, Laurent Pinchart wrote: > > On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote: > > > BugLink: http://bugs.launchpad.net/bugs/1217957 > > > > > >

Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor.

2013-08-30 Thread Laurent Pinchart
Hi Greg, On Friday 30 August 2013 09:39:58 Greg KH wrote: > On Fri, Aug 30, 2013 at 12:28:16PM +0200, Laurent Pinchart wrote: > > On Thursday 29 August 2013 21:00:21 Greg KH wrote: > > > On Fri, Aug 30, 2013 at 02:41:17AM +0200, Laurent Pinchart wrote: > > > > On Th

Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7790: add pin definitions for the I2C3 interface

2013-09-26 Thread Laurent Pinchart
Hi Guennadi, On Thursday 26 September 2013 11:24:26 Guennadi Liakhovetski wrote: > On Wed, 25 Sep 2013, Laurent Pinchart wrote: > > On Monday 09 September 2013 18:03:53 Guennadi Liakhovetski wrote: > > > There are four I2C interfaces on r8a7790, each of them can be connected &

Re: [PATCH v2 5/5] ARM: shmobile: lager: (DEVEL) add CPUFreq support

2013-09-26 Thread Laurent Pinchart
, NULL); > + platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0); Out of curiosity, could you explain how this cpufreq-cpu0 platform device gets associated with the cpu0 DT node ? The cpufreq-cpu0 driver requires a DT node (its probe function returns -ENOENT if pdev-&

Re: [PATCH v2 1/5] pinctrl: sh-pfc: r8a7790: add pin definitions for the I2C3 interface

2013-09-26 Thread Laurent Pinchart
tion. > > This patch uses the sh-pfc ability to configure pins, not associated with > GPIOs and adds support for I2C3 to the r8a7790 PFC set up. > > Signed-off-by: Guennadi Liakhovetski Acked-by: Laurent Pinchart I've taken the patch in my tree and sent an update to my pr

Re: [PATCH] [media] uvcvideo: fix data type for pan/tilt control

2013-09-28 Thread Laurent Pinchart
mping for unsigned integer > controls). > > It leads to wrong setting of the control values. For example, > when min and max are -36000 and 36000, the setting value between of this > range is always 36000. So, Its data type should be changed to signed. > > Signed-off-by: Chanho Mi

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-29 Thread Laurent Pinchart
because it needed to be updated for PWM subsystem changes. > > > > > > What's the plan going forward? Given the coupling between the PWM > > > subsystem and the pwm-backlight driver it might be useful to keep > > > maintaining it as part of the PWM subsyst

Re: [PATCH] Revert "V4L/DVB: uvc: Enable USB autosuspend by default on uvcvideo"

2013-09-30 Thread Laurent Pinchart
Hi, On Tuesday 24 September 2013 08:55:19 VDR User wrote: > On Tue, Sep 24, 2013 at 4:34 AM, Laurent Pinchart wrote: > > I've discussed this issue during LPC last week, and I still believe we > > should enable auto-suspend. The feature really saves power, without it my >

Re: [PATCH] ARM: shmobile: ape6evm: fix incorrect placement of __initdata tag

2013-09-30 Thread Laurent Pinchart
;), > }; > > -static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = { > +static struct gpio_keys_platform_data ape6evm_keys_pdata = { > .buttons= gpio_buttons, > .nbuttons = ARRAY_SIZE(gpio_buttons), > }; -- Regards, Laurent Pincha

Re: [PATCH 2/6] serial8250-em: convert to clk_prepare/unprepare

2013-09-30 Thread Laurent Pinchart
Shinya Kuribayashi > [takashi.yoshii...@renesas.com: edited for conflicts] > Signed-off-by: Takashi Yoshii Acked-by: Laurent Pinchart > --- > drivers/tty/serial/8250/8250_em.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/serial/825

Re: [PATCH 1/6] clocksource: em_sti: convert to clk_prepare/unprepare

2013-09-30 Thread Laurent Pinchart
uribayashi Acked-by: Laurent Pinchart > --- > drivers/clocksource/em_sti.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c > index 3a5909c..9d17083 100644 > --- a/drivers/clocksour

Re: [PATCH v2] ARM: shmobile: ape6evm: fix incorrect placement of __initdata tag

2013-09-30 Thread Laurent Pinchart
in Park Acked-by: Laurent Pinchart > --- > v2: > - use __initdata as it is OK to do it > > arch/arm/mach-shmobile/board-ape6evm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c > b/arch/arm/mach-shmob

Re: [PATCH 3/6] sh: clkfwk: Select sh-/common- clkfwk alternatively

2013-09-30 Thread Laurent Pinchart
reamcast > diff --git a/drivers/sh/clk/Makefile b/drivers/sh/clk/Makefile > index 5d15ebf..e73b031 100644 > --- a/drivers/sh/clk/Makefile > +++ b/drivers/sh/clk/Makefile > @@ -1,3 +1,2 @@ > -obj-y:= core.o > - > +obj-$(CONFIG_HAVE_MACH_CLKDEV) += core.o > obj-$(CO

[PATCH v6] gpio: pcf857x: Add OF support

2013-09-21 Thread Laurent Pinchart
Add DT bindings for the pcf857x-compatible chips and parse the device tree node in the driver. Signed-off-by: Laurent Pinchart --- .../devicetree/bindings/gpio/gpio-pcf857x.txt | 71 ++ drivers/gpio/gpio-pcf857x.c| 44 +++--- 2 files

Re: [PATCH] Revert "V4L/DVB: uvc: Enable USB autosuspend by default on uvcvideo"

2013-09-24 Thread Laurent Pinchart
Hi Adam, On Thursday 13 June 2013 17:56:47 Adam Lee wrote: > On Thu, Apr 25, 2013 at 02:33:06PM +0800, Adam Lee wrote: > > On Wed, Apr 24, 2013 at 11:17:52AM +0200, Laurent Pinchart wrote: > > > On Wednesday 24 April 2013 15:57:19 adam@canonical.com wrote: >

Re: [PATCH v6 0/5] clk: clock deregistration support

2013-09-25 Thread Laurent Pinchart
er); > + > +static inline struct clk *clk_register(struct device *dev, struct > clk_hw *hw) > +{ > + return ___clk_register(dev, hw, THIS_MODULE); > +} > + > +struct clk *__devm_clk_register(struct device *dev, struct clk_hw *hw, > + struct mo

Re: [PATCH 2/4] ARM: shmobile: r8a7790: add I2C support in Device Tree mode

2013-09-25 Thread Laurent Pinchart
> [MSTP720] = SH_CLK_MSTP32(&p_clk, SMSTPCR7, 20, 0), /* SCIF1 */ > @@ -261,6 +267,10 @@ static struct clk_lookup lookups[] = { > CLKDEV_DEV_ID("sh-sci.7", &mstp_clks[MSTP720]), > CLKDEV_DEV_ID("sh-sci.8", &mstp_clks[MSTP717]), &

Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7790: add pin definitions for the I2C3 interface

2013-09-25 Thread Laurent Pinchart
_groups[] = { > + "i2c3", > +}; > + > static const char * const intc_groups[] = { > "intc_irq0", > "intc_irq1", > @@ -3469,6 +3496,7 @@ static const struct sh_pfc_function pinmux_functions[] > = { SH_PFC_FUNCTION(eth), >

[PATCH] drivers: cma: Fix wrong CMA selected region size default value

2012-10-17 Thread Laurent Pinchart
Kconfig lists CMA_SIZE_SEL_ABSOLUTE as the default value fo the CMA selected region size, but that option isn't available in the defined choices. Set the default to CMA_SIZE_SEL_MBYTES instead. Signed-off-by: Laurent Pinchart --- drivers/base/Kconfig |2 +- 1 files changed, 1 inser

[PATCH 2/2] drivers: dma-coherent: Fix typo in dma_mmap_from_coherent documentation

2012-10-17 Thread Laurent Pinchart
The function documentation incorrectly references dma_release_coherent. Fix it. Don't mention a specific function name as dma_mmap_from_coherent as multiple callers. Signed-off-by: Laurent Pinchart --- drivers/base/dma-coherent.c |5 ++--- 1 files changed, 2 insertions(+), 3 dele

[PATCH 1/2] drivers: dma-contiguous: Don't redefine SZ_1M

2012-10-17 Thread Laurent Pinchart
Use the definition from linux/sizes.h instead. Signed-off-by: Laurent Pinchart --- drivers/base/dma-contiguous.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c index 9a14694..612afcc 100644 --- a/drivers

[RFC] linux/time.h vs. sys/time.h mess (was [PATCH 1/2] [media] remove include/linux/dvb/dmx.h)

2012-10-19 Thread Laurent Pinchart
VIDEODEV2_H #include /* need struct timeval */ #include #endif /* __LINUX_VIDEODEV2_H */ Patches have been posted to remove those headers and push the #include one level up, which breaks the "self-contained" headers concept. How could we fix this ? Are there legitimate users of

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-22 Thread Laurent Pinchart
index 6ae70cb..acd513b 100644 > > > --- a/drivers/usb/gadget/fsl_udc_core.c > > > +++ b/drivers/usb/gadget/fsl_udc_core.c > > > @@ -955,7 +955,10 @@ static int fsl_ep_dequeue(struct usb_ep *_ep, > > struct usb_request *_req) > > > > > int ep_num, stopped, r

Re: [PATCH RESEND] media: davinci: vpbe: fix build warning

2012-10-22 Thread Laurent Pinchart
gt; return val; > } > @@ -88,9 +88,9 @@ static inline u32 osd_modify(struct osd_state *sd, u32 > mask, u32 val, struct osd_state *osd = sd; > > u32 addr = osd->osd_base + offset; > - u32 new_val = (readl(addr) & ~mask) | (val & mask); > + u32 new_v

Re: [PATCH v4 1/2] iommu/shmobile: Add iommu driver for Renesas IPMMU modules

2012-12-10 Thread Laurent Pinchart
vice failed\n"); > + } > +err: > + spin_unlock(&lock_add); > + return 0; > +} > + > +void ipmmu_add_device(struct device *dev) > +{ > + spin_lock(&lock_add); > + dev->archdata.iommu = ipmmu_devices; > + ipmmu_devices = dev; That looks a bit h

Re: [PATCH v4] fbdev: sh_mobile_lcdc: use dma_mmap_coherent

2012-12-10 Thread Laurent Pinchart
Hi Eiraku-san, On Monday 10 December 2012 19:31:25 Hideki EIRAKU wrote: > On Thu, 16 Aug 2012 14:16:32 +0200 Laurent Pinchart wrote: > > On Thursday 16 August 2012 19:13:20 Hideki EIRAKU wrote: > >> fb_mmap() implemented in fbmem.c uses smem_start as the physical > >>

Re: [PATCH v4 1/2] iommu/shmobile: Add iommu driver for Renesas IPMMU modules

2012-12-11 Thread Laurent Pinchart
Hi Eiraku-san, On Tuesday 11 December 2012 19:10:42 Hideki EIRAKU wrote: > On Mon, 10 Dec 2012 16:55:58 +0100 Laurent Pinchart wrote: > > On Monday 15 October 2012 17:34:52 Hideki EIRAKU wrote: > >> This is the Renesas IPMMU driver and IOMMU API implementation. > >

  1   2   3   4   5   6   7   8   9   10   >