[PATCH] of: make sure of_alias is initialized before accessing it

to use core stdout parsing code] Signed-off-by: Laurentiu Tudor laurentiu.tu...@freescale.com Cc: Grant Likely grant.lik...@linaro.org --- drivers/of/base.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index d8574ad

Re: [PATCH] of: make sure of_alias is initialized before accessing it

On 09/08/2014 04:29 PM, Grant Likely wrote: On Wed, 27 Aug 2014 17:09:39 +0300, Laurentiu Tudor b10...@freescale.com wrote: Simply swap of_alias and of_chosen initialization so that of_alias ends up read first. This must be done because it is accessed couple of lines below when trying

Re: [PATCH 03/15] powerpc/msi: Improve IRQ bitmap allocator

On 09/19/2014 11:16 PM, Scott Wood wrote: On Thu, 2014-09-18 at 18:26 +1000, Michael Neuling wrote: From: Ian Munsie imun...@au1.ibm.com Currently msi_bitmap_alloc_hwirqs() will round up any IRQ allocation requests to the nearest power of 2. eg. ask for 5 IRQs and you'll get 8. This

Re: [PATCH 03/15] powerpc/msi: Improve IRQ bitmap allocator

On 09/19/2014 11:19 PM, Scott Wood wrote: On Fri, 2014-09-19 at 15:16 -0500, Scott Wood wrote: On Thu, 2014-09-18 at 18:26 +1000, Michael Neuling wrote: From: Ian Munsie imun...@au1.ibm.com Currently msi_bitmap_alloc_hwirqs() will round up any IRQ allocation requests to the nearest power

Re: [PATCH 03/15] powerpc/msi: Improve IRQ bitmap allocator

Hi Michael, Minor comment inline. On 09/18/2014 11:26 AM, Michael Neuling wrote: From: Ian Munsie imun...@au1.ibm.com Currently msi_bitmap_alloc_hwirqs() will round up any IRQ allocation requests to the nearest power of 2. eg. ask for 5 IRQs and you'll get 8. This wastes a lot of IRQs

Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support

Hi Jingchang, On 09/23/2014 09:46 AM, Jingchang Lu wrote: The IP is shared by PPC and ARM, this renames it to qoriq for better represention, and this also adds the CLK_OF_DECLARE support for being initialized by of_clk_init() on ARM. I think you need to also update

Re: [PATCH 5/8] arm64: kernel: replace early 64-bit literal loads with move-immediates

On 04/18/2016 06:09 PM, Ard Biesheuvel wrote: > When building a relocatable kernel, we currently rely on the fact that > early 64-bit literal loads need to be deferred to after the relocation > has been performed only if they involve symbol references, and not if > they involve assemble time

Re: [PATCH 4/9] staging: fsl-mc: don't use devres api for refcounted objects

talin >> Horghidan >> <catalin.horghi...@nxp.com>; Leo Li <leoyang...@nxp.com>; Roy Pledge >> <roy.ple...@nxp.com>; Laurentiu >> Tudor <laurentiu.tu...@nxp.com> >> Subject: [PATCH 4/9] staging: fsl-mc: don't use devres api for refcounted >> o

Re: [PATCH 2/9] staging: fsl-mc: fix device ref counting

Hi Greg, Thanks for having a look. Comment below. On 02/03/2017 11:56 AM, Greg KH wrote: > On Wed, Feb 01, 2017 at 05:43:22AM -0600, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Drop unneeded get_device() call at dev

Re: [PATCH 3/9] staging: fsl-mc: add device release callback

> <catalin.horghi...@nxp.com>; Leo Li <leoyang...@nxp.com>; Stuart Yoder >> <stuart.yo...@nxp.com>; >> Laurentiu Tudor <laurentiu.tu...@nxp.com> >> Subject: [upstream-release] [PATCH 3/9] staging: fsl-mc: add device release >> callback >> &

Re: [PATCH] staging: fsl-mc: Add missing header

ex 0e2c1b5..87e4471 100644 > --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > @@ -17,6 +17,7 @@ > #include > #include > #include "../include/mc-bus.h" > +#include "fsl-mc-private.h" > > static struct irq_chip its_msi_irq_chip = { > .name = "ITS-fMSI", > Acked-by: Laurentiu Tudor <laurentiu.tu...@nxp.com> --- Best Regards, Laurentiu

Re: [PATCH] staging: fsl-mc: fix warning in DT ranges parser

unction return code > rather than passing it by reference. With this change, gcc can see that > we don't evaluate the cell numbers for an missing ranges property. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Looks good to me, i've tested it and did not see any issues, so here's

[PATCH] Documentation: kasan: arm64 has kasan support too

Mention that arm64 also has kasan support. Signed-off-by: Laurentiu Tudor <laurentiu.tu...@nxp.com> --- Documentation/kasan.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/kasan.txt b/Documentation/kasan.txt index 7dd95b3..c156934 100644 --- a/Documen

Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

On 12/05/2016 10:52 PM, Dan Carpenter wrote: > On Fri, Dec 02, 2016 at 12:12:14PM +0000, Laurentiu Tudor wrote: >>> +static inline bool dpaa2_sg_is_final(const struct dpaa2_sg_entry *sg) >>> +{ >>> + return !!(le16_to_cpu(sg->format_offset) >> SG_F

Re: [PATCH v3 5/9] bus: fsl-mc: dpio: add global dpaa2 definitions

On 12/02/2016 12:41 AM, Stuart Yoder wrote: > From: Roy Pledge > > Create header for global dpaa2 definitions. Add definitions > for dequeue results. > > Signed-off-by: Roy Pledge > Signed-off-by: Stuart Yoder > --- >

Re: [PATCH v3 6/9] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2

On 12/02/2016 12:41 AM, Stuart Yoder wrote: > From: Roy Pledge > > Add QBman APIs for frame queue and buffer pool operations. > > Signed-off-by: Roy Pledge > Signed-off-by: Haiying Wang > Signed-off-by: Stuart Yoder

Re: [PATCH v3 7/9] bus: fsl-mc: dpio: add the DPAA2 DPIO service interface

On 12/02/2016 12:41 AM, Stuart Yoder wrote: > From: Roy Pledge > > The DPIO service interface handles initialization of DPIO objects > and exports APIs to be used by other DPAA2 object drivers to perform > queuing and buffer management related operations. The service allows

Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

Some more bits and pieces inside. --- Best Regards, Laurentiu On 12/02/2016 12:41 AM, Stuart Yoder wrote: > From: Roy Pledge > > Add global definitions for DPAA2 frame descriptors and scatter > gather entries. > > Signed-off-by: Roy Pledge >

Re: [PATCH v3 3/9] bus: fsl-mc: dpio: add APIs for DPIO objects

Couple of nits inline. --- Best Regards, Laurentiu On 12/02/2016 12:41 AM, Stuart Yoder wrote: > From: Ioana Radulescu > > Add the command build/parse APIs for operating on DPIO objects through > the DPAA2 Management Complex. > > Signed-off-by: Ioana Radulescu

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

Hi Stephen, That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not all arches implement the support for the option. I can submit a patch that adds explicit dependencies on arches that it was build-tested (x86, arm, powerpc, all both 32 and 64 bits) similar to how it's done

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

On 07/31/2017 06:58 PM, Greg KH wrote: > On Mon, Jul 31, 2017 at 09:55:14AM +0000, Laurentiu Tudor wrote: >> Hi Stephen, >> >> That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not >> all arches implement the support for the option. I can submit a

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

On 08/16/2017 03:06 PM, Dan Carpenter wrote: > On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The previous fix removed the equal to zero comparisons by the strcmps and >> now the function always returns true. Fix this by adding

Re: [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

Hi Robin, On 07/17/2017 04:43 PM, Robin Murphy wrote: > On 17/07/17 14:26, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Split the 64-bit accesses in 32-bit accesses because there's no real >> constrain in MC to do onl

Re: [PATCH 2/7] staging: fsl-mc: use generic memory barriers

On 07/17/2017 04:38 PM, Robin Murphy wrote: > On 17/07/17 14:26, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> No need to use arch-specific memory barriers; switch to using generic >> ones. The rmb()s were usele

Re: [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

Hi Arnd, On 07/17/2017 04:45 PM, Arnd Bergmann wrote: > On Mon, Jul 17, 2017 at 3:26 PM, <laurentiu.tu...@nxp.com> wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Split the 64-bit accesses in 32-bit accesses because there's no real >> c

Re: [PATCH v2 6/8] staging: fsl-mc: don't use raw device io functions

Hi Arnd, On 07/18/2017 05:18 PM, Arnd Bergmann wrote: > On Tue, Jul 18, 2017 at 3:37 PM, <laurentiu.tu...@nxp.com> wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> As raw device io functions are not portable and don't handle byte-order >>

Re: [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

On 07/17/2017 06:00 PM, Arnd Bergmann wrote: > On Mon, Jul 17, 2017 at 4:27 PM, Laurentiu Tudor > <laurentiu.tu...@nxp.com> wrote: >> Hi Arnd, >> >> On 07/17/2017 04:45 PM, Arnd Bergmann wrote: >>> On Mon, Jul 17, 2017 at 3:26 PM, <laurentiu.tu...@

Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch

Hi Arnd, On 07/18/2017 05:25 PM, Arnd Bergmann wrote: > On Tue, Jul 18, 2017 at 3:37 PM, wrote: > >> --- a/drivers/staging/fsl-dpaa2/Kconfig >> +++ b/drivers/staging/fsl-dpaa2/Kconfig >> @@ -4,7 +4,7 @@ >> >> config FSL_DPAA2 >> bool "Freescale DPAA2 devices"

Re: [PATCH v2 0/7] staging: fsl-mc: make the driver compile on other architectures

Hi Arnd, On 07/18/2017 05:26 PM, Arnd Bergmann wrote: > On Tue, Jul 18, 2017 at 3:37 PM, <laurentiu.tu...@nxp.com> wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Apart from a small change (first patch) which adds a missing comment, >>

Re: [PATCH 7/7] staging: fsl-mc: allow the driver compile multi-arch

Hi, Sparc seems to be broken in multiple places, including generic code. Is this a known issue? Is there something I could/should do? --- Thanks & Best Regards, Laurentiu On 07/19/2017 08:31 PM, kbuild test robot wrote: > Hi Laurentiu, > > [auto build test ERROR on staging/staging-testing] >

Re: [PATCH] staging: fsl-mc: move bus driver out of staging

.txt >> >> Update or delete other remaining staging files-- Makefile, Kconfig, TODO. >> Update dpaa2_eth and dpio staging drivers. >> >> Signed-off-by: Stuart Yoder <stuyo...@gmail.com> >> Signed-off-by: Laurentiu Tudor <laurentiu.tu...@nxp.com> >>

Re: [PATCH] powerpc: booke: fix boot crash due to null hugepd

Hi Greg, On 05/17/2017 12:15 PM, Greg KH wrote: > On Tue, May 16, 2017 at 09:47:52AM -0500, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> On 32-bit book-e machines, hugepd_ok() does not take >> into account null hugepd v

Re: [PATCH 01/14] staging: fsl-mc: drop macros with possible side effects

Hi Joe, On 06/22/2017 07:07 PM, Joe Perches wrote: > On Thu, 2017-06-22 at 16:35 +0300, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Several macros were triggering this checkpatch.pl warning: >>"Macro argumen

Re: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix address translations

Hi Ioana, Debatable nit inline. On 05/24/2017 03:13 PM, Ioana Radulescu wrote: > Use the correct mechanisms for translating a DMA-mapped IOVA > address into a virtual one. Without this fix, once SMMU is > enabled on Layerscape platforms, the Ethernet driver throws > IOMMU translation faults. > >

Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings

Hi Greg, On 05/25/2017 07:58 PM, Greg KH wrote: > On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> > > Your subject line is very odd, please use the 'v2' marking properly... > >> >&g

RE: [PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging

Hi Marc, > -Original Message- > From: Marc Zyngier [mailto:marc.zyng...@arm.com] > Sent: Monday, May 22, 2017 10:41 AM > > On Mon, May 22 2017 at 7:12:39 am GMT, Laurentiu Tudor > <laurentiu.tu...@nxp.com> wrote: > > Hi Laurentiu, > > >

RE: [PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging

Hi Marc, > -Original Message- > From: Marc Zyngier [mailto:marc.zyng...@arm.com] > Sent: Saturday, May 20, 2017 9:43 AM > To: Matthias Brugger <matthias@gmail.com> > Cc: Laurentiu Tudor <laurentiu.tu...@nxp.com>; gre...@linuxfoundation.or

RE: [PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging

> -Original Message- > From: Marc Zyngier [mailto:marc.zyng...@arm.com] > Sent: Monday, May 22, 2017 12:06 PM > To: Laurentiu Tudor <laurentiu.tu...@nxp.com> > > On 22/05/17 09:42, Laurentiu Tudor wrote: > > Hi Marc, > > > >> -

Re: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix address translations

On 05/25/2017 03:31 PM, Ruxandra Ioana Radulescu wrote: >> -Original Message- >> From: Laurentiu Tudor >> Sent: Wednesday, May 24, 2017 3:34 PM >> To: Ruxandra Ioana Radulescu <ruxandra.radule...@nxp.com>; >> gre...@linuxfoundation.org >> Cc

Re: [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging

t; >> Update or delete other remaining staging files-- Makefile, Kconfig, TODO. >> Update dpaa2_eth and dpio staging drivers. >> >> Signed-off-by: Stuart Yoder <stuyo...@gmail.com> >> Signed-off-by: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> [Laurentiu: re

RE: [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, June 06, 2017 5:20 PM > To: Laurentiu Tudor <laurentiu.tu...@nxp.com> > > On Tue, Jun 06, 2017 at 02:03:44PM +, Laurentiu Tudor wrote: > > Hi Greg, &

RE: [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging

Hi Greg, > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, June 03, 2017 11:40 AM > > On Wed, May 31, 2017 at 01:58:52PM +0300, laurentiu.tu...@nxp.com wrote: > > From: Stuart Yoder > > Your subject says 'v4' yet the other

Re: [PATCH v7 02/10] staging: fsl-mc: fix macros with possible side effects

On 06/13/2017 01:12 PM, Greg KH wrote: > On Thu, Jun 08, 2017 at 05:28:47PM +0300, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Several macros were triggering this checkpatch.pl warning: >>"Macro argumen

Re: [PATCH v7 10/10] staging: fsl-mc: move bus driver out of staging

Hi Greg, On 06/13/2017 01:22 PM, Greg KH wrote: > On Thu, Jun 08, 2017 at 05:28:55PM +0300, laurentiu.tu...@nxp.com wrote: >> From: Stuart Yoder >> >> Move the source files out of staging into their final locations: >>-include files in drivers/staging/fsl-mc/include go

RE: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

Hi Greg, > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, June 03, 2017 11:41 AM > > On Wed, May 31, 2017 at 01:58:43PM +0300, laurentiu.tu...@nxp.com wrote: > > From: Laurentiu Tudor <laurentiu.tu...@nxp.com> > &

RE: [PATCH v2] staging: fsl-mc: move bus driver out of staging

mc > > -README.txt, providing and overview of DPAA goes to > >Documentation/dpaa2/overview.txt > > > > Update or delete other remaining staging files-- Makefile, Kconfig, TODO. > > Update dpaa2_eth and dpio staging drivers. > > > > Signed-off-by: Stuart Yod

RE: [PATCH v2] staging: fsl-mc: move bus driver out of staging

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, September 11, 2017 4:03 PM > > On Mon, Sep 11, 2017 at 11:55:22AM +0000, Laurentiu Tudor wrote: > > Hi, > > > > > -Original Message- > > > Fro

Re: mpic IRQ_TYPE_BOTH handling

On 08/31/2017 01:52 AM, Michael Ellerman wrote: > Hi Gregory, > > Gregory Fong writes: >> Hi all, >> >> In arch/powerpc/sysdev/mpic.c , it looks like IRQ_TYPE_EDGE_BOTH is >> handled the same way as IRQ_TYPE_EDGE_FALLING: >> >> static unsigned int

Re: [RESEND PATCH 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

rginean >>> <alexandru.margin...@nxp.com>; Ruxandra Ioana Radulescu >>> <ruxandra.radule...@nxp.com>; Laurentiu Tudor >> <laurentiu.tu...@nxp.com>; >>> stuyo...@gmail.com >>> Subject: RE: [RESEND PATCH 2/6] staging: fsl-dpaa2/ethsw: Add >

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

README.txt, providing and overview of DPAA goes to >>> Documentation/dpaa2/overview.txt >>> >>> Update or delete other remaining staging files-- Makefile, Kconfig, TODO. >>> Update dpaa2_eth and dpio staging drivers. >>> >>> Signed-off-by: S

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

On 11/28/2017 02:59 PM, Greg KH wrote: > On Mon, Nov 27, 2017 at 03:32:28PM +0000, Laurentiu Tudor wrote: >> >> >> On 11/03/2017 05:17 PM, Greg KH wrote: >>> On Thu, Aug 31, 2017 at 06:04:30PM +0200, Greg KH wrote: >>>> On Mon, Aug 28, 2017 at 01:54

Re: [PATCH v3] staging: fsl-mc: use 32bits to support 64K size mc-portals

com> > --- Ok, so just to clarify this fixes the case where size is equal (or maybe larger in the future) to 0x10000. Acked-By: Laurentiu Tudor <laurentiu.tu...@nxp.com> --- Best Regards, Laurentiu

Re: [PATCH v3] staging: fsl-mc: move bus driver out of staging

Hi Andrew, On 11/28/2017 06:04 PM, Andrew Lunn wrote: > On Tue, Nov 28, 2017 at 05:27:57PM +0200, laurentiu.tu...@nxp.com wrote: >> diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/bus/fsl-mc/dpmcp.h >> similarity index 100% >> rename from drivers/staging/fsl-mc/bus/dpmcp.h >> rename to

Re: [PATCH] staging: fsl-mc: fix uninitialized variable use

On 11/27/2017 11:08 AM, Greg KH wrote: > On Mon, Nov 27, 2017 at 11:01:34AM +0200, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Fix this warning triggering on a powerpc build: >> warning: 'error' may be used uninitiali

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

.txt >> >> Update or delete other remaining staging files-- Makefile, Kconfig, TODO. >> Update dpaa2_eth and dpio staging drivers. >> >> Signed-off-by: Stuart Yoder <stuyo...@gmail.com> >> Signed-off-by: Laurentiu Tudor <laurentiu.tu...@nxp.com> >>

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

On 12/19/2017 05:29 PM, Greg KH wrote: > On Tue, Dec 19, 2017 at 03:21:19PM +0000, Laurentiu Tudor wrote: >> >> >> On 12/19/2017 04:48 PM, Greg KH wrote: >>> On Wed, Nov 29, 2017 at 12:08:44PM +0200, laurentiu.tu...@nxp.com wrote: >>>> From: Stuart Y

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

On 12/19/2017 06:10 PM, Greg KH wrote: > On Tue, Dec 19, 2017 at 03:39:44PM +0000, Laurentiu Tudor wrote: >> On 12/19/2017 05:29 PM, Greg KH wrote: >>> On Tue, Dec 19, 2017 at 03:21:19PM +0000, Laurentiu Tudor wrote: >>>> >>>> >>>> On 12

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

On 12/20/2017 12:42 PM, Greg KH wrote: > On Wed, Dec 20, 2017 at 10:26:49AM +0000, Laurentiu Tudor wrote: >> On 12/19/2017 06:10 PM, Greg KH wrote: >>>>> But all of these .h files are only used by the code in this specific >>>>> directory, no where el

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

On 12/20/2017 01:06 PM, Greg KH wrote: > On Wed, Dec 20, 2017 at 10:52:52AM +0000, Laurentiu Tudor wrote: >> >> >> On 12/20/2017 12:42 PM, Greg KH wrote: >>> On Wed, Dec 20, 2017 at 10:26:49AM +, Laurentiu Tudor wrote: >>>> On 12/19/2017 06:10 PM,

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

;-README.txt, providing and overview of DPAA goes to >>> Documentation/dpaa2/overview.txt >>> >>> Update or delete other remaining staging files-- Makefile, Kconfig, TODO. >>> Update dpaa2_eth and dpio staging drivers. >>> >>> Signed

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

README.txt, providing and overview of DPAA goes to >>> Documentation/dpaa2/overview.txt >>> >>> Update or delete other remaining staging files-- Makefile, Kconfig, TODO. >>> Update dpaa2_eth and dpio staging drivers. >>> >>> Signed-off-by: S

Re: [PATCH 1/2] staging: fsl-mc: Allocate IRQ's before scanning DPRC objects

On 12/07/2017 03:18 PM, Nipun Gupta wrote: > > >> -Original Message----- >> From: Laurentiu Tudor >> Sent: Wednesday, December 06, 2017 19:00 >> To: Nipun Gupta <nipun.gu...@nxp.com>; stuyo...@gmail.com; Bharat >> Bhushan <bharat.bhus...@

Re: [PATCH 1/2] staging: fsl-mc: Allocate IRQ's before scanning DPRC objects

Hi Nipun, Can you polish a bit this commit message? It doesn't seem to explain why this is needed. On 12/06/2017 06:18 PM, Nipun Gupta wrote: > When DPRC probing is deferred (such as where IOMMU is not probed > before the fsl-mc bus), all the devices in the DPRC containers gets > initialized

Re: [PATCH 1/2] staging: fsl-mc: Allocate IRQ's before scanning DPRC objects

Hi Bharat, On 12/06/2017 04:03 PM, Bharat Bhushan wrote: > Hi Laurentiu, > >> -Original Message----- >> From: Laurentiu Tudor >> Sent: Wednesday, December 06, 2017 7:00 PM >> To: Nipun Gupta <nipun.gu...@nxp.com>; stuyo...@gmail.com; Bharat >

Re: [PATCH 5/6 v3] bus: fsl-mc: supoprt dma configure for devices on fsl-mc bus

Hi Nipun, On 04/27/2018 01:27 PM, Nipun Gupta wrote: > Signed-off-by: Nipun Gupta > --- > drivers/bus/fsl-mc/fsl-mc-bus.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c

Re: [PATCH 6/7 v5] bus: fsl-mc: set coherent dma mask for devices on fsl-mc bus

On 05/20/2018 04:49 PM, Nipun Gupta wrote: > of_dma_configure() API expects coherent_dma_mask to be correctly > set in the devices. This patch does the needful. > > Signed-off-by: Nipun Gupta <nipun.gu...@nxp.com> Acked-by: Laurentiu Tudor <laurentiu.tu...@nxp.com> ---

[PATCH] irqchip/ls-scfg-msi: map MSIs in the iommu

Add the required iommu_dma_map_msi_msg() when composing the MSI message, otherwise the interrupts will not work. Signed-off-by: Laurentiu Tudor --- drivers/irqchip/irq-ls-scfg-msi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq

Re: [PATCH] irqchip/ls-scfg-msi: update effective affinity mask

Hi Marc, On 26.06.2018 17:56, Marc Zyngier wrote: > On Tue, 26 Jun 2018 15:37:12 +0100, > Laurentiu Tudor wrote: >> >> Update the effective affinity mask to fix this warning issued by the >> generic irq handling code: >> >> "genirq: irq_chip MSI d

[PATCH] irqchip/ls-scfg-msi: update effective affinity mask

Update the effective affinity mask to fix this warning issued by the generic irq handling code: "genirq: irq_chip MSI did not update eff. affinity mask of irq x" Signed-off-by: Laurentiu Tudor --- drivers/irqchip/irq-ls-scfg-msi.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] mmc: sdhci-of-esdhc: set proper dma mask for ls104x chips

Hi Uffe, On 02.07.2018 17:37, Ulf Hansson wrote: > On 28 June 2018 at 10:45, Laurentiu Tudor wrote: >> SDHCI controller in ls1043a and ls1046a generate 40-bit wide addresses >> when doing DMA. Make sure that the corresponding dma mask is correctly >> configured. >>

Re: [PATCH v4 6/6] arm64: dts: ls208xa: comply with the iommu map binding for fsl_mc

Hi Nipun, On 04/30/2018 09:27 AM, Nipun Gupta wrote: > fsl-mc bus support the new iommu-map property. Comply to this binding > for fsl_mc bus. > > Signed-off-by: Nipun Gupta <nipun.gu...@nxp.com> This looks good to me, so: Reviewed-By: Laurentiu Tudor <laurentiu.tu...@nxp.c

Re: [PATCH v4 5/6] bus: fsl-mc: supoprt dma configure for devices on fsl-mc bus

s good to me, so Reviewed-by: Laurentiu Tudor <laurentiu.tu...@nxp.com> --- Best Regards, Laurentiu > drivers/bus/fsl-mc/fsl-mc-bus.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-m

[PATCH v2] mmc: sdhci-of-esdhc: set proper dma mask for ls104x chips

dma mask fixes this situation. Signed-off-by: Laurentiu Tudor --- Changes in v2: - updated commit log with some context drivers/mmc/host/sdhci-of-esdhc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index

Re: [PATCH 1/2] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

Hi Roy, Couple of comments inline. On 05.07.2018 22:41, Roy Pledge wrote: > Move the NXP DPIO (Datapath I/O Driver) out of the > drivers/staging directory and into the drivers/soc/fsl directory. > > The DPIO driver enables access to Queue and Buffer Manager (QBMAN) > hardware on NXP DPAA2

Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver

Hi Dan, On 03/15/2018 12:56 PM, Dan Carpenter wrote: > On Thu, Mar 15, 2018 at 12:44:37AM +0100, Andrew Lunn wrote: >> On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: >>> This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs >>> with DPAA2 (DataPath

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

Hello, My 2c below. On 04/04/2018 03:42 PM, Andrew Lunn wrote: >> I hear you. It is more complicated this way...having all these individual >> objects vs just a single "bundle" of them that represents a NIC. But, that's >> the way the DPAA2 hardware is, and we're implementing kernel support

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

On 04/05/2018 02:47 PM, Andrew Lunn wrote: > On Thu, Apr 05, 2018 at 10:30:01AM +0000, Laurentiu Tudor wrote: >> Hello, >> >> My 2c below. >> >> On 04/04/2018 03:42 PM, Andrew Lunn wrote: >>>> I hear you. It is more complicated this way...hav

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

Hi Greg, On 04/05/2018 03:30 PM, gregkh wrote: > On Thu, Apr 05, 2018 at 10:30:01AM +0000, Laurentiu Tudor wrote: >> Hello, >> >> My 2c below. >> >> On 04/04/2018 03:42 PM, Andrew Lunn wrote: >>>> I hear you. It is more complicated this way...hav

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

Hi Andrew, On 04/05/2018 03:48 PM, Andrew Lunn wrote: >>> Hi Laurentiu >>> >>> So i can use switchdev without it? I can modprobe the switchdev >>> driver, all the physical interfaces will appear, and i can use ip addr >>> add etc. I do not need to use a user space tool at all in order to use >>>

Re: [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging

bp.c > @@ -5,9 +5,9 @@ >*/ > #include > #include > -#include "../include/dpbp.h" > +#include "linux/fsl/mc.h" I think we can use <> here, same comment for patch 3/3. Other than that, the series looks ok to me so for all the patches: Reviewed-by: La

[PATCH] mmc: sdhci-of-esdhc: set proper dma mask for ls104x chips

SDHCI controller in ls1043a and ls1046a generate 40-bit wide addresses when doing DMA. Make sure that the corresponding dma mask is correctly configured. Signed-off-by: Laurentiu Tudor --- drivers/mmc/host/sdhci-of-esdhc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/mmc

Re: [PATCH v1 1/2] bus: mc-bus: Add support for mapping shareable portals

Hi Roy, On 30.10.2018 22:30, Roy Pledge wrote: > Starting with v5 of NXP QBMan devices the hardware supports using > regular cacheable/shareable memory as the backing store for the > portals. > > This patch adds support for the new portal mode by switching to > use the DPRC get object region v2

Re: [PATCH] bus: fsl-mc: explicitly define the fsl_mc_command endianness

On 02.10.2018 15:16, Ioana Ciornei wrote: > Both the header and the command parameters of the fsl_mc_command are > 64-bit little-endian words. Use the appropriate type to explicitly > specify their endianness. > > Signed-off-by: Ioana Ciornei Reviewed-By: Laurentiu Tudor -

[PATCH v3 16/22] arm64: dts: ls1046a: add smmu node

From: Laurentiu Tudor This allows for the SMMU device to be probed by the SMMU kernel driver. Signed-off-by: Laurentiu Tudor --- .../arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 42 +++ 1 file changed, 42 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/fsl

Re: [GIT PULL] fixes for soc/fsl drivers for v4.19 take 2

> - Fix crash of qman_portal by deferring its probe if qman is not probed > > > Laurentiu Tudor (2): >soc: fsl: qbman: add APIs to retrieve the probing status >soc: fsl: qman_portals: defer probe after qman's probe There's a similar fix for bman portals [1]. I w

Re: [PATCH 00/21] SMMU enablement for NXP LS1043A and LS1046A

Hi Robin, On 19.09.2018 16:25, Robin Murphy wrote: > Hi Laurentiu, > > On 19/09/18 13:35, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor >> >> This patch series adds SMMU support for NXP LS1043A and LS1046A chips >> and consists mostly in important dri

[PATCH v2 18/22] arm64: dts: ls104xa: set mask to drop TBU ID from StreamID

From: Laurentiu Tudor The StreamID entering the SMMU is actually a concatenation of the SMMU TBU ID and the ICID configured in software. Since the TBU ID is internal to the SoC and since we want that the actual the ICID configured in software to enter the SMMU witout any additional set bits

[PATCH v2 15/22] dpaa_eth: fix SG frame cleanup

From: Laurentiu Tudor Fix issue with the entry indexing in the sg frame cleanup code being off-by-1. This problem showed up when doing some basic iperf tests and manifested in traffic coming to a halt. Signed-off-by: Laurentiu Tudor --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1

[PATCH v2 08/22] soc/fsl/qbman_portals: add APIs to retrieve the probing status

From: Laurentiu Tudor Add a couple of new APIs to check the probing status of the required cpu bound qman and bman portals: 'int bman_portals_probed()' and 'int qman_portals_probed()'. They return the following values. * 1 if qman/bman portals were all probed correctly * 0 if qman/bman

[PATCH v2 11/22] dpaa_eth: defer probing after qbman

From: Laurentiu Tudor Enabling SMMU altered the order of device probing causing the dpaa1 ethernet driver to get probed before qbman and causing a boot crash. Add predictability in the probing order by deferring the ethernet driver probe after qbman and portals by using the recently introduced

Re: [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging

> #include > #include > -#include "../include/dpbp.h" > +#include "linux/fsl/mc.h" I think we can use <> here, same comment for patch 3/3. Other than that, the series looks ok to me so for all the patches: Reviewed-by: Laurentiu Tudor --- Best Regar

Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver

Hi Dan, On 03/15/2018 12:56 PM, Dan Carpenter wrote: > On Thu, Mar 15, 2018 at 12:44:37AM +0100, Andrew Lunn wrote: >> On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: >>> This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs >>> with DPAA2 (DataPath

Re: [PATCH 5/6 v3] bus: fsl-mc: supoprt dma configure for devices on fsl-mc bus

Hi Nipun, On 04/27/2018 01:27 PM, Nipun Gupta wrote: > Signed-off-by: Nipun Gupta > --- > drivers/bus/fsl-mc/fsl-mc-bus.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c > index

Re: [PATCH v4 6/6] arm64: dts: ls208xa: comply with the iommu map binding for fsl_mc

Hi Nipun, On 04/30/2018 09:27 AM, Nipun Gupta wrote: > fsl-mc bus support the new iommu-map property. Comply to this binding > for fsl_mc bus. > > Signed-off-by: Nipun Gupta This looks good to me, so: Reviewed-By: Laurentiu Tudor --- Best Regards, Laurentiu > --- > a

Re: [PATCH v4 5/6] bus: fsl-mc: supoprt dma configure for devices on fsl-mc bus

viewed-by: Laurentiu Tudor --- Best Regards, Laurentiu > drivers/bus/fsl-mc/fsl-mc-bus.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c > index 5d8266c..624828b 100644 > ---

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

Hi Stephen, That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not all arches implement the support for the option. I can submit a patch that adds explicit dependencies on arches that it was build-tested (x86, arm, powerpc, all both 32 and 64 bits) similar to how it's done

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

On 07/31/2017 06:58 PM, Greg KH wrote: > On Mon, Jul 31, 2017 at 09:55:14AM +0000, Laurentiu Tudor wrote: >> Hi Stephen, >> >> That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not >> all arches implement the support for the option. I can submit a

Re: [RESEND PATCH 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

To: Razvan Stefanescu ; >>> gre...@linuxfoundation.org >>> Cc: de...@driverdev.osuosl.org; linux-kernel@vger.kernel.org; >>> net...@vger.kernel.org; ag...@suse.de; a...@arndb.de; Alexandru >> Marginean >>> ; Ruxandra Ioana Radulescu >>> ; Laur

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

delete other remaining staging files-- Makefile, Kconfig, TODO. >> Update dpaa2_eth and dpio staging drivers. >> >> Signed-off-by: Stuart Yoder >> Signed-off-by: Laurentiu Tudor >> [Laurentiu: rebased, add dpaa2_eth and dpio #include updates] >> Cc: Thomas Gleixn

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

On 12/19/2017 05:29 PM, Greg KH wrote: > On Tue, Dec 19, 2017 at 03:21:19PM +0000, Laurentiu Tudor wrote: >> >> >> On 12/19/2017 04:48 PM, Greg KH wrote: >>> On Wed, Nov 29, 2017 at 12:08:44PM +0200, laurentiu.tu...@nxp.com wrote: >>>> From: Stuart

  1   2   3   >