On Fri, Jun 24, 2016 at 10:38 PM, Rob Herring wrote:
> On Fri, Jun 17, 2016 at 2:51 AM, Mathieu Malaterre
> wrote:
>> v3 tested here multiple times ! memleak is now gone.
>>
>> Tested-by: Mathieu Malaterre
>>
>> Thanks
>>
>> On Thu, Jun 16, 2016
ping ?
On Thu, Mar 8, 2018 at 9:29 PM Mathieu Malaterre wrote:
>
> The inline keyword was not at the beginning of the function declaration.
> Fix the following warning (reported at W=1)
>
> CC kernel/events/ring_buffer.o
> kernel/events/ring_buffer.c:105:1: warning:
revert "mm/memblock: add missing include
"") #ifdef blockers were missing which lead to compilation
failure on mips/ia64 where CONFIG_NO_BOOTMEM=n.
Suggested-by: Tony Luck
Signed-off-by: Mathieu Malaterre
---
mm/memblock.c | 3 +++
1 file changed, 3 insertions(+)
diff -
On Mon, Jun 25, 2018 at 4:03 PM Michal Hocko wrote:
>
> On Fri 22-06-18 23:05:41, Mathieu Malaterre wrote:
> > Commit 26f09e9b3a06 ("mm/memblock: add memblock memory allocation apis")
> > introduced two new function definitions:
> >
> &g
Hi Matt,
On Mon, Jan 22, 2018 at 5:36 PM, Matt Redfearn wrote:
>
> Hi Serge,
>
>
> On 17/01/18 22:22, Serge Semin wrote:
>>
>> Even though it's common to see the architecture code using both
>> bootmem and memblock early memory allocators, it's not good for
>> multiple reasons. First of all, it's
ing 0x
from bindings notation")
Reported-by: David Daney
Suggested-by: Rob Herring
Signed-off-by: Mathieu Malaterre
---
arch/mips/boot/dts/img/boston.dts | 2 +-
arch/mips/boot/dts/ingenic/ci20.dts | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/mips
James Hogan
Signed-off-by: Mathieu Malaterre
---
arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
b/arch/mips/boot/dts/ingenic/ci20.dts
index 7d5e49e40b0d..38078594cf97 100644
--- a/arch/mips/boot/dts/i
Bartlomiej,
On Wed, Jan 3, 2018 at 3:47 PM, Bartlomiej Zolnierkiewicz
wrote:
>
> On Thursday, December 21, 2017 11:07:56 PM Mathieu Malaterre wrote:
>> When the linux kernel is build with (typical kernel ship with Debian
>> installer):
>>
>> CONFIG_FB_OF=y
>
tion on the radeon side.
Signed-off-by: Mathieu Malaterre
Link: https://bugs.debian.org/826629#57
Link: https://bugzilla.kernel.org/show_bug.cgi?id=119741
Suggested-by: Lennart Sorensen
Cc: Bartlomiej Zolnierkiewicz
Cc: Benjamin Herrenschmidt
Cc: Tomi Valkeinen
---
v2: Only fails when CONFIG_PCC is
Hi Marcin,
Since it's been a week, could you confirm the patch is ok as-is or do
you think some comment(s) from James should be incorporated ?
On Tue, Jan 23, 2018 at 3:17 PM, James Hogan wrote:
> On Thu, Dec 21, 2017 at 10:00:59PM +0100, Mathieu Malaterre wrote:
>> From: Mar
Fix warning for all register unsigned long (0,3-12) that appear during W=1
compilation:
./arch/powerpc/include/asm/epapr_hcalls.h:479:2: warning: ‘register’ is not at
beginning of declaration [-Wold-style-declaration]
unsigned long register r[\d] asm("r[\d]");
Signed-off-by: Mathieu
Hi Peter,
On Tue, Jan 30, 2018 at 9:30 PM, Peter Malone wrote:
> Signed-off-by: Peter Malone
AFAIK empty commit message is not acceptable upstream
> drivers/video/fbdev/sbuslib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/sbuslib.c b/drive
r *ublue;
> struct fb_cmap *cmap = &info->cmap;
> - int index, count, i;
> + unsigned int index, count, i;
> u8 red, green, blue;
>
> if (get_user(index, &c->index) ||
> --
> 2.14.3
>
By just looking at the code and commit message:
Acked-by: Mathieu Malaterre
Bartlomiej,
On Wed, Jan 31, 2018 at 12:57 PM, Bartlomiej Zolnierkiewicz
wrote:
> On Tuesday, January 30, 2018 02:14:10 PM Mathieu Malaterre wrote:
>> Bartlomiej,
>>
>> On Wed, Jan 3, 2018 at 3:47 PM, Bartlomiej Zolnierkiewicz
>> wrote:
>> >
>> &g
Hi cocci gurus,
I am wondering if coccinelle can handle detection of kzalloc mem leak
(within alloc_apertures call) ? Typically:
$ cat drivers/video/fbdev/vesafb.c
static int vesafb_probe(struct platform_device *dev)
[...]
info->apertures = alloc_apertures(1);
but then:
static void vesafb_des
During compilation using W=1 one would get:
drivers/rtc/systohc.c:11: info: Scanning doc for rtc_set_ntp_time
drivers/rtc/systohc.c:23: warning: bad line: (
Signed-off-by: Mathieu Malaterre
---
drivers/rtc/systohc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Hi there,
I am trying to get sdhci-pci driver to work with the following hardware:
$ sudo lspci -s 03:00.1 -v -nn
03:00.1 SD Host controller [0805]: Broadcom Limited BCM57765/57785
SDXC/MMC Card Reader [14e4:16bc] (rev 10) (prog-if 01)
Subsystem: Broadcom Limited BCM57765/57785 SDXC/MMC Card Read
Replace pointer comparison to 0 with NULL in prepare_ftrace_return
to improve code readability. Identified with coccinelle script
'badzero.cocci'.
Signed-off-by: Mathieu Malaterre
---
arch/mips/kernel/ftrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/m
ping ?
On Thu, Feb 1, 2018 at 5:47 PM, Mathieu Malaterre wrote:
> During compilation using W=1 one would get:
>
> drivers/rtc/systohc.c:11: info: Scanning doc for rtc_set_ntp_time
> drivers/rtc/systohc.c:23: warning: bad line: (
>
> Signed-off-by: Mathieu Malaterre
&g
-by: Mathieu Malaterre
---
include/linux/serial_core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
index b32df49a3bd5..1d356105f25a 100644
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -379,7
On Sun, Mar 4, 2018 at 11:54 AM, Michael Ellerman wrote:
> Mathieu Malaterre writes:
>
>> Re-use the object-like macro EARLYCON_USED_OR_UNUSED to mark
>> `earlycon_acpi_spcr_enable` as maybe_unused.
>>
>> Fix the following warning (treated as error in W=1)
>&
On Wed, Mar 7, 2018 at 5:25 PM, PrasannaKumar Muralidharan
wrote:
> On 7 March 2018 at 21:22, Jiaxun Yang wrote:
>> 在 2018-03-07三的 20:35 +0530，PrasannaKumar Muralidharan写道：
>>> Hi James,
>>>
>>> Seems Jiaxun is interested in the board and is willing to help.
>>>
>>> I have been told that Ingenic
)
^
cc1: all warnings being treated as errors
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/mm/init_32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
index 6419b33ca309..a2bf6965d04f 100644
--- a/arch
limits]
#define pfn_valid(pfn) ((pfn) >= ARCH_PFN_OFFSET && (pfn) < max_mapnr)
^
Suggested-by: Christophe Leroy
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/include/asm/page.h | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff
On Sun, Mar 4, 2018 at 11:54 AM, Michael Ellerman wrote:
> Mathieu Malaterre writes:
>
>> In commit 81e7009ea46c ("powerpc: merge ppc signal.c and ppc64 signal32.c")
>> the function sys_debug_setcontext was added without a prototype.
>>
>> Fix comp
}’
[-Werror=format=]
arch/powerpc/xmon/xmon.c:1665:17: error: format ‘%ld’ expects argument of
type ‘long int’, but argument 2 has type ‘int’ [-Werror=format=]
arch/powerpc/xmon/xmon.c:2339:9: error: '#' flag used with ‘%p’ gnu_printf
format [-Werror=format=]
Signed-off-by: Mathieu
Michael,
On Thu, Mar 8, 2018 at 11:36 AM, Michael Ellerman wrote:
> Mathieu Malaterre writes:
>
>> On Sun, Mar 4, 2018 at 11:54 AM, Michael Ellerman
>> wrote:
>>> Mathieu Malaterre writes:
>>>
>>>> In commit 81e7009ea46c ("powerpc: merge
Christophe,
On Sat, Mar 24, 2018 at 9:10 PM, LEROY Christophe
wrote:
> Mathieu Malaterre a écrit :
>
>
>> On Fri, Mar 23, 2018 at 1:19 PM, christophe leroy
>> wrote:
>>>
>>>
>>>
>>> Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit :
>
On Fri, Apr 6, 2018 at 5:33 PM, LEROY Christophe
wrote:
> Mathieu Malaterre a écrit :
>
>> Add gcc attribute unused for `l` variable, replace `path` variable
>> directly
>> with prom_scratch. Fix warnings treated as errors with W=1:
>>
>> arch/powerpc/kerne
: https://bugs.debian.org/819725
Link:
https://salsa.debian.org/kernel-team/linux/blob/master/debian/patches/bugfix/all/fs-add-module_softdep-declarations-for-hard-coded-cr.patch
Suggested-by: Ben Hutchings
Cc: Milan Kupcevic
Signed-off-by: Mathieu Malaterre
---
fs/ext4/super.c | 1 +
1 file
function's name, in a string
#138: FILE: arch/powerpc/kernel/prom_init.c:1278:
+ prom_debug("alloc_down(%lx, %lx, %s)\n", size, align,
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/prom_init.c | 114
1 file changed, 58 insertio
king-dev.c:881:2: warning: function might be possible candidate for
‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
Signed-off-by: Mathieu Malaterre
---
include/linux/backing-dev.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/backing-dev.h b/include/linux/bac
40:19: error: static declaration of
‘ppc_setup_l3cr’ follows non-static declaration
arch/powerpc/kernel/setup_32.c:186:19: error: static declaration of
‘ppc_init’ follows non-static declaration
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/setup_32.c | 6 +++---
1 file changed, 3 insert
mpty
body in an ‘if’ statement [-Werror=empty-body]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/prom_init.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 5ae153b97d0a..f0e802495530 100644
40:19: error: static declaration of
‘ppc_setup_l3cr’ follows non-static declaration
arch/powerpc/kernel/setup_32.c:186:19: error: static declaration of
‘ppc_init’ follows non-static declaration
Signed-off-by: Mathieu Malaterre
---
v2: Previous version contained the reverted patch, correct that.
arch/po
totype for ‘module_layout’
[-Wmissing-prototypes]
Signed-off-by: Mathieu Malaterre
---
include/linux/module.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/linux/module.h b/include/linux/module.h
index d44df9b2c131..28046e8b7e9d 100644
--- a/include/linux/module.h
+++ b/inc
EAD) {
^
Signed-off-by: Mathieu Malaterre
---
drivers/gpu/drm/radeon/atombios_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/atombios_i2c.c
b/drivers/gpu/drm/radeon/atombios_i2c.c
index 4157780585a0..9022e9af11a0 100644
--- a/drivers/gpu/drm/rad
ULL)
CHECK: Comparison to NULL could be written "!pp"
#297: FILE: drivers/macintosh/via-pmu.c:2110:
+ if (count < 1 || pp == NULL)
CHECK: Comparison to NULL could be written "!pp"
#306: FILE: drivers/macintosh/via-pmu.c:2167:
+ if (pp == NULL)
CHECK: C
eg = <0x10002000 0x140>;
+
+ interrupt-parent = <&intc>;
+ interrupts = <27 26 25>;
+ };
So:
Tested-by: Mathieu Malaterre
> Signed-off-by: Paul Cercueil
> Reviewed-by: Rob Herring
> ---
> include/dt-bindings/clock/ingenic,tcu.h | 23 +++
Here is another batch for warnings treated as error on ppc32. Tested with:
$ make ARCH=powerpc ppc32_defconfig
$ make -j8 ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- W=1
Using:
$ powerpc-linux-gnu-gcc --version
powerpc-linux-gnu-gcc (Debian 6.3.0-18) 6.3.0 20170516
Mathieu Malaterre (19
Add gcc attribute unused for two variables. Fix warnings treated as errors
with W=1:
arch/powerpc/kernel/prom_init.c:1388:8: error: variable ‘path’ set but not
used [-Werror=unused-but-set-variable]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/prom_init.c | 4 ++--
1 file
‘chrp_init_IRQ’ [-Werror=missing-prototypes]
arch/powerpc/platforms/chrp/setup.c:559:1: error: no previous prototype for
‘chrp_init2’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/platforms/chrp/setup.c | 10 +-
1 file changed, 5 insertions(+), 5
: error: no previous prototype for
‘tau_interrupts’ [-Werror=missing-prototypes]
Compile tested with CONFIG_TAU_INT.
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/irq.c | 2 +-
arch/powerpc/kernel/setup-common.c | 6 --
arch/powerpc/kernel/setup.h| 6 ++
arch
The header file was missing from the includes. Fix the
following warning, treated as error with W=1:
arch/powerpc/kernel/pci_32.c:286:6: error: no previous prototype for
‘sys_pciconfig_iobase’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/pci_32.c
previous prototype
for ‘mpc52xx_pm_finish’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/include/asm/mpc52xx.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/include/asm/mpc52xx.h
b/arch/powerpc/include/asm/mpc52xx.h
index
The header file was missing from the includes. Fix the
following warning, treated as error with W=1:
arch/powerpc/kernel/vecemu.c:260:5: error: no previous prototype for
‘emulate_altivec’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/vecemu.c | 1
function `via_calibrate_decr` was made static to silence a warning.
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/platforms/powermac/time.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powermac/time.c
b/arch/powerpc/platforms/powermac/time.c
‘xor_altivec_5’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/lib/xor_vmx.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/arch/powerpc/lib/xor_vmx.h b/arch/powerpc/lib/xor_vmx.h
index 5c2b0839b179..2173e3c84151 100644
--- a/arch/powerpc/lib/xor_vmx.h
-by: Mathieu Malaterre
---
arch/powerpc/platforms/chrp/pci.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/chrp/pci.c
b/arch/powerpc/platforms/chrp/pci.c
index 0f512d35f7c5..84e1fedb3796 100644
--- a/arch/powerpc/platforms/chrp/pci.c
+++ b/arch
Add a missing prototype for function `note_bootable_part` to silence a
warning treated as error with W=1:
arch/powerpc/platforms/powermac/setup.c:361:12: error: no previous prototype
for ‘note_bootable_part’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc
’ [-Werror=missing-prototypes]
arch/powerpc/platforms/chrp/time.c:130:6: error: no previous prototype for
‘chrp_get_rtc_time’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/platforms/chrp/time.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a
Add one missing prototype for function rh_dump_blk. Fix warning treated as
error in W=1:
arch/powerpc/lib/rheap.c:740:6: error: no previous prototype for
‘rh_dump_blk’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/include/asm/rheap.h | 3 +++
1 file changed
‘pmac_pfunc_base_install’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/include/asm/pmac_pfunc.h | 1 +
arch/powerpc/platforms/powermac/smp.c | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/pmac_pfunc.h
b/arch/powerpc
: no previous prototype for
‘TAUException’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/tau_6xx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/kernel/tau_6xx.c b/arch/powerpc/kernel/tau_6xx.c
index 8cdd852aedd1
Since the value of x is never intended to be read, declare it with gcc
attribute as unused. Fix warning treated as error with W=1:
arch/powerpc/platforms/powermac/udbg_scc.c:76:9: error: variable ‘x’ set but
not used [-Werror=unused-but-set-variable]
Signed-off-by: Mathieu Malaterre
/powermac/pci.c:784:19: error: variable ‘has_address’
set but not used [-Werror=unused-but-set-variable]
arch/powerpc/platforms/powermac/pci.c:907:22: error: variable ‘ht’ set but
not used [-Werror=unused-but-set-variable]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/platforms/powermac/pci.c
This function can be static, make it so, this fix a warning treated as
error with W=1:
arch/powerpc/kernel/btext.c:173:5: error: no previous prototype for
‘btext_initialize’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/btext.c | 2 +-
1 file changed
Add gcc attribute unused to variable tmp. Fix warning treated as error with
W=1:
arch/powerpc/kernel/kvm.c:675:6: error: variable ‘tmp’ set but not used
[-Werror=unused-but-set-variable]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1
Since the value of x is never intended to be read, declare it with gcc
attribute as unused. Fix warning treated as error with W=1:
arch/powerpc/platforms/powermac/bootx_init.c:471:21: error: variable ‘x’ set
but not used [-Werror=unused-but-set-variable]
Signed-off-by: Mathieu Malaterre
-prototypes]
Also in commit 978d2d683123 ("PCI: Add pcibios_iov_resource_alignment()
interface") a new function was added but the prototype was located in the
main header instead of the CONFIG_PCI_IOV specific section. Move this
function next to the newly added ones.
Signed-off-by: Mathieu
On Fri, Mar 23, 2018 at 1:19 PM, christophe leroy
wrote:
>
>
> Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit :
>>
>> Some functions prototypes were missing for the non-altivec code. Add the
>> missing prototypes directly in xor_vmx, fix warnings treated as errors
&g
__always_inline rb_need_aux_wakeup(struct ring_buffer *rb)
^~
AR kernel/events/built-in.o
Signed-off-by: Mathieu Malaterre
---
kernel/events/ring_buffer.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c
index
=format]
len = vscnprintf(tbuffer, TRACE_BUF_SIZE, fmt, args);
^~~
AR kernel/trace/built-in.o
Signed-off-by: Mathieu Malaterre
---
kernel/trace/trace.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 926718fa846d..117e246d0a49
p___devtable[];
> -#endif /* __MACH__ */
> -
> -#if !defined(__used)
> -# if __GNUC__ == 3 && __GNUC_MINOR__ < 3
> -# define __used __attribute__((__unused__))
> -# else
> -# define __used __attribute__((__used__))
> -# endif
> -#en
onst char *device_id; /* name of table,
> __mod___*_device_table. */
> unsigned long id_size;
> - void *function;
> + int (*do_entry)(const char *filename, void *symval, char *alias);
> };
It makes sense to do this cleanup.
Reviewed-by: Mathieu Malaterre
> /
On Wed, Oct 31, 2018 at 12:15 PM Mathieu Malaterre wrote:
>
> GCC 4.6 is the minimum supported now.
>
> Signed-off-by: Mathieu Malaterre
> ---
> scripts/mod/file2alias.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/scripts/mod
There is a plan to build the kernel with -Wimplicit-fallthrough and
these places in the code produced warnings. Fix them up.
Signed-off-by: Mathieu Malaterre
---
v2: fix subject prefix non sense
drivers/mtd/nand/raw/jz4780_bch.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd
ng: no previous prototype for ‘to_mnt_ns’
[-Wmissing-prototypes]
Signed-off-by: Mathieu Malaterre
---
fs/namespace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/namespace.c b/fs/namespace.c
index a7f91265ea67..f0cf252d9aa3 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
.
Cc: Rob Herring
Fixes: 5c63e407aaab ("fbdev: Convert to using %pOFn instead of
device_node.name")
Cc: sta...@vger.kernel.org # v4.19+
Signed-off-by: Mathieu Malaterre
---
drivers/video/fbdev/offb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/of
dds a prototype to fix warning at W=1:
arch/powerpc/kernel/ptrace.c:3339:13: error: no previous prototype for
‘pt_regs_check’ [-Werror=missing-prototypes]
Suggested-by: Christophe Leroy
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/ptrace.c | 4
1 file changed, 4 insertions(+)
diff
There is a plan to build the kernel with -Wimplicit-fallthrough and
these places in the code produced warnings. Fix them up.
Signed-off-by: Mathieu Malaterre
---
drivers/mtd/nand/raw/jz4780_bch.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/nand/raw/jz4780_bch.c
b/drivers
There is a plan to build the kernel with -Wimplicit-fallthrough and
these places in the code produced warnings. Fix them up.
This patch produces no change in behaviour, but should be reviewed in
case these are actually bugs not intentional fallthoughs.
Cc: Kees Cook
Signed-off-by: Mathieu
'
On Mon, Jul 9, 2018 at 3:57 PM Serge Semin wrote:
>
> Adaptive ioremap_wc() method is now available (see "mips: mm:
> Create UCA-based ioremap_wc() method" commit). We can use it for
> UCA-featured MMIO transactions in the kernel, so we don't need
> it platform clone ioremap_uncached_accelerated
ggested-by: Tony Luck
Suggested-by: Michal Hocko
Signed-off-by: Mathieu Malaterre
---
v2: Simplify #ifdef
mm/memblock.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/mm/memblock.c b/mm/memblock.c
index 03d48d8835ba..611a970ac902 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -20
On Mon, Jun 25, 2018 at 8:07 PM Michal Hocko wrote:
>
> On Mon 25-06-18 19:15:12, Mathieu Malaterre wrote:
> > Commit 26f09e9b3a06 ("mm/memblock: add memblock memory allocation apis")
> > introduced two new function definitions:
> >
> &g
ined(CONFIG_HAVE_MEMBLOCK) && defined(CONFIG_NO_BOOTMEM)
to simply:
#if defined(CONFIG_NO_BOOTMEM)
Suggested-by: Tony Luck
Suggested-by: Michal Hocko
Acked-by: Michal Hocko
Signed-off-by: Mathieu Malaterre
---
v3: Add missing reference to commit 6cc22dc08a24
v2: Simplify #ifdef
mm/me
Fix non-fatal warning triggered during compilation with W=1:
kernel/events/core.c:6106:1: warning: ‘inline’ is not at beginning of
declaration [-Wold-style-declaration]
static void __always_inline
^~
Signed-off-by: Mathieu Malaterre
---
v2: Explicit reference to W=1
kernel/events
Hi Peter,
I am seeing a new warning in dmesg on my Mac Mini G4 (ppc32), which
seems to refer to commit 85f1abe0019fc (*). Does this means there is
an issue on my setup ?
Thanks,
(*)
[0.006350] MPC7450 family performance monitor hardware support registered
[0.007544] WARNING: CPU: 0 PID:
there.
For the entire series, everything works as expected on JZ4780 (Creator
CI20), including reading from sdcard.
Tested-by: Mathieu Malaterre
> Regards,
> -Paul
>
On Thu, May 17, 2018 at 4:45 AM, Shawn Lin wrote:
>
> On 2018/5/17 3:20, Mathieu Malaterre wrote:
>>
>> In commit 97548575bef3 ("mmc: block: Convert RPMB to a character device")
>> a
>> new function `mmc_rpmb_ioctl` was added. The final return is simpl
On Thu, May 17, 2018 at 12:49 PM, Christophe Leroy
wrote:
> In my 8xx configuration, I get 208 calls to memcmp()
> Within those 208 calls, about half of them have constant sizes,
> 46 have a size of 8, 17 have a size of 16, only a few have a
> size over 16. Other fixed sizes are mostly 4, 6 and 10
ch/powerpc/kernel/ptrace.c:3281:4: error: suggest braces around empty body
in an ‘if’ statement [-Werror=empty-body]
Fixes: a225f1567405 ("powerpc/ptrace: replace ptrace_report_syscall() with a
tracehook call")
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/ptrace.c | 4 ++-
‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
drivers/clk/clkdev.c:398:2: warning: function might be possible candidate for
‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
Signed-off-by: Mathieu Malaterre
---
drivers/clk/clkdev.c | 5 +++--
1 file changed, 3 insertions
Rob, any comment ?
On Fri, Dec 7, 2018 at 1:59 PM Mathieu Malaterre wrote:
>
> This is a partial revert of commit 5c63e407aaab ("fbdev: Convert to
> using %pOFn instead of device_node.name"). This is the minimal work to
> get a Mac Mini G4 back to a bootab
5.0.0-rc1+ (ma...@debian.org) (gcc
version 6.3.0 20170516 (Debian 6.3.0-18)) #21 Mon Jan 7 21:03:53 CET
2019
...
So here is my :
Tested-by: Mathieu Malaterre
Thanks
> Reported-by: Mathieu Malaterre
> Cc: sta...@vger.kernel.org # v4.19+
> Cc: Bartlomiej Zolnierkiewicz
> Cc: dri-de...
Hi Rob,
On Mon, Jan 7, 2019 at 9:11 PM Mathieu Malaterre wrote:
>
> On Mon, Jan 7, 2019 at 6:31 PM Rob Herring wrote:
> >
> > Commit 5c63e407aaab ("fbdev: Convert to using %pOFn instead of
> > device_node.name") changed how the OF FB driver handles the OF n
hanks
On Thu, Dec 20, 2018 at 5:10 PM Mathieu Malaterre wrote:
>
> Rob, any comment ?
>
> On Fri, Dec 7, 2018 at 1:59 PM Mathieu Malaterre wrote:
> >
> > This is a partial revert of commit 5c63e407aaab ("fbdev: Convert to
> > using %pOFn instead of device_node.n
s been removed.
Revert commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with
access_ok()") to fix the following compilation error:
arch/powerpc/include/asm/uaccess.h:66:32: error: ‘type’ undeclared (first use
in this function)
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/incl
GCC 4.6 is the minimum supported now.
Signed-off-by: Mathieu Malaterre
---
scripts/mod/file2alias.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
index 28a61665bb9c..4b59564d4706 100644
--- a/scripts/mod/file2alias.c
Hi,
On Sun, Oct 14, 2018 at 7:04 PM Aaro Koskinen wrote:
>
> Hi,
>
> There is something wrong with jz4740-mmc in current mainline kernel
> (tested v4.18 and 4.19-rc, the MMC support for CI20 does not exist
> prior those), as the DMA support does not work properly if I disable
> kernel pre-emption
Paul,
On Mon, Sep 3, 2018 at 8:15 AM Mathieu Malaterre wrote:
>
> On Fri, Aug 31, 2018 at 10:59 PM Paul Burton wrote:
> >
> > On Fri, Aug 31, 2018 at 01:37:52PM -0700, Paul Burton wrote:
> > > Further to that, this series doesn't seem to work for me. With
> &g
On Wed, Jun 6, 2018 at 9:38 PM Mathieu Malaterre wrote:
>
> Update the Ci20's defconfig to enable the JZ4780's SND driver.
>
> Signed-off-by: Mathieu Malaterre
> ---
> arch/mips/configs/ci20_defconfig | 4
> 1 file changed, 4 insertions(+)
>
> diff --g
ping ?
On Wed, Jun 6, 2018 at 9:42 PM Mathieu Malaterre wrote:
>
> In commit 73ce0511c436 ("kernel/watchdog.c: move hardlockup detector to
> separate file") two new functions were added ‘watchdog_nmi_enable’ and
> ‘watchdog_nmi_disable’ the functions were changed from stat
Hi Yamada-san,
Since commit:
80463f1b7bf9 kbuild: add --include-dir flag only for out-of-tree build
I can no longer run the bindeb-pkg rule. For example:
$ make O=wii ARCH=powerpc wii_defconfig
$ make -j8 O=wii ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- bindeb-pkg
...
WRAParch/powerpc/
[-Werror=unused-but-set-variable]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/process.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 96f34730010f..b9f1a2408738 100644
--- a/arch/powerpc/kernel
[-Wmissing-prototypes]
kernel/workqueue.c:4783:5: warning: no previous prototype for
‘workqueue_offline_cpu’ [-Wmissing-prototypes]
Signed-off-by: Mathieu Malaterre
---
kernel/workqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/w
crypt_init’
[-Wmissing-prototypes]
Signed-off-by: Mathieu Malaterre
---
init/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/init/main.c b/init/main.c
index 3d6b31f4e520..35ce2ddb1322 100644
--- a/init/main.c
+++ b/init/main.c
@@ -91,6 +91,7 @@
#include
#include
#include
+#include
Fix typo introduced for RTC_DRV_JZ4740 in commit 586655d278ba ("rtc:
jz4740: make the driver buildable as a module again").
Signed-off-by: Mathieu Malaterre
---
drivers/rtc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/Kconfig b/drivers/r
On Thu, Mar 1, 2018 at 3:55 AM, Michael Ellerman wrote:
> Mathieu Malaterre writes:
>
>> When neither CONFIG_ALTIVEC, nor CONFIG_VSX or CONFIG_PPC64 is defined, the
>> array feature_properties is defined as an empty array, which in turn
>> triggers the following warning
-off-by: Mathieu Malaterre
---
v3: style: add missing empty line after declaration
v2: move x variable within its local scope
arch/powerpc/platforms/powermac/bootx_init.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powermac/bootx_init.c
b/arch
1 - 100 of 455 matches
Mail list logo
