Re: [PATCH v5 4/4] clk: bd71837: Add driver for BD71837 PMIC clock

2018-08-03 Thread Matti Vaittinen
On Tue, Jul 31, 2018 at 11:28:58AM +0300, Matti Vaittinen wrote: > On Tue, Jun 26, 2018 at 11:13:19AM +0300, Matti Vaittinen wrote: > > On Mon, Jun 25, 2018 at 04:44:57PM -0700, Stephen Boyd wrote: > > > Quoting Matti Vaittinen (2018-06-12 01:23:54) > > > > On Tue, Ju

Re: [PATCH v11 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-08-03 Thread Matti Vaittinen
return button.irq; >166} Comparing unsiged to smaller-than-zero. These tools are handy! I'll fix the errno check and send v12 in a minute... (or a bit more - but soonish in any case =]) Br, Matti Vaittinen

[PATCH v12 0/2] mfd/regulator/clk/input: bd71837: ROHM BD71837 PMIC driver

2018-08-03 Thread Matti Vaittinen
tch 1: MFD driver and definitions bringing interrupt support and enabling clk, regulator and input subsystems. patch 2: MFD driver DT bindings This patch series is based on for-mfd-next --- Matti Vaittinen (2): mfd: bd71837: mfd driver for ROHM BD71837 PMIC mfd: bd

[PATCH v12 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-08-03 Thread Matti Vaittinen
ROHM BD71837 PMIC MFD driver providing interrupts and support for three subsystems: - clk - Regulators - input/power-key Signed-off-by: Matti Vaittinen Reviewed-by: Enric Balletbo i Serra --- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile | 1 + drivers/mfd/rohm

[PATCH v12 2/2] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-08-03 Thread Matti Vaittinen
Document devicetree bindings for ROHM BD71837 PMIC MFD. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring Acked-for-MFD-by: Lee Jones --- .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 62 ++ 1 file changed, 62 insertions(+) create mode 100644 Documentation

Re: [PATCH v12 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-08-03 Thread Matti Vaittinen
On Fri, Aug 03, 2018 at 02:08:14PM +0300, Matti Vaittinen wrote: > ROHM BD71837 PMIC MFD driver providing interrupts and support > for three subsystems: > - clk > - Regulators > - input/power-key > > Signed-off-by: Matti Vaittinen > Reviewed-by: Enric Balletbo i Serr

Re: [PATCH v12 2/2] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-08-03 Thread Matti Vaittinen
On Fri, Aug 03, 2018 at 02:09:12PM +0300, Matti Vaittinen wrote: > Document devicetree bindings for ROHM BD71837 PMIC MFD. > > Signed-off-by: Matti Vaittinen > Reviewed-by: Rob Herring > Acked-for-MFD-by: Lee Jones > --- I kept the Reviewed-by and Acked-by as this patch

Re: [PATCH v7 4/4] input/power: Add driver for BD71837/BD71847 PMIC power button

2018-06-21 Thread Matti Vaittinen
On Wed, Jun 20, 2018 at 09:43:16AM +0300, Matti Vaittinen wrote: > On Tue, Jun 19, 2018 at 10:50:28AM -0700, Dmitry Torokhov wrote: > > Hi Matti, > > > > On Tue, Jun 19, 2018 at 01:57:09PM +0300, Matti Vaittinen wrote: > > > ROHM BD71837 PMIC power button dr

Re: [PATCH v7 0/4] mfd/regulator/clk/input: bd71837: ROHM BD71837 PMIC driver

2018-06-21 Thread Matti Vaittinen
On Tue, Jun 19, 2018 at 01:55:31PM +0300, Matti Vaittinen wrote: > Patch series adding support for ROHM BD71837 PMIC. > What is the preferred way when I send updated patches: 1. always resend _all_ unapplied patches even if there is no changes to some of them. (patch-vN mail thread co

Re: [PATCH] regulator: bd71837: Remove duplicate assignment for n_voltages of LDO2

2018-08-26 Thread Matti Vaittinen
837_LDO_EN, > .owner = THIS_MODULE, > -- > 2.17.1 > This is how it should have been in the first place! Br, Matti Vaittinen

Re: [RFC/PATCH] regulator: Support regulators where voltage ranges are selectable

2018-08-27 Thread Matti Vaittinen
On Wed, Aug 22, 2018 at 02:05:07PM +0300, Matti Vaittinen wrote: > For example ROHM BD71837 and ROHM BD71847 Power management ICs have > regulators which provide multiple linear ranges. Ranges can be > selected by individual non contagious bit in vsel register. Add > regmap helper f

[PATCH 0/8] regulator/mfd/dt_bindings: bd718x7: Support ROHM bd71847

2018-08-29 Thread Matti Vaittinen
s based on linux-next tag next-20180823. Matti Vaittinen (8): regulator: bd71837: Disable voltage monitoring for LDO3/4 regulator: Support ROHM BD71847 power management IC regulator: dt bindings: add BD71847 device-tree binding documentation mfd: dt bindings: add BD71847 device-tr

[PATCH 1/8] regulator: bd71837: Disable voltage monitoring for LDO3/4

2018-08-29 Thread Matti Vaittinen
force PMIC to emergency state instead of poweroff. Disable voltage monitoring for LDO5 and LDO6 at probe to avoid this. Signed-off-by: Matti Vaittinen --- drivers/regulator/bd71837-regulator.c | 19 +++ include/linux/mfd/rohm-bd718x7.h | 33 ++--- 2

[PATCH 2/8] regulator: Support ROHM BD71847 power management IC

2018-08-29 Thread Matti Vaittinen
BD71847 is reduced version of BD71837. DVS bucks 3 and 4 are removed as is LDO7. Voltage ranges of some regulators are expanded. Add initial support for BD71847 with BD71847 driver. Signed-off-by: Matti Vaittinen --- drivers/mfd/rohm-bd718x7.c| 84 ++- drivers/regulator/bd71837

[PATCH 3/8] regulator: dt bindings: add BD71847 device-tree binding documentation

2018-08-29 Thread Matti Vaittinen
Add ROHM BD71847 Power Management IC regulator binding information to device-tree binding documents. Signed-off-by: Matti Vaittinen --- .../devicetree/bindings/regulator/rohm,bd71837-regulator.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Documentation

[PATCH 4/8] mfd: dt bindings: add BD71847 device-tree binding documentation

2018-08-29 Thread Matti Vaittinen
Add ROHM BD71847 Power Management IC MFD binding information to device-tree binding documents. Signed-off-by: Matti Vaittinen --- .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/Documentation

[PATCH 5/8] regulator: Support regulators where voltage ranges are selectable

2018-08-29 Thread Matti Vaittinen
For example ROHM BD71837 and ROHM BD71847 Power management ICs have regulators which provide multiple linear ranges. Ranges can be selected by individual non contagious bit in vsel register. Add regmap helper functions for selecting ranges. Signed-off-by: Matti Vaittinen --- drivers/regulator

[PATCH 6/8] regulator/mfd: bd718xx: rename bd71837/bd71847 common instances

2018-08-29 Thread Matti Vaittinen
Rename parts of code that support both BD71837 and BD71847 to BD718XX. Signed-off-by: Matti Vaittinen --- drivers/mfd/rohm-bd718x7.c| 112 +- drivers/regulator/bd71837-regulator.c | 24 include/linux/mfd/rohm-bd718x7.h | 62

[PATCH 7/8] regulator: bd718XX use pickable ranges

2018-08-29 Thread Matti Vaittinen
bits (as usual). Support BD71837 and BD71847 selectible range voltages using new pickable ranges helpers. Signed-off-by: Matti Vaittinen --- drivers/regulator/bd71837-regulator.c | 155 +++--- include/linux/mfd/rohm-bd718x7.h | 38 + 2 files changed, 147

[PATCH 8/8] regulator: bd718xx: renme bd71837 to 718xx

2018-08-29 Thread Matti Vaittinen
rename bd71837-regulator.c to bd718x7-regulator.c to reflect the fact that also BD71847 is now supported by the driver. Signed-off-by: Matti Vaittinen --- drivers/regulator/Kconfig | 2 +- drivers/regulator/Makefile | 2

[PATCH] regulator: regmap helpers - support overlapping linear ranges

2018-08-22 Thread Matti Vaittinen
Don't give up voltage mapping if first range with suitable min/max uV does not provide the wanted voltage. Signed-off-by: Matti Vaittinen --- We may have HW which handles regulator voltage setting like: LDO5 voltage reg: bit [3] voltage range selection bit [2:0] voltage selection where: I

[RFC/PATCH] regulator: Support regulators where voltage ranges are selectable

2018-08-22 Thread Matti Vaittinen
For example ROHM BD71837 and ROHM BD71847 Power management ICs have regulators which provide multiple linear ranges. Ranges can be selected by individual non contagious bit in vsel register. Add regmap helper functions for selecting ranges. Signed-off-by: Matti Vaittinen --- For example the

Re: [PATCH v10 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-29 Thread Matti Vaittinen
Hello Lee & All others, I'm physically back from my vacations so I can once again reach the keyboard. So it's time to try address these issues =) On Thu, Jul 12, 2018 at 02:00:13PM +0100, Lee Jones wrote: > On Thu, 05 Jul 2018, Matti Vaittinen wrote: > > > + ret = r

[PATCH v11 0/2] mfd/regulator/clk/input: bd71837: ROHM BD71837 PMIC driver

2018-07-30 Thread Matti Vaittinen
bling clk, regulator and input subsystems. patch 2: MFD driver DT bindings This patch series is based on for-mfd-next --- Matti Vaittinen (2): mfd: bd71837: mfd driver for ROHM BD71837 PMIC mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC .../devicetree/bindings/mfd/rohm,bd

[PATCH v11 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-30 Thread Matti Vaittinen
ROHM BD71837 PMIC MFD driver providing interrupts and support for three subsystems: - clk - Regulators - input/power-key Signed-off-by: Matti Vaittinen Reviewed-by: Enric Balletbo i Serra --- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile | 1 + drivers/mfd/rohm

[PATCH v11 2/2] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-07-30 Thread Matti Vaittinen
Document devicetree bindings for ROHM BD71837 PMIC MFD. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring Acked-for-MFD-by: Lee Jones --- .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 62 ++ 1 file changed, 62 insertions(+) create mode 100644 Documentation

Re: [PATCH v11 2/2] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-07-30 Thread Matti Vaittinen
On Mon, Jul 30, 2018 at 01:46:37PM +0300, Matti Vaittinen wrote: > Document devicetree bindings for ROHM BD71837 PMIC MFD. > > Signed-off-by: Matti Vaittinen > Reviewed-by: Rob Herring > Acked-for-MFD-by: Lee Jones Please note - this patch is unchanged from previous version s

Re: [PATCH v11 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-30 Thread Matti Vaittinen
On Mon, Jul 30, 2018 at 01:43:34PM +0300, Matti Vaittinen wrote: > ROHM BD71837 PMIC MFD driver providing interrupts and support > for three subsystems: > - clk > - Regulators > - input/power-key > > Signed-off-by: Matti Vaittinen > Reviewed-by: Enric Balletbo i Se

Re: [PATCH] clk: clkdev - add managed versions of lookup registrations

2018-07-30 Thread Matti Vaittinen
Hello All, Sorry for longish delay but the exceptionally great summer in Finland has kept me away from computer... Now when I am back from my travels it's time to focus on patches again =) On Sun, Jul 08, 2018 at 11:33:44PM -0700, Stephen Boyd wrote: > Quoting Matti Vaittinen (2018-06-

Re: [PATCH v5 4/4] clk: bd71837: Add driver for BD71837 PMIC clock

2018-07-31 Thread Matti Vaittinen
On Tue, Jun 26, 2018 at 11:13:19AM +0300, Matti Vaittinen wrote: > On Mon, Jun 25, 2018 at 04:44:57PM -0700, Stephen Boyd wrote: > > Quoting Matti Vaittinen (2018-06-12 01:23:54) > > > On Tue, Jun 12, 2018 at 12:44:11AM -0700, Stephen Boyd wrote: > > > > Quoting Mat

Re: [PATCH v5 4/4] clk: bd71837: Add driver for BD71837 PMIC clock

2018-07-31 Thread Matti Vaittinen
Hello Again, On Wed, Jun 27, 2018 at 11:40:00AM +0300, Matti Vaittinen wrote: > Hello Stephen, > > On Mon, Jun 25, 2018 at 04:46:24PM -0700, Stephen Boyd wrote: > > Quoting Matti Vaittinen (2018-06-13 06:03:38) > > > On Tue, Jun 12, 2018 at 11:23:54AM +030

Re: [PATCH v3 1/7] regulator/mfd: Support ROHM BD71847 power management IC

2018-09-28 Thread Matti Vaittinen
them in the pull request? > > Please. I was just wondering if I could do something to help get this patch series applied? Mark, have you had the time to take a look on pickable ranges addition yet? Should I do some rebasing/resending? Are you giving me a nudge if I can do something? Br, Matti Vaittinen

[RFC] regmap-irq: add "main register" and level-irq support

2018-11-30 Thread Matti Vaittinen
- but quick grep for drivers allow me to think that it is currently only the gpio-max77620 which uses the type setting in-tree. So the patch below is not properly tested but it should explain what I am plannig. Can you plese tell me if this makes sense or not? If this sounds like acceptable patch -

Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-11-30 Thread Matti Vaittinen
On Fri, Nov 30, 2018 at 11:06:53AM +, Russell King - ARM Linux wrote: > On Fri, Nov 30, 2018 at 12:50:22PM +0200, Matti Vaittinen wrote: > > Hello Stephen, > > > > Thanks a bunch for taking the time and reviewing this! > > > > On Fri, Nov 30, 2018 at 12:

Re: [PATCH v6 03/10] clk: of-provider: look at parent if registered device has no provider info

2018-12-04 Thread Matti Vaittinen
counting. Hence I think we should keep the of_node NULL for sub-device if the sub-device does not have own node inside the main devie node. And I think Rob was not a fan of having own nodes for sub-devices inside the MFD node (AFAIR my first driver draft for this device had it but Rob and you thought

Re: [RFC] regmap-irq: add "main register" and level-irq support

2018-12-05 Thread Matti Vaittinen
Hello Mark, Thank you for taking the time and checking this! Highly appreciated! On Tue, Dec 04, 2018 at 05:21:37PM +, Mark Brown wrote: > On Fri, Nov 30, 2018 at 10:59:08AM +0200, Matti Vaittinen wrote: > > > IRQ handling is implemented so that each sub block has own > &g

Re: [RFC] regmap-irq: add "main register" and level-irq support

2018-12-06 Thread Matti Vaittinen
Hello Again Mark, On Wed, Dec 05, 2018 at 05:27:01PM +, Mark Brown wrote: > On Wed, Dec 05, 2018 at 10:22:51AM +0200, Matti Vaittinen wrote: > > On Tue, Dec 04, 2018 at 05:21:37PM +, Mark Brown wrote: > > > On Fri, Nov 30, 2018 at 10:59:08AM +0200, Matti Vaittinen wr

[PATCH v7] clk: bd718x7: Initial support for ROHM bd71837/bd71847 PMIC clock

2018-12-07 Thread Matti Vaittinen
ROHM bd71837 and bd71847 contain 32768Hz clock gate. Support the clock using generic clock framework. Note, only bd71837 is tested but bd71847 should be identical what comes to clk parts. Signed-off-by: Matti Vaittinen --- This is a split from series https://lore.kernel.org/linux-clk

[PATCH v7 0/3] clk: clkdev add managed lookup registrations

2018-12-07 Thread Matti Vaittinen
k as this device can never be removed - Fix indentiation for clk-max77686 - Rest of the patches are unchanged. Changelog v2 Issue spotted by 0-Day test suite - Add a stub function 'devm_of_clk_add_parent_hw_provider' for no OF config. - patches 2-8 are unchanged. This patch series is bas

[PATCH v7 1/3] clkdev: add managed clkdev lookup registration

2018-12-07 Thread Matti Vaittinen
Clkdev registration lacks of managed registration functions and it seems few drivers do not drop clkdev lookups at exit. Add devm_clk_hw_register_clkdev and devm_clk_release_clkdev to ease lookup releasing at exit. Signed-off-by: Matti Vaittinen --- Documentation/driver-model/devres.txt | 1

[PATCH v7 2/3] clk: clk-max77686: Clean clkdev lookup leak and use devm

2018-12-07 Thread Matti Vaittinen
clk-max77686 never clean clkdev lookup at remove. This can cause oops if clk-max77686 is removed and inserted again. Fix leak by using new devm clkdev lookup registration. Simplify also error path by using new devm_of_clk_add_hw_provider. Signed-off-by: Matti Vaittinen Reviewed-by: Krzysztof

[PATCH v7 3/3] clk: clk-st: avoid clkdev lookup leak at remove

2018-12-07 Thread Matti Vaittinen
Use devm based clkdev lookup registration to avoid leaking lookup structures. Signed-off-by: Matti Vaittinen --- drivers/clk/x86/clk-st.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/x86/clk-st.c b/drivers/clk/x86/clk-st.c index 3a0996f2d556..25d4b97aff9b

[PATCH v5 4/9] clk: clk-st: avoid clkdev lookup leak at remove

2018-12-03 Thread Matti Vaittinen
Use devm based clkdev lookup registration to avoid leaking lookup structures. Signed-off-by: Matti Vaittinen --- drivers/clk/x86/clk-st.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/x86/clk-st.c b/drivers/clk/x86/clk-st.c index 3a0996f2d556..25d4b97aff9b

[PATCH v6 00/10] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-12-04 Thread Matti Vaittinen
nchanged. Changelog (for this series) v2 Issue spotted by 0-Day test suite - Add a stub function 'devm_of_clk_add_parent_hw_provider' for no OF config. - patches 2-8 are unchanged. This patch series is based on clk-next --- Matti Vaittinen (10): clkdev: add managed clkdev lookup r

[PATCH v6 01/10] clkdev: add managed clkdev lookup registration

2018-12-04 Thread Matti Vaittinen
Clkdev registration lacks of managed registration functions and it seems few drivers do not drop clkdev lookups at exit. Add devm_clk_hw_register_clkdev and devm_clk_release_clkdev to ease lookup releasing at exit. Signed-off-by: Matti Vaittinen --- Documentation/driver-model/devres.txt | 1

Re: [PATCH v5 4/4] clk: bd71837: Add driver for BD71837 PMIC clock

2018-06-26 Thread Matti Vaittinen
v8 when I get it done. On Mon, Jun 25, 2018 at 04:44:57PM -0700, Stephen Boyd wrote: > Quoting Matti Vaittinen (2018-06-12 01:23:54) > > On Tue, Jun 12, 2018 at 12:44:11AM -0700, Stephen Boyd wrote: > > > Quoting Matti Vaittinen (2018-06-04 06:19:13) > > > Use u8 inst

Re: [PATCH v7 1/4] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-06-26 Thread Matti Vaittinen
comments below, some are feedback I > received when I sent some patches to this subsystem. > > Missatge de Matti Vaittinen del > dia dt., 19 de juny 2018 a les 12:57: > > > > ROHM BD71837 PMIC MFD driver providing interrupts and support > > for two subsystems: > > -

Re: [PATCH v7 1/4] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-06-26 Thread Matti Vaittinen
Hello Again Eric, On Tue, Jun 26, 2018 at 01:40:40PM +0200, Enric Balletbo Serra wrote: > Hi Matti, > Missatge de Matti Vaittinen del > dia dt., 26 de juny 2018 a les 13:25: > > On Tue, Jun 26, 2018 at 11:06:33AM +0200, Enric Balletbo Serra wrote: > > > Missatge de Matti

[PATCH] input: gpio_keys: add missing include to gpio_keys.h

2018-06-27 Thread Matti Vaittinen
gpio_keys.h uses 'bool' - type which is defined in linux/types.h. Include this header. Signed-off-by: Matti Vaittinen --- include/linux/gpio_keys.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/gpio_keys.h b/include/linux/gpio_keys.h index 7160df54a6fe..3f84aeb81

Re: [PATCH v5 4/4] clk: bd71837: Add driver for BD71837 PMIC clock

2018-06-27 Thread Matti Vaittinen
Hello Stephen, On Mon, Jun 25, 2018 at 04:46:24PM -0700, Stephen Boyd wrote: > Quoting Matti Vaittinen (2018-06-13 06:03:38) > > On Tue, Jun 12, 2018 at 11:23:54AM +0300, Matti Vaittinen wrote: > > > > > > I see. This makes sense. I need to verify from HW colleagues

[PATCH] clk: clkdev - add managed versions of lookup registrations

2018-06-28 Thread Matti Vaittinen
Add devm_clk_hw_register_clkdev, devm_clk_register_clkdev and devm_clk_release_clkdev as a first styep to clean up drivers which are leaking clkdev lookups at driver remove. Signed-off-by: Matti Vaittinen --- While searching for example on how clk drivers release clkdev at exit I found that

[PATCH 1/2] regulator: bd71837: Editorial cleanups.

2018-06-28 Thread Matti Vaittinen
Address issues spotted by Andy Shevchenko during review of original patch No functional changes intended Signed-off-by: Matti Vaittinen --- drivers/regulator/bd71837-regulator.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/regulator

[PATCH 2/2] regulator: bd71837: Remove duplicate description from DT bindings

2018-06-28 Thread Matti Vaittinen
Same general chip description was written in MFD and Regulator binding documents for ROHM bd71837 PMIC. Remove description from regulator binding as suggested by Rob H. Signed-off-by: Matti Vaittinen --- .../devicetree/bindings/regulator/rohm,bd71837-regulator.txt | 8 1 file

[PATCH v8 0/2] mfd/regulator/clk/input: bd71837: ROHM BD71837 PMIC driver

2018-06-29 Thread Matti Vaittinen
-next --- Matti Vaittinen (2): mfd: bd71837: mfd driver for ROHM BD71837 PMIC mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 67 drivers/mfd/Kconfig| 13 + drivers/mfd/Mak

[PATCH v8 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-06-29 Thread Matti Vaittinen
ROHM BD71837 PMIC MFD driver providing interrupts and support for three subsystems: - clk - Regulators - input/power-key fix too long lines Signed-off-by: Matti Vaittinen --- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile| 1 + drivers/mfd/bd71837.c | 220

[PATCH v8 2/2] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-06-29 Thread Matti Vaittinen
Document devicetree bindings for ROHM BD71837 PMIC MFD. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring --- .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 67 ++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/rohm

Re: [PATCH v8 2/2] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-06-29 Thread Matti Vaittinen
On Fri, Jun 29, 2018 at 11:23:42AM +0300, Matti Vaittinen wrote: > Document devicetree bindings for ROHM BD71837 PMIC MFD. > > Signed-off-by: Matti Vaittinen > Reviewed-by: Rob Herring I kept the Reviewed-by: tag here as there is no changes from patch v6 which was reviewed by Rob

Re: [PATCH 8/9] regulator: bd71837: BD71837 PMIC regulator driver

2018-05-24 Thread Matti Vaittinen
hen the power gets removed > just because they changed the voltage. Instead implement a custom set > operation that returns an error if the user attempts to change the > voltage while the regualtor is enabled. Makes perfect sense. I will change the operation to this. Br, Matti Vaittinen

Re: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

2018-05-24 Thread Matti Vaittinen
On Thu, May 24, 2018 at 06:57:21PM +0100, Mark Brown wrote: > On Thu, May 24, 2018 at 05:30:57PM +, Vaittinen, Matti wrote: > > > > On Thu, May 24, 2018 at 08:57:52AM +0300, Matti Vaittinen wrote: > > > > > > > +Required properties: > > > &

Re: [PATCH 8/9] regulator: bd71837: BD71837 PMIC regulator driver

2018-05-25 Thread Matti Vaittinen
On Thu, May 24, 2018 at 05:51:27PM +, Vaittinen, Matti wrote: > > From: Mark Brown [broo...@kernel.org] > > Sent: Thursday, May 24, 2018 5:14 PM > > On Thu, May 24, 2018 at 09:00:36AM +0300, Matti Vaittinen wrote: > > > + rdev = regul

Re: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

2018-05-25 Thread Matti Vaittinen
On Fri, May 25, 2018 at 11:24:58AM +0100, Mark Brown wrote: > On Fri, May 25, 2018 at 08:54:30AM +0300, Matti Vaittinen wrote: > > On Thu, May 24, 2018 at 06:57:21PM +0100, Mark Brown wrote: > > > > You can look at the regulators node within the parent device, you know &g

Re: [PATCH 8/9] regulator: bd71837: BD71837 PMIC regulator driver

2018-05-25 Thread Matti Vaittinen
On Fri, May 25, 2018 at 11:14:23AM +0100, Mark Brown wrote: > On Fri, May 25, 2018 at 10:22:53AM +0300, Matti Vaittinen wrote: > > On Thu, May 24, 2018 at 05:51:27PM +, Vaittinen, Matti wrote: > > > > > devm_regulator_regster() > > > > Makes se

[PATCH v2 0/6] mfd/regulator/clk: bd71837: ROHM BD71837 PMIC driver

2018-05-28 Thread Matti Vaittinen
nd support for gated clock. Patch 6: regulator driver supporting 8 bucks and 7 LDOs. This patch series is based on for-mfd-next --- Matti Vaittinen (6): mfd: bd71837: mfd driver for ROHM BD71837 PMIC mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC regulator: bd71837:

[PATCH v2 1/6] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-05-28 Thread Matti Vaittinen
ROHM BD71837 PMIC MFD driver providing interrupts and support for two subsystems: - clk - Regulators Signed-off-by: Matti Vaittinen --- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile| 1 + drivers/mfd/bd71837.c | 238 + include/linux

[PATCH v2 3/6] regulator: bd71837: Devicetree bindings for BD71837 regulators

2018-05-28 Thread Matti Vaittinen
Document devicetree bindings for ROHM BD71837 PMIC regulators. Signed-off-by: Matti Vaittinen --- .../bindings/regulator/rohm,bd71837-regulator.txt | 126 + 1 file changed, 126 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd71837

[PATCH v2 4/6] clk: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-05-28 Thread Matti Vaittinen
Document devicetree bindings for ROHM BD71837 PMIC clock output. Signed-off-by: Matti Vaittinen --- .../bindings/clock/rohm,bd71837-clock.txt | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/rohm,bd71837

[PATCH v2 2/6] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-05-28 Thread Matti Vaittinen
Document devicetree bindings for ROHM BD71837 PMIC MFD. Signed-off-by: Matti Vaittinen --- .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 52 ++ 1 file changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt diff --git

[PATCH v2 5/6] clk: bd71837: Add driver for BD71837 PMIC clock

2018-05-28 Thread Matti Vaittinen
Support BD71837 gateable 32768 Hz clock. Signed-off-by: Matti Vaittinen --- drivers/clk/Kconfig | 9 +++ drivers/clk/Makefile | 1 + drivers/clk/clk-bd71837.c | 154 ++ 3 files changed, 164 insertions(+) create mode 100644 drivers/clk

[PATCH v2 6/6] regulator: bd71837: BD71837 PMIC regulator driver

2018-05-28 Thread Matti Vaittinen
Support for controlling the 8 bucks and 7 LDOs the PMIC contains. Signed-off-by: Matti Vaittinen --- drivers/regulator/Kconfig | 11 + drivers/regulator/Makefile| 1 + drivers/regulator/bd71837-regulator.c | 678 ++ 3 files changed, 690

[PATCH v7 3/4] clk: bd71837: Add driver for BD71837 PMIC clock

2018-06-19 Thread Matti Vaittinen
Support BD71837 gateable 32768 Hz clock. Signed-off-by: Matti Vaittinen --- drivers/clk/Kconfig | 6 ++ drivers/clk/Makefile | 1 + drivers/clk/clk-bd71837.c | 146 ++ 3 files changed, 153 insertions(+) create mode 100644 drivers/clk

[PATCH v7 4/4] input/power: Add driver for BD71837/BD71847 PMIC power button

2018-06-19 Thread Matti Vaittinen
ROHM BD71837 PMIC power button driver providing power-key press information to user-space. Signed-off-by: Matti Vaittinen --- drivers/input/misc/Kconfig | 10 + drivers/input/misc/Makefile | 1 + drivers/input/misc/bd718xx-pwrkey.c | 90

[PATCH v7 1/4] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-06-19 Thread Matti Vaittinen
ROHM BD71837 PMIC MFD driver providing interrupts and support for two subsystems: - clk - Regulators Signed-off-by: Matti Vaittinen --- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile| 1 + drivers/mfd/bd71837.c | 221 ++ include/linux/mfd

[PATCH v7 0/4] mfd/regulator/clk/input: bd71837: ROHM BD71837 PMIC driver

2018-06-19 Thread Matti Vaittinen
tch 4: power button driver for power button connected to BD71837 This patch series is based on for-mfd-next --- Matti Vaittinen (4): mfd: bd71837: mfd driver for ROHM BD71837 PMIC mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC clk: bd71837: Add driver for BD71837 PMIC clock input/power

[PATCH v7 2/4] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-06-19 Thread Matti Vaittinen
Document devicetree bindings for ROHM BD71837 PMIC MFD. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring --- .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 67 ++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/rohm

Re: [PATCH v7 4/4] input/power: Add driver for BD71837/BD71847 PMIC power button

2018-06-19 Thread Matti Vaittinen
Hello Dmitry, First of all - thanks for taking the time to review the patch =) On Tue, Jun 19, 2018 at 10:50:28AM -0700, Dmitry Torokhov wrote: > Hi Matti, > > On Tue, Jun 19, 2018 at 01:57:09PM +0300, Matti Vaittinen wrote: > > ROHM BD71837 PMIC power button driver providing

[PATCH v4 0/6] mfd/regulator/clk: bd71837: ROHM BD71837 PMIC driver

2018-05-30 Thread Matti Vaittinen
system and support for gated clock. Patch 6: regulator driver supporting 8 bucks and 7 LDOs. This patch series is based on for-mfd-next --- Matti Vaittinen (6): mfd: bd71837: mfd driver for ROHM BD71837 PMIC mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC regulator: bd71837:

[PATCH v4 1/6] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-05-30 Thread Matti Vaittinen
ROHM BD71837 PMIC MFD driver providing interrupts and support for two subsystems: - clk - Regulators Signed-off-by: Matti Vaittinen --- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile| 1 + drivers/mfd/bd71837.c | 222 ++ include/linux

[PATCH v4 2/6] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-05-30 Thread Matti Vaittinen
Document devicetree bindings for ROHM BD71837 PMIC MFD. Signed-off-by: Matti Vaittinen --- .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 52 ++ 1 file changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt diff --git

[PATCH v4 3/6] regulator: bd71837: Devicetree bindings for BD71837 regulators

2018-05-30 Thread Matti Vaittinen
Document devicetree bindings for ROHM BD71837 PMIC regulators. Signed-off-by: Matti Vaittinen --- .../bindings/regulator/rohm,bd71837-regulator.txt | 126 + 1 file changed, 126 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd71837

[PATCH v4 5/6] clk: bd71837: Add driver for BD71837 PMIC clock

2018-05-30 Thread Matti Vaittinen
Support BD71837 gateable 32768 Hz clock. Signed-off-by: Matti Vaittinen --- drivers/clk/Kconfig | 9 +++ drivers/clk/Makefile | 1 + drivers/clk/clk-bd71837.c | 151 ++ 3 files changed, 161 insertions(+) create mode 100644 drivers/clk

[PATCH v4 4/6] clk: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-05-30 Thread Matti Vaittinen
Document devicetree bindings for ROHM BD71837 PMIC clock output. Signed-off-by: Matti Vaittinen --- .../bindings/clock/rohm,bd71837-clock.txt | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/rohm,bd71837

[PATCH v4 6/6] regulator: bd71837: BD71837 PMIC regulator driver

2018-05-30 Thread Matti Vaittinen
Support for controlling the 8 bucks and 7 LDOs the PMIC contains. Signed-off-by: Matti Vaittinen --- drivers/regulator/Kconfig | 11 + drivers/regulator/Makefile| 1 + drivers/regulator/bd71837-regulator.c | 640 ++ 3 files changed, 652

Re: [PATCH v4 0/6] mfd/regulator/clk: bd71837: ROHM BD71837 PMIC driver

2018-05-30 Thread Matti Vaittinen
Hello All, I would like to ask for an educated opinion from more experienced regulator driver developers. On Wed, May 30, 2018 at 11:41:13AM +0300, Matti Vaittinen wrote: > Patch series adding support for ROHM BD71837 PMIC. > > BD71837 is a programmable Power Management IC for poweri

Re: Applied "regulator: bd71837: BD71837 PMIC regulator driver" to the regulator tree

2018-05-30 Thread Matti Vaittinen
patches (or at least the MFD parts which is patch 1/6) to his tree - then we are Ok. But if the MFD needs to go via Lee's tree - then I need some process guidance in order to understand how this goes and what is expected from me =) Br, Matti Vaittinen > > All being well this

Re: [PATCH v4 0/6] mfd/regulator/clk: bd71837: ROHM BD71837 PMIC driver

2018-05-30 Thread Matti Vaittinen
On Wed, May 30, 2018 at 12:00:00PM +0100, Mark Brown wrote: > On Wed, May 30, 2018 at 12:05:12PM +0300, Matti Vaittinen wrote: > > > Other 4 can be used on PWM or PFM switching mode. When PWM is used > > voltages can be changed without disabling regulator. On PFM this shou

Re: Applied "regulator: bd71837: BD71837 PMIC regulator driver" to the regulator tree

2018-05-30 Thread Matti Vaittinen
On Wed, May 30, 2018 at 12:17:14PM +0100, Mark Brown wrote: > On Wed, May 30, 2018 at 02:14:25PM +0300, Matti Vaittinen wrote: > > > The patch 1/6 contains the header file > > include/linux/mfd/bd71837.h with bunch of definitions this patch is > > requiring. > >

Re: [PATCH v4 2/6] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-05-31 Thread Matti Vaittinen
Hello Rob, Thanks for the review! On Wed, May 30, 2018 at 10:01:29PM -0500, Rob Herring wrote: > On Wed, May 30, 2018 at 11:42:03AM +0300, Matti Vaittinen wrote: > > Document devicetree bindings for ROHM BD71837 PMIC MFD. > > + - interrupts : The interrupt lin

Re: [PATCH v4 3/6] regulator: bd71837: Devicetree bindings for BD71837 regulators

2018-05-31 Thread Matti Vaittinen
On Wed, May 30, 2018 at 10:04:36PM -0500, Rob Herring wrote: > On Wed, May 30, 2018 at 11:42:32AM +0300, Matti Vaittinen wrote: > > Document devicetree bindings for ROHM BD71837 PMIC regulators. > > +ROHM BD71837 Power Management Integrated Circuit (PMIC) regulator bindings > &

Re: [PATCH v2 0/6] mfd/regulator/clk: bd71837: ROHM BD71837 PMIC driver

2018-05-31 Thread Matti Vaittinen
On Wed, May 30, 2018 at 08:23:47AM -0700, Stephen Boyd wrote: > Quoting Lee Jones (2018-05-30 04:16:49) > > On Tue, 29 May 2018, Matti Vaittinen wrote: > > > > > Hello, > > > > > > On Tue, May 29, 2018 at 08:39:58AM +0100, Lee Jones wrote: > >

Re: [PATCH v4 2/6] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-05-31 Thread Matti Vaittinen
On Thu, May 31, 2018 at 10:17:17AM +0300, Matti Vaittinen wrote: > Hello Rob, > > Thanks for the review! > > On Wed, May 30, 2018 at 10:01:29PM -0500, Rob Herring wrote: > > On Wed, May 30, 2018 at 11:42:03AM +0300, Matti Vaittinen wrote: > > > Document devicetree

Re: [PATCH v4 2/6] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-05-31 Thread Matti Vaittinen
On Thu, May 31, 2018 at 09:07:24AM -0500, Rob Herring wrote: > On Thu, May 31, 2018 at 5:23 AM, Matti Vaittinen > wrote: > > On Thu, May 31, 2018 at 10:17:17AM +0300, Matti Vaittinen wrote: > >> On Wed, May 30, 2018 at 10:01:29PM -0500, Rob Herring wrote: > >> > O

Re: [PATCH v4 5/6] clk: bd71837: Add driver for BD71837 PMIC clock

2018-06-01 Thread Matti Vaittinen
First of all - Thanks for looking at this! On Thu, May 31, 2018 at 08:10:39AM -0700, Stephen Boyd wrote: > Quoting Matti Vaittinen (2018-05-30 01:43:19) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > > index 41492e980ef4..4b045699bb5e 100644 > > --- a/drivers/

Re: [PATCH v4 2/6] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-06-01 Thread Matti Vaittinen
On Thu, May 31, 2018 at 07:57:53AM -0700, Stephen Boyd wrote: > Quoting Rob Herring (2018-05-31 07:07:24) > > On Thu, May 31, 2018 at 5:23 AM, Matti Vaittinen > > wrote: > > > On Thu, May 31, 2018 at 10:17:17AM +0300, Matti Vaittinen wrote: > > >> Hello Rob,

Re: [PATCH v8 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-04 Thread Matti Vaittinen
, Enric Balletbo Serra wrote: > One doubt regarding the probe function and few comments. > > Missatge de Matti Vaittinen del > dia dv., 29 de juny 2018 a les 11:47: > > > > ROHM BD71837 PMIC MFD driver providing interrupts and support > > for three subsystems: > >

Re: [PATCH v7 0/4] mfd/regulator/clk/input: bd71837: ROHM BD71837 PMIC driver

2018-07-04 Thread Matti Vaittinen
On Tue, Jul 03, 2018 at 08:02:00AM +0100, Lee Jones wrote: > On Thu, 21 Jun 2018, Matti Vaittinen wrote: > > > On Tue, Jun 19, 2018 at 01:55:31PM +0300, Matti Vaittinen wrote: > > > Patch series adding support for ROHM BD71837 PMIC. > > > > > What is the prefe

Re: [PATCH v8 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-04 Thread Matti Vaittinen
On Wed, Jul 04, 2018 at 11:39:11AM +0300, Matti Vaittinen wrote: > On Tue, Jul 03, 2018 at 11:26:00AM +0200, Enric Balletbo Serra wrote: > > Missatge de Matti Vaittinen del > > dia dv., 29 de juny 2018 a les 11:47: > > > > Now that you use devm calls and you do

Re: [PATCH v8 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-04 Thread Matti Vaittinen
On Wed, Jul 04, 2018 at 11:11:02AM +0100, Lee Jones wrote: > On Wed, 04 Jul 2018, Matti Vaittinen wrote: > > > On Wed, Jul 04, 2018 at 11:39:11AM +0300, Matti Vaittinen wrote: > > > On Tue, Jul 03, 2018 at 11:26:00AM +0200, Enric Balletbo Serra wrote: > > > >

[PATCH v9 0/2] mfd/regulator/clk/input: bd71837: ROHM BD71837 PMIC driver

2018-07-05 Thread Matti Vaittinen
r and definitions bringing interrupt support and enabling clk, regulator and input subsystems. patch 2: MFD driver DT bindings This patch series is based on for-mfd-next --- Matti Vaittinen (2): mfd: bd71837: mfd driver for ROHM BD71837 PMIC mfd: bd71837: Devicetree binding

[PATCH v9 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-05 Thread Matti Vaittinen
ROHM BD71837 PMIC MFD driver providing interrupts and support for three subsystems: - clk - Regulators - input/power-key Signed-off-by: Matti Vaittinen --- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile| 1 + drivers/mfd/bd71837.c | 215

[PATCH v9 2/2] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-07-05 Thread Matti Vaittinen
Document devicetree bindings for ROHM BD71837 PMIC MFD. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring --- .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 67 ++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/rohm

  1   2   3   4   5   6   7   8   9   >