Re: [PATCH 1/5] pinctrl: abx500: Staticize some symbols

2013-03-19 Thread Patrice CHOTARD
00.c:714:5: warning: > symbol 'abx500_pin_config_get' was not declared. Should it be static? > drivers/pinctrl/pinctrl-abx500.c:721:5: warning: > symbol 'abx500_pin_config_set' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat &g

Re: [PATCH 2/5] pinctrl: ab8500: Staticize some symbols

2013-03-19 Thread Patrice CHOTARD
l/pinctrl-ab8500.c:458:32: warning: > symbol 'ab8500_gpio_irq_cluster' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat > Cc: Patrice Chotard > --- > drivers/pinctrl/pinctrl-ab8500.c |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-)

Re: [PATCH 3/5] pinctrl: ab9540: Staticize some symbols

2013-03-19 Thread Patrice CHOTARD
7;ab9540_gpio_irq_cluster' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat > Cc: Patrice Chotard > --- > drivers/pinctrl/pinctrl-ab9540.c |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pin

Re: [PATCH 4/5] pinctrl: ab8540: Staticize some symbols

2013-03-19 Thread Patrice CHOTARD
'ab8540_gpio_irq_cluster' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat > Cc: Patrice Chotard > --- > drivers/pinctrl/pinctrl-ab8540.c |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pin

Re: [PATCH 5/5] pinctrl: ab8505: Staticize some symbols

2013-03-19 Thread Patrice CHOTARD
'ab8505_gpio_irq_cluster' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat > Cc: Patrice Chotard > --- > drivers/pinctrl/pinctrl-ab8505.c |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pin

Re: [PATCH RFT] pinctrl: abx500: Fix checking if pin use AlternateFunction register

2013-03-13 Thread Patrice CHOTARD
f.alt_bit2 are UNUSED. >> >> Signed-off-by: Axel Lin > > Tentatively applied to fixes, waiting for Patrice to confirm... > > Thanks! > Linus Walleij Acked-by: Patrice Chotard Patrice-- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-03-14 Thread Patrice CHOTARD
On 03/13/2013 07:22 PM, Stephen Warren wrote: > On 03/13/2013 09:44 AM, Linus Walleij wrote: >> From: Patrice Chotard >> >> This mutex avoids deadlock in case of use of multiple pin >> controllers. Before this modification, by using a global >> mutex, deadlock a

[PATCH] pinctrl: pinctrl-abx500: fix issue when no pdata

2013-04-18 Thread Patrice CHOTARD
Fix an issue when probing pinctrl-abx500 with no platform data Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c index 0cf3fa4..04b1408 100644 --- a

Re: [PATCH 1/2] Add pin list based GPIO ranges

2013-06-14 Thread Patrice CHOTARD
On 06/13/2013 02:55 PM, Christian Ruppert wrote: > Traditionally, GPIO ranges are based on consecutive ranges of both GPIO > and pin numbers. This patch allows for GPIO ranges with arbitrary lists > of pin numbers. > > Signed-off-by: Christian Ruppert > --- > drivers/pinctrl/core.c |

Re: [PATCH 2/2] pinctrl: abx500: fix abx500_gpio_get()

2013-06-20 Thread Patrice Chotard
On Thu, Jun 20, 2013 at 11:00 AM, Fabio Baltieri wrote: > Hi Patrice, > > On Thu, Jun 20, 2013 at 09:24:44AM +0200, patrice.chotard...@gmail.com wrote: >> From: Patrice Chotard >> >> _ allow to get output GPIO value. >> _ as there is no GPIO0 o

Re: [PATCH 1/2] pinctrl: abx500: Add device tree support

2013-06-20 Thread Patrice Chotard
rd...@gmail.com wrote: >> From: Patrice Chotard >> >> We use the same way to define pin muxing and pin configuration >> than for nomadik. So pickup code from pinctrl_nomadik.c to be >> able to implement pin multiplexing and pin configuration using >> the devic

Re: [PATCH 2/2] pinctrl: abx500: fix abx500_pin_config_set()

2013-06-20 Thread Patrice Chotard
On Thu, Jun 20, 2013 at 10:18 AM, Fabio Baltieri wrote: > On Thu, Jun 20, 2013 at 09:23:22AM +0200, patrice.chotard...@gmail.com wrote: >> From: Patrice Chotard >> >> _ Update abx500_pin_config_set() in order to take in >> account PIN_CONFIG_BIAS_DISABLE state to disa

Re: [PATCH v2 1/4] pinctrl: abx500: suppress hardcoded value

2013-06-24 Thread Patrice CHOTARD
On 06/24/2013 01:29 PM, Linus Walleij wrote: > On Thu, Jun 20, 2013 at 4:05 PM, wrote: > >> From: Patrice Chotard >> >> Replace hardcoded value by corresponding #define's. >> >> Signed-off-by: Patrice Chotard > > This is not so good. The c

Re: [PATCH v2 4/4] pinctrl: abx500: rework error path

2013-06-24 Thread Patrice CHOTARD
On 06/24/2013 01:37 PM, Linus Walleij wrote: > On Thu, Jun 20, 2013 at 4:05 PM, wrote: > >> From: Patrice Chotard >> >> At several places, return value was not tested >> and error output was missing. >> >> Signed-off-by: Patrice Chotard > > Th

Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-04-10 Thread Patrice CHOTARD
On 03/28/2013 12:33 AM, Stephen Warren wrote: > On 03/27/2013 03:45 PM, Linus Walleij wrote: >> On Thu, Mar 14, 2013 at 5:59 PM, Patrice CHOTARD >> wrote: >>> On 03/13/2013 07:22 PM, Stephen Warren wrote: >>> >>>> On 03/13/2013 09:44 AM, Lin

Re: [PATCH] [media] ngene: Use newly created function

2013-01-06 Thread Patrice Chotard
Hi Emil, You are right, there was a missing piece of code. During merge, part of the orignal patch was missing. I have signaled it to Mauro who have fixed it in media_tree. Regards. Le 06/01/2013 21:59, Emil Goode a écrit : > The function demod_attach_drxd was split into two by commit 36a495a3.

Re: [PATCH V2 08/63] clocksource/drivers/st_lpc: Convert init function to return error

2016-06-20 Thread Patrice Chotard
r_info("clksrc-st-lpc: clocksource initialised - running @ %luHz\n", clk_get_rate(ddata.clk)); + + return ret; } -CLOCKSOURCE_OF_DECLARE(ddata, "st,stih407-lpc", st_clksrc_of_register); +CLOCKSOURCE_OF_DECLARE_RET(ddata, "st,stih407-lpc", st_clksrc_of_register); Acked-by: Patrice Chotard

Re: [PATCH] MAINTAINERS: update STi maintainer list

2016-06-21 Thread Patrice Chotard
On 06/21/2016 11:35 AM, Maxime Coquelin wrote: Remove myself as STi maintainer as I will no longer have access to STi platforms, and remove Srini too, who now works on other platforms. Patrice will manage the pull requests. Signed-off-by: Maxime Coquelin Cc: Patrice Chotard Cc: Srinivas

Re: [PATCH 1/4] ARM: dts: STiH410: Handle interconnect clock required by EHCI/OHCI (USB)

2016-09-08 Thread Patrice Chotard
interrupts = ; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usb1>; > - clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>; > + clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>, > + <&clk_s_c0_flexgen CLK_RX_ICN_DISP_0>; > resets = <&powerdown STIH407_USB2_PORT1_POWERDOWN>, ><&softreset STIH407_USB2_PORT1_SOFTRESET>; > reset-names = "power", "softreset"; Acked-by: Patrice Chotard

Re: [PATCH 2/4] ARM: dts: STiH407-family: Provide interconnect clock for consumption in ST SDHCI

2016-09-08 Thread Patrice Chotard
+ clock-names = "mmc", "icn"; > + clocks = <&clk_s_c0_flexgen CLK_MMC_1>, > + <&clk_s_c0_flexgen CLK_RX_ICN_HVA>; > resets = <&softreset STIH407_MMC1_SOFTRESET>; > bus-width = <4>; > }; Acked-by: Patrice Chotard

Re: [PATCH 2/4] ARM: dts: STiH407-family: Provide interconnect clock for consumption in ST SDHCI

2016-09-08 Thread Patrice Chotard
Hi Lee On 09/08/2016 11:11 AM, Lee Jones wrote: > The STiH4{07,10} platform contains some interconnect clocks which are used > by various IPs. If these clocks aren't handled correctly by ST's SDHCI > driver MMC will break and the following output can be observed: > > [ 13.916949] mmc0: Timeout

Re: [PATCH 1/4] ARM: dts: STiH410: Handle interconnect clock required by EHCI/OHCI (USB)

2016-09-08 Thread Patrice Chotard
Hi Lee On 09/08/2016 11:11 AM, Lee Jones wrote: > The STiH4{07,10} platform contains some interconnect clocks which are used > by various IPs. If this clock isn't handled correctly by ST's EHCI/OHCI > drivers, their hub won't be found, the following error be shown and the > result will be non-wor

[RESEND GIT PULL] STi DT fixes for v4.8-rcs

2016-09-08 Thread Patrice Chotard
Hi Arnd, Olof, Kevin I resend this pull request as i got issue with the local IT infrastructure. Please consider this set for inclusion into the v4.8-rcs. The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) are available in t

Re: [PATCH v9 00/19] Add support for FDMA DMA controller and slim core rproc found on STi chipsets

2016-09-14 Thread Patrice Chotard
Hi Bjorn On 09/13/2016 08:06 PM, Bjorn Andersson wrote: > On Tue 13 Sep 02:31 PDT 2016, Peter Griffin wrote: > >> Hi Vinod & Bjorn, >> >> [..] >> >> On Mon, 05 Sep 2016, Peter Griffin wrote: >> >>> v8 actions some review feedback from Bjorn to the slim rproc driver, and >>> also includes >>> a p

Re: [PATCH v9 06/19] ARM: STi: DT: STiH407: Add FDMA driver dt nodes.

2016-09-14 Thread Patrice Chotard
Hi Peter On 09/05/2016 03:16 PM, Peter Griffin wrote: > These nodes are required to get the fdma driver working > on STiH407 based silicon. > > Signed-off-by: Peter Griffin > Acked-by: Lee Jones > --- > arch/arm/boot/dts/stih407-family.dtsi | 52 > +++ > 1 file

Re: [PATCH v9 10/19] ARM: DT: STiH407: Add i2s_out pinctrl configuration

2016-09-14 Thread Patrice Chotard
Hi Peter On 09/05/2016 03:16 PM, Peter Griffin wrote: > This patch adds the pinctrl config for the i2s_out pins > used by the uniperif player IP. > > Signed-off-by: Arnaud Pouliquen > Signed-off-by: Peter Griffin > Acked-by: Lee Jones > --- > arch/arm/boot/dts/stih407-pinctrl.dtsi | 23 ++

Re: [PATCH v9 11/19] ARM: DT: STiH407: Add i2s_in pinctrl configuration

2016-09-14 Thread Patrice Chotard
Hi Peter On 09/05/2016 03:16 PM, Peter Griffin wrote: > This patch adds the pinctrl config for the i2s_in pins > used by the uniperif reader IP. > > Signed-off-by: Arnaud Pouliquen > Signed-off-by: Peter Griffin > Acked-by: Lee Jones > --- > arch/arm/boot/dts/stih407-pinctrl.dtsi | 24 +++

Re: [PATCH v9 12/19] ARM: DT: STiH407: Add spdif_out pinctrl config

2016-09-14 Thread Patrice Chotard
Hi Peter On 09/05/2016 03:16 PM, Peter Griffin wrote: > This patch adds the pinctrl config for the spidf out > pins used by the sasg codec IP. > > Signed-off-by: Arnaud Pouliquen > Signed-off-by: Peter Griffin > Acked-by: Lee Jones > --- > arch/arm/boot/dts/stih407-pinctrl.dtsi | 8 >

Re: [PATCH v9 14/19] ARM: STi: DT: STiH407: Add uniperif player dt nodes

2016-09-14 Thread Patrice Chotard
Hi Peter On 09/05/2016 03:16 PM, Peter Griffin wrote: > This patch adds the DT nodes for the uniperif player > IP blocks found on STiH407 family silicon. > > Signed-off-by: Arnaud Pouliquen > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407-family.dtsi | 80 > +++

Re: [PATCH v9 15/19] ARM: STi: DT: STiH407: Add uniperif reader dt nodes

2016-09-14 Thread Patrice Chotard
Hi Peter On 09/05/2016 03:16 PM, Peter Griffin wrote: > This patch adds the DT node for the uniperif reader > IP block found on STiH407 family silicon. > > Signed-off-by: Arnaud Pouliquen > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407-family.dtsi | 28

Re: [PATCH v9 16/19] ARM: DT: STi: stihxxx-b2120: Add DT nodes for STi audio card

2016-09-14 Thread Patrice Chotard
Hi Peter On 09/05/2016 03:16 PM, Peter Griffin wrote: > This patch enables the uniperif players 2 & 3 for b2120 boards > and also adds the "simple-audio-card" device node to interconnect > the SoC sound device and the codec. > > Signed-off-by: Arnaud Pouliquen > Signed-off-by: Peter Griffin > -

Re: [PATCH v9 13/19] ARM: STi: DT: STiH407: Add sti-sasg-codec dt node

2016-09-14 Thread Patrice Chotard
Hi Peter On 09/05/2016 03:16 PM, Peter Griffin wrote: > This patch adds the dt node for the internal audio > codec IP. > > Signed-off-by: Arnaud Pouliquen > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407-family.dtsi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

[GIT PULL] STi DT update for v4.9

2016-09-14 Thread Patrice Chotard
: STiH407: Declare PWM Capture data lines via Pinctrl ARM: dts: STiH416: Supply PWM Capture IRQs ARM: dts: STiH416: Declare PWM Capture data lines via Pinctrl ARM: dts: STiH416: Define PWM Capture clock ARM: dts: STiH416: Define the number of PWM Capture channels Patrice

Re: [PATCH 00/19] [RESEND] Remove STiH415 and STiH416 SoC platform support

2016-09-14 Thread Patrice Chotard
Hi Peter, Arnd On 09/14/2016 03:38 PM, Arnd Bergmann wrote: > On Wednesday, September 14, 2016 2:27:38 PM CEST Peter Griffin wrote: >> Resending due to incorrect Cc tags. >> >> ST have sent patches which remove clock support for these SoCs [1] >> which once applied mean the platform will no longer

Re: [PATCH v3 00/14] Clock improvement for video playback

2016-09-14 Thread Patrice Chotard
On 09/14/2016 08:36 PM, Stephen Boyd wrote: > On 08/29, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> v3: >> - Rebase to v4.8-rc1 >> - Tipo fix in st,clkgen-pll.txt >> - Add Ack of Peter for the series >> - Add missed patch: "ARM: DT: STiH4xx: Simplify clock binding of

Re: [PATCH v3 03/14] ARM: DT: STiH4xx: Simplify clock binding of STiH4xx platforms

2016-09-15 Thread Patrice Chotard
On 08/29/2016 02:26 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch simplifies the clock binding because we had too much detail. > > Signed-off-by: Gabriel Fernandez > --- > arch/arm/boot/dts/stih407-clock.dtsi | 18 +- > arch/arm/boot/dts/stih410

Re: [PATCH v3 09/14] ARM: DT: STiH418: Enable clock propagation for audio clocks

2016-09-15 Thread Patrice Chotard
On 08/29/2016 02:27 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch is used in the clock driver to apply a clock propagation > flag on the audio clocks of STiH418 > > Signed-off-by: Olivier Bideau > Signed-off-by: Gabriel Fernandez > Acked-by: Peter Griffin > --

Re: [PATCH v3 07/14] ARM: DT: STiH407: Enable clock propagation for audio clocks

2016-09-15 Thread Patrice Chotard
On 08/29/2016 02:26 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch is used in the clock driver to apply a clock propagation > flag on the audio clocks of STiH407 > > Signed-off-by: Olivier Bideau > Signed-off-by: Gabriel Fernandez > Acked-by: Peter Griffin > --

Re: [PATCH v3 14/14] ARM: DT: STi: STiH410: clock configuration to address 720p and 1080p

2016-09-15 Thread Patrice Chotard
On 08/29/2016 02:27 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > It is necessary to properly configure these clocks in order > to address 720p and 1080p HDMI resolution. > > Signed-off-by: Vincent Abriou > Signed-off-by: Gabriel Fernandez > Acked-by: Peter Griffin > ---

Re: [PATCH v3 13/14] ARM: DT: STi: STiH407: clock configuration to address 720p and 1080p

2016-09-15 Thread Patrice Chotard
On 08/29/2016 02:27 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > It is necessary to properly configure these clocks in order > to address 720p and 1080p HDMI resolution. > > Signed-off-by: Vincent Abriou > Signed-off-by: Gabriel Fernandez > Acked-by: Peter Griffin > ---

Re: [PATCH v3 10/14] ARM: DT: STiH407: Enable synchronous clock mode for video clocks

2016-09-15 Thread Patrice Chotard
On 08/29/2016 02:27 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch enables the synchronous clock mode for video clocks > on STiH407 board. > > Signed-off-by: Olivier Bideau > Signed-off-by: Gabriel Fernandez > Acked-by: Peter Griffin > --- > arch/arm/boot/dts/

Re: [PATCH v3 11/14] ARM: DT: STiH410: Enable synchronous clock mode for video clocks

2016-09-15 Thread Patrice Chotard
On 08/29/2016 02:27 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch enables the synchronous clock mode for video clocks > on STiH410 board. > > Signed-off-by: Olivier Bideau > Signed-off-by: Gabriel Fernandez > Acked-by: Peter Griffin > --- > arch/arm/boot/dts/

Re: [PATCH v3 12/14] ARM: DT: STiH418: Enable synchronous clock mode for video clocks

2016-09-15 Thread Patrice Chotard
On 08/29/2016 02:27 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch enables the synchronous clock mode for video clocks > on STiH418 board. > > Signed-off-by: Olivier Bideau > Signed-off-by: Gabriel Fernandez > Acked-by: Peter Griffin > --- > arch/arm/boot/dts/

Re: [PATCH v3 08/14] ARM: DT: STiH410: Enable clock propagation for audio clocks

2016-09-15 Thread Patrice Chotard
On 08/29/2016 02:27 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch is used in the clock driver to apply a clock propagation > flag on the audio clocks of STiH410 > > Signed-off-by: Olivier Bideau > Signed-off-by: Gabriel Fernandez > Acked-by: Peter Griffin > --

Re: [PATCH v3 00/14] Clock improvement for video playback

2016-09-15 Thread Patrice Chotard
On 09/15/2016 08:57 AM, Patrice Chotard wrote: > > > On 09/14/2016 08:36 PM, Stephen Boyd wrote: >> On 08/29, gabriel.fernan...@st.com wrote: >>> From: Gabriel Fernandez >>> >>> v3: >>> - Rebase to v4.8-rc1 >>> - Tipo fix

Re: [GIT PULL] STi DT update for v4.9

2016-09-15 Thread Patrice Chotard
On 09/14/2016 03:15 PM, Patrice Chotard wrote: > Hi Arnd, Kevin, Olof > > PLease consider this next batch for v4.9 > > The following changes since commit ba5ba11906d5462993f5fd4e3da4d234505427a0: > > ARM: dts: STiH41x-b2020: Update gpio specifier (2016-09-02 15:

Re: [RESEND PATCH v2 00/13] Clock improvement for video playback

2016-08-05 Thread Patrice Chotard
Hi Mike I believe that you and Gabriel found an agreement to include this series in v4.8 Unfortunately it seems it's not the case, for which reason ? Thanks Patrice On 06/16/2016 11:20 AM, Gabriel Fernandez wrote: > v2: > - Simpliflication of clock binding > remark from Rob https://lkm

Re: [PATCH 1/3] ARM: dts: stm32: Fix DT dtc warnings for stm32h7

2018-08-07 Thread Patrice CHOTARD
I will send a v2 Thanks for reviewing ;-) Patrice On 08/07/2018 01:56 PM, Alexandre Torgue wrote: > Hi Patrice > > On 08/07/2018 01:38 PM, Alexandre Torgue wrote: >>> +    #address-cells = <1>; >>> +    #size-cells = <1>; >>> + >>>   clocks { >>>   clk_hse: clk-hse { >>>    

Re: [PATCH v2 3/3] ARM: dts: stm32: Fix DT dtc warnings for stm32f4

2018-08-07 Thread Patrice CHOTARD
Hi Rob On 08/07/2018 04:08 PM, Rob Herring wrote: > On Tue, Aug 7, 2018 at 6:55 AM wrote: >> >> From: Patrice Chotard >> >> Fix the following DT dtc warnings for stm32f429 and >> stm32f469 boards: >> >> Warning (node_name_chars_strict): /soc/pin-

Re: [U-BOOT internal] ARM: dts: stm32: Add clk-lse node's label on stm32f429

2018-07-19 Thread Patrice CHOTARD
Sorry, don't take care about this patch, it was send using the wrong script Patrice On 07/19/2018 03:10 PM, patrice.chot...@st.com wrote: > From: Patrice Chotard > > Add missing clk_lse label for node clk-lse. > > Signed-off-by: Patrice Chotard > --- > arch/arm/b

Re: [PATCH] ARM: STi: at least warn if of_iomap fails

2018-07-16 Thread Patrice CHOTARD
Hi Nicholas On 07/12/2018 05:48 PM, Nicholas Mc Guire wrote: > The call to of_iomap() is unchecked but scu_enable(), which the returned > address is passed on to, assumes a valid mapping. If the mapping is > invalid this could probably lead to undefined system state so at least > a warning should

Re: [PATCH 1/1] ARM: compressed/head.S: fix __nop macro rept number for ARMv7M

2017-05-12 Thread Patrice CHOTARD
Hi all It's a gentle reminder to not forgot this patch. Thanks Patrice On 04/25/2017 11:01 AM, patrice.chot...@st.com wrote: > From: Patrice Chotard > > In zImage, _magic_sig is located at offset 0x24. > But for ARMv7M architecture which enable CPU_THUMBONLY > and !

Re: [PATCH 0/7] ARM: dts: STi: Fix DT dtc warnings

2018-01-10 Thread Patrice CHOTARD
Hi Arnd On 01/10/2018 04:52 PM, Arnd Bergmann wrote: > On Wed, Jan 10, 2018 at 9:21 AM, wrote: >> From: Patrice Chotard >> >> This series fixes all dtc warnings related to STi platforms dt files. >> It has been triggered by Rob Herring [1] >> >> [1] h

Re: [PATCH 0/7] ARM: dts: STi: Fix DT dtc warnings

2018-01-10 Thread Patrice CHOTARD
HI Arnd On 01/10/2018 09:52 PM, Arnd Bergmann wrote: > On Wed, Jan 10, 2018 at 6:17 PM, Patrice CHOTARD > wrote: >> Hi Arnd >> >> On 01/10/2018 04:52 PM, Arnd Bergmann wrote: >>> On Wed, Jan 10, 2018 at 9:21 AM, wrote: >>>> From: Patrice Chotard

Re: [PATCH v2 03/15] mmc: mmci: Don't pretend all variants to have OPENDRAIN bit

2018-01-18 Thread Patrice CHOTARD
Hi Ulf On 01/17/2018 10:33 AM, Ulf Hansson wrote: > [...] > >> /* Busy detection for the ST Micro variant */ >> @@ -1455,16 +1465,13 @@ static void mmci_set_ios(struct mmc_host *mmc, >> struct mmc_ios *ios) >> ~MCI_ST_DATA2DIREN); >> } >> >> - if

Re: [PATCH v2 04/15] mmc: mmci: Add support for setting pad type via pinctrl

2018-01-18 Thread Patrice CHOTARD
Hi Ulf On 01/17/2018 10:34 AM, Ulf Hansson wrote: > [...] > >> /* >> @@ -1616,6 +1625,32 @@ static int mmci_probe(struct amba_device *dev, >> host = mmc_priv(mmc); >> host->mmc = mmc; >> >> + /* >> +* Some variant (STM32) doesn't have opendrain bit, nevert

Re: [PATCH 2/5] pinctrl: stm32: add STM32F769 MCU support

2018-01-18 Thread Patrice CHOTARD
Hi Linus It's a gentle reminder because this patch seems not yet merged in any of your pinctrl branch. Thanks Patrice On 12/11/2017 09:54 AM, Alexandre Torgue wrote: > This patch which adds STM32F769 pinctrl and GPIO support, relies on the > generic STM32 pinctrl driver. > > Signed-off-by: Al

Re: [PATCH 04/14] mmc: mmci: Add STM32 variant

2018-01-15 Thread Patrice CHOTARD
Hi Linus On 01/15/2018 02:13 AM, Linus Walleij wrote: > On Fri, Jan 12, 2018 at 1:15 PM, wrote: > >> From: Patrice Chotard >> >> STM32F4 and STM32F7 MCUs has a SDIO controller that looks like >> an ARM pl810. > > PL180 you mean. Ulf can fix while applying.

Re: [PATCH 02/14] mmc: mmci: Don't pretend all variants to have MCI_STARBITERR flag

2018-01-15 Thread Patrice CHOTARD
Hi Ulf On 01/15/2018 01:32 PM, Ulf Hansson wrote: > On 12 January 2018 at 13:15, wrote: >> From: Patrice Chotard >> >> This patch prepares for supporting the STM32 variant that >> has no such bit in the status register. >> >> Signed-off-by: Andrea Mer

Re: [PATCH 03/14] mmc: mmci: Add support for setting pad type via pinctrl

2018-01-15 Thread Patrice CHOTARD
Hi Ulf On 01/15/2018 01:43 PM, Ulf Hansson wrote: > On 12 January 2018 at 13:15, wrote: >> From: Patrice Chotard >> >> The STM32 variant hasn't the control bit to switch pads in opendrain mode. >> In this case we can achieve the same result by asking to the pi

Re: [PATCH 2/7] ARM: dts: STi: Add gpio polarity for "hdmi,hpd-gpio" property

2018-01-15 Thread Patrice CHOTARD
Hi Arnd On 01/15/2018 03:59 PM, Arnd Bergmann wrote: > On Wed, Jan 10, 2018 at 9:21 AM, wrote: >> From: Patrice Chotard >> >> The GPIO polarity is missing in the hdmi,hpd-gpio property, this >> fixes the following DT warnings: >> >> arch/arm/boot/dts/sti

Re: [PATCH v2 10/10] board: Add STM32F769 SoC, discovery board support

2018-03-13 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Signed-off-by: yannick fertre Can you add a commit message explaining why you add a specific defconfig for this board. FYI, previously, the same defconfig was used for all STM32F7 boards (ie /stm32f746-disco_defconfig). You will also

Re: [PATCH v2 01/10] video: stm32: stm32_ltdc: add bridge to display controller

2018-03-13 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Manage a bridge insert between the display controller & a panel. > > Signed-off-by: yannick fertre > --- > drivers/video/stm32/stm32_ltdc.c | 107 > ++- > 1 file changed, 71 insertions(+), 36 delet

Re: [PATCH v2 02/10] video: stm32: stm32_ltdc: update debug log

2018-03-13 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Replace macro debug by pr_error, pr_warn or pr_info. > > Signed-off-by: yannick fertre > --- > drivers/video/stm32/stm32_ltdc.c | 62 > > 1 file changed, 31 insertions(+), 31 deletions(-) >

Re: [PATCH 1/2] ARM: dts: STi: Fix aliases property name for STi boards

2018-03-05 Thread Patrice CHOTARD
Hi Rob On 03/05/2018 04:28 PM, Rob Herring wrote: > On Mon, Mar 5, 2018 at 9:00 AM, wrote: >> From: Patrice Chotard >> >> Since dtc v1.4.6-9-gaadd0b65c987, aliases property name must >> be lowercase only. >> This allows to fix following warnings when compiling

Re: [PATCH v2 2/3] ARM: dts: STi: Remove useless stdout-path for STi boards

2018-03-07 Thread Patrice CHOTARD
Hi Rob On 03/06/2018 02:26 PM, Rob Herring wrote: > On Tue, Mar 6, 2018 at 2:07 AM, wrote: >> From: Patrice Chotard >> >> As serial interface is already specified into bootargs, >> stdout-path can be removed. > > Wrong way around. stdout-path is preferred ov

Re: [PATCH v2 3/3] tty: st-asc: Update tty alias

2018-03-07 Thread Patrice CHOTARD
Hi Rob On 03/06/2018 02:29 PM, Rob Herring wrote: > On Tue, Mar 6, 2018 at 2:07 AM, wrote: >> From: Patrice Chotard >> >> Since dtc v1.4.6-9-gaadd0b65c987, aliases property name >> must include only lowercase and '-'. >> >> After having updated

Re: [PATCH v2 0/6] Add mmc support for STM32F7 boards

2018-03-07 Thread Patrice CHOTARD
Hi Lee On 03/07/2018 09:35 AM, Lee Jones wrote: > On Mon, 05 Mar 2018, Alexandre Torgue wrote: > >> Hi Patrice, >> >> On 03/01/2018 11:53 AM, patrice.chot...@st.com wrote: >>> From: Patrice Chotard >>> >>> This series adds : >>>

Re: [PATCH v3 1/3] ARM: dts: STi: Fix aliases property name for STi boards

2018-03-07 Thread Patrice CHOTARD
Hi Rob On 03/07/2018 05:15 PM, Rob Herring wrote: > On Wed, Mar 7, 2018 at 2:49 AM, wrote: >> From: Patrice Chotard >> >> Update serial aliases from "ttyASN" to more common "serialN". >> >> Since dtc v1.4.6-9-gaadd0b65c987, aliases proper

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

2018-03-23 Thread Patrice CHOTARD
On 03/22/2018 10:01 PM, Alexandre Belloni wrote: > On 16/03/2018 at 07:34:06 +0000, Patrice CHOTARD wrote: >> Hi Arnd, Stephen >> >> On 03/15/2018 10:06 PM, Arnd Bergmann wrote: >>> On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell >>&g

Re: [PATCH v2 04/10] video: add support of panel OTM8009A

2018-03-13 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Support for Orise Tech otm8009a 480p dsi 2dl video mode panel. > > Signed-off-by: yannick fertre > --- > drivers/video/Kconfig | 8 + > drivers/video/Makefile | 1 + > drivers/video/orisetech_otm8009a.c |

Re: [PATCH v2 06/10] video: add support of STM32 MIPI DSI controller driver

2018-03-13 Thread Patrice CHOTARD
Hi yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Add the STM32 DSI controller driver that uses the Synopsys DesignWare > MIPI DSI host controller bridge. > > Signed-off-by: yannick fertre > --- > drivers/video/stm32/Kconfig | 10 + > drivers/video/stm32/Makefile| 1 + >

Re: [PATCH v2 07/10] video: add support of panel rm68200

2018-03-13 Thread Patrice CHOTARD
Hi yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Support for Raydium rm68200 720p dsi 2dl video mode panel. > > Signed-off-by: yannick fertre > --- > drivers/video/Kconfig | 8 + > drivers/video/Makefile | 1 + > drivers/video/raydium-rm68200.c | 329 > +

Re: [PATCH v3 10/10] board: Add STM32F769 SoC, discovery board support

2018-03-13 Thread Patrice CHOTARD
Hi Yannick You have forgotten the commit message Patrice On 03/13/2018 02:50 PM, yannick fertre wrote: > Signed-off-by: yannick fertre > --- > configs/stm32f769-disco_defconfig | 65 > +++ > 1 file changed, 65 insertions(+) > create mode 100644 configs/

Re: [PATCH v3 04/10] otm

2018-03-13 Thread Patrice CHOTARD
Hi Yannick There is a problem with patch 4. I received two patches 04/10, this one and [PATCH v3 04/10] video: add support of panel OTM8009A. Patrice On 03/13/2018 02:50 PM, yannick fertre wrote: > --- > drivers/video/orisetech_otm8009a.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deleti

Re: [PATCH v4 3/3] ARM: dts: STi: Remove "console=ttyASN" from bootargs for STi boards

2018-03-14 Thread Patrice CHOTARD
Hi Greg On 03/14/2018 02:57 PM, Greg KH wrote: > On Wed, Mar 07, 2018 at 06:35:34PM +0100, patrice.chot...@st.com wrote: >> From: Patrice Chotard >> >> As serial interface is already specified into stdout-path property, >> "console=ttyASN,115200" from bootarg

Re: [RESEND PATCH v4 3/3] ARM: dts: STi: Remove console=ttyASN from bootargs for STi boards] ARM: dts: STi: Remove "console=ttyASN" from bootargs for STi boards

2018-03-14 Thread Patrice CHOTARD
Sorry I just noticed that the commit header is corrupted I will resend this patch Patrice On 03/14/2018 03:52 PM, patrice.chot...@st.com wrote: > From: Patrice Chotard > > As serial interface is already specified into stdout-path property, > "console=ttyASN,115200"

Re: [PATCH] mmc: sdhci-*: Don't emit error msg if sdhci_add_host() fails

2018-05-25 Thread Patrice CHOTARD
st); > > diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c > index c32daed0d418..8f95647195d9 100644 > --- a/drivers/mmc/host/sdhci-st.c > +++ b/drivers/mmc/host/sdhci-st.c > @@ -422,10 +422,8 @@ static int sdhci_st_probe(struct platform_device *pdev) > st_mmcss_cconfig(np, host); > > ret = sdhci_add_host(host); > - if (ret) { > - dev_err(&pdev->dev, "Failed sdhci_add_host\n"); > + if (ret) > goto err_out; > - } > > host_version = readw_relaxed((host->ioaddr + SDHCI_HOST_VERSION)); > > For drivers/mmc/host/sdhci-st.c: Acked-by: Patrice Chotard Thanks

[GIT PULL] STi DT update for v4.18 round 1

2018-05-14 Thread Patrice CHOTARD
for 4.18: - Fix complain about IRQ_TYPE_NONE_usage Patrice Chotard (5): ARM: dts: stih407-family: Fix complain about IRQ_TYPE_NONE usage ARM: dts: stih407-pinctrl: Fix complain about IRQ_TYPE_NONE usage ARM: dts

Re: [PATCH 1/1] ARM: STi: Restore secondary CPU's bringup

2018-12-18 Thread Patrice CHOTARD
Hi Russell On 12/18/18 4:52 PM, Russell King - ARM Linux wrote: > On Tue, Dec 18, 2018 at 03:48:13PM +0100, patrice.chot...@st.com wrote: >> From: Patrice Chotard >> >> Due to pen_release and boot_lock removal, secondary CPU's bringup >> was broken. Restore CPU

Re: [PATCH 1/1] ARM: STi: Restore secondary CPU's bringup

2018-12-19 Thread Patrice CHOTARD
Hi Russell On 12/18/18 6:27 PM, Russell King - ARM Linux wrote: > On Tue, Dec 18, 2018 at 05:05:18PM +0000, Patrice CHOTARD wrote: >> Hi Russell >> >> On 12/18/18 4:52 PM, Russell King - ARM Linux wrote: >>> On Tue, Dec 18, 2018 at 03:48:13PM +0100, patrice.c

Re: [PATCH 1/1] ARM: STi: Restore secondary CPU's bringup

2018-12-19 Thread Patrice CHOTARD
On 12/19/18 12:28 PM, Russell King - ARM Linux wrote: > On Wed, Dec 19, 2018 at 10:31:35AM +0000, Patrice CHOTARD wrote: >> Hi Russell >> >> On 12/18/18 6:27 PM, Russell King - ARM Linux wrote: >>> On Tue, Dec 18, 2018 at 05:05:18PM +, Patrice CHOTARD wrote: >

[GIT PULL] STi SoC update for v4.21 round 1

2018-12-20 Thread Patrice CHOTARD
boot_lock cleanup initiated by Russell King, .smp_prepare_cpus and .smp_boot_secondary STi callbacks must be reworked to keep secondary CPU's bringup. Patrice Chotard (1): ARM: sti: remove pen_release and boot_lock arc

Re: [PATCH] dmaengine: st_fdma: use struct_size() in kzalloc()

2019-01-07 Thread Patrice CHOTARD
int i; > > - fdesc = kzalloc(sizeof(*fdesc) + > - sizeof(struct st_fdma_sw_node) * sg_len, GFP_NOWAIT); > + fdesc = kzalloc(struct_size(fdesc, node, sg_len), GFP_NOWAIT); > if (!fdesc) > return NULL; > > Acked-by: Patrice Chotard Thanks

Re: [PATCH V2] ARM: STi: warn if scu mapping fails

2018-07-18 Thread Patrice CHOTARD
cholas Mc Guire > Link: http://lkml.org/lkml/2018/7/16/219 > Fixes: commit 65ebcc115889 ("ARM: sti: Add STiH415 SOC support") > --- > > V2: replacement of WARN_ON() by a meaningful pr_err as suggested by > Patrice CHOTARD . > > Problem was found by an expe

Re: [PATCH] remoteproc: st: Use device_get_match_data()

2023-10-09 Thread Patrice CHOTARD
; - ddata->config = (struct st_rproc_config *)match->data; > + ddata->config = (struct st_rproc_config *)device_get_match_data(dev); > + if (!ddata->config) > + goto free_rproc; > > platform_set_drvdata(pdev, rproc); > Reviewed-by: Patrice Chotard Thanks Patrice

Re: [PATCH 0/3] MAINTAINERS: update STMicroelectronics email

2021-02-15 Thread Patrice CHOTARD
Hi Arnd, Olof, Kevin What is the best way to get this series merged ? Do you pick it and apply it directly, or do we integrate it in the next STM32 pull request ? Thanks Patrice On 2/1/21 11:00 AM, patrice.chot...@foss.st.com wrote: > From: Patrice Chotard > > This series: >

Re: [PATCH 0/3] MAINTAINERS: update STMicroelectronics email

2021-02-15 Thread Patrice CHOTARD
Hi Arnd On 2/15/21 3:19 PM, Arnd Bergmann wrote: > On Mon, Feb 15, 2021 at 2:17 PM Patrice CHOTARD > wrote: >> >> Hi Arnd, Olof, Kevin >> >> What is the best way to get this series merged ? >> Do you pick it and apply it directly, or do we integrate it in the

Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log

2021-04-09 Thread Patrice CHOTARD
dev_warn(&pdev->dev, "FlashSS Top Dly registers not available"); > + if (IS_ERR(pdata->top_ioaddr)) > pdata->top_ioaddr = NULL; > - } > > pltfm_host->clk = clk; > pdata->icnclk = icnclk; > Reviewed-by: Patrice Chotard Thanks Patrice

[PATCH 0/2] various fixes for pinctrl-st

2014-12-09 Thread Patrice CHOTARD
Fix deadlock when using debugfs pinconf-pins entry Add missing hook .irq_disable Francesco VIRLINZI (1): pinctrl: st: avoid multiple mutex lock Pankaj Dev (1): pinctrl: st: Add irq_disable hook to st_gpio_irqchip drivers/pinctrl/pinctrl-st.c | 5 - 1 file changed, 4 insertions(+), 1 del

[PATCH 1/2] pinctrl: st: avoid multiple mutex lock

2014-12-09 Thread Patrice CHOTARD
returns. With this patch the mutex is temporary freed. Signed-off-by: Francesco Virlinzi Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-st.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index caeeb1c

[PATCH 2/2] pinctrl: st: Add irq_disable hook to st_gpio_irqchip

2014-12-09 Thread Patrice CHOTARD
From: Pankaj Dev Currently disable_irq() doesn't work for pinctrl-st driver, due to missing irq_disable hook in the driver. disable_irq() is required only for level-triggered interrupts, which is not the case normally. Signed-off-by: Pankaj Dev Signed-off-by: Patrice Chotard --- dr

[RESEND PATCH 0/2] pinctrl-st: various fixes

2015-01-05 Thread Patrice CHOTARD
Resend this series, it seems that the one i send in December has been lost despite it was visible on lkml Two fixes for pinctrl-st pinctrl driver Francesco VIRLINZI (1): pinctrl: st: avoid multiple mutex lock Patrice Chotard (1): pinctrl: st: Add irq_disable hook to st_gpio_irqchip

[RESEND PATCH 2/2] pinctrl: st: Add irq_disable hook to st_gpio_irqchip

2015-01-05 Thread Patrice CHOTARD
Currently disable_irq() doesn't work for pinctrl-st driver, due to missing irq_disable hook in the driver. disable_irq() is required only for level-triggered interrupts, which is not the case normally. Signed-off-by: Pankaj Dev Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl

[RESEND PATCH 1/2] pinctrl: st: avoid multiple mutex lock

2015-01-05 Thread Patrice CHOTARD
returns. With this patch the mutex is temporary freed. Signed-off-by: Francesco Virlinzi Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-st.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index 7c9d513

Re: [STLinux Kernel] [PATCH v3 1/4] spi: Add new driver for STMicroelectronics' SPI Controller

2014-12-08 Thread Patrice Chotard
Hi Lee Acked-by: Patrice Chotard Thanks On 12/08/2014 01:53 PM, Lee Jones wrote: This patch adds support for the SPI portion of ST's SSC device. Signed-off-by: Lee Jones --- drivers/spi/Kconfig | 7 + drivers/spi/Makefile | 1 + drivers/spi/spi-st-ssc4.c

Re: [RESEND PATCH 1/2] pinctrl: st: avoid multiple mutex lock

2015-01-07 Thread Patrice Chotard
Hi Linus On 01/07/2015 10:44 AM, Linus Walleij wrote: On Mon, Jan 5, 2015 at 11:04 AM, Patrice CHOTARD wrote: From: Francesco VIRLINZI Using the sysfs inteface to inspect the pins configuration the system can walk around a path which acquires the same mutex twice. On STiH407 platform, for

Re: [PATCH V2] tty: serial: Add const to struct uart_ops declarations

2015-04-07 Thread Patrice Chotard
Hi On 04/05/2015 08:24 PM, Joe Perches wrote: These structs can be const, so make them const. Miscellanea: o Add static to struct uart_ops declaration in bfin_sport_uart Signed-off-by: Joe Perches --- [...] for drivers/tty/serial/st-asc.c | 2 +- Acked-by: Patrice

Re: [PATCH 1/2] rtc: st-lpc: fix possible race condition

2018-05-23 Thread Patrice CHOTARD
gt; - return 0; > -} > - > #ifdef CONFIG_PM_SLEEP > static int st_rtc_suspend(struct device *dev) > { > @@ -325,7 +320,6 @@ static struct platform_driver st_rtc_platform_driver = { > .of_match_table = st_rtc_match, > }, > .probe = st_rtc_probe, > - .remove = st_rtc_remove, > }; > > module_platform_driver(st_rtc_platform_driver); > Acked-by: Patrice Chotard Thanks Patrice

Re: [PATCH v2] rtc: st-lpc: add range

2018-05-23 Thread Patrice CHOTARD
p;st_rtc_ops; > + rtc->rtc_dev->range_max = U64_MAX; > + do_div(rtc->rtc_dev->range_max, rtc->clkrate); > > ret = rtc_register_device(rtc->rtc_dev); > if (ret) { > Acked-by: Patrice Chotard Patrice

  1   2   3   >