Hi Matthias,
Am Dienstag, 9. April 2013, 16:42:42 schrieb Matthias Leblanc:
From: Mathias leblanc mathias.leb...@st.com
* STMicroelectronics version 1.2.0, Copyright (C) 2010
* STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
* This is free software, and you are welcome to
Hi Matthias,
Am Donnerstag, 11. April 2013, 10:58:59 schrieb Mathias LEBLANC:
Hi Peter,
Yes, you have right, these error are generated by #ifndef
__STM_ST33_TPM_SPI_H__ Just remove it and the #endif next the structure.
Yes, I know that - for the submission to be included this has to be
Hi Peter,
Also the flags etc would perhaps be handy, they can be retrieved via
sysfs - on you machine it _should_ be
# cat /sys/devices/pnp0/00:0a/*
and also post the output.
root@zepto:/home/peter# ls /sys/devices/pnp0/00\:0a/
Okay it seems it's not 00:0a ;/
Can you check the node
Hi Kent,
short reply from my private account - so only talking on behalf of myself.
Am Montag, 4. März 2013, 18:41:04 schrieb Kent Yoder:
Hi Peter,
Sorry for the long delay in getting this reviewed...
No problem.
- for (count = 0; count MAX_COUNT; count++) {
-
Am Montag, 4. März 2013, 20:42:00 schrieb Geert Uytterhoeven:
drivers/staging/vt6656/card.c: In function ‘CARDqGetNextTBTT’:
drivers/staging/vt6656/card.c:793: warning: integer constant is too large
for ‘unsigned long’ type
Commit c7b7cad0d8df823ea063c86a54316bbcbfa04a7c (staging/vt6656: Fix
Am Donnerstag, 29. November 2012, 23:08:11 schrieb Kent Yoder:
On Thu, Nov 29, 2012 at 01:54:52PM -0800, Joe Perches wrote:
- itpm = (probe == 0) ? 0 : 1;
+ itpm = !!probe;
Even more trivia:
This !! isn't necessary as ints assigned to bool are converted
by
Am Mittwoch, 13. Februar 2013, 03:54:26 schrieb Peter Huewe:
Local variable AcmCtrl is never read/used after assignment so we can remove
all assignments to it and the related code around the assignments.
Signed-off-by: Peter Huewe peterhu...@gmx.de
Sorry wrong distribution list.
Seems my
Hi,
while analyzing the comedi drivers, I noticed that quite a lot of them use a
more or less similar find_boardinfo function.
e.g.:
cb_pcidas64.c
static const struct pcidas64_board
*cb_pcidas64_find_pci_board(struct pci_dev *pcidev)
{
unsigned int i;
for (i = 0; i
Am Freitag, 25. Januar 2013, 21:25:38 schrieb Jason Gunthorpe:
https://github.com/shpedoikal/linux.git tpmdd-01-22-13
Thanks Kent, I will try to test your branch next week, if I am able.
Can you also grab
https://github.com/jgunthorpe/linux/commit/98b2a198b43b41b0535200bf47516078
Hi,
thanks for resending.
Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare:
From: Shubhrajyoti Datta omaplinuxker...@gmail.com
Convert the struct i2c_msg initialization to C99 format. This makes
maintaining and editing the code simpler. Also helps once other fields
like
I'd suggest not to. Mixing actual changes with cleanups is generally
discouraged.
Yes, please don't do this. Also because it makes it really
confusing for me to figure out whether something has been applied or
not and if I have the right people on the sign off.
Peter, can you
Am Montag, 21. Januar 2013, 21:56:22 schrieb H Hartley Sweeten:
On Monday, January 21, 2013 1:52 PM, Peter Huewe wrote:
This patch adds the comedi_driver.name to pci_driver.name
to the skel driver, so we can remove the workaround in drivers.c
Signed-off-by: Peter Huewe peterhu...@gmx.de
Am Dienstag, 22. Januar 2013, 23:49:53 schrieb H Hartley Sweeten:
On Tuesday, January 22, 2013 3:40 PM, Peter Huewe wrote:
(Almost) all comedi pci drivers have some wrapper for their
pci_driver.remove function which simply calls comedi_pci_auto_unconfig
which has the same function
Am Freitag, 15. Februar 2013, 17:11:02 schrieb Dan Carpenter:
Are you using this version of clang?:
http://git.linuxfoundation.org/llvmlinux.git/
regards,
dan carpenter
Hi,
nope - plain vanilla llvm/clang, but I use some of the kernel patches from
there:
Hi,
loading iio_dummy results in kernel panic as the call to
iio_buffer_register in iio_dummy_probe is performed with indio_dev-buffer ==
NULL and thus the access to indio_dev-buffer-attrs results in this
oops/panic.
Thanks,
Peter
Steps to reproduce:
#modprobe iio_dummy
iio_dummy: module is
Hi Kent,
Heh, duh, well of course it is. I've now staged everything I'm
planning on pushing at:
git://github.com/shpedoikal/linux.git tpmdd-12-05-12
Please test and let me know if I missed anything.
Thanks,
Kent
Kent
(I'm still writing this on behalf of myself ;)
pedantic
Hi Kent, Matthias,
Am Mittwoch, 5. Dezember 2012, 19:07:20 schrieb Kent Yoder:
Heh, duh, well of course it is. I've now staged everything I'm
planning on pushing at:
git://github.com/shpedoikal/linux.git tpmdd-12-05-12
Please test and let me know if I missed anything.
I just checked
Hi Kent,
Am Mittwoch, 5. Dezember 2012, 22:00:48 schrieb Kent Yoder:
This is already at least v3 of the driver IIRC. And its not fully
committed at all, its just in a staging tree. I can blow it away at any
time if we find problems.
Not a problem. usually I'd attach any updates I
Am Donnerstag, 6. Dezember 2012, 00:09:41 schrieb Kent Yoder:
static int tpm_st33_i2c_pm_suspend(struct i2c_client *client,
pm_message_t mesg)
...
static int tpm_st33_i2c_pm_resume(struct i2c_client *client)
,,,
static struct i2c_driver tpm_st33_i2c_driver = {
Am Donnerstag, 6. Dezember 2012, 17:27:02 schrieb Kent Yoder:
On Thu, Dec 06, 2012 at 01:20:51AM +0100, Peter Huewe wrote:
This patch converts the suspend and resume functions for
tpm_i2c_stm_st33 to the new dev_pm_ops.
Signed-off-by: Peter Huewe peterhu...@gmx.de
One minor tweak,
Hi,
since I don't have a tpm I simply tried out whether the handling without a tpm
is correct, which it unfortunately isn't as my kernel oopses.
Steps to reproduce:
# insmod /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_stm_st33.ko
# echo st33zp24_i2c 0x20
Hi Jason,
Thanks for the updated patch!
Sorry, I have one really minor remark left:
+ if (rc) {
+ dev_err(chip-dev,
+ A TPM error (%d) occurred attempting to determine the
timeouts\n,
rc is a ssize_t here and when compiling with C=1 I get
Hi Mathias,
please note:
I'm writing this email on behalf of myself only and nobody else, especially not
my employer - and I'm doing this in my spare time.
I'm working for a direct competitor of yours, but I'm not using any knowledge
that I've picked up at work or that is considered secret in
Am Mittwoch, 14. November 2012, 23:18:26 schrieb Kent Yoder:
On Mon, Nov 12, 2012 at 11:37:18PM +0100, Peter Huewe wrote:
This patch also gets rid of the (false positive) sparse warning:
drivers/char/tpm/tpm.c:360 tpm_calc_ordinal_duration() error: buffer
overflow
Hi,
Do you have the I2C configuration activated ?
I have this error when I add the driver in a kernel with no I2C activated
I2C works fine on my beaglebone, however I did not add the platform data to my
boardfile.
a) as I don't use board files anymore but device trees ;)
b) it's perfectly
Hi,
thanks for your patch
static struct pnp_device_id tpm_pnp_tbl[] = {
{PNP0C31, 0}, /* TPM */
{ATM1200, 0}, /* Atmel */
@@ -835,9 +834,12 @@ static struct pnp_driver tis_pnp_driver = {
.name = tpm_tis,
.id_table = tpm_pnp_tbl,
.probe =
Hi Shuah,
thanks for your reply.
+#ifdef CONFIG_PM_SLEEP
+ .driver = {
+ .pm = tpm_tis_pm,
+ },
+#endif
};
I don't think the #if CONFIG_PM_SLEEP is required here.
In this case, the SIMPLE_DEV_PM_OPS macro handles the case internally - i.e.
no matter whether
When compiling it I get
WARNING: modpost: missing MODULE_LICENSE() in
drivers/char/tpm/tpm_spi_stm_st33.o
Thanks,
Peter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Am Montag, 23. September 2013, 20:14:31 schrieb Jason Gunthorpe:
This suppresses compile warnings on 32 bit builds.
Signed-off-by: Jason Gunthorpe jguntho...@obsidianresearch.com
Reviewed-by: Peter Huewe peterhu...@gmx.de
Signed-off-by: Peter Huewe peterhu...@gmx.de
Staged here
Hi Jason,
Am Mittwoch, 2. Oktober 2013, 00:21:13 schrieb Jason Gunthorpe:
On Wed, Oct 02, 2013 at 12:09:22AM +0200, Peter H?we wrote:
Since the tpm_spi_stm_st33, tpm_i2c_nuvoton and tpm_i2c_atmel drivers
are not yet merged and were heavily improved by you anyway, please
include
Am Montag, 23. September 2013, 20:14:38 schrieb Jason Gunthorpe:
CLASS-dev.c is a common idiom for Linux subsystems
This pulls all the code related to the miscdev into tpm-dev.c and makes it
static. The identical file_operation structs in the drivers are purged and
the tpm common code
Am Mittwoch, 2. Oktober 2013, 00:57:33 schrieb Jason Gunthorpe:
When compiling the tpm drivers as modules I get
ERROR: tpm_sysfs_del_device [drivers/char/tpm/tpm.ko] undefined!
ERROR: tpm_dev_add_device [drivers/char/tpm/tpm.ko] undefined!
ERROR: tpm_dev_del_device
Am Donnerstag, 3. Oktober 2013, 07:05:04 schrieb Jason Gunthorpe:
On Wed, Oct 02, 2013 at 01:14:18AM +0200, Peter H?we wrote:
I botched the makefile changes for the new .c files.
I believe it should be like this:
obj-$(CONFIG_TCG_TPM) += tpm-core.o
tpm-core-y := tpm.o
Am Freitag, 4. Oktober 2013, 21:17:36 schrieb Stefan Berger:
On 10/04/2013 01:08 PM, Jason Gunthorpe wrote:
On Mon, Sep 30, 2013 at 05:09:51PM -0500, Joel Schopp wrote:
So far, nobody I have talked to has offered any strong opinions on
what locality should be used or how it should be set. I
Hi Daniel,
thanks for this v3.
It's really nice to see the progress and I really like that
sparse/smatch/clang/coccicheck do not complain at all - nice job!
Konrad already did an excellent job at reviewing the driver (thanks for that),
and all previously pointed out issues are fixed.
Am Samstag, 15. Juni 2013, 16:23:24 schrieb Lars-Peter Clausen:
The I2C client driver is not supposed to modify the client's driver
pointer, this is handled by the I2C core.
Signed-off-by: Lars-Peter Clausen l...@metafoo.de
---
Nice catch.
Staged here:
Hi Matthias,
it's nice to see that you consider most of the comments, unfortunately I still
have some left ;)
+/*
+ * tpm_st33_spi_init initialize driver
+ * @return: 0 if successful, else non zero value.
+ */
+static int __init tpm_st33_spi_init(void)
+{
+ return
Hi Matthias:
Regarding the while loop, I don't see how can I check the number of dummy
byte differently?
Checking the number of dummy bytes is fine -
in line #144 you check it with a while loop which looks fine
in line #198 you check it with a for loop with an empty body, which in my
opinion
Am Montag, 20. Mai 2013, 21:56:16 schrieb Peter Huewe:
Removing some boilerplate by using module_spi_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe peterhu...@gmx.de
Sorry for the noise
already exists in 3.10-rc1 by
Am Montag, 20. Mai 2013, 21:28:35 schrieb Peter Huewe:
Removing some boilerplate by using module_i2c_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe peterhu...@gmx.de
Sorry for the noise
099bb952b064 mfd: adp5520: Use
Am Montag, 20. Mai 2013, 21:31:57 schrieb Peter Huewe:
Removing some boilerplate by using module_i2c_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
Sorry for the noise
already exists in 3.10-rc1
Am Montag, 20. Mai 2013, 21:54:46 schrieb Peter Huewe:
Removing some boilerplate by using module_spi_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe peterhu...@gmx.de
Sorry for the noise
already exists in 3.10-rc1
Am Montag, 20. Mai 2013, 21:53:31 schrieb Marc Kleine-Budde:
On 05/20/2013 09:49 PM, Peter Huewe wrote:
Removing some boilerplate by using module_spi_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe peterhu...@gmx.de
Hi James,
The following changes since commit 5b88e270253db6d817e6a2f61909d1e53620e990:
maintainers: Remove Kent from maintainers
are available in the git repository at:
git://github.com/PeterHuewe/linux-tpmdd.git for-james
for you to fetch changes up to
Hi Daniel,
Daniel De Graaf wrote:
I wasn't sure if this patch goes in via a Xen tree or TPM driver
maintainers. I'll CC the full list from scripts/get_maintainer.pl
on my v3 submission.
I'd suggest to get at least an ack from both subsystems, as most people aren't
expert in both fields --
As far as I know, none of these people have
previously submitted a single patch.
Works for me... I'll submit a new patch removing myself. The tpmdd
list will be monitored by the same folks in the meantime.
If prior experience is an issue I'd nominate Peter Huewe if he's
Hi Greg,
CID: 986658
What is this field for?
That's the scan id in the coverity database.
If you think that's just noise I can leave it out.
Thanks,
Peter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
Hi Joe, Jason
fyi: using
if (strcmp(foo, bar) 0)
is canonical.
Yeah of course you're both right -
if (strcmp(foo, bar) 0)
is the correct version.
Sorry about the rubbish patch.
lib/string.c:strcmp returns only -1,0,1
so that's what the arch versions should do too.
However,
Hi Greg,
It [the CID] is noise as not everyone can see it or make anything out of it,
so please don't include it.
I'll remove it from my tree before sending out the pull request to James.
Thanks for your opinion.
Peter
--
To unsubscribe from this list: send the line unsubscribe
Hi Matthias,
Am Mittwoch, 15. Mai 2013, 15:53:19 schrieb Matthias Leblanc:
+static inline int spi_read_write(struct spi_device *spi,
+ struct spi_transfer xfer) {
+ struct spi_message msg;
+ spi_message_init(msg);
+ spi_message_add_tail(xfer, msg);
+ return
Am Dienstag, 21. Januar 2014, 18:15:01 schrieb Linus Torvalds:
is that this is a callback for acpi_walk_namespace(), and returning a
failure status means that the walk will be interrupted.
So you actually want to return AE_OK if the acpi_get_name() call
fails, because that just skips the
Hi James,
The following changes since commit 38fd2c202a3d82bc12430bce5789fa2c2a406f71:
Merge to v3.13-rc7 for prerequisite changes in the Xen code for TPM
(2014-01-06 22:23:01 +1100)
are available in the git repository at:
https://github.com/PeterHuewe/linux-tpmdd for-james
for you to
Hi James,
since the next merge window approaches, can you please pull the following TPM
Changes for 3.14?
I'll send the patches as replies to this email.
The following changes since commit 802eee95bde72fd0cd0f3a5b2098375a487d1eda:
Linux 3.13-rc6 (2013-12-29 16:01:33 -0800)
are available in
Hi James,
Please generate this against my next branch.
Here it is - note:
I cherry-picked the changes that went through the xen tree before applying my
changes.
The following changes since commit dcf4e392867bf98d50ad108ed7c2bfb941e8c33d:
ima: remove unneeded size_limit argument from
Am Freitag, 29. November 2013, 22:12:52 schrieb Jason Gunthorpe:
On Fri, Nov 29, 2013 at 06:00:18PM +0100, Michal Nazarewicz wrote:
From: Michal Nazarewicz min...@mina86.com
“wait” wait queue is defined but never used in the function, thus
it can be removed.
Signed-off-by: Michal
Hi Jason
did push everything to
https://github.com/PeterHuewe/linux-tpmdd/tree/testing-and-review
against latest rc, with alls signed-offs and reviewed-bys
I'll move it to for-james after giving it a final test run.
Thanks,
Peter
--
To unsubscribe from this list: send the line
Hi Daniel,
thanks for the rework.
I'll try to review it this week, so Konrad might take it through his tree.
Thanks,
Peter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Am Montag, 1. Juli 2013, 23:34:28 schrieb Daniel De Graaf:
This is a complete rewrite of the Xen TPM frontend driver, taking
advantage of a simplified frontend/backend interface and adding support
for cancellation and timeouts. The backend for this driver is provided
by a vTPM stub domain
Am Dienstag, 22. Juli 2014, 01:43:30 schrieb Jason Gunthorpe:
On Tue, Jul 22, 2014 at 01:26:05AM +0200, Peter Huewe wrote:
Unfortunately the tpm_tis driver did never call request_region for its
adress space - now since we've got devm_ioremap_resource we can simply
remove all the stuff and
CC: Luigi, he works at Google and is responsible for the TPMs in
Chromebooks ;)
Thanks,
Peter
Am Freitag, 22. August 2014, 22:32:41 schrieb Jason Gunthorpe:
On Fri, Aug 22, 2014 at 08:17:27PM +, Scot Doyle wrote:
On Fri, 22 Aug 2014, Jason Gunthorpe wrote:
On Fri, Aug 22, 2014 at
Hi,
as far as I remember everything marked with __exit or __exit_data will only be
used/called when unloading a module, and gets moved to the .exit.text or
.exit.data sections.
Why are these sections present in the vmlinux/vmlinux.bin/bzImage and not
dropped by the linker or at least objdump?
Am Freitag, 12. September 2014, 21:09:47 schrieb Peter Huewe:
If adapter-dev.parent == NULL there is a NULL pointer dereference in
acpi_i2c_install_space_handler and acpi_i2c_remove_space_handler.
This is present since introduction of this code:
366047515c6e i2c: rework kernel config
Hi
Am Samstag, 13. September 2014, 19:35:33 schrieb Jarkko Sakkinen:
Replaced transmit_cmd() functions in tpm-interface.c and tpm-sysfs.c
with a single tpm_transmit_cmd() that can be used in both files.
This patch is preliminary clean up work for the TPM2 support. This
function is needed
Am Montag, 22. September 2014, 19:13:38 schrieb Jason Gunthorpe:
This does look much nicer, lets use this version.
I think Peter were prefer a new clean patch that superceeds the
original.
+ if (!priv-irq_tested) {
I think the sleep and check is still needed here, the IRQ delivery
Hi Scot,
Am Montag, 25. August 2014, 09:14:03 schrieb Scot Doyle:
commit 4c663cfc523a88d97a8309b04a089c27dc57fd7e
wait: fix false timeouts when using wait_event_timeout()
changed the semantics of wait_event_interruptible_timeout so that a
condition check is performed after timeout and 1
Am Mittwoch, 24. September 2014, 19:13:38 schrieb Jason Gunthorpe:
On Wed, Sep 24, 2014 at 12:06:02PM +0300, Jarkko Sakkinen wrote:
Added tpm2-sysfs.c that implements sysfs attributes for a TPM2
device.
You need to document in Documentation every new sysfs that is added.
The existing
Am Mittwoch, 24. September 2014, 21:43:23 schrieb Jarkko Sakkinen:
On Wed, Sep 24, 2014 at 10:53:20AM -0600, Jason Gunthorpe wrote:
On Wed, Sep 24, 2014 at 12:05:53PM +0300, Jarkko Sakkinen wrote:
+static struct tpm_input_header tpm2_pcrread_header = {
Missing const - all of these
Am Mittwoch, 24. September 2014, 22:19:38 schrieb Jason Gunthorpe:
On Wed, Sep 24, 2014 at 10:02:34PM +0300, Jarkko Sakkinen wrote:
The pcrs file never conformed to the sysfs rules, if TPM2 is getting a
whole new file set, I wouldn't mind seeing it not include the
non-conformant ones.
Am Mittwoch, 24. September 2014, 19:59:40 schrieb Jason Gunthorpe:
On Wed, Sep 24, 2014 at 01:34:11PM -0400, Stefan Berger wrote:
On 09/24/2014 01:13 PM, Jason Gunthorpe wrote:
On Wed, Sep 24, 2014 at 12:06:02PM +0300, Jarkko Sakkinen wrote:
+static ssize_t durations_show(struct device
Hi,
so shall I apply this patch? or not?
Thanks,
Peter
Am Dienstag, 2. Dezember 2014, 20:22:35 schrieb Ashley Lai:
@@ -63,9 +63,9 @@ static int ibmvtpm_send_crq(struct vio_dev *vdev, u64
w1, u64 w2) static struct ibmvtpm_dev *ibmvtpm_get_data(const struct
device *dev) {
struct
Hi Anton,
is this patchset still needed after Vicky's patch
[tpmdd-devel] Fix NULL return in tpm_ibmvtpm_get_desired_dma
https://patchwork.ozlabs.org/patch/402315/
Ashley raised some concerns.
Since merge window is coming up, a fast reply is appreciated.
Thanks,
Peter
Am Freitag, 19.
Am Freitag, 19. September 2014, 09:14:39 schrieb Kiran Padwal:
Currently these driver are missing a check on the return value of
devm_kzalloc, which would cause a NULL pointer dereference in a OOM
situation.
This patch adds a missing check for tpm_i2c_atmel.c and tpm_i2c_nuvoton.c
Hi Jarkko,
Am Dienstag, 2. Dezember 2014, 23:31:12 schrieb Jarkko Sakkinen:
This patch set enables TPM2 protocol and provides drivers for FIFO and
CRB interfaces. This patch set does not export any sysfs attributes for
TPM 2.0 because existing sysfs attributes have three non-trivial issues:
Am Dienstag, 2. Dezember 2014, 23:31:19 schrieb Jarkko Sakkinen:
tpm_crb is a driver for TPM 2.0 Command Response Buffer (CRB) Interface
as defined in PC Client Platform TPM Profile (PTP) Specification.
Only polling and single locality is supported as these are the limitations
of the
Am Dienstag, 2. Dezember 2014, 23:31:12 schrieb Jarkko Sakkinen:
This patch set enables TPM2 protocol and provides drivers for FIFO and
CRB interfaces. This patch set does not export any sysfs attributes for
TPM 2.0 because existing sysfs attributes have three non-trivial issues:
- They are
Am Mittwoch, 3. Dezember 2014, 00:16:19 schrieb Peter Hüwe:
Am Dienstag, 2. Dezember 2014, 23:31:12 schrieb Jarkko Sakkinen:
This patch set enables TPM2 protocol and provides drivers for FIFO and
CRB interfaces. This patch set does not export any sysfs attributes for
TPM 2.0 because
Am Mittwoch, 3. Dezember 2014, 00:24:43 schrieb Aaro Koskinen:
Hi,
On Wed, Dec 03, 2014 at 12:21:07AM +0100, Peter Hüwe wrote:
--- a/drivers/char/tpm/tpm_i2c_nuvoton.c
+++ b/drivers/char/tpm/tpm_i2c_nuvoton.c
@@ -605,10 +605,8 @@ static int i2c_nuvoton_probe(struct i2c_client
*client
Applied to my tree:
https://github.com/PeterHuewe/linux-tpmdd for-james
Will be included in the next pull-request.
Thanks,
Peter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Hi Scot,
Am Montag, 29. September 2014, 19:24:57 schrieb Jason Gunthorpe:
On Wed, Sep 24, 2014 at 10:41:10PM +, Scot Doyle wrote:
Some machines, such as the Acer C720 and Toshiba CB35, have TPMs that do
not send IRQs while also having an ACPI TPM entry indicating that they
will be
Am Donnerstag, 4. Dezember 2014, 06:55:17 schrieb Jarkko Sakkinen:
tpm_crb is a driver for TPM 2.0 Command Response Buffer (CRB) Interface
as defined in PC Client Platform TPM Profile (PTP) Specification.
Only polling and single locality is supported as these are the limitations
of the
Am Donnerstag, 4. Dezember 2014, 06:55:13 schrieb Jarkko Sakkinen:
Traversal of the ACPI device tree was not done right. PPI interface
should be looked up only from the ACPI device that is the platform
device for the TPM. This could cause problems with systems with
two TPM chips such as 4th
Am Donnerstag, 4. Dezember 2014, 06:55:14 schrieb Jarkko Sakkinen:
Rename chip-dev to chip-pdev to make it explicit that this not the
character device but actually represents the platform device.
Signed-off-by: Jarkko Sakkinen jarkko.sakki...@linux.intel.com
---
drivers/char/tpm/tpm-chip.c
Am Donnerstag, 4. Dezember 2014, 06:55:18 schrieb Jarkko Sakkinen:
From: Will Arthur will.c.art...@intel.com
Detect TPM 2.0 by using the extended STS (STS3) register. For TPM 2.0,
instead of calling tpm_get_timeouts(), assign duration and timeout
values defined in the TPM 2.0 PTP
Hi Jarkko,
Am Donnerstag, 4. Dezember 2014, 06:55:18 schrieb Jarkko Sakkinen:
From: Will Arthur will.c.art...@intel.com
Detect TPM 2.0 by using the extended STS (STS3) register. For TPM 2.0,
instead of calling tpm_get_timeouts(), assign duration and timeout
values defined in the TPM 2.0 PTP
Am Donnerstag, 4. Dezember 2014, 23:18:33 schrieb Peter Hüwe:
Hi Jarkko,
Am Donnerstag, 4. Dezember 2014, 06:55:18 schrieb Jarkko Sakkinen:
From: Will Arthur will.c.art...@intel.com
Detect TPM 2.0 by using the extended STS (STS3) register. For TPM 2.0,
instead of calling
Am Donnerstag, 4. Dezember 2014, 06:55:17 schrieb Jarkko Sakkinen:
tpm_crb is a driver for TPM 2.0 Command Response Buffer (CRB) Interface
as defined in PC Client Platform TPM Profile (PTP) Specification.
Only polling and single locality is supported as these are the limitations
of the
Am Mittwoch, 3. Dezember 2014, 03:28:35 schrieb Stefan Berger:
On 12/02/2014 05:31 PM, Jarkko Sakkinen wrote:
+
+/**
+ * tpm2_startup() - send startup command to the TPM chip
+ * @chip: TPM chip to use.
+ * @startup_type startup type. The value is either
+ *
Am Donnerstag, 4. Dezember 2014, 06:55:16 schrieb Jarkko Sakkinen:
TPM 2.0 devices are separated by adding a field 'flags' to struct
tpm_chip and defining a flag TPM_CHIP_FLAG_TPM2 for tagging them.
This patch adds the following internal functions:
- tpm2_get_random()
- tpm2_get_tpm_pt()
Am Mittwoch, 4. Februar 2015, 15:21:09 schrieb Jarkko Sakkinen:
If during transmission system error was returned, the logic was to
incorrectly deduce that chip is a TPM 1.x chip. This patch fixes this
issue. Also, this patch changes probing so that message tag is used as the
measure for TPM
Hi Bruno,
thanks for your patch!
The patch is fine,
but unfortunately not against the latest version of the tpm subsytem code.
You can find the latest version of the tpm subsystem at
https://github.com/PeterHuewe/linux-tpmdd
the for-james branch is usually the best choice here.
Am Montag, 30. März 2015, 22:06:08 schrieb Fabian Frederick:
KERN_ERR is implicitely declared in pr_err()
Signed-off-by: Fabian Frederick f...@skynet.be
Good catch.
Acked-by: Peter Huewe peterhu...@gmx.de
If nobody else pulls this one through his tree, I'll apply it probably for
4._2_ (so it
Am Sonntag, 1. März 2015, 22:55:47 schrieb Jarkko Sakkinen:
- tpm_dev_add_device(): cdev_add() must be done before uevent is
propagated in order to avoid races.
- tpm_chip_register(): tpm_dev_add_device() must be done as the
last step before exposing device to the user space in order to
Am Dienstag, 5. Mai 2015, 18:32:19 schrieb Geert Uytterhoeven:
The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
functionality only, can still be compiled if GPIOLIB is not enabled.
Relax the
Hi,
Am Mittwoch, 3. Juni 2015, 18:39:14 schrieb Jarkko Sakkinen:
This patch introduces struct tpm_buf that provides a string buffer for
constructing TPM commands. This allows to construct variable sized TPM
commands. This feature is needed for TPM 2.0 commands in order to allow
policy
Hey,
Am Freitag, 22. Mai 2015, 19:23:02 schrieb Hon Ching(Vicky) Lo:
tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) without having yet
set the virtual device in the ibmvtpm structure. So in ibmvtpm_reset_crq,
the phype call contains empty unit addresses, ibmvtpm-vdev-unit_address.
Hi Jarkko
Betreff: [PATCH] tpm, tpm_crb: migrate to struct acpi_table_tpm2 and
acpi_tpm2_control
but are the names there still correct? Isn't this information outdated?
The acpi spec refers to the MS spec which is not present anymore, and
MS refers to the TCG -- and in the PTP your
Hi Vicky,
Am Donnerstag, 16. Juli 2015, 19:54:15 schrieb Hon Ching(Vicky) Lo:
Hi Peter,
On Mon, 2015-07-13 at 23:08 +0200, Peter Hüwe wrote:
Hi Vicky,
sorry for the late reply
This patch makes the code endianness independent. We defined a
macro do_endian_conversion to apply
Am Mittwoch, 24. Juni 2015, 16:14:55 schrieb Jarkko Sakkinen:
At least some versions of AMI BIOS have corrupted contents in the TPM2
ACPI table and namely the physical address of the control area is set to
zero.
This patch changes the driver to fail gracefully when we observe a zero
Hi Vicky,
sorry for the late reply
This patch makes the code endianness independent. We defined a
macro do_endian_conversion to apply endianness to raw integers
in the event entries so that they will be displayed properly.
tpm_binary_bios_measurements_show() is modified for the display.
Am Freitag, 10. Juli 2015, 07:32:28 schrieb Krzysztof Kozlowski:
Hi,
The i2c drivers also do not have to set 'owner' field because
i2c_register_driver() will do it instead.
'owner' is removed from i2c drivers, which I was able to compile
with allyesconfig (arm, arm64, i386, x86_64,
1 - 100 of 218 matches
Mail list logo
