Jan Kara wrote:
Hum, I have somewhat hard time to understand what do you mean by
'magically optimized syscalls'. What should happen in VFS to speedup your
load?
In retrospect, I think this is a terrible hack to begin with. Tuning
the filesystem specifically for git repositories is inelegant
[Dropping git people from the CC, as this is not relevant to git anymore]
Okay, let me attempt to understand this.
Jan Kara wrote:
On Fri 05-04-13 17:12:29, Al Viro wrote:
On Fri, Apr 05, 2013 at 05:55:34PM +0200, Jan Kara wrote:
What your question reminds me is an idea of recursive
Jan Kara wrote:
Initially, you will have to flip the flag on every directory in the
subtree. But the flag is persistently stored on disk so you have to do it
once when the directory is created and then each time you notice the
directory has changed and the flag has been cleared.
How is this
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/virtio/.gitignore | 3 +++
1 file changed, 3 insertions(+)
create mode 100644 tools/virtio/.gitignore
diff --git a/tools/virtio/.gitignore b/tools/virtio/.gitignore
new file mode 100644
index 000..1cfbb01
--- /dev/null
+++ b
atleast
submit a bug report. Maybe I'm missing something?
Thanks.
Ramkumar Ramachandra (2):
virtio tools: strip bad include-path from Makefile
virtio tools: add .gitignore
tools/virtio/.gitignore | 3 +++
tools/virtio/Makefile | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
create
...@rustcorp.com.au
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/virtio/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virtio/Makefile b/tools/virtio/Makefile
index 3187c62..53623c6 100644
--- a/tools/virtio/Makefile
+++ b/tools/virtio/Makefile
Michael S. Tsirkin wrote:
CFLAGS contains a mysterious -I ../../usr/include, but no such path
exists in the linux tree. The line was originally introduced in
4e53f78e (tools/virtio: virtio_test tool, 2010-11-29), but no such path
existed in the tree even then.
It exists if you do make
Michael S. Tsirkin wrote:
This is usespace code so it needs the cleaned-up version from
usr/include, not the internal kernel one.
Right, thanks for clearing that up. However, it does seem to depend
on some code in /include in the linux tree. From
tools/virtio/linux/virtio_ring.h:
#include
These letters that should not be used in menu selection.
Cc: Michal Marek mma...@suse.cz
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
scripts/kconfig/lxdialog/menubox.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/scripts/kconfig/lxdialog/menubox.c
b
Like in Vim.
Cc: Michal Marek mma...@suse.cz
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
scripts/kconfig/lxdialog/menubox.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/scripts/kconfig/lxdialog/menubox.c
b/scripts/kconfig/lxdialog/menubox.c
index
first_alpha() checks only against lowercase characters anyway.
Cc: Michal Marek mma...@suse.cz
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
scripts/kconfig/lxdialog/menubox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/lxdialog/menubox.c
b
/3].
Independent of part 3, I think parts 1 and 2 are obviously correct,
and should be merged.
Thanks.
Ramkumar Ramachandra (3):
menuconfig: factor out reserved letters
menuconfig: remove redundant info from RESERVED_LETTERS
menuconfig: allow j/k to move down/up the menu
scripts/kconfig
Arnaldo Carvalho de Melo wrote:
Huh? In what distro? I see, one that has a newer perl (5.18.0)
I use Arch. Yeah, all my packages are new :)
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
Trivial.
arch/x86/ia32/ia32entry.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S
index 474dc1b..4299eb0
Cc: David Daney david.da...@cavium.com
Cc: Michal Marek mma...@suse.cz
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
Trivial. I wonder why make didn't tell us?
scripts/sortextable.c | 8
1 file changed, 8 deletions(-)
diff --git a/scripts/sortextable.c b/scripts
Alexey Shmalko wrote:
It would be great to participate in the next year GSoC contributing to
the Linux kernel. For this reason, I have to find a mentor. If someone
pushes me in the right direction, I'll be happy.
Start sending patches. There's plenty of low-hanging fruit: just look
around the
Gleixner t...@linutronix.de
Cc: Eli Friedman eli.fried...@gmail.com
Cc: Jim Grosbach grosb...@apple.com
Cc: Stephen Checkoway s...@pahtak.org
Cc: LLVMdev llvm...@cs.uiuc.edu
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
We discussed this pretty extensively on LLVMDev, but I'm still
Linus Torvalds wrote:
btrl $1, 0
btr $1, 0
btsl $1, 0
bts $1, 0
What the heck is that supposed to show?
I was trying to show a reduced case where gas doesn't complain, but
llvm-mc does. Try compiling this with llvm-mc, and you'll get:
.text
btrl$1, 0
Linus Torvalds wrote:
Ok. So your commit message and explanation was pure and utter tripe,
and the real reason you want this is that llvm-mc is broken.
Please fix llvm-mc instead, ok? If the intent of llvm is to be
compatible with the gnu compiler tools, then it should do that. Plus
the gas
Ping?
Does this patch look okay?
Thanks.
On Fri, Jul 5, 2013 at 4:15 AM, Ramkumar Ramachandra artag...@gmail.com wrote:
arch/um/defconfig only lists one default configuration, and that applies
only to the i386 architecture. Replace it with two files:
i386_defconfig and x86_64_defconfig
Ping?
Does this series look alright?
On Thu, Jul 4, 2013 at 6:11 PM, Ramkumar Ramachandra artag...@gmail.com wrote:
Hi,
So I just started using perf, and noticed the accompanying completion
script. Having dabbled with git.git's completion script a bit, I
thought I should contribute what I
Rob Landley wrote:
(Balsa is such an incompetent email client I wrote a python script to do
this via raw smtp, and I'm always convinced it's going to screw up the send.
But I think I've got it debugged now...)
Use the tried-and-tested git-send-email.perl, perhaps?
--
To unsubscribe from this
Hi,
So, I was trying to boot User-Mode Linux with a modern rootfs with
systemd on it, and found that it wouldn't present me a prompt. I dug
further, and found out that getty is not able to open /dev/tty1; I
then tried the console-getty.service (which uses /dev/console), and it
worked. The
Richard Weinberger wrote:
UML does not have CONFIG_VT.
Not sure what this means.
But recent systemd versions can deal with that.
Nope, running systemd HEAD. I only recently figured out how to detect
that um Linux is running [1].
[1]: https://github.com/systemd/systemd/commit/7080ea16
--
To
Richard Weinberger wrote:
UML does not have virtual consoles.
Then why do I see this on my UML box?
# ls /dev/tty* | wc -l
113
Why is it creating unusable devices? Is drivers/tty.c responsible for
this? What is it exactly?
I'm not running HEAD, but opensuse 12.3 (with systemd) works on
Avoid creating lots of bogus devices nodes like /dev/tty* (since
User-Mode Linux does not have virtual consoles.
Cc: Richard Weinberger rich...@nod.at
Cc: Jeff Dike jd...@addtoit.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
Applies on top of the patch I posted earlier.
arch
Richard Weinberger wrote:
If you don't want devtmpfs, just disable it in your config.
I don't understand: is this not a good default? Why is creating bogus
devices, confusing systemd, and making um Linux hard to boot
desirable?
--
To unsubscribe from this list: send the line unsubscribe
Richard Weinberger wrote:
Why does this confuse systemd? systemd has also a dependency on devtmpfs.
See getty@.service, which is a dependency of getty.target:
# On systems without virtual consoles, don't start any getty. (Note
# that serial gettys are covered by serial-getty@.service, not
Ramkumar Ramachandra wrote:
No, systemd does not have a hard dependency on devtmpfs.
Wait, let me double-check that.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
Arnaldo Carvalho de Melo wrote:
Huh? Why would this be more modern, if both are equivalent, I think
applying the same rules as we have for C code applies here.
It's the prevalent style in git.git, and I figured that it was picked
up from linux.git but didn't check. Drop this part otherwise.
Ramkumar Ramachandra wrote:
Ramkumar Ramachandra wrote:
No, systemd does not have a hard dependency on devtmpfs.
Wait, let me double-check that.
Sorry about the stupidity; devtmpfs is very much a hard dependency. I
just realized that CONFIG_VT is on, and can't be turned off (!). See
drivers
Richard Weinberger wrote:
BTW: I'll not apply any patch to the kernel if the issue can easily
fixed in user space, that's the major reason for my NAK.
I was just asking for good defaults; I want um Linux to work
out-of-the-box. There's really no point in creating bogus devices in
/dev, and
Al Viro wrote:
As for the devices, they are *not* bogus. RTFM, already.
Documentation/virtual/uml/UserModeLinux-HOWTO.txt, if you can't be bothered
to say git grep UML Documentation/ and find where it on your own. The
relevant section is called Setting up serial lines and consoles.
Richard Weinberger wrote:
http://user-mode-linux.sourceforge.net/downloads.html
I found a uml_utilities_20070815.tar.bz2. 2007, seriously? Is there
no interest in maintaining it?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
Rob Landley wrote:
Is this script of yours any use for patches that aren't, and never were, in
git? (Given that it's not in the kernel tree, I'm guessing no.)
It's part of git.git. And yes, it works with plain mbox files
(especially those generated by `git format-patch`).
--
To unsubscribe
Sarah Sharp wrote:
I do smile often in email. :) And be sad. :( And be apologetic. :-/
Smug. ^~^ Angry. :[ Sarcastic. ;) Trolling/crazy. 8) D'oh. (.)
Worried. (_); Disappointed. (-_-) Kitty! =^_^= Meow!
Be creative. There are ways of expressing emotion without cussing.
Personally, I
Sarah Sharp wrote:
https://picasaweb.google.com/116960357493251979546/Trolls#5901298464591248626
https://picasaweb.google.com/116960357493251979546/Trolls#5901288095984358098
On my blog, here's some choice comments, mostly asking me to quit kernel
development, along with more than a few
Hi,
I tried building lguest to play with it, but was disappointed to find
this in the Kconfig:
depends on X86_32
Why is this [1]? What is so hard about supporting 64-bit machines? I
found a five-year old tree that claims to do lguest64 [2], but didn't
investigate further.
Thanks.
[1]:
Konrad Rzeszutek Wilk wrote:
diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c
index 0438b93..71db82c 100644
--- a/arch/x86/xen/spinlock.c
+++ b/arch/x86/xen/spinlock.c
@@ -81,7 +81,6 @@ static inline void spin_time_accum_blocked(u64 start)
spinlock_stats.time_blocked +=
Wei Ni wrote:
diff --git a/Documentation/devicetree/bindings/hwmon/lm90.txt
b/Documentation/devicetree/bindings/hwmon/lm90.txt
new file mode 100644
index 000..5570875
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/lm90.txt
While at it, please update and rename ads1015.txt.
Konrad Rzeszutek Wilk wrote:
There is no need to setup this IPI kicker if we are never going
to use the paravirtualized ticketlock mechanism.
Excellent patch; the important takeaway is that paravirtualization is
still quite useful in the real world.
--
To unsubscribe from this list: send the
Pointers appreciated.
% ./linux
Locating the bottom of the address space ... 0x1000
Locating the top of the address space ... 0xd000
Core dump limits :
soft - 0
hard - NONE
Checking that ptrace can change system call numbers...OK
Checking syscall emulation patch for
Al Viro wrote:
_What_ pathname translations? Pathname resolution doesn't fall back to
seq_writelock() at all.
Maybe it should then?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Linus Torvalds wrote:
It doesn't need to. The RCU lookup looks at individual dentry sequence
numbers and doesn't care about the bigger rename sequence number at
all.
Right; it's sequential.
The fallback (if you hit one of the very very rare races, or if you
hit a symlink) ends up doing
Stephane Eranian wrote:
[ 2229.021966] Call Trace:
[ 2229.021967] NMI [8159dcd6] dump_stack+0x46/0x58
[ 2229.021976] [8108dfdc] warn_slowpath_common+0x8c/0xc0
[ 2229.021979] [8108e0c6] warn_slowpath_fmt+0x46/0x50
[ 2229.021982] [810646c8]
Stephane Eranian wrote:
a simple multithreaded program where
#threads #CPUs
To put it another way, does Intel's HT work for CPU intensive and IO
minimal tasks? I think HT assumes some amount of inefficient IO
coupled with pure CPU usage.
--
To unsubscribe from this list: send the line
H. Peter Anvin wrote:
UML, lguest and Xen were done before the x86 architecture supported
hardware virtualization.
[...]
but on KVM-enabled hardware KVM seems
like the better option (and is indeed what libguestfs uses.)
While we're still on the topic, I'd like a few clarifications. From
Replace a complex git log invocation with a simpler git rev-parse
invocation.
Cc: Ingo Molnar mi...@kernel.org
Cc: Namhyung Kim namhy...@gmail.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/util/PERF-VERSION-GEN | 2
Cc: David Ahern dsah...@gmail.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/Documentation/perf-trace.txt | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/tools/perf/Documentation/perf-trace.txt
b/tools/perf/Documentation/perf
Hi,
All the other perf tooling can be used as a normal user. At one point,
I had to touch /proc/sys/kernel/perf_event_paranoid to get me numbers
on a PMU event without a symbolic name, but that's about it.
perf-trace seems to be the exception though:
artagnon|perf-core=:~/src/linux/tools/perf$
Hi,
I tried using the `perf timechart` command after a `sudo perf
timechart record -- git status`, and it segfaulted. Backtrace follows:
Program received signal SIGSEGV, Segmentation fault.
0x in ?? ()
(gdb) bt
#0 0x in ?? ()
#1 0x0047d728 in
Hi Jiri,
Jiri Olsa wrote:
what perf version are you running?
I'm running off the one in torvalds/linux.git.
$ perf --version
perf version 3.12.rc3.g34b22d5
The log of builtin-timechart.c shows that it was last touched by you
three months ago: 5936678 (perf timechart: Remove event types
Jiri Olsa wrote:
looks like you're missing this one:
(git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf/core)
Very messy; doesn't rebase on top of the latest torvalds/linux.git
cleanly: I get a merge conflict at patch 9 of 74. Since my work is
based on torvalds/linux.git, I was
Cc: Ingo Molnar mi...@kernel.org
Cc: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 744a239..9ef82c7 100644
David Ahern wrote:
If you trust your users make the debugfs mount point rx by group,world.
Thanks David. I can preserve this configuration across reboots by
putting an entry in fstab, right? How do I preserve the value of
/proc/sys/kernel/perf_event_paranoid across reboots?
--
To unsubscribe
Ingo Molnar wrote:
echo 'kernel.perf_event_paranoid = -1' /etc/sysctl.conf
Thanks Ingo. It's called /etc/sysctl.d/* now:
https://www.archlinux.org/news/deprecation-of-etcsysctlconf/
The current output:
comet:~/tip perf trace
Couldn't read the raw_syscalls tracepoints information!
the permissions of debugfs: /sys/kernel/debug
The directory will be present if your kernel was compiled with debugfs
support.
Cc: Ingo Molnar mi...@kernel.org
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/builtin
While at it, update the synopsis to include options.
Cc: Ingo Molnar mi...@kernel.org
Cc: Namhyung Kim namhy...@gmail.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: David Ahern dsah...@gmail.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/Documentation
Cc: Ingo Molnar mi...@kernel.org
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
index 8f8fbc2..782d86e 100644
the permissions of debugfs: /sys/kernel/debug
The directory will be present if your kernel was compiled with debugfs
support.
Cc: Ingo Molnar mi...@kernel.org
Cc: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
While at it, update the synopsis to show both forms.
Cc: Ingo Molnar mi...@kernel.org
Cc: Namhyung Kim namhy...@gmail.com
Cc: David Ahern dsah...@gmail.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/Documentation
Ingo Molnar wrote:
+ /* Perform a quick sanity check */
+ if (!is_valid_tracepoint(power:cpu_frequency)) {
+ fprintf(stderr, Error:\tNo permissions to read
$debugfs/tracing/events/power/cpu_frequency\n);
+ fprintf(stderr, Hint:\tChange the permissions of
Arnaldo Carvalho de Melo wrote:
[acme@zoo ~]$ mount | grep debugfs
[acme@zoo ~]$
[acme@zoo ~]$ perf trace usleep 1
Is debugfs mounted? Try 'sudo mount -t debugfs nodev /sys/kernel/debug'
[acme@zoo ~]$ sudo mkdir /d
[acme@zoo ~]$ sudo mount -t debugfs nodev /d
[acme@zoo ~]$ mount | grep
$debugfs/tracing/events/raw_syscalls
Hint: Change the permissions of the debugfs filesystem
Cc: Ingo Molnar mi...@kernel.org
Cc: David Ahern dsah...@gmail.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
We don't want to spoonfeed
-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/tests/parse-events.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
index 48114d1..a6f51ff 100644
--- a/tools/perf/tests/parse-events.c
+++ b/tools
Ramkumar Ramachandra wrote:
The TEST_EVENTS macro is open-coded towards the end of
test__parse_events(). While at it, undef it cleanly after its usage.
Kindly ignore this patch; I made a trivial mistake.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Hi,
`perf test` doesn't give me a clean run; it seems to be out-of-date. I
spent many hours on tracing parse events tests with gdb, but
preprocessor macros and other complexity make my job very difficult. I
haven't determined where the warnings in #5 are coming from exactly,
but it seems to be
Hi,
Probably a very silly question, but why doesn't dmesg output include
timestamps in place of the cryptic number prefix?
Thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Hi Arnaldo,
Arnaldo Carvalho de Melo wrote:
Can you check how is this in the current perf/core branch so that we can
move forward while I process some other patches?
perf/completion is now 3 months old, and my more recent patches have
already been merged into Linus' tree. Why is
Rusty Russell wrote:
Ramkumar Ramachandra artag...@gmail.com writes:
asm and volatile are provided for backward compatibility; use the ansi
versions __asm__ and __volatile__.
Really? I don't see that in the gcc documentation. In fact, I didn't
know __volatile__ at all:
Try compiling
Jiri Olsa wrote:
On Thu, Nov 21, 2013 at 08:03:47PM +0530, Ramkumar Ramachandra wrote:
In
$ perf diff -c ratio
color the Ratio column using percent_color_snprintf().
why is there 'INCOMPLETE' in the subject?
As explained in the segment below the diffstat:
The incomplete bit is marked
Jiri Olsa wrote:
this patch changes the diff output for 'perf diff'
file '1' - old perf
file '2' - your change
I expected only the difference would be only color
not numbers.
Oh, sorry; I forgot about the threshold completely. I'll submit
another iteration with a fresh [4/4] once you tell
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/builtin-diff.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 3b67ea2..79e0448 100644
--- a/tools/perf/builtin
].
Thanks.
Ramkumar Ramachandra (5):
perf diff: don't compute Delta if he-dummy
perf diff: color the Delta column
perf diff: generalize hpp__color_delta for -c
perf diff: color the Ratio column
perf diff: color the Weighted Diff column
tools/perf/builtin-diff.c | 109
Generalize the function so that we can accommodate all three comparison
methods: delta, ratio, and wdiff.
Cc: Jiri Olsa jo...@redhat.com
Cc: Namhyung Kim namhy...@kernel.org
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/builtin
Color the numbers in the Delta column either green or red depending on
whether the number is positive or negative.
Cc: Jiri Olsa jo...@redhat.com
Cc: Namhyung Kim namhy...@kernel.org
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools
In
$ perf diff -c ratio
color the Ratio column using percent_color_snprintf().
Cc: Jiri Olsa jo...@redhat.com
Cc: Namhyung Kim namhy...@kernel.org
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/builtin-diff.c | 20
In
$ perf diff -c wdiff:M,N
color the numbers in the Weighted Diff column either green or red,
depending on whether the number is positive or negative.
Cc: Jiri Olsa jo...@redhat.com
Cc: Namhyung Kim namhy...@kernel.org
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar
Jiri Olsa wrote:
The incomplete bit is marked using a TODO; removing two trailing '%'
symbols doesn't seem to work. Can someone please tell me how to fix
this problem?
aah here it is..
I fixed it and sent another iteration.
--
To unsubscribe from this list: send the line unsubscribe
Jiri Olsa wrote:
I think it'd be better to have just one switch for
comparison_method and do all the processing within
Okay, will fix in the next iteration.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
Jiri Olsa wrote:
if (!pair)
goto dummy_print;
if (pair-diff.computed)
- percent = pair-diff.period_ratio_delta;
+ switch (comparison_method) {
+ case COMPUTE_DELTA:
+ delta = pair-diff.period_ratio_delta;
+
Jiri Olsa wrote:
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 79e0448..84d5f2d 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -769,6 +769,33 @@ static int hpp__entry_baseline(struct hist_entry *he,
char *buf, size_t size)
return
Jiri Olsa wrote:
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 3b67ea2..79e0448 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -792,6 +792,9 @@ hpp__entry_pair(struct hist_entry *he, struct hist_entry
*pair,
switch (idx) {
Ramkumar Ramachandra wrote:
Jiri Olsa wrote:
if (!pair)
goto dummy_print;
if (pair-diff.computed)
- percent = pair-diff.period_ratio_delta;
+ switch (comparison_method) {
+ case COMPUTE_DELTA:
+ delta = pair
Generalize the function so that we can accommodate all three comparison
methods: delta, ratio, and wdiff.
Cc: Jiri Olsa jo...@redhat.com
Cc: Namhyung Kim namhy...@kernel.org
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/builtin
In
$ perf diff -c wdiff:M,N
color the numbers in the Weighted Diff column either green or red,
depending on whether the number is positive or negative.
Cc: Jiri Olsa jo...@redhat.com
Cc: Namhyung Kim namhy...@kernel.org
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar
Color the numbers in the Delta column either green or red depending on
whether the number is positive or negative.
Cc: Jiri Olsa jo...@redhat.com
Cc: Namhyung Kim namhy...@kernel.org
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools
In
$ perf diff -c ratio
color the Ratio column using percent_color_snprintf().
Cc: Jiri Olsa jo...@redhat.com
Cc: Namhyung Kim namhy...@kernel.org
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/builtin-diff.c | 20
Hi,
This iteration fixes several small problems in the previous iteration
pointed out by Jiri Olsa. Most significantly, the first patch has been
dropped, and there's just one switch-case statement for the entire
logic.
Thanks.
Ramkumar Ramachandra (4):
perf diff: color the Delta column
perf
Jiri Olsa wrote:
these colors are not consistent with colors in baseline,
moreover all negative values are shown as red
- please check get_percent_color function (used for baseline),
it checks the percentage against following values:
#define MIN_GREEN 0.5
#define MIN_RED
Jiri Olsa wrote:
This patch basicaly factor the code you added in previous one.
Could we use the function below from the beggining?
Yeah, I suppose I could squash this into [2/4].
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
Color the numbers in the Delta column using percent_color_snprintf().
Generalize the function so that we can accommodate all three comparison
methods in the future: delta, ratio, and wdiff.
Cc: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar
In
$ perf diff -c wdiff:M,N
color the numbers in the Weighted Diff column either green or red,
depending on whether the number is positive or negative.
Cc: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools
Olsa.
Cc: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Ramkumar Ramachandra (3):
perf diff: color the Delta column
perf diff: color the Ratio column
perf diff: color the Weighted Diff column
tools/perf/builtin-diff.c | 91
In
$ perf diff -c ratio
color the Ratio column using percent_color_snprintf().
Cc: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/builtin-diff.c | 20
1 file changed, 20
asm and volatile are provided for backward compatibility; use the ansi
versions __asm__ and __volatile__.
Cc: Rusty Russell ru...@rustcorp.com.au
Cc: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/virtio/asm/barrier.h | 2 +-
1 file changed, 1
asm and volatile are provided for backward compatibility; use the ansi
versions __asm__ and __volatile__.
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Paul Mackerras pau...@samba.org
Cc: Ingo Molnar mi...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Signed-off-by: Ramkumar
Peter Zijlstra wrote:
On Tue, Oct 15, 2013 at 04:16:26PM +0530, Ramkumar Ramachandra wrote:
asm and volatile are provided for backward compatibility; use the ansi
versions __asm__ and __volatile__.
I won't object much to this; but I have to note that the entire kernel
tree is loaded
asm and volatile are provided for backward compatibility; use the ansi
versions __asm__ and __volatile__.
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Paul Mackerras pau...@samba.org
Cc: Ingo Molnar mi...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Signed-off-by: Ramkumar
] to [3/5] factors things out and prepares the stage for [4/5],
which is the focus of the series. [5/5] is just a pure rename.
Thanks.
Ramkumar Ramachandra (5):
perf completion: introduce a layer of indirection
perf completion: factor out compgen stuff
perf completion: factor out call
1 - 100 of 703 matches
Mail list logo
