Return the value obtained from extcon_find_cable_index()
instead of -ENODEV.
Fixes the following smatch info:
drivers/extcon/extcon-class.c:478 extcon_register_interest() info:
why not propagate 'obj-cable_index' from extcon_find_cable_index()
instead of -19?
Signed-off-by: Sachin Kamat
'pindesc' was not freed when returning from an error induced
exit path.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/pinctrl/core.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index dc5c126
On 25 September 2012 14:45, anish singh anish198519851...@gmail.com wrote:
On Tue, Sep 25, 2012 at 12:28 PM, Sachin Kamat sachin.ka...@linaro.org
wrote:
Return the value obtained from extcon_find_cable_index()
instead of -ENODEV.
Fixes the following smatch info:
drivers/extcon/extcon
On 25 September 2012 16:02, Chanwoo Choi cw00.c...@samsung.com wrote:
On 09/25/2012 03:58 PM, Sachin Kamat wrote:
Return the value obtained from extcon_find_cable_index()
instead of -ENODEV.
Fixes the following smatch info:
drivers/extcon/extcon-class.c:478 extcon_register_interest() info
Propagate the value returned from extcon_find_cable_index()
instead of -ENODEV. For readability, -EINVAL is returned in place of
the variable.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/extcon/extcon-class.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
Hi Thomas,
Please provide your review comments.
On 14 September 2012 19:37, Linus Walleij linus.wall...@linaro.org wrote:
On Fri, Sep 14, 2012 at 2:02 PM, Sachin Kamat sachin.ka...@linaro.org wrote:
Return the value obtained from of_property_count_strings()
instead of -EINVAL.
Silences
exynos_unregister_thermal() is functional only when 'th_zone' is not
NULL (ensured by the NULL checks). However, in the event it is NULL, it
gets dereferenced in the for loop. This patch fixes this issue.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/thermal/exynos_thermal.c
Fixes the following sparse warnings:
drivers/thermal/step_wise.c:153:5: warning:
symbol 'step_wise_throttle' was not declared. Should it be static?
drivers/thermal/step_wise.c:172:25: warning:
symbol 'thermal_gov_step_wise' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
On 27 September 2012 16:45, R, Durgadoss durgados...@intel.com wrote:
-Original Message-
From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
Sent: Thursday, September 27, 2012 4:28 PM
To: linux-kernel@vger.kernel.org
Cc: R, Durgadoss; Zhang, Rui; sachin.ka...@linaro.org; patc
Fixes the following sparse warnings:
drivers/thermal/fair_share.c:80:5: warning:
symbol 'fair_share_throttle' was not declared. Should it be static?
drivers/thermal/fair_share.c:111:25: warning:
symbol 'thermal_gov_fair_share' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
Fixes the following sparse warnings:
drivers/thermal/user_space.c:38:5: warning:
symbol 'notify_user_space' was not declared. Should it be static?
drivers/thermal/user_space.c:46:25: warning:
symbol 'thermal_gov_user_space' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
Commit 4f2de3bf (extcon : register for cable interest by cable name)
reverted the change done in commit 5cd3c277.
Re-doing it.
Cc: Chanwoo Choi cw00.c...@samsung.com
Cc: MyungJoo Ham myungjoo@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/extcon/extcon-class.c
Variable 'start_addr' is not used and hence can be removed.
Silences the following compilation warning:
arch/arm/mm/mmap.c: In function ‘arch_get_unmapped_area’:
arch/arm/mm/mmap.c:60:16: warning:
unused variable ‘start_addr’ [-Wunused-variable]
Signed-off-by: Sachin Kamat sachin.ka
(ARCH_HAS_CPUFREQ CPU_FREQ)
Cc: Amit Daniel Kachhap amit.kach...@linaro.org
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Build tested using exynos4_defconfig on linux-next tree of 20121114.
---
drivers/thermal/Kconfig |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
On 19 March 2013 06:50, Damian Hobson-Garcia dhobs...@igel.co.jp wrote:
On 2013/03/14 19:22, Sachin Kamat wrote:
This eliminates having an #ifdef returning NULL for the case
when OF is disabled.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Damian Hobson-Garcia dhobs...@igel.co.jp
Hi Linus,
On 19 March 2013 13:58, Patrice CHOTARD patrice.chot...@st.com wrote:
On 03/19/2013 07:31 AM, Sachin Kamat wrote:
These symbols are used only in this file. Without this patch
we get the following warnings:
drivers/pinctrl/pinctrl-abx500.c:520:5: warning:
symbol
regcache_sync_block_raw is used only in this file. Hence make it static.
Silences the following warning:
drivers/base/regmap/regcache.c:608:5: warning:
symbol 'regcache_sync_block_raw' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/base
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat
On 27 March 2013 14:50, Hennerich, Michael michael.henner...@analog.com wrote:
Von: Sachin Kamat [sachin.ka...@linaro.org]
Gesendet: Mittwoch, 27. März 2013 09:59
An: device-drivers-de...@blackfin.uclinux.org; LKML
Cc: Hennerich, Michael; sa
On 26 March 2013 10:13, Sachin Kamat sachin.ka...@linaro.org wrote:
'data' is a pointer and hence use NULL instead of 0.
Silences the following warning:
drivers/mfd/max77686.c:49:50: warning: Using plain integer as NULL pointer
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Jonghwa
Hi Kukjin,
On 13 March 2013 14:42, Sachin Kamat sachin.ka...@linaro.org wrote:
Fixes the following warnings:
WARNING: line over 80 characters
WARNING: Prefer pr_warn(... to pr_warning(...
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/irqchip/exynos-combiner.c |6
On 9 April 2013 08:39, Joe Perches j...@perches.com wrote:
On Tue, 2013-04-09 at 08:33 +0530, Sachin Kamat wrote:
On 13 March 2013 14:42, Sachin Kamat sachin.ka...@linaro.org wrote:
Fixes the following warnings:
WARNING: line over 80 characters
WARNING: Prefer pr_warn(... to pr_warning
On 9 April 2013 09:15, Joe Perches j...@perches.com wrote:
On Tue, 2013-04-09 at 09:06 +0530, Sachin Kamat wrote:
On 9 April 2013 08:39, Joe Perches j...@perches.com wrote:
On Tue, 2013-04-09 at 08:33 +0530, Sachin Kamat wrote:
On 13 March 2013 14:42, Sachin Kamat sachin.ka...@linaro.org
Hi Samuel,
On 9 April 2013 15:43, Samuel Ortiz sa...@linux.intel.com wrote:
Hi Sachin,
On Thu, Apr 04, 2013 at 03:15:14PM +0530, Sachin Kamat wrote:
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat
On 2 April 2013 22:10, Olof Johansson o...@lixom.net wrote:
On Wed, Mar 13, 2013 at 03:05:15PM +0530, Sachin Kamat wrote:
Fixes the following errors:
ERROR: do not initialise statics to 0 or NULL
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Sachin Kamat sachin.ka
On 14 March 2013 04:47, Alexandru Gheorghiu gheorghiuan...@gmail.com wrote:
Replaced call to devm_request_and_ioremap with devm_ioremap_resource which
provides better error handling.
Signed-off-by: Alexandru Gheorghiu gheorghiuan...@gmail.com
---
Already sent a similar patch to do this:
Hi Linus,
On 4 March 2013 22:38, Tony Prisk li...@prisktech.co.nz wrote:
On Mon, 2013-03-04 at 14:39 +0530, Sachin Kamat wrote:
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource
On 14 March 2013 14:57, Alexandru Gheorghiu gheorghiuan...@gmail.com wrote:
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error
handling.
Signed-off-by: Alexandru Gheorghiu gheorghiuan...@gmail.com
Similar patch has
This eliminates having an #ifdef returning NULL for the case
when OF is disabled.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/power/sbs-battery.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/sbs-battery.c b/drivers/power/sbs
This eliminates having an #ifdef returning NULL for the case
when OF is disabled.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Damian Hobson-Garcia dhobs...@igel.co.jp
---
drivers/uio/uio_dmem_genirq.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers
This eliminates having an #ifdef returning NULL for the case
when OF is disabled.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/uio/uio_pdrv_genirq.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio
Silences the following type of checkpatch errors:
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/pinctrl/pinctrl-nomadik-db8500.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl
Fixes the following types of checkpatch errors:
ERROR: space required after that ',' (ctx:VxV)
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/pinctrl/pinctrl-nomadik.c |6 +++---
1 files changed, 3 insertions(+), 3
const declared twice. Fixes the following sparse warning:
drivers/pinctrl/pinctrl-at91.c:815:21: warning: duplicate const
drivers/pinctrl/pinctrl-at91.c:849:21: warning: duplicate const
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/pinctrl/pinctrl-at91.c |4 ++--
1 files
*)
ERROR: space required before that '*' (ctx:VxB)
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/pinctrl/pinctrl-at91.c | 17 +
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index
'conf_items' is used only in this file. Silences the below
sparse warning:
drivers/pinctrl/pinconf-generic.c:37:24: warning:
symbol 'conf_items' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/pinctrl/pinconf-generic.c |2 +-
1 files
Fixes the following type of checkpatch errors:
ERROR: space required before the open parenthesis '('
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/pinctrl/pinconf-generic.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/pinconf
Fixes the following checkpatch error:
ERROR: space required before the open parenthesis '('
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/pinctrl/pinctrl-coh901.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-coh901.c b
There's no need for me to take the patch I think; now that 3.9-rc1 is
out, the serial and driver core trees all have whatever dependencies
this series needed, so any patches can go through their usual trees, I
think... (Sorry, the context of this discussion was little while ago).
Ok, can
On 19 March 2013 07:33, Jingoo Han jg1@samsung.com wrote:
Fixed the checkpatch warning as below:
WARNING: static const char * array should probably be static const char *
const
#163: FILE: drivers/extcon/extcon-max8997.c:163:
+static const char *max8997_extcon_cable[] = {
' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/extcon/extcon-max77693.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
index 8f3c947..7b2e93d 100644
:721:5: warning:
symbol 'abx500_pin_config_set' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Patrice Chotard patrice.chot...@st.com
---
This series is compile tested against linux-next tree (20130319).
---
drivers/pinctrl/pinctrl-abx500.c | 10
-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Patrice Chotard patrice.chot...@stericsson.com
---
drivers/pinctrl/pinctrl-ab8505.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-ab8505.c b/drivers/pinctrl/pinctrl-ab8505.c
index 3a4238e..2841db7 100644
' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Patrice Chotard patrice.chot...@stericsson.com
---
drivers/pinctrl/pinctrl-ab8500.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-ab8500.c b/drivers/pinctrl
Fixes the following warnings:
drivers/pinctrl/pinctrl-ab9540.c:382:28: warning:
symbol 'ab9540alternate_functions' was not declared. Should it be static?
drivers/pinctrl/pinctrl-ab9540.c:457:32: warning:
symbol 'ab9540_gpio_irq_cluster' was not declared. Should it be static?
Signed-off-by: Sachin
-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Patrice Chotard patrice.chot...@stericsson.com
---
drivers/pinctrl/pinctrl-ab8540.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-ab8540.c b/drivers/pinctrl/pinctrl-ab8540.c
index 8ee1e8d..9867535 100644
'data' is a pointer and hence use NULL instead of 0.
Silences the following warning:
drivers/mfd/max77686.c:49:50: warning: Using plain integer as NULL pointer
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Jonghwa Lee jonghwa3@samsung.com
---
drivers/mfd/max77686.c |2 +-
1
/clk.c:252:60: error: expected ‘;’ before ‘{’ token
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/clk/samsung/clk.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c
index 91d12f3..78615dd 100644
On 15 March 2013 17:10, Sachin Kamat sachin.ka...@linaro.org wrote:
module_i2c_driver() removes some boilerplate and makes the code
simple.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/mfd/adp5520.c | 12 +---
1 files changed, 1 insertions(+), 11 deletions
max8997_update_reg() instead of (-11)?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/extcon/extcon-max8997.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index 69641bc..05b76b3 100644
()
info: why not propagate 'ret' from max77693_update_reg() instead of (-11)?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/extcon/extcon-max77693.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon
()
info: why not propagate 'ret' from max77693_update_reg() instead of (-11)?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Changes since v1:
Include additional instances.
Compile tested.
---
drivers/extcon/extcon-max77693.c |8
1 files changed, 4 insertions(+), 4 deletions
:
why not propagate 'ret' from max8997_update_reg() instead of (-11)?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/extcon/extcon-max8997.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon
Hi Chanwoo,
On 28 March 2013 04:51, Chanwoo Choi cw00.c...@samsung.com wrote:
On 03/27/2013 08:23 PM, Sachin Kamat wrote:
Return the value obtained from the function instead of hardcoding.
Silences the following warning:
drivers/extcon/extcon-max77693.c:297 max77693_muic_set_path()
info: why
Hi,
On 11 March 2013 13:08, Silviu-Mihai Popescu
silviupopescu1...@gmail.com wrote:
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so all
Fixes the following warnings:
WARNING: line over 80 characters
WARNING: Prefer pr_warn(... to pr_warning(...
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/irqchip/exynos-combiner.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip
Fixes the following errors:
ERROR: do not initialise statics to 0 or NULL
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Compile tested and based on linux-next tree (20130313).
---
drivers/irqchip/irq-gic.c |4 ++--
1 files changed, 2
Return type of function clk_propagate_rate_change is a pointer.
But 0 was being returned. Change it to NULL.
Silences the following warning:
drivers/clk/clk.c:977:24: warning: Using plain integer as NULL pointer
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/clk/clk.c |2
: undefined reference to
`pinconf_generic_dump_config'
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/pinctrl/pinconf.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pinctrl/pinconf.h b/drivers/pinctrl/pinconf.h
index 1f7113e..92c7267 100644
Fixes the following error:
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/pinctrl/pinctrl-nomadik-stn8815.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-nomadik-stn8815.c
b
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Reviewed-by: Thierry Reding thierry.red...@avionic-design.de
---
drivers/dma/pl330.c |7 ---
1 files
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat
struct samsung_pin_bank does not have a member called reg_offset.
It should be pctl_offset instead.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/pinctrl/pinctrl-samsung.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pinctrl/pinctrl
Hi Greg,
On 1 February 2013 15:37, Sachin Kamat sachin.ka...@linaro.org wrote:
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error
by regulator voltage set/get API's.
Reviewed-by: Thomas Abraham thomas.abra...@linaro.org
Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com
Tested this patch using [1] on Exynos4412 based Origen board and it works fine.
Feel free to add Tested-by: Sachin Kamat sachin.ka...@linaro.org if needed
'max8997_extcon_cable' is used only in this file. Hence make it static.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/extcon/extcon-max8997.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon
'break' after 'return' is never executed and hence can be deleted.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/extcon/extcon-max8997.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
'max77693_extcon_cable' is used only in this file. Hence
make it static.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/extcon/extcon-max77693.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon
This patch is required along with the
patch gpio: samsung: fix pinctrl condition for exynos and exynos5440
(mainline commit Id: e4a5da51) which has already made it into
mainline. Without the missing patch we get the following boot up
warnings and subsequent failures with dt boot on 4412 based
On 30 January 2013 09:38, Kukjin Kim kgene@samsung.com wrote:
Sachin Kamat wrote:
This patch is required along with the
patch gpio: samsung: fix pinctrl condition for exynos and exynos5440
(mainline commit Id: e4a5da51) which has already made it into
mainline. Without the missing
Hi Linus,
On 30 January 2013 15:18, Linus Walleij linus.wall...@linaro.org wrote:
On Wed, Jan 30, 2013 at 5:08 AM, Kukjin Kim kgene@samsung.com wrote:
Sachin Kamat wrote:
This patch is required along with the
patch gpio: samsung: fix pinctrl condition for exynos and exynos5440
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Vinod Koul vinod.k...@intel.com
Cc: Thierry Reding thierry.red...@avionic-design.de
Cc: Greg Kroah-Hartman
On 31 January 2013 12:58, Thierry Reding
thierry.red...@avionic-design.de wrote:
On Thu, Jan 31, 2013 at 12:37:04PM +0530, Sachin Kamat wrote:
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
Signed-off
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Donghwa Lee dh09@samsung.com
Cc: Florian Tobias Schandinat florianschandi...@gmx.de
Cc: linux-fb
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Dmitry Torokhov dmitry.torok...@gmail.com
Cc: linux-in...@vger.kernel.org
---
Compile tested with linux
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Laxman Dewangan ldewan...@nvidia.com
Cc: linux-ser...@vger.kernel.org
---
Compile tested with linux-next
On 31 January 2013 16:12, Thierry Reding
thierry.red...@avionic-design.de wrote:
On Thu, Jan 31, 2013 at 03:55:37PM +0530, Sachin Kamat wrote:
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
Signed-off
On 31 January 2013 22:30, Stephen Warren swar...@wwwdotorg.org wrote:
On 01/31/2013 03:25 AM, Sachin Kamat wrote:
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
Presumably though that function isn't yet
On 1 February 2013 09:54, Stephen Warren swar...@wwwdotorg.org wrote:
The entire series is merged in Greg's driver-core tree [1] and I
presume all other associated patches would also be picked up by him.
Isn't it Greg?
[1] git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat
Hi Padma,
While trying to boot the latest mainline kernel (Linus tree tip at
commit b0af9cd9) on Exynos4210 based Origen board, it stops at
Uncompressing Linux... done, booting the kernel.
Git bisect pointed to the commit 421da89aa (DMA: PL330: Register the
DMA controller with the generic DMA
of_dma_controller_register: not enough information provided
dma-pl330 dma-pl330.0: unable to register DMA to the generic DT DMA helpers
dma-pl330: probe of dma-pl330.0 failed with error -22
On 2 March 2013 09:40, Sachin Kamat sachin.ka...@linaro.org wrote:
Hi Padma,
While trying to boot the latest
Hi Alim,
On 2 March 2013 10:18, Alim Akhtar alim.akh...@gmail.com wrote:
Hi Sachin,
Looks like exynos4 is not yet moved to the generic dma binding recently
merged.
Could you try out below:
I forgot to mention in the previous mail that the problem was in non-dt case.
With the below entries
On 27 January 2013 05:52, Samuel Ortiz sa...@linux.intel.com wrote:
Hi Sachin,
On Thu, Jan 24, 2013 at 09:13:20AM +0530, Sachin Kamat wrote:
Hi Samuel,
On 8 January 2013 16:06, Mark Brown broo...@opensource.wolfsonmicro.com
wrote:
On Tue, Jan 08, 2013 at 02:01:22PM +0530, Sachin Kamat
Hi Linus, Kukjin,
Patch titled pinctrl: exynos: change PINCTRL_EXYNOS option
(linux-next commit Id: 7452b64d) which is present in linux-next is
missing in the mainline kernel. This patch is required along with the
patch gpio: samsung: fix pinctrl condition for exynos and exynos5440
(mainline
'exynos_rng_pm_ops' is used only in this file. Without this patch
we get the following sparse warning:
drivers/char/hw_random/exynos-rng.c:165:1: warning:
symbol 'exynos_rng_pm_ops' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Jonghwa Lee jonghwa3
Hi Samuel,
Could you please check this patch which is pending since some time.
On 7 December 2012 14:08, Sachin Kamat sachin.ka...@linaro.org wrote:
This driver uses devm_* APIs.
Thus explicit exit calls (regmap_exit and devm_kfree) are not needed
as they are device managed APIs.
Cc: Qiao
Hi Samuel,
On 8 January 2013 16:06, Mark Brown broo...@opensource.wolfsonmicro.com wrote:
On Tue, Jan 08, 2013 at 02:01:22PM +0530, Sachin Kamat wrote:
devm_regulator_bulk_get is device managed and saves some cleanup
and exit code.
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
'pinctrl_release' is used only in this file. Hence make it static.
Without this patch we get the following sparse error:
drivers/pinctrl/core.c:815:6: warning:
symbol 'pinctrl_release' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/pinctrl
This cleanup also fixes the following sparse warning:
fs/proc/root.c:64:45: warning: Using plain integer as NULL pointer
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
fs/proc/root.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/proc/root.c b/fs/proc
Path to gpio.txt (dt) document was broken.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Documentation/devicetree/bindings/gpio/led.txt |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpio/led.txt
b/Documentation/devicetree
'r-cfg' is being checked for NULL. However, it is dereferenced
in the previous statements. Thus moving those statements within
the check.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/dma/pl330.c | 16 +---
1 files changed, 9 insertions(+), 7 deletions(-)
diff
kzalloc could return NULL. Hence add a check to avoid
NULL pointer dereference.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/dma/pl330.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 018a445
Murthy arun.mur...@stericsson.com
Cc: Matthew Garrett m...@redhat.com
Cc: Robert Morell rmor...@nvidia.com
Cc: Dilan Lee di...@nvidia.com
Cc: Axel Lin axel@gmail.com
Cc: Mark Brown broo...@opensource.wolfsonmicro.com
Cc: Alexandre Courbot acour...@nvidia.com
Cc: Sachin Kamat sachin.ka
On 13 September 2012 13:14, Stephen Rothwell s...@canb.auug.org.au wrote:
Hi Andrew,
After merging the akpm tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/thermal/cpu_cooling.c: In function 'get_idr':
drivers/thermal/cpu_cooling.c:89:14: error: 'MAX_ID_MASK'
...@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/pinctrl/pinctrl-samsung.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-samsung.c
b/drivers/pinctrl/pinctrl-samsung.c
index 8a24223..824fda9 100644
--- a/drivers
1 - 100 of 1357 matches
Mail list logo
