Re: CPU hotplug hang due to "swap: make each swap partition have one address_space"

2013-02-03 Thread Shaohua Li
On Fri, Feb 01, 2013 at 10:02:33PM -0700, Stephen Warren wrote: > Shaohua, > > In next-20130128, commit 174f064 "swap: make each swap partition have > one address_space" (from the mm/akpm tree) appears causes a hang/RCU > stall for me when hot-unplugging a CPU. does this one work for you? http://

Re: mkfs.f2fs gets stuck with "blk_update_request: bio idx 0 >= vcnt 0" on 3.8

2013-04-04 Thread Shaohua Li
On Thu, Apr 04, 2013 at 06:00:18AM +0400, Max Filippov wrote: > Hi, > > On Tue, Apr 2, 2013 at 7:41 PM, Max Filippov wrote: > > I'm trying to create f2fs filesystem on SD card on pandaboard using > > f2fs-tools v1.0.0. > > It works fine on Linus' v3.6, but fails on both v3.8 and stable v3.8.5: >

Re: boot warnings due to swap: make each swap partition have one address_space

2013-01-30 Thread Shaohua Li
On Sun, Jan 27, 2013 at 01:40:40PM -0800, Hugh Dickins wrote: > On Sun, 27 Jan 2013, Shaohua Li wrote: > > On Sat, Jan 26, 2013 at 06:16:05PM -0800, Hugh Dickins wrote: > > > On Fri, 25 Jan 2013, Shaohua Li wrote: > > > > On Thu, Jan 24, 2013 at 10:45

Re: linux-next: build failure after merge of the final tree (akpm tree related)

2013-01-24 Thread Shaohua Li
On Thu, Jan 24, 2013 at 04:54:48PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (sparc32 defconfig) > failed like this: > > arch/sparc/mm/init_32.c: In function 'show_mem': > arch/sparc/mm/init_32.c:60:23: error: invalid operands to binary <<

Re: boot warnings due to swap: make each swap partition have one address_space

2013-01-24 Thread Shaohua Li
one. Does this one help? Subject: give-each-swapper-space-separate-backing_dev_info The backing_dev_info can't be shared by all swapper address space. Reported-by: Sasha Levin Signed-off-by: Shaohua Li --- mm/

Re: boot warnings due to swap: make each swap partition have one address_space

2013-01-27 Thread Shaohua Li
On Sat, Jan 26, 2013 at 06:16:05PM -0800, Hugh Dickins wrote: > On Fri, 25 Jan 2013, Shaohua Li wrote: > > On Thu, Jan 24, 2013 at 10:45:57PM -0500, Sasha Levin wrote: > > > Hi folks, > > > > > > Commit "swap: make each swap partition have one address_spac

Re: [PATCH next/mmotm] swap: add per-partition lock for swapfile fix

2013-01-27 Thread Shaohua Li
On Sun, Jan 27, 2013 at 01:47:01PM -0800, Hugh Dickins wrote: > I had all cpus spinning in swap_info_get(), for the lock on an area > being swapped off: probably because get_swap_page() forgot to unlock. > > Signed-off-by: Hugh Dickins Good catch. Thanks! > --- > > mm/swapfile.c |5 ++---

[bug]patch "acpi, memory-hotplug: parse SRAT before memblock is ready" breaks numa detection

2013-02-18 Thread Shaohua Li
This patch in linux-next breaks numa detection. numa_init() will zero numa_meminfo. If acpi_numa_init() does not call early_parse_srat(), we will have no memory numa info. Thanks, Shaohua -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord.

Re: linux-next: build failure after merge of the final tree (akpm tree related)

2012-09-13 Thread Shaohua Li
microblaze, mips, powerpc and x86 ... > > I have reverted that commit (and the following trivial fix commit) for > today. The x86 implementation of atomic_dec_if_positive is quite generic, how about add this one? Signed-off-by: Shaohua Li --- arch/microblaze/include/asm/atomic.h |

Re: [PATCH RFC] mm/swap: automatic tuning for swapin readahead

2012-10-22 Thread Shaohua Li
On Mon, Oct 22, 2012 at 10:16:40PM -0700, Hugh Dickins wrote: > On Mon, 22 Oct 2012, Shaohua Li wrote: > > On Tue, Oct 16, 2012 at 08:50:49AM +0800, Shaohua Li wrote: > > > On Mon, Oct 08, 2012 at 03:09:58PM -0700, Hugh Dickins wrote: > > > > On Thu, 4 Oct 201

Re: [PATCH RFC] mm/swap: automatic tuning for swapin readahead

2012-10-23 Thread Shaohua Li
On Tue, Oct 23, 2012 at 09:41:00AM -0400, Rik van Riel wrote: > On 10/23/2012 01:51 AM, Shaohua Li wrote: > > >I have no strong point against the global state method. But I'd agree making > >the > >heuristic simple is preferred currently. I'm happy about the p

Re: Problem with DISCARD and RAID5

2012-11-01 Thread Shaohua Li
On Thu, Nov 01, 2012 at 05:38:54PM +1100, NeilBrown wrote: > > Hi Shaohua, > I've been doing some testing and discovered a problem with your discard > support for RAID5. > > The code in blkdev_issue_discard assumes that the 'granularity' is a power > of 2, and for example subtracts 1 to get a

[PATCH] blk-mq: cache rq->q

2013-10-10 Thread Shaohua Li
If a tag is freed, the request might be used very soon. There is a short window rq->q is null, so cache it. Signed-off-by: Shaohua Li --- block/blk-mq.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: master/block/blk-m

[PATCH] null_blk: fix a bug in capacity calculation

2013-10-10 Thread Shaohua Li
the capacity calculation is obvious buggy. Signed-off-by: Shaohua Li --- drivers/block/null_blk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: master/drivers/block/null_blk.c === --- master.orig/drivers/block

[patch]block: add plug for blkdev_issue_discard

2012-10-08 Thread Shaohua Li
Now discard merge works, add plug for blkdev_issue_discard. This will help discard request merge especially for raid0 case. In raid0, a big discard request is split to small requests, and if correct plug is added, such small requests can be merged in low layer. Signed-off-by: Shaohua Li

Re: [PATCH RFC] mm/swap: automatic tuning for swapin readahead

2012-10-22 Thread Shaohua Li
On Tue, Oct 16, 2012 at 08:50:49AM +0800, Shaohua Li wrote: > On Mon, Oct 08, 2012 at 03:09:58PM -0700, Hugh Dickins wrote: > > On Thu, 4 Oct 2012, Konstantin Khlebnikov wrote: > > > > > Here results of my test. Workload isn't very realistic, but at least it > &

Re: Read starvation by sync writes

2012-12-11 Thread Shaohua Li
2012/12/11 Jan Kara : > Hi, > > I was looking into IO starvation problems where streaming sync writes (in > my case from kjournald but DIO would look the same) starve reads. This is > because reads happen in small chunks and until a request completes we don't > start reading further (reader rea

Re: [PATCH RFC] mm/swap: automatic tuning for swapin readahead

2012-11-05 Thread Shaohua Li
On Wed, Oct 24, 2012 at 09:13:56AM +0800, Shaohua Li wrote: > On Tue, Oct 23, 2012 at 09:41:00AM -0400, Rik van Riel wrote: > > On 10/23/2012 01:51 AM, Shaohua Li wrote: > > > > >I have no strong point against the global state method. But I'd agree > > &

block CFQ: avoid moving request to different queue

2012-11-06 Thread Shaohua Li
e the two cfqq are different, but didn't cause kernel crash, maybe it's because fifo list isn't used frequently. Anyway, from the code logic, this is buggy. I thought we can re-enable the recusive merge logic after this is fixed. Signed-off-by: Shaohua Li --- block/cfq-iosche

Re: block CFQ: avoid moving request to different queue

2012-11-06 Thread Shaohua Li
On Tue, Nov 06, 2012 at 12:39:13PM +0100, Jens Axboe wrote: > On 2012-11-06 12:34, Shaohua Li wrote: > > request is queued in cfqq->fifo list. Looks it's possible we are > > moving a request from one cfqq to another in request merge case. In > > such case, adjustin

Re: Problem with DISCARD and RAID5

2012-11-06 Thread Shaohua Li
On Tue, Nov 06, 2012 at 09:06:16AM +0100, Jens Axboe wrote: > On 2012-11-05 22:48, Dave Chinner wrote: > > On Fri, Nov 02, 2012 at 09:40:58AM +0800, Shaohua Li wrote: > >> On Thu, Nov 01, 2012 at 05:38:54PM +1100, NeilBrown wrote: > >>> > >>> Hi Shaohu

[patch]smp: make smp_call_function_many use the similar logic like smp_call_function_single

2012-12-23 Thread Shaohua Li
e a lot of cache ping-pong. With the patch, the data becomes per-cpu. The ping-pong is avoided. And from the perf data, this doesn't make call_single_queue lock contend. Next step is to remove generic_smp_call_function_interrupt from arch code. Signed-off-by: Shaohua Li --- include/lin

Re: [PATCH RFC] mm/swap: automatic tuning for swapin readahead

2012-11-18 Thread Shaohua Li
On Wed, Nov 14, 2012 at 01:48:18AM -0800, Hugh Dickins wrote: > On Tue, 6 Nov 2012, Shaohua Li wrote: > > On Wed, Oct 24, 2012 at 09:13:56AM +0800, Shaohua Li wrote: > > > On Tue, Oct 23, 2012 at 09:41:00AM -0400, Rik van Riel wrote: > > > > On 10/23/2

Re: RFC: Allow block drivers to poll for I/O instead of sleeping

2013-07-03 Thread Shaohua Li
On Thu, Jun 20, 2013 at 04:17:13PM -0400, Matthew Wilcox wrote: > > A paper at FAST2012 > (http://static.usenix.org/events/fast12/tech/full_papers/Yang.pdf) pointed > out the performance overhead of taking interrupts for low-latency block > I/Os. The solution the author investigated was to spin w

Re: [PATCH 01/02] swap: discard while swapping only if SWAP_FLAG_DISCARD_PAGES

2013-06-27 Thread Shaohua Li
On Sun, May 26, 2013 at 01:31:55AM -0300, Rafael Aquini wrote: > This patch introduces SWAP_FLAG_DISCARD_PAGES and SWAP_FLAG_DISCARD_ONCE > new flags to allow more flexibe swap discard policies being flagged through > swapon(8). The default behavior is to keep both single-time, or batched, area > d

[patch]workqueue: copy attr with all fields.

2013-07-28 Thread Shaohua Li
copy_workqueue_attrs() forgets to copy no_numa field. Signed-off-by: Shaohua Li diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 0b72e81..a988f54 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -3411,6 +3411,7 @@ static void copy_workqueue_attrs(struct workqueue_attrs *to

Re: [patch]workqueue: copy attr with all fields.

2013-07-29 Thread Shaohua Li
On Mon, Jul 29, 2013 at 07:14:01AM -0400, Tejun Heo wrote: > Hello, Shaohua. > > On Mon, Jul 29, 2013 at 02:24:12PM +0800, Shaohua Li wrote: > > copy_workqueue_attrs() forgets to copy no_numa field. > > Explaining how that affects things and how the behavior changes >

Re: [patch]workqueue: copy attr with all fields.

2013-07-29 Thread Shaohua Li
On Mon, Jul 29, 2013 at 11:35:23AM -0400, Tejun Heo wrote: > Hello, > > On Mon, Jul 29, 2013 at 08:52:59PM +0800, Shaohua Li wrote: > > Ah, ok, I thought it's straightforward... It's a bug fix. > > It never is, seriously. If it's something trivial / straighf

Re: [patch 1/3] raid5: offload stripe handle to workqueue

2013-07-30 Thread Shaohua Li
On Tue, Jul 30, 2013 at 08:53:06AM -0400, Tejun Heo wrote: > Hello, > > On Tue, Jul 30, 2013 at 01:52:08PM +0800, s...@kernel.org wrote: > > +static void raid5_wakeup_stripe_thread(struct stripe_head *sh) > > +{ > > + struct r5conf *conf = sh->raid_conf; > > + struct r5worker_group *group; > >

Re: [patch 3/3] raid5: only wakeup necessary threads

2013-07-30 Thread Shaohua Li
On Tue, Jul 30, 2013 at 08:46:55AM -0400, Tejun Heo wrote: > Hello, > > On Tue, Jul 30, 2013 at 01:52:10PM +0800, s...@kernel.org wrote: > > If there are no enough stripes to handle, we'd better now always queue all > > available work_structs. If one worker can only handle small or even none > > s

Re: [patch 1/3] raid5: offload stripe handle to workqueue

2013-07-30 Thread Shaohua Li
On Tue, Jul 30, 2013 at 09:57:51AM -0400, Tejun Heo wrote: > Hello, > > On Tue, Jul 30, 2013 at 09:07:08PM +0800, Shaohua Li wrote: > > Ok, I should explain here. I can't add a work_struct for each stripe, > > because > > this will stress workqueue very hard.

Re: [patch]workqueue: copy attr with all fields.

2013-07-30 Thread Shaohua Li
On Tue, Jul 30, 2013 at 10:14:19AM -0400, Tejun Heo wrote: > Hello, Shaohua. > > On Tue, Jul 30, 2013 at 01:49:55PM +0800, Shaohua Li wrote: > > > Note that copy_workqueue_attrs() is also used while creating worker > > > pools and this change would mean that ther

Re: [RFC PATCH] cfq-iosched: limit slice_idle when many busy queues are in idle window

2013-07-30 Thread Shaohua Li
On Tue, Jul 30, 2013 at 03:30:33PM -0400, Tomoki Sekiyama wrote: > Hi, > > When some application launches several hundreds of processes that issue > only a few small sync I/O requests, CFQ may cause heavy latencies > (10+ seconds at the worst case), although the request rate is low enough for > th

Re: [patch]workqueue: copy attr with all fields.

2013-07-31 Thread Shaohua Li
On Wed, Jul 31, 2013 at 06:27:52AM -0400, Tejun Heo wrote: > Hello, > > On Wed, Jul 31, 2013 at 09:39:29AM +0800, Shaohua Li wrote: > > Hmm, I didn't agree it's more confusing to change copy_workqueue_attrs(), > > the > > We're talking past each o

Re: [patch 1/3] raid5: offload stripe handle to workqueue

2013-07-31 Thread Shaohua Li
On Wed, Jul 31, 2013 at 06:33:32AM -0400, Tejun Heo wrote: > Hello, > > On Wed, Jul 31, 2013 at 09:24:34AM +0800, Shaohua Li wrote: > > stripe is the work unit actually. As I said, if I queue a work for each > > stripe, > > just queue_work() will make the system bla

[patch 3/3 v2] raid5: only wakeup necessary threads

2013-08-11 Thread Shaohua Li
ripes number. Note: some statistics info used in the patch are accessed without locking protection. This should doesn't matter, we just try best to avoid queue unnecessary work_struct. Signed-off-by: Shaohua Li --- drivers/md/raid5.c | 50 --

[patch 2/3 v2] raid5: sysfs entry to control worker thread number

2013-08-11 Thread Shaohua Li
Add a sysfs entry to control running workqueue thread number. If group_thread_cnt is set to 0, we will disable workqueue offload handling of stripes. Signed-off-by: Shaohua Li --- drivers/md/raid5.c | 60 + 1 file changed, 60 insertions

[patch 0/3 v2] raid5: make stripe handling multi-threading

2013-08-11 Thread Shaohua Li
Neil, This is another attempt to make raid5 stripe handling multi-threading. Recent workqueue improvement for unbound workqueue looks very promising to the raid5 usage. I had details in the first patch. The patches are against your tree with patch 'raid5: make release_stripe lockless' and 'raid5:

[patch 1/3 v2] raid5: offload stripe handle to workqueue

2013-08-11 Thread Shaohua Li
ase request size dispatching down to low level layer. The impact depends on thread number, raid configuration and workload. So multi-thread raid5 might not be proper for all setups. Changes V1 -> V2: 1. remove WQ_NON_REENTRANT 2. disabling multi-threading by default 3. Add more descripti

Re: mkfs.f2fs gets stuck with "blk_update_request: bio idx 0 >= vcnt 0" on 3.8

2013-04-06 Thread Shaohua Li
On Fri, Apr 05, 2013 at 06:18:10AM +0400, Max Filippov wrote: > On Fri, Apr 5, 2013 at 5:53 AM, Shaohua Li wrote: > > On Thu, Apr 04, 2013 at 06:00:18AM +0400, Max Filippov wrote: > > [...] > > >> the commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9 'block: add pl

Re: hybrid raid1 with trim support [REGRESSION]

2013-04-27 Thread Shaohua Li
On Sat, Apr 27, 2013 at 06:29:49PM +0200, Markus wrote: > Hi! > > Now I had the time to bisect, started with 3.7 as good and 3.8 as bad. > 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9 is the bad commit. [1] > block: add plug for blkdev_issue_discard > > While 3.8.10 was still bad, the same kernel wit

Re: hybrid raid1 with trim support [REGRESSION]

2013-04-27 Thread Shaohua Li
On Sun, Apr 28, 2013 at 08:54:46AM +0800, Shaohua Li wrote: > On Sat, Apr 27, 2013 at 06:29:49PM +0200, Markus wrote: > > Hi! > > > > Now I had the time to bisect, started with 3.7 as good and 3.8 as bad. > > 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9 is the bad commit.

Re: hybrid raid1 with trim support [REGRESSION]

2013-04-28 Thread Shaohua Li
he > raid? The discards are still passed to the ssd? Thanks for testing, I'll send to Neil soon. Yes, the discard will still be passed to SSD, we just ignore the request for harddisk. Thanks, Shaohua > Thanks, > Markus > > > Shaohua Li schrieb am 28.04.2013: > > On Su

Re: [RFC] mm: remove swapcache page early

2013-03-27 Thread Shaohua Li
On Thu, Mar 28, 2013 at 10:18:24AM +0900, Minchan Kim wrote: > On Wed, Mar 27, 2013 at 04:16:48PM -0700, Hugh Dickins wrote: > > On Wed, 27 Mar 2013, Dan Magenheimer wrote: > > > > From: Hugh Dickins [mailto:hu...@google.com] > > > > Subject: Re: [RFC] mm: remove swapcache page early > > > > > > >

Re: change of behavior for madvise in 3.9-rc1

2013-03-06 Thread Shaohua Li
On Wed, Mar 06, 2013 at 11:05:04PM -0500, CAI Qian wrote: > Bisecting indicated that this commit, > 1998cc048901109a29924380b8e91bc049b32951 > mm: make madvise(MADV_WILLNEED) support swap file prefetch > > Caused an LTP test failure, > http://goo.gl/1FVPy > > madvise021 TPASS : failed as e

Re: [patch 1/2]block: handle merged discard request

2012-08-02 Thread Shaohua Li
2012/6/22 Martin K. Petersen : >> "Christoph" == Christoph Hellwig writes: > >>> There are several additional commands in the pipeline where the 1:1 >>> mapping between DMA size and block range is invalid. I want to get >>> rid of the 1:1 assumption in general so we can handle any command >>>

Re: ext4 write performance regression in 3.6-rc1 on RAID0/5

2012-08-21 Thread Shaohua Li
On 8/22/12 11:57 AM, Yuanhan Liu wrote: On Fri, Aug 17, 2012 at 10:25:26PM +0800, Fengguang Wu wrote: > [CC md list] > > On Fri, Aug 17, 2012 at 09:40:39AM -0400, Theodore Ts'o wrote: >> On Fri, Aug 17, 2012 at 02:09:15PM +0800, Fengguang Wu wrote: >>> Ted, >>> >>> I find ext4 write performance

Re: [RFC PATCH] block:Fix some problems about handling plug in blk_queue_bio().

2012-08-07 Thread Shaohua Li
2012/8/8 Jianpeng Ma : > I think there are three problems about handling plug in blk_queue_bio(): > 1:if request_count >= BLK_MAX_REQUEST_COUNT, avoid unnecessary > plug->should_sort judge. this makes sense, though not a big deal, nice to fix it. > 2:Only two device can trace plug. I didn't get t

Re: What happened to TRIM support for raid linear/0/1/10?

2012-08-08 Thread Shaohua Li
2012/8/9 NeilBrown : > On Wed, 8 Aug 2012 13:10:51 + (GMT) Holger Kiehl > wrote: > >> Hello, >> >> I have been using the patches posted by Shaohua Li on 16th March 2012: >> >> http://lkml.indiana.edu/hypermail/linux/kernel/1203.2/00048.html >

[RFC]block: disable discard request merge temporarily

2012-08-08 Thread Shaohua Li
The SCSI discard request merge never worked, and looks no solution for in future, let's disable it temporarily. Signed-off-by: Shaohua Li diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 4e72a9d..0e6efb1 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blk

Re: Re: [RFC PATCH] block:Fix some problems about handling plug in blk_queue_bio().

2012-08-09 Thread Shaohua Li
2012/8/8 Jianpeng Ma : > On 2012-08-08 11:06 Shaohua Li Wrote: >>2012/8/8 Jianpeng Ma : >>> I think there are three problems about handling plug in blk_queue_bio(): >>> 1:if request_count >= BLK_MAX_REQUEST_COUNT, avoid unnecessary >>> plug->should_so

Re: [bootup crash, -git] Re: patch pci-pcie-aspm-support.patchadded to gregkh-2.6 tree

2008-02-18 Thread Shaohua Li
em with 3 PCIE links. Note: some devices might not work well with aspm, either because chipset issue or device issue. The patch provide API (pci_disable_link_state), driver can disable ASPM for specific device. Signed-off-by: Shaohua Li <[EMAIL PROTECTED]> --- drivers/pci/pci-sysfs.c

Re: PCIE ASPM support hangs my laptop pretty often

2008-02-18 Thread Shaohua Li
On Wed, 2008-02-06 at 01:40 +0800, Дамјан Георгиевски wrote: > I've patched my kernel with the PCIe ASPM and after setting > echo powersave > /sys/module/pcie_aspm/parameters/policy > > I started to experience random hangs of my laptop. > Hardware info: > Thinkpad x60s 1704-5UG > also tested on a

Re: [bootup crash, -git] Re: patch pci-pcie-aspm-support.patchadded to gregkh-2.6 tree

2008-02-19 Thread Shaohua Li
On Tue, 2008-02-19 at 15:45 -0800, Greg KH wrote: > On Tue, Feb 19, 2008 at 01:45:45PM +0800, Shaohua Li wrote: > > Sorry for the long delay, I just back from vocation. I fixed all the > > issues I found in the list (except one hang issue, which should be fixed > > in specif

Re: [bootup crash, -git] Re: patch pci-pcie-aspm-support.patchadded to gregkh-2.6 tree

2008-02-19 Thread Shaohua Li
On Tue, 2008-02-19 at 20:14 -0800, Greg KH wrote: > On Wed, Feb 20, 2008 at 09:36:07AM +0800, Shaohua Li wrote: > > --- linux.orig/include/linux/pci-acpi.h 2008-02-19 11:03:51.0 > > +0800 > > +++ linux/include/linux/pci-acpi.h 2008-02-20 09:19:15.0 +08

Re: [bootup crash, -git] Re: patch pci-pcie-aspm-support.patchadded to gregkh-2.6 tree

2008-02-19 Thread Shaohua Li
On Tue, 2008-02-19 at 21:04 -0800, Greg KH wrote: > On Wed, Feb 20, 2008 at 12:48:21PM +0800, Shaohua Li wrote: > > > > On Tue, 2008-02-19 at 20:14 -0800, Greg KH wrote: > > > On Wed, Feb 20, 2008 at 09:36:07AM +0800, Shaohua Li wrote: > > > > --- linux.orig

Re: [bootup crash, -git] Re: patch pci-pcie-aspm-support.patchadded to gregkh-2.6 tree

2008-02-19 Thread Shaohua Li
On Tue, 2008-02-19 at 21:42 -0800, Greg KH wrote: > On Wed, Feb 20, 2008 at 01:24:48PM +0800, Shaohua Li wrote: > > > > On Tue, 2008-02-19 at 21:04 -0800, Greg KH wrote: > > > On Wed, Feb 20, 2008 at 12:48:21PM +0800, Shaohua Li wrote: > > > > > > >

[patch]block: stack unplug

2012-07-09 Thread Shaohua Li
MD raid1 prepares to dispatch request in unplug callback. If make_request in low level queue also uses unplug callback to dispatch request, the low level queue's unplug callback will not be called. Recheck the callback list helps this case. Signed-off-by: Shaohua Li diff --git a/bloc

Re: [PATCH] block: Add blk_rq_pos(rq) to sort rq when plushing plug-list.

2012-10-15 Thread Shaohua Li
2012/10/15 Jianpeng Ma : > My workload is a raid5 which had 16 disks. And used our filesystem to > write using direct-io mode. > I used the blktrace to find those message: > > 8,16 0 3570 1.083923979 2519 I W 144323176 + 24 [md127_raid5] > 8,16 00 1.083926214 0 m

Re: [PATCH] block: Add blk_rq_pos(rq) to sort rq when plushing plug-list.

2012-10-15 Thread Shaohua Li
2012/10/15 Shaohua Li : > 2012/10/15 Jianpeng Ma : >> My workload is a raid5 which had 16 disks. And used our filesystem to >> write using direct-io mode. >> I used the blktrace to find those message: >> >> 8,16 0 3570 1.083923979 2519 I W 1443231

Re: [PATCH RFC] mm/swap: automatic tuning for swapin readahead

2012-10-15 Thread Shaohua Li
On Mon, Oct 08, 2012 at 03:09:58PM -0700, Hugh Dickins wrote: > On Thu, 4 Oct 2012, Konstantin Khlebnikov wrote: > > > Here results of my test. Workload isn't very realistic, but at least it > > threaded: compiling linux-3.6 with defconfig in 16 threads on tmpfs, > > 512mb ram, dualcore cpu, ordin

Re: Re: [PATCH] block: Add blk_rq_pos(rq) to sort rq when plushing plug-list.

2012-10-16 Thread Shaohua Li
2012/10/16 Jianpeng Ma : > On 2012-10-15 21:18 Shaohua Li Wrote: >>2012/10/15 Shaohua Li : >>> 2012/10/15 Jianpeng Ma : >>>> My workload is a raid5 which had 16 disks. And used our filesystem to >>>> write using direct-io mode. >>>> I used

Re: [RFC]x86: clearing access bit don't flush tlb

2013-01-14 Thread Shaohua Li
On Tue, Jan 08, 2013 at 02:03:25AM -0500, Rik van Riel wrote: > On 01/08/2013 12:09 AM, H. Peter Anvin wrote: > >On 01/07/2013 09:08 PM, Rik van Riel wrote: > >>On 01/08/2013 12:03 AM, H. Peter Anvin wrote: > >>>On 01/07/2013 08:55 PM, Shaohua Li wrote: > >&g

Re: Read starvation by sync writes

2012-12-12 Thread Shaohua Li
2012/12/12 Jan Kara : > On Wed 12-12-12 10:55:15, Shaohua Li wrote: >> 2012/12/11 Jan Kara : >> > Hi, >> > >> > I was looking into IO starvation problems where streaming sync writes (in >> > my case from kjournald but DIO would look the same) starv

[patch 1/2]block: discard granularity might not be power of 2

2012-12-13 Thread Shaohua Li
In MD raid case, discard granularity might not be power of 2, for example, a 4-disk raid5 has 3*chunk_size discard granularity. Correct the calculation for such cases. Reported-by: Neil Brown Signed-off-by: Shaohua Li --- block/blk-lib.c| 23 +-- block/blk

[patch 2/2]block: add plug for blkdev_issue_discard

2012-12-13 Thread Shaohua Li
merged in low layer. Signed-off-by: Shaohua Li --- block/blk-lib.c |3 +++ 1 file changed, 3 insertions(+) Index: linux/block/blk-lib.c === --- linux.orig/block/blk-lib.c 2012-12-14 10:03:22.305422686 +0800 +++ linux/block/blk

Re: [PATCH] block: makes bio_split support bio without data

2012-09-28 Thread Shaohua Li
data discard bio hasn't data attached. We hit a BUG_ON with such bio. This makes bio_split works for such bio. Signed-off-by: Shaohua Li Signed-off-by: NeilBrown --- fs/bio.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) Index: linux/fs/bio.c

[RFC]x86: clearing access bit don't flush tlb

2013-01-07 Thread Shaohua Li
again, it's quite unlikely this page's pte is still in TLB. Skiping the tlb flush for this case sounds ok to me. And in some workloads, TLB flush overhead is very heavy. In my simple multithread app with a lot of swap to several pcie SSD, removing the tlb flush gives about 20% ~ 30% swapout spee

Re: [patch]smp: make smp_call_function_many use the similar logic like smp_call_function_single

2013-01-07 Thread Shaohua Li
ping! On Mon, Dec 24, 2012 at 03:03:30PM +0800, Shaohua Li wrote: > > I'm testing swapout workload in a two-socket Xeon machine. The workload has 10 > threads, each thread sequentially accesses separate memory region. TLB flush > overhead is very big in the workload. For each p

Re: [RFC]x86: clearing access bit don't flush tlb

2013-01-07 Thread Shaohua Li
On Mon, Jan 07, 2013 at 02:31:21PM -0800, H. Peter Anvin wrote: > On 01/07/2013 07:14 AM, Rik van Riel wrote: > > On 01/07/2013 03:12 AM, Shaohua Li wrote: > >> > >> We use access bit to age a page at page reclaim. When clearing pte > >> access bit, > >

[PATCH]hande sysdev suspend failure

2005-08-10 Thread Shaohua Li
Hi, This patch adds the return value check for sysdev suspend and does restore in failure case. Send the patch to pm-list, but seems lost, so I resend it. Signed-off-by: Shaohua Li<[EMAIL PROTECTED]> --- linux-2.6.13-rc3-root/drivers/base/sys.c | 110 +++ 1

Re: [PATCH] [16/48] Suspend2 2.1.9.8 for 2.6.12: 406-dynamic-pageflags.patch

2005-07-06 Thread Shaohua Li
On Wed, 2005-07-06 at 12:20 +1000, Nigel Cunningham wrote: > + > +/* > + * Save and restore processor state for secondary processors. > + * IRQs (and therefore preemption) are already disabled > + * when we enter here (IPI). > + */ > + > +static volatile int loop __nosavedata; > + > +void __smp_su

Re: [PATCH] [16/48] Suspend2 2.1.9.8 for 2.6.12: 406-dynamic-pageflags.patch

2005-07-06 Thread Shaohua Li
On Wed, 2005-07-06 at 18:13 +1000, Nigel Cunningham wrote: > Hi. > > On Wed, 2005-07-06 at 17:46, Shaohua Li wrote: > > we are using cpu hotplug for S3 & S4 SMP to avoid nasty deadlocks. Could > > this be avoided in suspend2 SMP? > > I haven't had any proble

Re: [PATCH] [4/48] Suspend2 2.1.9.8 for 2.6.12: 302-init-hooks.patch

2005-07-06 Thread Shaohua Li
On Wed, 2005-07-06 at 12:20 +1000, Nigel Cunningham wrote: > diff -ruNp 350-workthreads.patch-old/drivers/acpi/osl.c > 350-workthreads.patch-new/drivers/acpi/osl.c > --- 350-workthreads.patch-old/drivers/acpi/osl.c 2005-06-20 > 11:46:50.0 +1000 > +++ 350-workthreads.patch-new/drivers

Re: [linux-pm] Re: [PATCH 1/23] Add missing device_suspsend(PMSG_FREEZE) calls.

2005-07-27 Thread Shaohua Li
On Wed, 2005-07-27 at 19:12 -0600, Eric W. Biederman wrote: > Nigel Cunningham <[EMAIL PROTECTED]> writes: > > > Hi. > > > > Could you please send PMSG_* related patches to linux-pm at > > lists.osdl.org as well? > > I'll try. My goal was not to add or change not functionality but to > make what

Re: [ACPI] Re: [Alsa-devel] [PATCH] 2.6.13-rc3-git5: fix Bug #4416 (1/2)

2005-07-28 Thread Shaohua Li
On Thu, 2005-07-28 at 10:06 +0200, Takashi Iwai wrote: > At Wed, 27 Jul 2005 22:52:49 +0200, > Pavel Machek wrote: > > > > Hi! > > > > > > The following patch adds free_irq() and request_irq() to the suspend and > > > > resume, respectively, routines in the snd_intel8x0 driver. > > > > > > The p

Re: [ACPI] Re: [Alsa-devel] [PATCH] 2.6.13-rc3-git5: fix Bug #4416 (1/2)

2005-07-28 Thread Shaohua Li
On Thu, 2005-07-28 at 10:43 +0200, Rafael J. Wysocki wrote: > Hi, > > On Thursday, 28 of July 2005 10:06, Takashi Iwai wrote: > > At Wed, 27 Jul 2005 22:52:49 +0200, > > Pavel Machek wrote: > > > > > > Hi! > > > > > > > > The following patch adds free_irq() and request_irq() to the suspend > >

Re: revert yenta free_irq on suspend

2005-07-31 Thread Shaohua Li
Hi, > In general, I think that calling free_irq is the right behavior. > Although irqs changing after suspend is rare, there are also some > more serious issues. This has been discussed in the past, and a > summary is as follows: irqs actually isn't changed after suspend currently, it's a consider

Re: revert yenta free_irq on suspend

2005-07-31 Thread Shaohua Li
On Sun, 2005-07-31 at 19:06 -0700, Andrew Morton wrote: > Shaohua Li <[EMAIL PROTECTED]> wrote: > > > > Hi, > > > In general, I think that calling free_irq is the right behavior. > > > Although irqs changing after suspend is rare, there are also some &g

Re: [ACPI] S3 and sigwait (was Re: 2.6.13-rc3: swsusp works (TP 600X))

2005-07-31 Thread Shaohua Li
On Sat, 2005-07-30 at 18:30 +0800, Pavel Machek wrote: > Hi! > > > >> One other glitch is that pdnsd (a nameserver caching daemon) has > crashed > > >> when the system wakes up from swsusp. It also happens when > waking up > > >> from S3, which was working with 2.6.11.4 although not with > 2.6.

Re: [ACPI] S3 and sigwait (was Re: 2.6.13-rc3: swsusp works (TP 600X))

2005-08-01 Thread Shaohua Li
On Mon, 2005-08-01 at 09:09 +0200, Pavel Machek wrote: > Hi! > > > > If you think it is a linux bug, can you produce small test case doing > > > just the sigwait, and post it on l-k with big title "sigwait() breaks > > > when straced, and on suspend"? > > > > > > That way it is going to get som

Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-02 Thread Shaohua Li
On Tue, 2005-08-02 at 09:55 -0600, Bjorn Helgaas wrote: > Any objections to the patch below? I posted it last Wednesday, > but haven't heard anything. Once we have this fix, 8250_pnp > should have sufficient functionality that we can get rid of > 8250_acpi. > > > > Use types that match the ACP

Re: [ACPI] Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-03 Thread Shaohua Li
On Wed, 2005-08-03 at 09:20 -0600, Bjorn Helgaas wrote: > On Tuesday 02 August 2005 7:01 pm, Shaohua Li wrote: > > On Tue, 2005-08-02 at 09:55 -0600, Bjorn Helgaas wrote: > > > Any objections to the patch below? I posted it last Wednesday, > > > but haven't heard

Re: [ACPI] Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-03 Thread Shaohua Li
On Wed, 2005-08-03 at 23:16 +0200, matthieu castet wrote: > > There are drivers/acpi/motherboard.c that done some stuff already handle > by pnp/system.c. Yes, it should be disabled if pnpacpi is enabled. The only concern is motherboard.c also request some ACPI resources, which might not declaim i

[RFC/PATCH]reconfigure MSI registers after resume

2005-08-17 Thread Shaohua Li
Hi, It appears pci_enable_msi doesn't reconfigure msi registers if it successfully look up a msi for a device. It assumes the data and address registers unchanged after calling pci_disable_msi. But this isn't always true, such as in a suspend/resume circle. In my test system, the registers unsurpri

[PATCH] Add MCE resume under ia32

2005-08-22 Thread Shaohua Li
Hi, It's widely seen a MCE non-fatal error reported after resume. It seems MCE resume is lacked under ia32. This patch tries to fix the gap. Signed-off-by: Shaohua Li<[EMAIL PROTECTED]> --- linux-2.6.13-rc6-root/arch/i386/kernel/cpu/mcheck/k7.c |2 +- linux-2.6.13-rc6-roo

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Shaohua Li
On Tue, 2005-08-23 at 12:32 +0200, Pavel Machek wrote: > > It's widely seen a MCE non-fatal error reported after resume. It seems > > MCE resume is lacked under ia32. This patch tries to fix the gap. > > Well, you patch seems like missing piece of puzzle, but: > > a) we probably want to do it for

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Shaohua Li
On Wed, 2005-08-24 at 03:52 +0200, Andi Kleen wrote: > Shaohua Li <[EMAIL PROTECTED]> writes: > > > x86-64 has resume support. It uses 'on_each_cpu' in resume method, which > > is known broken. We'd better fix it. > > What is broken with it? It&

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Shaohua Li
On Wed, 2005-08-24 at 05:12 +0200, Andi Kleen wrote: > On Wednesday 24 August 2005 03:59, Shaohua Li wrote: > > On Wed, 2005-08-24 at 03:52 +0200, Andi Kleen wrote: > > > Shaohua Li <[EMAIL PROTECTED]> writes: > > > > x86-64 has resume support. It uses 'on_

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Shaohua Li
On Wed, 2005-08-24 at 05:59 +0200, Andi Kleen wrote: > [adding discuss to cc] > > On Wednesday 24 August 2005 05:47, Shaohua Li wrote: > > On Wed, 2005-08-24 at 05:12 +0200, Andi Kleen wrote: > > > On Wednesday 24 August 2005 03:59, Shaohua Li wrote: > > > &g

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Shaohua Li
On Wed, 2005-08-24 at 06:26 +0200, Andi Kleen wrote: > On Wednesday 24 August 2005 06:16, Shaohua Li wrote: > > > The boot code already initialized MCE for APs, it isn't required to > > initialize again. The MCE entries are cpuhotplug friendly, so for > > suspend/res

Re: [PATCH] Add MCE resume under ia32

2005-08-24 Thread Shaohua Li
+extern void mcheck_init(struct cpuinfo_x86 *c); > > > > + > > > > void __restore_processor_state(struct saved_context *ctxt) > > > > { > > > > /* > > > > > > > > > this should go to some header file and most importantly

Re: [patch 1/1] Hot plug CPU to support physical add of new processors (i386)

2005-09-01 Thread Shaohua Li
Hi, On Wed, 2005-08-31 at 20:13 +0800, [EMAIL PROTECTED] wrote: > Current IA32 CPU hotplug code doesn't allow bringing up processors > that were not present in the boot configuration. > To make existing hot plug facility more practical for physical hot > plug, possible processors should be encoun

RE: [RFC/PATCH]reconfigure MSI registers after resume

2005-09-01 Thread Shaohua Li
On Thu, 2005-09-01 at 23:20 +0800, Nguyen, Tom L wrote: > On Wednesday, August 31, 2005 2:44 PM Greg KH wrote: > >>On Thu, Aug 18, 2005 at 01:35:46PM +0800, Shaohua Li wrote: > >> Hi, > >> It appears pci_enable_msi doesn't reconfigure msi registers if it &g

Re: [RFC] PCIE ASPM support

2008-01-03 Thread Shaohua Li
On Thu, 2008-01-03 at 11:33 -0800, Kok, Auke wrote: > Shaohua Li wrote: > > PCI Express ASPM defines a protocol for PCI Express components in the D0 > > state to reduce Link power by placing their Links into a low power state > > and instructing the other end of the Link

Re: [RFC] PCIE ASPM support

2008-01-07 Thread Shaohua Li
On Tue, 2008-01-08 at 09:02 +1100, Michael Ellerman wrote: > On Thu, 2008-01-03 at 14:15 +0800, Shaohua Li wrote: > > PCI Express ASPM defines a protocol for PCI Express components in the D0 > > state to reduce Link power by placing their Links into a low power state > > and

Re: [RFC] PCIE ASPM support

2008-01-07 Thread Shaohua Li
On Mon, 2008-01-07 at 10:19 -0800, Kok, Auke wrote: > Shaohua Li wrote: > > On Thu, 2008-01-03 at 11:33 -0800, Kok, Auke wrote: > >> Shaohua Li wrote: > >>> PCI Express ASPM defines a protocol for PCI Express components in the D0 > >>> state to reduce Li

Re: Suspend code ordering (again)

2008-01-07 Thread Shaohua Li
On Fri, 2007-12-28 at 08:25 +0800, Robert Hancock wrote: > Rafael J. Wysocki wrote: > >> Also, as was pointed out, pre-Vista versions of Windows follow ACPI > 1.0 > >> and Vista follows 3.0, so 2.0 doesn't really matter since BIOS > people > >> won't test against it. 1.0 specifies that _PTS is

Re: RFC: PNP: do not stop/start devices in suspend/resume path

2007-12-06 Thread Shaohua Li
On Thu, 2007-12-06 at 02:24 +0800, Bjorn Helgaas wrote: > Re: warning on suspend-to-RAM caused by > pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch, > thread here: http://lkml.org/lkml/2007/11/22/110 > > On Saturday 01 December 2007 05:00:34 am Jiri Slaby wrote: > > I didn't g

Re: [lm-sensors] 2.6.24-rc4 hwmon it87 probe fails

2007-12-09 Thread Shaohua Li
On Sun, 2007-12-09 at 23:04 +0100, Adrian Bunk wrote: > On Sun, Dec 09, 2007 at 04:12:25PM -0500, Elvis Pranskevichus wrote: > > Jean Delvare wrote: > > > > > Hi Mike, > > > > > > On Sat, 8 Dec 2007 21:22:34 -0500, Mike Houston wrote: > > >> On Sun, 9 Dec 2007 01:05:54 +0100 > > >> Adrian Bunk <

  1   2   3   4   5   6   7   8   9   >