Hi Bjorn/Matthias,
Thanks for the review, will fix them in the next-respin.
On 2018-08-28 08:32, Bjorn Andersson wrote:
On Mon 27 Aug 17:22 PDT 2018, Matthias Kaehlcke wrote:
On Fri, Aug 24, 2018 at 06:48:56PM +0530, Sibi Sankar wrote:
> diff --git a/drivers/reset/reset-qcom-pdc.c b/driv
Tested-by: Sibi Sankar
On 2018-08-28 12:44, Bjorn Andersson wrote:
Add support for booting the Audio and Compute DSPs found in Qualcomm's
SDM845 platform.
As with the previous platforms the power rail handling needs to be
updated once the appropriate support lands upstream.
Signed-o
Reviewed-by: Sibi Sankar
On 2018-08-28 12:42, Bjorn Andersson wrote:
Add the SMP2P nodes for the remoteproc states for adsp, cdsp, mpss and
slpi.
Signed-off-by: Bjorn Andersson
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 88
1 file changed, 88 insertions(+)
diff
ug 24, 2018 at 06:48:57PM +0530, Sibi Sankar wrote:
Remove the additional definition tag declared for WCSS sub-system
under reset-names.
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Add PDC Global (Power Domain Controller) binding for SDM845 SoCs.
Reviewed-by: Bjorn Andersson
Reviewed-by: Rob Herring
Signed-off-by: Sibi Sankar
---
.../bindings/reset/qcom,pdc-global.txt| 52 +++
include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
2 files
Philipp/Bjorn/Rob suggestions
Renamed reset binding to pdc-global.txt
replaced offset with #define of register name
replaced with devm_reset_control_get_exclusive()
Separted dt binding from the drivers
Sibi Sankar (6):
dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
reset: qcom
Remove the additional definition tag declared for WCSS sub-system
under reset-names.
Reviewed-by: Matthias Kaehlcke
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation
Add additional pdc_reset binding required for Q6V5 Modem PIL on
SDM845 SoCs.
Reviewed-by: Rob Herring
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc
Add reset controller for SDM845 SoCs to control reset signals provided
by PDC Global for Modem, Compute, Display, GPU, Debug, AOP, Sensors,
Audio, SP and APPS
Signed-off-by: Sibi Sankar
---
drivers/reset/Kconfig | 9 +++
drivers/reset/Makefile | 1 +
drivers/reset/reset
Explicitly get mss_restart to facilitate adding PDC reset line
for modem on SDM845 SoCs
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remoteproc/qcom_q6v5_pil.c
In the presence of a PDC block working with subsystem RSC, assert/deassert
PDC reset in modem start/stop path.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/drivers/remoteproc
Hi Vinod,
Thanks for the review,
On 08/07/2018 11:45 AM, Vinod wrote:
Hi Sibi,
On 27-07-18, 20:49, Sibi Sankar wrote:
Introduce custom dump function per remoteproc segment. It is responsible
for filling the device memory segment associated with coredump
Signed-off-by: Sibi Sankar
Hi Rob,
Thanks for the review
On 08/07/2018 11:46 PM, Rob Herring wrote:
On Tue, Jul 31, 2018 at 06:27:24PM +0530, Sibi S wrote:
Hi Philipp,
Thanks for the review!
On 07/31/2018 02:12 PM, Philipp Zabel wrote:
Hi Sibi,
On Fri, 2018-07-27 at 20:58 +0530, Sibi Sankar wrote:
Add SDM845 PDC
On 08/07/2018 11:48 PM, Rob Herring wrote:
On Fri, Jul 27, 2018 at 08:58:11PM +0530, Sibi Sankar wrote:
In the presence of a PDC block working with subsystem RSC,
assert/deassert PDC restart in modem start/stop path.
Signed-off-by: Sibi Sankar
---
.../bindings/remoteproc/qcom,q6v5.txt
Add PDC Global(Power Domain Controller) binding for SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
.../bindings/reset/qcom,pdc-global.txt| 52 +++
include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
2 files changed, 72 insertions(+)
create mode 100644 Documentation
devm_reset_control_get_exclusive()
Separted dt binding from the drivers
The last 4 remoteproc patches can be picked up after the pdc global
reset driver lands on linux-next.
Sibi Sankar (6):
dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
reset: qcom: PDC Global (Power Domain Controller) reset
Add reset controller for SDM845 SoCs to control reset signals provided
by PDC Global for Modem, Compute, Display, GPU, Debug, AOP, Sensors,
Audio, SP and APPS
Signed-off-by: Sibi Sankar
---
drivers/reset/Kconfig | 9 +++
drivers/reset/Makefile | 1 +
drivers/reset/reset
Remove the additional definition tag declared for WCSS sub-system
under reset-names.
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom
Add additional pdc_reset binding required for Q6V5 Modem PIL on
SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
b
Explicitly get mss_restart to facilitate adding PDC reset line
for modem on SDM845 SoCs
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remoteproc/qcom_q6v5_pil.c
In the presence of a PDC block working with subsystem RSC, assert/deassert
PDC reset in modem start/stop path.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/drivers/remoteproc
Register the MDT segments and custom dumpfn with the remoteproc core
dump functionality.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 40 ++
1 file changed, 40 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remoteproc
This patch adds a mechanism for assigning each rproc segment with
a custom dump function. It is to be called for each rproc segment
during coredump if assigned.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/remoteproc_core.c | 37
include/linux/remoteproc.h
Refactor re-useable parts of mba load/unload sequence into mba_load and
mba_reclaim respectively and introduce mba_load flag. This is done in
order to prevent code duplication for modem coredump which requires the
mba to be loaded.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc
Introduce custom dump function per remoteproc segment. It is responsible
for filling the device memory segment associated with coredump
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/remoteproc_core.c | 15 ++-
include/linux/remoteproc.h | 3 +++
2 files changed, 13
segment
dump function
V2:
Introduce prepare/unprepare ops for rproc coredump
Sibi Sankar (6):
remoteproc: Introduce custom dump function for each remoteproc segment
remoteproc: Add mechanism for custom dump function assignment
remoteproc: qcom: q6v5-pil: Refactor mba load/unload sequence
The per segment dump function is responsible for loading the mba
before device memory segments associated with coredump can be populated
and for cleaning up the resources post coredump.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 25 +
1 file
Assign the relocated base of the modem image, as the offsets
from the virtual memory might not be based on the physical
address.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers
Add SDM845 PDC (Power Domain Controller) reset controller binding
Signed-off-by: Sibi Sankar
---
.../bindings/reset/qcom,pdc-reset.txt | 52 +++
include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
2 files changed, 72 insertions(+)
create mode 100644
Add reset controller for SDM845 SoC to control reset signals
provided by PDC for Modem, Compute, Display, GPU, Debug, AOP,
Sensors, Audio, SP and APPS
Signed-off-by: Sibi Sankar
---
drivers/reset/Kconfig | 9 +++
drivers/reset/Makefile | 1 +
drivers/reset/reset-qcom-pdc.c
Explicitly get mss_restart to facilitate adding PDC
restart line for modem on SDM845 SoCs
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remoteproc
In the presence of a PDC block working with subsystem RSC,
assert/deassert PDC restart in modem start/stop path.
Signed-off-by: Sibi Sankar
---
.../bindings/remoteproc/qcom,q6v5.txt | 4 +++
drivers/remoteproc/qcom_q6v5_pil.c| 27 ---
2 files changed, 27
On 2018-09-26 05:05, Bjorn Andersson wrote:
On Tue 25 Sep 03:18 PDT 2018, Sibi Sankar wrote:
On 2018-09-20 22:52, Bjorn Andersson wrote:
> diff --git a/drivers/remoteproc/qcom_adsp_pil.c
> b/drivers/remoteproc/qcom_adsp_pil.c
> index da2254ea1135..fcbb816a9698 100644
> --- a/driver
On 2018-09-28 00:33, Bjorn Andersson wrote:
Add compatibles for the three PAS based remote processors found in
QCS404.
Signed-off-by: Bjorn Andersson
---
Reviewed-by: Sibi Sankar
Changes since v1:
- Fixed incorrect sysmon_name, as pointed out by Sibi.
.../devicetree/bindings/remoteproc
This patch adds Q6V5 MSS remoteproc node for SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
The remoteproc mss node depends on the following bindings:
https://patchwork.kernel.org/patch/10490559/ - rpmhp dt bindings
https://patchwork.kernel.org/patch/10678301/ - AOP QMP dt bindings
https
Add optional shutdown-irq binding required for sysmon shutdown on
SDM845/MSM8996/QCS404 SoCs.
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings
After sending a sysmon shutdown request to the SSCTL service on the
subsystem, wait for the service to send shutdown-ack interrupt or
an indication message back.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_sysmon.c | 59 +++-
1 file changed, 58 insertions
Add power-domain bindings for Q6V5 MSS on SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
Add dt-binding corresponding to https://patchwork.kernel.org/patch/10586893/
(remoteproc: q6v5: Add support to vote for rpmh power domains)
.../devicetree/bindings/remoteproc/qcom,q6v5.txt | 11
nt to skip wcss entry for now till the shutdown-ack
gets posted,
reviewed and merged.
+
+ clocks = <&xo_board>;
+ clock-names = "xo";
+
+ memory-region = <&wlan_fw_mem>;
+
+ qcom,smem-states = <&wcss_smp2p_out 0>;
+ qcom,smem-state-names = "stop";
+
+ status = "disabled";
+
+ glink-edge {
+ interrupts = ;
+
+ qcom,remote-pid = <1>;
+ mboxes = <&apcs_glb 16>;
+
+ label = "wcss";
+ };
+ };
+
reserved-memory {
#address-cells = <2>;
#size-cells = <2>;
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
Hi Bjorn,
Thanks for the review!
On 2018-12-06 22:28, Bjorn Andersson wrote:
On Tue 20 Nov 13:08 PST 2018, Sibi Sankar wrote:
Add power-domain bindings for Q6V5 MSS on SDM845 SoCs.
Thanks Sibi,
Signed-off-by: Sibi Sankar
---
Add dt-binding corresponding to
https://patchwork.kernel.org
unvoting axis2 clk caused modem hang]
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remoteproc/qcom_q6v5_pil.c
index e04319573c91..d7a4b9eca5d2 100644
--- a/drivers/remoteproc
Add SDM845 AOSS (always on subsystem) reset controller binding
Signed-off-by: Sibi Sankar
---
Not including Rob's earlier Reviewed-by due to change in compatible
.../bindings/reset/qcom,aoss-reset.txt| 52 +++
include/dt-bindings/reset/qcom,sdm845-aoss.h
Add reset controller driver for Qualcomm SDM845 SoC to
control reset signals provided by AOSS for Modem, Venus
ADSP, GPU, Camera, Wireless, Display subsystem
Reviewed-by: Bjorn Andersson
Signed-off-by: Sibi Sankar
---
drivers/reset/Kconfig | 9 +++
drivers/reset/Makefile
In some occasions the remoteproc device might need to
prepare some hardware before the coredump can be performed
and cleanup the state afterwards.
Q6V5 modem requires the mba to be loaded before the
coredump and some cleanup of the resources afterwards.
Signed-off-by: Sibi Sankar
---
This
Add optional firmware bindings for Q6V5 MSS. It lists the two relative
firmware paths which are used for booting and authenticating the Hexagon
core.
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 7 +++
1 file changed, 7 insertions(+)
diff
Q6V5 MSS on certain SoCs like SDM845 are capable of operating under
completely different configuration (like Non-Modem WLAN configuration)
depending on the firmware loaded without any change in boot sequence
of the Hexagon core. The patch series is ultimately aimed to avoid
multiple compatibles per
Add support for parsing "qcom,firmware" dt bindings which specifies
the relative paths of mba and modem metadata as a list of strings.
Fallback to the default paths for mba/modem on -EINVAL.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 49 +++
From: Saravana Kannan
If the new governor fails to start, switch back to old governor so that the
devfreq state is not left in some weird limbo.
Signed-off-by: Sibi Sankar
Signed-off-by: Saravana Kannan
Reviewed-by: Chanwoo Choi
---
V4:
* Removed prev_governor check.
V3:
* Fix NULL deref
Hi Doug,
Thanks for the review :)
On 2018-12-18 05:29, Doug Anderson wrote:
Hi,
On Mon, Dec 17, 2018 at 2:07 AM Sibi Sankar
wrote:
Add missing qcom,remote-pid dt binding required for GLINK SMEM
which specifies the remote endpoint of the GLINK edge.
Signed-off-by: Sibi Sankar
Hi Doug,
Thanks for the review :)
On 2018-12-18 05:29, Doug Anderson wrote:
Hi,
On Mon, Dec 17, 2018 at 2:07 AM Sibi Sankar
wrote:
Add missing clock bindings for Q6V5 MSS on SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
.../devicetree/bindings/remoteproc/qcom,q6v5.txt | 10
Hi Doug,
Thanks for the review :)
On 2018-12-18 05:31, Doug Anderson wrote:
Hi,
On Mon, Dec 17, 2018 at 2:08 AM Sibi Sankar
wrote:
Add power-domain bindings for Q6V5 MSS on MSM8996 and SDM845 SoCs.
Reviewed-by: Rob Herring
Signed-off-by: Sibi Sankar
---
v2:
* Add load_state power
Hi Doug,
Thanks for the review :)
On 2018-12-18 05:32, Doug Anderson wrote:
Hi,
On Mon, Dec 17, 2018 at 2:08 AM Sibi Sankar
wrote:
This patch adds Q6V5 MSS remoteproc node for SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
v2:
* Fixed style changes
* Added missing clocks in the dt
Hi Doug,
Thanks for the review :)
On 2018-12-18 05:32, Doug Anderson wrote:
Hi,
On Mon, Dec 17, 2018 at 2:08 AM Sibi Sankar
wrote:
Add power-domains cx, mx, mss and load_state for Q6V5 MSS node.
Signed-off-by: Sibi Sankar
---
This patch depends on the following bindings:
https
Hi Doug,
Thanks for the review :)
On 2018-12-18 05:30, Doug Anderson wrote:
Hi,
On Mon, Dec 17, 2018 at 2:08 AM Sibi Sankar
wrote:
Fixup regulator supply dependencies for Q6V5 MSS on MSM996 SoCs.
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
Hi Rob,
Thanks for the review!
On 2018-12-18 22:57, Rob Herring wrote:
On Mon, Dec 17, 2018 at 03:37:19PM +0530, Sibi Sankar wrote:
Add missing clock bindings for Q6V5 MSS on SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
.../devicetree/bindings/remoteproc/qcom,q6v5.txt | 10
Hi Doug,
Thanks for the review!
On 2018-12-14 03:47, Doug Anderson wrote:
Hi,
On Tue, Nov 27, 2018 at 12:58 AM Sibi Sankar
wrote:
This patch adds Q6V5 MSS remoteproc node for SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
The remoteproc mss node depends on the following bindings:
https
Hi Bjorn,
Thanks for the review!
On 2018-12-06 12:46, Bjorn Andersson wrote:
On Tue 20 Nov 13:02 PST 2018, Sibi Sankar wrote:
After sending a sysmon shutdown request to the SSCTL service on the
subsystem, wait for the service to send shutdown-ack interrupt or
an indication message back.
So
Add missing clock bindings for Q6V5 MSS on SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
.../devicetree/bindings/remoteproc/qcom,q6v5.txt | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
b
Add missing qcom,remote-pid dt binding required for GLINK SMEM
which specifies the remote endpoint of the GLINK edge.
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree
Add power-domain bindings for Q6V5 MSS on MSM8996 and SDM845 SoCs.
Reviewed-by: Rob Herring
Signed-off-by: Sibi Sankar
---
v2:
* Add load_state power-domain
* List cx and mx power-domains for MSM8996
.../devicetree/bindings/remoteproc/qcom,q6v5.txt | 16
1 file changed
This patch adds Q6V5 MSS remoteproc node for SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
v2:
* Fixed style changes
* Added missing clocks in the dt-bindings
* Split mss remoteproc node into a number of patches
This patch depends on the mpss and mba memory regions and pdc reset node
Fixup regulator supply dependencies for Q6V5 MSS on MSM996 SoCs.
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
b
Add power-domains cx, mx, mss and load_state for Q6V5 MSS node.
Signed-off-by: Sibi Sankar
---
This patch depends on the following bindings:
https://patchwork.kernel.org/patch/10725801/ - rpmhpd dt bindings
https://patchwork.kernel.org/patch/10725793/ - rpmhpd dt node
https
Add shutdown-ack smp2p interrupt for Q6V5 MSS node.
Signed-off-by: Sibi Sankar
---
This patch depends on:
https://patchwork.kernel.org/patch/10691213/ - shutdown-ack dt bindings
arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch
Hi Bjorn,
Thanks for the review!
On 2019-01-04 05:03, Bjorn Andersson wrote:
On Mon 24 Dec 00:48 PST 2018, Sibi Sankar wrote:
After sending a sysmon shutdown request to the SSCTL service on the
subsystem, wait for the service to send shutdown-ack interrupt or
an indication message to signal
Introduce shutdown-irq binding required for sysmon shutdown for Q6V5 MSS
on SDM845/MSM8996 SoCs and for WCSS Q6V5 on QCS404 SoC.
Reviewed-by: Rob Herring
Signed-off-by: Sibi Sankar
---
v2:
* Make shutdown-ack mandatory for MSS on SDM845/MSM8996 and
for WCSS on QCS404 (Dropping Rob&#
Add shutdown-ack irq handling required for sysmon shutdown for
Q6V5 MSS on SDM845/MSM8996 and for WCSS Q6V5 on QCS404 SoC.
Signed-off-by: Sibi Sankar
---
v3:
* Move shutdown-irq handling back to sysmon and
modify qcom_add_sysmon_subdev to handle -EPROBE_DEFER
* Dropped
After sending a sysmon shutdown request to the SSCTL service on the
subsystem, wait for the service to send shutdown-ack interrupt or
an indication message to signal the completion of graceful shutdown.
Signed-off-by: Sibi Sankar
---
v2:
* Correct the shutdown-irq wait time to 10 * HZ
Hi Bjorn,
Thanks for the review!
On 2019-01-04 01:47, Bjorn Andersson wrote:
On Fri 28 Dec 10:53 PST 2018, Sibi Sankar wrote:
Add missing qcom,remote-pid dt binding required for GLINK SMEM
which specifies the remote endpoint of the GLINK edge.
Fixes: 2b41d6c8e696 ("dt-bindings: soc:
Hi Brian,
Thanks for the review!
On 2019-01-04 05:14, Brian Norris wrote:
On Fri, Dec 28, 2018 at 10:18:19AM +0530, Sibi Sankar wrote:
Add support for parsing "firmware-name" dt bindings which specifies
the relative paths of mba/modem/pas image as strings. Fallback to
the default pat
) I mostly
wanted
to give food for thought, in the hopes that something in here would
help
improve this a bit.
Bjorn,
let me know how you want it implemented.
I am okay with either of the following:
* (variant tag based solution)
or
* (simply going ahead with what we have now).
Regards,
Brian
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
Introduce shutdown-irq binding required for sysmon shutdown for Q6V5 MSS
on SDM845/MSM8996 SoCs and for WCSS Q6V5 on QCS404 SoC.
Signed-off-by: Sibi Sankar
---
v2:
Make shutdown-ack mandatory for MSS on SDM845/MSM8996 and
for WCSS on QCS404 (Dropping Rob's reviewed-by due to
Add shutdown-ack irq handling for Q6V5. This patch includes enabling
shutdown-ack irq on those Q6V5 instances with "has_shutdown_irq"
flag set and exposing Q6V5 state information to the sysmon instance
which is required to ascertain graceful shutdown completion.
Signed-off-by: S
Enable shutdown-ack irq handling for MSS Q6V5 on SDM845/MSM8996
SoCs and for WCSS Q6V5 on QCS404 SoC.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 11 ---
drivers/remoteproc/qcom_q6v5_pas.c | 9 +++--
2 files changed, 15 insertions(+), 5 deletions(-)
diff
After sending a sysmon shutdown request to the SSCTL service on the
subsystem, wait for the service to send shutdown-ack interrupt or
an indication message to signal the completion of graceful shutdown.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_sysmon.c | 40
Add missing qcom,remote-pid dt binding required for GLINK SMEM
which specifies the remote endpoint of the GLINK edge.
Fixes: 2b41d6c8e696 ("dt-bindings: soc: qcom: Extend GLINK to cover
SMEM")
Signed-off-by: Sibi Sankar
Reviewed-by: Doug Anderson
---
v3:
* Fixed typo
Doc
Add power-domain bindings for Q6V5 MSS on MSM8996 and SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
v3:
* Fixup dt-binding documentation as suggested by Doug
* Dropping Rob's Reviewed-by due to documentation style
change
v2:
* Add load_state power-domain
* List cx and mx
Add missing clock bindings for Q6V5 MSS on SDM845 SoCs.
Fixes: fb22022ff63d ("dt-bindings: remoteproc: Add Q6v5 Modem PIL
binding for SDM845")
Signed-off-by: Sibi Sankar
---
v3:
* Fixup dt-binding documentation as suggested by Doug
.../devicetree/bindings/remoteproc/qcom,q6v5.
Add missing clock bindings for Q6V5 MSS on MSM8996 SoCs.
Fixes: 9f058fa2efb1 ("remoteproc: qcom: Add support for mss remoteproc
on msm8996")
Signed-off-by: Sibi Sankar
---
v3:
* Fixup dt-binding documentation as suggested by Doug
Documentation/devicetree/bindings/remoteproc/qco
This patch adds Q6V5 MSS remoteproc node for SDM845 SoCs.
Signed-off-by: Sibi Sankar
Reviewed-by: Douglas Anderson
---
v3:
* with shutdown-ack irq redesign make it mandatory,
merge multiple patches into a single one
v2:
* Fixed style changes
* Added missing clocks in the dt-bindings
Add proxy vote for pll supply on MSM8996 SoC.
Fixes: 9f058fa2efb1 ("remoteproc: qcom: Add support for mss remoteproc
on msm8996")
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v
Fixup regulator supply dependencies for Q6V5 MSS on MSM996 SoCs.
Fixes: 9f058fa2efb1 ("remoteproc: qcom: Add support for mss remoteproc
on msm8996")
Signed-off-by: Sibi Sankar
---
v3:
* Fixup dt-binding documentation as suggested by Doug
.../bindings/remoteproc/qcom,q6v5.txt
Proxy vote for QDSS clock and remove vote on handover interrupt
to provide MSS PBL with access to STM hardware registers during
boot. Add "snoc_axi" and "mnoc_axi" to the active clock list.
Fixes: 9f058fa2efb1 ("remoteproc: qcom: Add support for mss remoteproc
on msm89
Hi Rob,
Thanks for the review!
On 2018-12-28 02:51, Rob Herring wrote:
On Wed, Dec 26, 2018 at 06:22:23PM +0530, Sibi Sankar wrote:
Add missing clock bindings for Q6V5 MSS on SDM845 SoCs.
Fixes: fb22022ff63d ("dt-bindings: remoteproc: Add Q6v5 Modem PIL
binding for SDM845")
Sig
Hi Rob,
Thanks for the review :)
On 2018-12-21 01:40, Rob Herring wrote:
On Wed, Dec 12, 2018 at 06:14:55PM +0530, Sibi Sankar wrote:
Add optional firmware bindings for Q6V5 MSS. It lists the two relative
firmware paths which are used for booting and authenticating the
Hexagon
core.
Signed
e-name" binding is not present.
Signed-off-by: Sibi Sankar
---
Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt | 6 ++
Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 7 +++
2 files changed, 13 insertions(+)
diff --git a/Documentation/devicetree/bindings/remo
by Rob
* Include dt-bindings/parsing logic for PAS based remoteprocs
Sibi Sankar (2):
dt-bindings: remoteproc: qcom: Add firmware bindings for Q6V5
remoteproc: qcom: Add support for parsing fw dt bindings
.../bindings/remoteproc/qcom,adsp.txt | 6 +++
.../bindings/remoteproc/qcom,q
Add support for parsing "firmware-name" dt bindings which specifies
the relative paths of mba/modem/pas image as strings. Fallback to
the default paths for mba/modem/pas image on -EINVAL.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_
Fixes: 9f058fa2efb1 ("remoteproc: qcom: Add support for mss remoteproc
on msm8996")
Signed-off-by: Sibi Sankar
---
v4:
* Rename "gpll0_mss_clk" to "gpll0_mss" for consistency across
SoCs
drivers/remoteproc/qcom_q6v5_mss.c | 5 -
1 file changed, 4 inserti
Add missing clock bindings for Q6V5 MSS on MSM8996 SoCs.
Fixes: 9f058fa2efb1 ("remoteproc: qcom: Add support for mss remoteproc
on msm8996")
Signed-off-by: Sibi Sankar
---
v4:
* Re-order clocks for consistency as suggested by Rob
v3:
* Fixup dt-binding documentation as suggest
Add missing clock bindings for Q6V5 MSS on SDM845 SoCs.
Fixes: fb22022ff63d ("dt-bindings: remoteproc: Add Q6v5 Modem PIL
binding for SDM845")
Signed-off-by: Sibi Sankar
---
v4:
* Re-order clocks for consistency as suggested by Rob
v3:
* Fixup dt-binding documentation as suggest
Add missing qcom,remote-pid dt binding required for GLINK SMEM
which specifies the remote endpoint of the GLINK edge.
Fixes: 2b41d6c8e696 ("dt-bindings: soc: qcom: Extend GLINK to cover
SMEM")
Signed-off-by: Sibi Sankar
Reviewed-by: Doug Anderson
Reviewed-by: Rob Herring
---
v3:
Fixup regulator supply dependencies for Q6V5 MSS on MSM996 SoCs.
Fixes: 9f058fa2efb1 ("remoteproc: qcom: Add support for mss remoteproc
on msm8996")
Signed-off-by: Sibi Sankar
Reviewed-by: Rob Herring
---
v3:
* Fixup dt-binding documentation as suggested by Doug
.../bindings/
Add proxy vote for pll supply on MSM8996 SoC.
Fixes: 9f058fa2efb1 ("remoteproc: qcom: Add support for mss remoteproc
on msm8996")
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v
This patch adds Q6V5 MSS remoteproc node for SDM845 SoCs.
Signed-off-by: Sibi Sankar
Reviewed-by: Douglas Anderson
---
v3:
* with shutdown-ack irq redesign make it mandatory,
merge multiple patches into a single one
v2:
* Fixed style changes
* Added missing clocks in the dt-bindings
Add power-domain bindings for Q6V5 MSS on MSM8996 and SDM845 SoCs.
Signed-off-by: Sibi Sankar
Reviewed-by: Rob Herring
---
v3:
* Fixup dt-binding documentation as suggested by Doug
* Dropping Rob's Reviewed-by due to documentation style
change
v2:
* Add load_state power-d
Hi Bjorn,
Thanks for the review :)
On 2018-10-08 11:53, Bjorn Andersson wrote:
On Fri 27 Jul 08:19 PDT 2018, Sibi Sankar wrote:
Introduce custom dump function per remoteproc segment. It is
responsible
for filling the device memory segment associated with coredump
Signed-off-by: Sibi Sankar
Hi Bjorn,
Thanks for the review !
On 2018-10-08 12:15, Bjorn Andersson wrote:
On Fri 27 Jul 08:20 PDT 2018, Sibi Sankar wrote:
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c
b/drivers/remoteproc/qcom_q6v5_pil.c
[..]
+static void qcom_q6v5_dump_segment(struct rproc *rproc, void *ptr,
size_t
Hi Bjorn,
Thanks for the review !
On 2018-10-08 12:18, Bjorn Andersson wrote:
On Fri 27 Jul 08:20 PDT 2018, Sibi Sankar wrote:
Register the MDT segments and custom dumpfn with the remoteproc core
dump functionality.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_pil.c | 40
epare ops with a more generalised per segment
dump function
V2:
Introduce prepare/unprepare ops for rproc coredump
Sibi Sankar (5):
remoteproc: Introduce custom dump function for each remoteproc segment
remoteproc: Add mechanism for custom dump function assignment
remoteproc: qcom: q6v
1 - 100 of 519 matches
Mail list logo
