Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros

2020-08-05 Thread Steev Klimaszewski
On 8/5/20 3:19 PM, Saravana Kannan wrote: > On Wed, Aug 5, 2020 at 12:44 AM John Stultz wrote: >> >> So this is where I bashfully admit I didn't get a chance to try this >> patch series out, as I had success with a much older version of >> Saravana's macro magic. >> >> But unfortunately, now

Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros

2020-08-05 Thread Steev Klimaszewski
On 8/5/20 4:16 PM, Steev Klimaszewski wrote: > On 8/5/20 3:19 PM, Saravana Kannan wrote: >> On Wed, Aug 5, 2020 at 12:44 AM John Stultz wrote: >>> >>> So this is where I bashfully admit I didn't get a chance to try this >>> patch series out, as I h

Re: [PATCH] drm/bridge: ti-sn65dsi86: Add retries for link training

2020-10-04 Thread Steev Klimaszewski
/* If we saw quite a few retries, add a note about it */ > + if (!ret && i > SN_LINK_TRAINING_TRIES / 2) > + DRM_DEV_INFO(pdata->dev, "Link training needed %d retries\n", > i); > + > exit: > /* Disable the PLL if we failed */ > if (ret) Apologies for the previous HTML email, I was trying a new mail client and... will not be switching to it. Anyway.. again, this time in text.. Tested on the Lenovo C630, and haven’t seen the message, although I hadn’t seen the described issue before either. Tested-By: Steev Klimaszewski

Re: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi86: Replace #pwm-cells

2020-09-30 Thread Steev Klimaszewski
-scale: > +description: > + The granularity of brightness for the PWM signal provided on GPIO4, if > + this property is specified. > + minimum: 0 > +maximum: 65535 > >ports: > type: object Tested-By: Steev Klimaszewski

Re: [PATCH 2/2] drm/bridge: ti-sn65dsi86: Expose backlight controls

2020-09-30 Thread Steev Klimaszewski
t;); > + return -EINVAL; > + } > + > + props.type = BACKLIGHT_RAW; > + props.max_brightness = pdata->max_brightness; > + bl = devm_backlight_device_register(dev, "sn65dsi86", dev, pdata, > + _sn_backlight_ops, ); > + if (IS_ERR(bl)) { > + DRM_ERROR("failed to register backlight device\n"); > + return PTR_ERR(bl); > + } > + > + return 0; > +} > + > static int ti_sn_bridge_probe(struct i2c_client *client, > const struct i2c_device_id *id) > { > @@ -1224,6 +1353,12 @@ static int ti_sn_bridge_probe(struct i2c_client > *client, > > pm_runtime_enable(pdata->dev); > > + ret = ti_sn_backlight_init(pdata); > + if (ret) { > + pm_runtime_disable(pdata->dev); > + return ret; > + } > + > ret = ti_sn_setup_gpio_controller(pdata); > if (ret) { > pm_runtime_disable(pdata->dev); Tested-By: Steev Klimaszewski

Re: [PATCH] arm64: dts: sdm845: Fixup OPP table for all qup devices

2020-09-14 Thread Steev Klimaszewski
as well), but just in case its >>> useful: >>> Tested-by: John Stultz >> Hey Everyone, >> Just wanted to nag folks on this again as it is still missing from >> upstream and resolves a bluetooth regression from 5.9-rc1. > Hey Everyone, > Just your weekl

Re: [PATCH v2 0/4] remoteproc: Improvement for the Qualcomm sysmon

2020-11-12 Thread Steev Klimaszewski
, 109 insertions(+), 37 deletions(-) > Entire series tested on Lenovo Yoga C630 Tested-by: Steev Klimaszewski

Re: [PATCH v5 0/3] iommu/arm-smmu-qcom: Support maintaining bootloader mappings

2020-10-22 Thread Steev Klimaszewski
0 ++ > drivers/iommu/arm/arm-smmu/arm-smmu.c | 13 +++- > drivers/iommu/arm/arm-smmu/arm-smmu.h | 1 + > 3 files changed, 101 insertions(+), 3 deletions(-) > Tested series here on my Lenovo C630. Tested-by: Steev Klimaszewski

Re: [PATCH v2] venus: venc: Fix setting of profile and level

2020-10-29 Thread Steev Klimaszewski
On 10/27/20 4:19 AM, Stanimir Varbanov wrote: > The profile and level in op_set_ctrl was recently changed but during > v4l2_ctrl_handler_setup profile and level control values are mangled. > > Fixes: 435c53c3698f ("media: venus: venc: Use helper to set profile and > level") > Signed-off-by:

Re: [PATCH] arm64: dts: qcom: c630: Define eDP bridge and panel

2020-11-30 Thread Steev Klimaszewski
t; + > +_mdp { > + status = "okay"; > +}; > + > _pil { > firmware-name = "qcom/LENOVO/81JL/qcdsp1v2850.mbn", > "qcom/LENOVO/81JL/qcdsp2850.mbn"; > }; > > +_i2c10_default { > + pinconf { > + pins = "gpio55", "gpio56"; > + drive-strength = <2>; > + bias-disable; > + }; > +}; > + > _i2c12_default { > drive-strength = <2>; > bias-disable; > @@ -454,6 +548,12 @@ codec { > { > gpio-reserved-ranges = <0 4>, <81 4>; > > + sn65dsi86_pin_active: sn65dsi86-enable { > + pins = "gpio96"; > + drive-strength = <2>; > + bias-disable; > + }; > + > i2c3_hid_active: i2c2-hid-active { > pins = "gpio37"; > function = "gpio"; Tested-by: Steev Klimaszewski

Re: [PATCH] arm64: dts: qcom: c630: Expose LID events

2020-11-30 Thread Steev Klimaszewski
input-enable; > + bias-disable; > + }; > + > + mode_pin_active: mode-pin { > + pins = "gpio95"; > + function = "gpio"; > + > + input-enable; > + bias-disable; > + }; > }; > > { Tested-by: Steev Klimaszewski

Re: [PATCH] Revert "i2c: qcom-geni: Disable DMA processing on the Lenovo Yoga C630"

2020-11-30 Thread Steev Klimaszewski
et_dma_safe_msg_buf(msg, 32); > - > + dma_buf = i2c_get_dma_safe_msg_buf(msg, 32); > if (dma_buf) > geni_se_select_mode(se, GENI_SE_DMA); > else Tested-by: Steev Klimaszewski

Re: [PATCH] arm64: dts: qcom: c630: Re-enable apps_smmu

2020-11-30 Thread Steev Klimaszewski
dm850-lenovo-yoga-c630.dts > @@ -232,11 +232,6 @@ vreg_lvs2a_1p8: lvs2 { > }; > }; > > -_smmu { > - /* TODO: Figure out how to survive booting with this enabled */ > - status = "disabled"; > -}; > - > _pas { > firmware-name = "qcom/LENOVO/81JL/qccdsp850.mbn"; > status = "okay"; Tested-by: Steev Klimaszewski

Re: [PATCH v4 2/2] ASoC: qcom: Add support for playback recover after resume

2020-11-30 Thread Steev Klimaszewski
ent_driver = { > .mmap = lpass_platform_pcmops_mmap, > .pcm_construct = lpass_platform_pcm_new, > .pcm_destruct = lpass_platform_pcm_free, > + .suspend = lpass_platform_pcmops_suspend, > + .resume = lpass_platform_pcmops_resume, > > }; > Tested this series on a Lenovo Yoga C630 Tested-by: Steev Klimaszewski

Re: [PATCH] arm64: defconfig: Enable QCOM_SCM as builtin

2020-11-30 Thread Steev Klimaszewski
PI_FIRMWARE=y > CONFIG_INTEL_STRATIX10_SERVICE=y > CONFIG_INTEL_STRATIX10_RSU=m > +CONFIG_QCOM_SCM=y > CONFIG_EFI_CAPSULE_LOADER=y > CONFIG_IMX_SCU=y > CONFIG_IMX_SCU_PD=y Tested-by: Steev Klimaszewski

Re: [PATCH] arm64: defconfig: Enable TMPFS Posix ACL

2020-11-30 Thread Steev Klimaszewski
t; CONFIG_VFAT_FS=y > +CONFIG_TMPFS_POSIX_ACL=y > CONFIG_HUGETLBFS=y > CONFIG_CONFIGFS_FS=y > CONFIG_EFIVAR_FS=y Tested-by: Steev Klimaszewski

Re: [PATCH] arm64: defconfig: Enable HID multitouch

2020-11-30 Thread Steev Klimaszewski
IMPLE_CARD=m > CONFIG_SND_AUDIO_GRAPH_CARD=m > +CONFIG_HID_MULTITOUCH=m > CONFIG_I2C_HID=m > CONFIG_USB_CONN_GPIO=m > CONFIG_USB=y Tested-by: Steev Klimaszewski

Re: [PATCH] arm64: defconfig: Enable Qualcomm PON driver

2020-11-30 Thread Steev Klimaszewski
t; @@ -521,6 +521,7 @@ CONFIG_POWER_AVS=y > CONFIG_QCOM_CPR=y > CONFIG_ROCKCHIP_IODOMAIN=y > CONFIG_POWER_RESET_MSM=y > +CONFIG_POWER_RESET_QCOM_PON=m > CONFIG_POWER_RESET_XGENE=y > CONFIG_POWER_RESET_SYSCON=y > CONFIG_SYSCON_REBOOT_MODE=y Tested-by: Steev Klimaszewski

Re: [PATCH] arm64: dts: qcom: c630: Polish i2c-hid devices

2020-11-30 Thread Steev Klimaszewski
> - i2c2_hid_active: i2c2-hid-active { > + i2c3_hid_active: i2c2-hid-active { > pins = <37>; > function = "gpio"; > > @@ -435,7 +440,7 @@ i2c2_hid_active: i2c2-hid-active { > drive-strength = <2>; > }; > > - i2c6_hid_active: i2c6-hid-active { > + i2c5_hid_active: i2c5-hid-active { > pins = <125>; > function = "gpio"; > > @@ -444,7 +449,7 @@ i2c6_hid_active: i2c6-hid-active { > drive-strength = <2>; > }; > > - i2c12_hid_active: i2c12-hid-active { > + i2c11_hid_active: i2c11-hid-active { > pins = <92>; > function = "gpio"; > Tested-by: Steev Klimaszewski

Re: [PATCH] arm64: dts: qcom: c630: Fix pinctrl pins properties

2020-11-30 Thread Steev Klimaszewski
> + pins = "gpio92"; > function = "gpio"; > > input-enable; > @@ -459,7 +459,7 @@ i2c11_hid_active: i2c11-hid-active { > }; > > wcd_intr_default: wcd_intr_default { > - pins = <54>; > + pins = "gpio54"; > function = "gpio"; > > input-enable; Tested-by: Steev Klimaszewski

Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support

2020-06-23 Thread Steev Klimaszewski
On 6/23/20 1:51 AM, Kyuho Choi wrote: > Hi Avri, > > On 6/23/20, Avri Altman wrote: >>> AFAIK, this device are ufs 2.1. It's not support writebooster. >>> >>> I'd check latest linux scsi branch and ufshcd_wb_config function's >>> called without device capability check. >> Please grep

Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support

2020-06-24 Thread Steev Klimaszewski
On 6/23/20 8:53 PM, Stanley Chu wrote: > Hi Steev, > > Please help try below simple patch to see if above WriteBooster messages > can be eliminated. > > > --- > drivers/scsi/ufs/ufshcd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/ufs/ufshcd.c

Re: [PATCH] drm/msm/dpu: fix/enable 6bpc dither with split-lm

2020-07-19 Thread Steev Klimaszewski
uct dpu_hw_pingpong *c, > c->ops.poll_timeout_wr_ptr = dpu_hw_pp_poll_timeout_wr_ptr; > c->ops.get_line_count = dpu_hw_pp_get_line_count; > > - if (test_bit(DPU_PINGPONG_DITHER, ) && > - IS_SC7180_TARGET(c->hw.hwversion)) > + if (test_bit(DPU_PINGPONG_DITHER, )) > c->ops.setup_dither = dpu_hw_pp_setup_dither; > }; Sorry for taking so long to get around to testing this.  I was able to today, and it does reduce the banding to be less noticeable. Tested-by: Steev Klimaszewski Thanks! -- steev

Re: [PATCH v2] arm64: dts: qcom: sdm845: Add cpu OPP tables

2020-07-08 Thread Steev Klimaszewski
et clock: -2 If these aren't anything to worry about, you can throw my Tested-by on Tested-by: Steev Klimaszewski

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-09 Thread Steev Klimaszewski
On 7/9/20 9:14 PM, Doug Anderson wrote: Hi, On Thu, Jul 9, 2020 at 6:38 PM Doug Anderson wrote: Hi, On Thu, Jul 9, 2020 at 6:19 PM Steev Klimaszewski wrote: Hi Doug, I've been testing 5.8 and linux-next on the Lenovo Yoga C630, and with this patch applied, there is really bad banding

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-09 Thread Steev Klimaszewski
On 7/9/20 10:12 PM, Steev Klimaszewski wrote: On 7/9/20 9:14 PM, Doug Anderson wrote: Hi, On Thu, Jul 9, 2020 at 6:38 PM Doug Anderson wrote: Hi, On Thu, Jul 9, 2020 at 6:19 PM Steev Klimaszewski wrote: Hi Doug, I've been testing 5.8 and linux-next on the Lenovo Yoga C630

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-09 Thread Steev Klimaszewski
On 7/9/20 10:17 PM, Steev Klimaszewski wrote: On 7/9/20 10:12 PM, Steev Klimaszewski wrote: On 7/9/20 9:14 PM, Doug Anderson wrote: Hi, On Thu, Jul 9, 2020 at 6:38 PM Doug Anderson wrote: Hi, On Thu, Jul 9, 2020 at 6:19 PM Steev Klimaszewski wrote: Hi Doug, I've been testing 5.8

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-10 Thread Steev Klimaszewski
Hi, On 7/9/20 11:12 PM, Doug Anderson wrote: root@c630:~# bus=$(i2cdetect -l | grep sn65 | sed 's/i2c-\([0-9]*\).*$/\1/') root@c630:~# i2cdump ${bus} 0x50 i > edid WARNING! This program can confuse your I2C bus, cause data loss and worse! I will probe file /dev/i2c-16, address 0x50, mode i2c

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-10 Thread Steev Klimaszewski
On 7/10/20 9:47 AM, Doug Anderson wrote: > Hi, > > > But should I continue on this path, > It's probably worth getting dithering working on your sdm845 anyway in > case anyone actually does put a 6bpp panel on this SoC. > > >> or should we be finding others who >> have an N61 and see what their

Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support

2020-06-21 Thread Steev Klimaszewski
On 6/21/20 11:50 AM, Rob Clark wrote: > This looks like a device issue to be taken with the flash vendor: >> There's no way for a end-user to file a bug report with the flash vendor >> on a device bought from an OEM and even if they would accept the bug >> report they wouldn't re-provision the

Re: [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume

2021-03-30 Thread Steev Klimaszewski
On 3/22/21 4:17 AM, Kalyan Thota wrote: > From: Kalyan Thota > > DPU runtime resume will request for a min vote on the AXI bus as > it is a necessary step before turning ON the AXI clock. > > The change does below > 1) Move the icc path set before requesting runtime get_sync. > 2) remove the

Re: [Freedreno] [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume

2021-03-31 Thread Steev Klimaszewski
On 3/31/21 7:34 AM, kalya...@codeaurora.org wrote: > On 2021-03-31 00:04, Steev Klimaszewski wrote: >> On 3/22/21 4:17 AM, Kalyan Thota wrote: >>> From: Kalyan Thota >>> >>> DPU runtime resume will request for a min vote on the AXI bus as >>> it

Re: [PATCH v7 0/6] soc: qcom: add in-kernel pd-mapper implementation

2024-04-25 Thread Steev Klimaszewski
14 files changed, 1193 insertions(+), 302 deletions(-) > --- > base-commit: a59668a9397e7245b26e9be85d23f242ff757ae8 > change-id: 20240301-qcom-pd-mapper-e12d622d4ad0 > > Best regards, > -- > Dmitry Baryshkov > > I've tested this series over a large number of reboots, and the p-d devices(?) do always seem to come up (with the pd-mapper service disabled) on my Thinkpad X13s. One less service to run in userland! Tested-by: Steev Klimaszewski

Re: [PATCH v8 0/5] soc: qcom: add in-kernel pd-mapper implementation

2024-05-12 Thread Steev Klimaszewski
n Andersson > To: Konrad Dybcio > To: Sibi Sankar > To: Mathieu Poirier > Cc: linux-arm-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-remotep...@vger.kernel.org > Cc: Johan Hovold > Cc: Xilin Wu > Cc: "Bryan O'Donoghue" > Cc: Steev Klimaszew