[mpt3sas driver V1 6/10] mpt3sas: Added smp_affinity_enable module parameter.

Module parameter to enable/disable configuring affinity hint for msix vector. SMP affinity feature can be enabled/disabled by setting module parameter "smp_affinity_enable" to 1/0. By default this feature is enabled. (smp_affinity_enable = 1 enabled). Signed-off-by: Suganath prabu

[PATCH 1/1] mpt3sas: Fix - Remove cpumask_clear for zalloc_cpumask_var and dont free free_cpu_mask_var before reply_q

From: Suganath prabu Subramani <suganath-prabu.subram...@broadcom.com> Removed cpumask_clear as it is not required for zalloc_cpumask_var and free free_cpumask_var before freeing reply_q. Signed-off-by: Suganath prabu Subramani <suganath-prabu.subram...@broadcom.com> Signed-off-by:

Re: [mpt3sas driver 06/10] mpt3sas: Added smp_affinity_enable module parameter.

view comments for freeing reply_q and cpumask_var in this patch and sending it soon. Thanks, Suganath prabu S On Thu, Feb 4, 2016 at 8:31 PM, Tomas Henzl <the...@redhat.com> wrote: > On 28.1.2016 07:37, Suganath prabu Subaramani wrote: >> From: Suganath prabu Subramani <suganath-

[PATCH v2 2/2] Updating maintainers list for MPT FUSION DRIVERS.

From: Suganath prabu Subramani <suganath-prabu.subram...@avagotech.com> Updating maintainers list for MPT FUSION DRIVERS, broadcom support link and email id. Signed-off-by: Suganath prabu Subramani <suganath-prabu.subram...@avagotech.com> Signed-off-by: Chaitra P B <chaitra.basa.

[PATCH v2 1/2] mpt3sas: Free memory pools before retrying to allocate with different value.

From: Suganath prabu Subramani <suganath-prabu.subram...@avagotech.com> Deallocate resources before reallocating of the same in retry_allocation path of _base_allocate_memory_pools() Signed-off-by: Suganath prabu Subramani <suganath-prabu.subram...@avagotech.com> Signed-off-by:

Re: [PATCH 03/10] mpt3sas: Implement device_remove_in_progress check in IOCTL path

Hi Hannes, Please give us little more info on the third comment. It ll help us to understand better and incorporate required changes. Comment is "Why don't you need to check for the size of the bitmap here?" i have taken care of other two comments in this patch. > /* check if device is

Re: [PATCH 03/10] mpt3sas: Implement device_remove_in_progress check in IOCTL path

max devices it can support. So, there is No possibility that driver can add more devices than bitmap. Thanks, Suganath Prabu S On Tue, Oct 25, 2016 at 3:21 PM, Hannes Reinecke <h...@suse.de> wrote: > On 10/25/2016 11:19 AM, Suganath Prabu Subramani wrote: >> Hi Hannes, >> >&

Re: [PATCH 02/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

Hi Keith, We have made change and submitted V2 of patch set. Thanks, Suganath Prabu S On Wed, Jul 12, 2017 at 5:34 AM, Keith Busch wrote: > On Tue, Jul 11, 2017 at 01:55:02AM -0700, Suganath Prabu S wrote: >> +/** >> + * _base_check_pcie_native_sgl - This function is

Re: [PATCH 00/13]mpt3sas driver NVMe support:

Is there any update on this ? Will include linux-n...@lists.infradead.org in next version of this patch submission, if there is any change suggestion. Thanks, Suganath Prabu S On Thu, Jun 29, 2017 at 8:01 PM, Johannes Thumshirn wrote: > On Thu, Jun 29, 2017 at 07:49:01PM

Re: [PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128

Hi Elliott, We are maintaining NVMe drives as scsi device in mpt3sas driver. There are lot of firmware/hardware level dependencies and after lot of discussions we arrived this value (128). So, we prefer not to provide module parameter to change this at least for now. Thanks, Suganath Prabu S On

Re: [PATCH v2 00/13] mpt3sas driver NVMe support:

Is there any update on these patches ? Thanks, Suganath Prabu S On Fri, Jul 14, 2017 at 6:52 PM, Suganath Prabu S wrote: > Ventura Series controller are Tri-mode. The controller and > firmware are capable of supporting NVMe devices and > PCIe switches to

Re: [PATCH v3 03/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

Hi Martin, This code was added to detect holes, when we started testing with 4.9 kernel. when we disabled "use_blk_mq" and no merges, we are hitting issues with holes. Anyhow In latest upstream, it got fixed with this commit 5a8d75a1b8c99bdc926ba69b7b7dbe4fae81a5af So we are removing the code

Re: [PATCH v3 01/13] mpt3sas: Update MPI Header

Hi James, we have fixed the sparse warnings associated with this patch set and posting V4 of mpt3sas patches soon. We are also working on sparse error/warnings that existed before this patch set and we ll be posting it separately. Thanks, Suganath Prabu S On Wed, Aug 9, 2017 at 2:48 AM, J

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, On Fri, Sep 15, 2017 at 6:37 AM, Martin K. Petersen wrote: > > Suganath, > >> Is there any update on the submitted mpt3sas patches. > > We are waiting for you to report back your findings on PRP vs. SGL. We are working on this, since there is h/w

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, Is there any update on the submitted mpt3sas patches. Thanks, Suganath Prabu S On Fri, Sep 1, 2017 at 2:09 PM, Suganath Prabu Subramani <suganath-prabu.subram...@broadcom.com> wrote: > Hi Martin, > > On Fri, Sep 1, 2017 at 8:52 AM, Martin K. Petersen > <marti

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, On Fri, Sep 1, 2017 at 8:52 AM, Martin K. Petersen wrote: > > Hi Suganath, > >> Let me explain - NVME device fast path is possible in two ways. IEEE >> SGL and PRP SGL. Due to h/w constraint we choose IEEE SGL only for >> smaller IO size. Both above is

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, Replied in line. - I don't understand why you go through all these hoops to decide whether to use PRPs or IEEE scatterlists. If the firmware translation is slow, why even bother with the SG format in the first place? Set the max I/O size to match MDTS and you're done. => We

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, Replied inline. Thanks, Suganath Prabu S On Thu, Aug 31, 2017 at 8:35 AM, Martin K. Petersen wrote: > > Hi Suganath, > >> Theoretically we want to use h/w capability (to translate IEEE to PRP) >> for smaller IO size to leverage h/w capability. > > Nobody

Re: [v6 0/4] mpt3sas: Hot-Plug Surprise removal support on IOC.

Any update on this ? In V6, I have posted has only defect fixes (Other than HBA Hot-Plug Surprise remove support). We are reworking and incorporating the suggestions from Bjorn. And after covering tests, we ll post Hot-Plug Surprise removal patches. Thanks, Suganath Prabu On Tue, Oct 23, 2018 at

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, Replied in line. - I don't understand why you go through all these hoops to decide whether to use PRPs or IEEE scatterlists. If the firmware translation is slow, why even bother with the SG format in the first place? Set the max I/O size to match MDTS and you're done. => We

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, Replied inline. Thanks, Suganath Prabu S On Thu, Aug 31, 2017 at 8:35 AM, Martin K. Petersen wrote: > > Hi Suganath, > >> Theoretically we want to use h/w capability (to translate IEEE to PRP) >> for smaller IO size to leverage h/w capability. > > Nobody says we have to use the

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, On Fri, Sep 1, 2017 at 8:52 AM, Martin K. Petersen wrote: > > Hi Suganath, > >> Let me explain - NVME device fast path is possible in two ways. IEEE >> SGL and PRP SGL. Due to h/w constraint we choose IEEE SGL only for >> smaller IO size. Both above is true h/w Fast Path and no

Re: [PATCH v2 00/13] mpt3sas driver NVMe support:

Is there any update on these patches ? Thanks, Suganath Prabu S On Fri, Jul 14, 2017 at 6:52 PM, Suganath Prabu S wrote: > Ventura Series controller are Tri-mode. The controller and > firmware are capable of supporting NVMe devices and > PCIe switches to be connected with the controller. This >

Re: [PATCH v3 01/13] mpt3sas: Update MPI Header

Hi James, we have fixed the sparse warnings associated with this patch set and posting V4 of mpt3sas patches soon. We are also working on sparse error/warnings that existed before this patch set and we ll be posting it separately. Thanks, Suganath Prabu S On Wed, Aug 9, 2017 at 2:48 AM, J

Re: [PATCH v3 03/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

Hi Martin, This code was added to detect holes, when we started testing with 4.9 kernel. when we disabled "use_blk_mq" and no merges, we are hitting issues with holes. Anyhow In latest upstream, it got fixed with this commit 5a8d75a1b8c99bdc926ba69b7b7dbe4fae81a5af So we are removing the code

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, On Fri, Sep 15, 2017 at 6:37 AM, Martin K. Petersen wrote: > > Suganath, > >> Is there any update on the submitted mpt3sas patches. > > We are waiting for you to report back your findings on PRP vs. SGL. We are working on this, since there is h/w dependent, we are in discussion with

Re: [PATCH 02/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

Hi Keith, We have made change and submitted V2 of patch set. Thanks, Suganath Prabu S On Wed, Jul 12, 2017 at 5:34 AM, Keith Busch wrote: > On Tue, Jul 11, 2017 at 01:55:02AM -0700, Suganath Prabu S wrote: >> +/** >> + * _base_check_pcie_native_sgl - This function is called for PCIe end >>

Re: [PATCH 00/13]mpt3sas driver NVMe support:

Is there any update on this ? Will include linux-n...@lists.infradead.org in next version of this patch submission, if there is any change suggestion. Thanks, Suganath Prabu S On Thu, Jun 29, 2017 at 8:01 PM, Johannes Thumshirn wrote: > On Thu, Jun 29, 2017 at 07:49:01PM +0530, Suganath Prabu

Re: [PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128

Hi Elliott, We are maintaining NVMe drives as scsi device in mpt3sas driver. There are lot of firmware/hardware level dependencies and after lot of discussions we arrived this value (128). So, we prefer not to provide module parameter to change this at least for now. Thanks, Suganath Prabu S On

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, Is there any update on the submitted mpt3sas patches. Thanks, Suganath Prabu S On Fri, Sep 1, 2017 at 2:09 PM, Suganath Prabu Subramani wrote: > Hi Martin, > > On Fri, Sep 1, 2017 at 8:52 AM, Martin K. Petersen > wrote: >> >> Hi Suganath, >> >>

Re: [PATCH] mpt3sas_ctl: fix double-fetch bug in _ctl_ioctl_main()

Please consider this patch as Ack-by: Suganath Prabu S Thanks, Suganath. On Mon, May 27, 2019 at 6:27 AM Gen Zhang wrote: > > In _ctl_ioctl_main(), 'ioctl_header' is fetched the first time from > userspace. 'ioctl_header.ioc_number' is then checked. The legal result > is saved to 'ioc'. Then,

Re: [PATCH 7/8] mpt3sas: set an unlimited max_segment_size for SAS 3.0 HBAs

Please consider this as Acked-by: Suganath Prabu On Tue, Jun 18, 2019 at 6:16 AM Ming Lei wrote: > > On Mon, Jun 17, 2019 at 8:21 PM Christoph Hellwig wrote: > > > > When using a virt_boundary_mask, as done for NVMe devices attached to > > mpt3sas controllers we require an unlimited

Re: [PATCH 7/8] mpt3sas: set an unlimited max_segment_size for SAS 3.0 HBAs

Acked-by: Suganath Prabu On Thu, Jun 20, 2019 at 12:34 PM Suganath Prabu Subramani wrote: > > Please consider this as Acked-by: Suganath Prabu > > > > On Tue, Jun 18, 2019 at 6:16 AM Ming Lei wrote: > > > > On Mon, Jun 17, 2019 at 8:21 PM Christoph Hellwig

Re: [v6 0/4] mpt3sas: Hot-Plug Surprise removal support on IOC.

Any update on this ? In V6, I have posted has only defect fixes (Other than HBA Hot-Plug Surprise remove support). We are reworking and incorporating the suggestions from Bjorn. And after covering tests, we ll post Hot-Plug Surprise removal patches. Thanks, Suganath Prabu On Tue, Oct 23, 2018 at

Re: [PATCH 31/41] scsi: mpt3sas: mpt3sas_scsih: Mark expected switch fall-through

Hi Gustavo, This patch may not apply smoothly over 4.21/scsi-queue. Our previous patch for Aero had some changes in this switch case. Can you resend this patch with latest code base ? Thanks, Suganath prabu On Thu, Dec 20, 2018 at 5:37 AM Gustavo A. R. Silva wrote: > > Hi, > > Friendly ping:

Re: [PATCH 03/10] mpt3sas: Implement device_remove_in_progress check in IOCTL path

Hi Hannes, Please give us little more info on the third comment. It ll help us to understand better and incorporate required changes. Comment is "Why don't you need to check for the size of the bitmap here?" i have taken care of other two comments in this patch. > /* check if device is

Re: [PATCH 03/10] mpt3sas: Implement device_remove_in_progress check in IOCTL path

max devices it can support. So, there is No possibility that driver can add more devices than bitmap. Thanks, Suganath Prabu S On Tue, Oct 25, 2016 at 3:21 PM, Hannes Reinecke wrote: > On 10/25/2016 11:19 AM, Suganath Prabu Subramani wrote: >> Hi Hannes, >> >> Please give us littl

Re: [mpt3sas driver 06/10] mpt3sas: Added smp_affinity_enable module parameter.

view comments for freeing reply_q and cpumask_var in this patch and sending it soon. Thanks, Suganath prabu S On Thu, Feb 4, 2016 at 8:31 PM, Tomas Henzl wrote: > On 28.1.2016 07:37, Suganath prabu Subaramani wrote: >> From: Suganath prabu Subramani >> >> Module parameter

[mpt3sas driver V1 6/10] mpt3sas: Added smp_affinity_enable module parameter.

Module parameter to enable/disable configuring affinity hint for msix vector. SMP affinity feature can be enabled/disabled by setting module parameter "smp_affinity_enable" to 1/0. By default this feature is enabled. (smp_affinity_enable = 1 enabled). Signed-off-by: Suganath prabu

[PATCH v2 2/2] Updating maintainers list for MPT FUSION DRIVERS.

From: Suganath prabu Subramani Updating maintainers list for MPT FUSION DRIVERS, broadcom support link and email id. Signed-off-by: Suganath prabu Subramani Signed-off-by: Chaitra P B --- MAINTAINERS | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS

[PATCH v2 1/2] mpt3sas: Free memory pools before retrying to allocate with different value.

From: Suganath prabu Subramani Deallocate resources before reallocating of the same in retry_allocation path of _base_allocate_memory_pools() Signed-off-by: Suganath prabu Subramani Signed-off-by: Chaitra P B --- drivers/scsi/mpt3sas/mpt3sas_base.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 1/1] mpt3sas: Fix - Remove cpumask_clear for zalloc_cpumask_var and dont free free_cpu_mask_var before reply_q

From: Suganath prabu Subramani Removed cpumask_clear as it is not required for zalloc_cpumask_var and free free_cpumask_var before freeing reply_q. Signed-off-by: Suganath prabu Subramani Signed-off-by: Chaitra P B --- drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +-- 1 file changed, 1 insertion