from the bus. With the flag set to false, the bit algo will keep its
current behavior of raising SDA only once before receiving a full byte.
The flag also ensures that |acknak| is always called with SDA raised.
Signed-off-by: Thomas Zimmermann <t...@users.sourceforge.net>
---
drivers/i2c/alg
Hi
Am 12.05.2016 um 11:05 schrieb Wolfram Sang:
> Hi Thomas,
>
> On Wed, Apr 27, 2016 at 08:11:54PM +0200, Thomas Zimmermann wrote:
>> Some I2C adapters don't raise SDA by themselves when sending a bit. This
>> behavior can be seen with the DDC channel of SiS 300 graphics ca
Hi
Am 13.05.2016 um 12:33 schrieb Wolfram Sang:
>
>> I was playing with the DRM framework and an old SiS graphics card. I
>> discovered this issue while trying to read the EDID from the monitor.
>
> So, there is no upstream user yet?
No.
>> I have a few other SiS cards/models here and they
; for (i = first_fb_vc; i <= last_fb_vc; i++)
> set_con2fb_map(i, idx, 0);
>
> @@ -3177,6 +3186,8 @@ static int fbcon_fb_registered(struct fb_info *info)
> {
> int ret = 0, i, idx;
>
> + WARN_CONSOLE_UNLOCKED();
> +
> id
;
} while (data != 1);
ast_moutdwm(ast, 0x1e6e207c, 0x0800); /* clear fast reset */
}
--
2.18.4
___
dri-devel mailing list
dri-de...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Thomas
y.
Sorry for the breakage. Fixed in drm-misc-next.
Best regards
Thomas
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
OpenPGP_signature
Description: OpenP
nvolvement by
+* the driver.
*/
void (*output_poll_changed)(struct drm_device *dev);
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix I
, 2021 at 10:03:50AM +0100, Thomas Zimmermann wrote:
Could you please double-check that 3fb91f56aea4 ("drm/udl: Retrieve USB
device from struct drm_device.dev") works correctly
Checked again, it does not seem to leak.
and that 823efa922102
("drm/cma-helper: Remove empty drm_gem_c
Am 20.01.21 um 12:12 schrieb Gerd Hoffmann:
Signed-off-by: Gerd Hoffmann
Reviewed-by: Daniel Vetter
Acked-by: Thomas Zimmermann
---
drivers/gpu/drm/qxl/qxl_display.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c
b/drivers
->dumb_shadow_bo) {
Wrt to my comment on patch 2, this might be the place to unpin the BO.
+ drm_gem_object_put(>dumb_shadow_bo->tbo.base);
+ qdev->dumb_shadow_bo = NULL;
+ }
qxl_destroy_monitors_object(qdev);
}
--
Thomas Zimmermann
Graphics Driv
qxl_bo_unref();
list_del(>tv.head);
kfree(entry);
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
OpenPGP_signature
Description: OpenPGP digital signature
Hi
Am 18.01.21 um 14:23 schrieb Christian König:
Am 18.01.21 um 14:22 schrieb Eli Cohen:
On Mon, Jan 18, 2021 at 02:20:49PM +0100, Thomas Zimmermann wrote:
Hi
Am 18.01.21 um 14:16 schrieb Eli Cohen:
On Mon, Jan 18, 2021 at 10:30:56AM +0100, Thomas Zimmermann wrote:
Here's the patch against
Hi
Am 18.01.21 um 14:16 schrieb Eli Cohen:
On Mon, Jan 18, 2021 at 10:30:56AM +0100, Thomas Zimmermann wrote:
Here's the patch against the latest DRM tree. v5.11-rc3 should work as well.
I was able to reproduce the memory leak locally and found that the patch
fixes it. Please give it a try
(cc'ing dri-devel)
Hi
Am 14.01.21 um 16:15 schrieb Eli Cohen:
Hi Thomas,
After long bisecting I found that this patch,
commit 1086db71a1dbbfb32ffb42cf0d540b69956f951e
Author: Thomas Zimmermann
Date: Tue Nov 3 10:30:06 2020 +0100
drm/vram-helper: Remove invariant parameters from
||
old_vc4_state->pos2_offset != new_vc4_state->pos2_offset ||
old_vc4_state->ptr0_offset != new_vc4_state->ptr0_offset ||
- vc4_lbm_size(plane->state) != vc4_lbm_size(state))
+ vc4_lbm_size(plane->state) != vc4_lbm_size(new_plane_state))
Hi
Am 15.01.21 um 13:56 schrieb Maxime Ripard:
diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c
b/drivers/gpu/drm/imx/ipuv3-plane.c
index 8a4235d9d9f1..2cb09e9d9306 100644
--- a/drivers/gpu/drm/imx/ipuv3-plane.c
+++ b/drivers/gpu/drm/imx/ipuv3-plane.c
@@ -344,12 +344,12 @@ static const struct
}
-
if (!ast_dram_init_2500(ast))
drm_err(dev, "DRAM init failed !\n");
--
2.18.4
___
dri-devel mailing list
dri-de...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Thomas Zim
Hi
Am 18.01.21 um 10:13 schrieb Eli Cohen:
On Mon, Jan 18, 2021 at 08:54:07AM +0100, Thomas Zimmermann wrote:
Hi
Am 18.01.21 um 08:43 schrieb Christian König:
Hi Eli,
have you already tried using kmemleak?
This sounds like a leak of memory allocated using kmalloc(), so kmemleak
should
drv_resume(struct platform_device *dev)
>
> memcpy(fbdev->regs, , sizeof(struct au1100fb_regs));
>
> - if (fbdev->lcdclk)
> - clk_enable(fbdev->lcdclk);
> + clk_enable(fbdev->lcdclk);
>
> /* Unblank the LCD */
> au110
On Wed, 14 Oct 2020 08:49:20 + Xu Wang wrote:
> Because clk_prepare_enable() and clk_disable_unprepare() already checked
> NULL clock parameter, so the additional checks are unnecessary, just
> remove them.
>
> Signed-off-by: Xu Wang
Reviewed-by: Thomas Zimmermann
> --
On Wed, 14 Oct 2020 08:57:22 + Xu Wang wrote:
> Because clk_prepare_enable() and clk_disable_unprepare() already checked
> NULL clock parameter, so the additional checks are unnecessary, just
> remove them.
>
> Signed-off-by: Xu Wang
Reviewed-by: Thomas Zimmermann
> --
Hi
On Thu, 15 Oct 2020 17:00:17 +0800 Tian Tao wrote:
> Consistently Use the same style of variable type in hibmc_drm_drv.c and
> hibmc_drm_drv.h.
>
> Signed-off-by: Tian Tao
> Acked-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 +++
On Thu, 15 Oct 2020 10:08:27 +0200 Thomas Zimmermann
wrote:
> On Wed, 14 Oct 2020 08:49:20 + Xu Wang wrote:
>
> > Because clk_prepare_enable() and clk_disable_unprepare() already checked
> > NULL clock parameter, so the additional checks are unnecessary, ju
On Thu, 15 Oct 2020 10:08:27 +0200 Thomas Zimmermann
wrote:
> On Wed, 14 Oct 2020 08:49:20 + Xu Wang wrote:
>
> > Because clk_prepare_enable() and clk_disable_unprepare() already checked
> > NULL clock parameter, so the additional checks are unnecessary, ju
On Thu, 15 Oct 2020 10:10:15 +0200 Thomas Zimmermann
wrote:
> On Wed, 14 Oct 2020 08:57:22 + Xu Wang wrote:
>
> > Because clk_prepare_enable() and clk_disable_unprepare() already checked
> > NULL clock parameter, so the additional checks are unnecessary, ju
of
the design. To fix this, your application has to stop drawing when you
switch consoles.
Best regards
Thomas
>
> Thanks!
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
signature.asc
Description: OpenPGP digital signature
Hi
Am 09.10.20 um 14:16 schrieb stsp:
> 09.10.2020 14:59, Thomas Zimmermann пишет:
>> Fbdev exposes the video ram (or a shadow buffer of it) to all
>> applications. Only one can draw at the same time. It's a limitation of
>> the design. To fix this, your application has to
Hi
Am 09.10.20 um 15:19 schrieb stsp:
> 09.10.2020 15:58, Thomas Zimmermann пишет:
>> Hi
>>
>> Am 09.10.20 um 14:16 schrieb stsp:
>>> 09.10.2020 14:59, Thomas Zimmermann пишет:
>>>> Fbdev exposes the video ram (or a shadow buffer of it) to all
>>>
interrupts.CPU94.RES:Rescheduling_interrupts
> 264.50 ± 19% +26.2% 333.75 ± 9%
> interrupts.CPU94.TLB:TLB_shootdowns
> 255.00 ± 6% +37.3% 350.00 ± 8%
> interrupts.CPU95.TLB:TLB_shootdowns
> 309.50 ± 2% +17.0% 362.25 ± 7%
> interrupts.CPU96.TLB:TL
Hi
Am 26.08.20 um 09:55 schrieb Tian Tao:
> hibmc can only be used in ARM64 architectures, and mmu defaults to y
> in arch/arm64/Kconfig, so there is no need to add a dependency on mmu
> in hibmc's kconfig.
>
> Signed-off-by: Tian Tao
Reviewed-by: Thomas Zimmermann
> ---
+ drm_warn(dev, "Unexpected BIOS PInS size: %d expected: %d\n",
> pins_len, expected_length[version]);
> return;
> }
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409
Hi
Am 03.08.20 um 02:38 schrieb Tian Tao:
> patch #1 and #3 is clean up, patch #2 is for code refactoring
Sorry for all my reviews taking so long. Please merge patch #3 into
patch #2 and then the series is
Reviewed-by: Thomas Zimmermann
I noticed that hibmc use DRM_ERROR in several pla
t; drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 5 --
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 +
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 2 -
> 4 files changed, 15 insertions(+), 52 deletions(-)
>
--
Thomas Zimmermann
Graphics Driver Developer
SUS
> Reported-by: kernel test robot
Reviewed-by: Thomas Zimmermann
I pushed the patch to drm-misc-next, but forgot to add my R-b tag. If
anyone complains, it's my fault.
Best regards
Thomas
> ---
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 +
> 1 file changed, 1 i
x0802A4
> +
> +#define GPIO_SCL_MASK 0x1
> +#define GPIO_SDA_MASK 0x2
Weird indention.
> +
> +static void hibmc_set_i2c_signal(void *data, u32 mask, int value)
> +{
> + struct hibmc_connector *hibmc_connector = data;
> + struct hibmc_drm_private *priv = hibmc_connector->d
_connector_funcs,
> + DRM_MODE_CONNECTOR_VGA,
> + _connector->adapter);
> if (ret) {
> drm_err(dev, "failed to init connector: %d\n", ret);
>
.fill_modes = drm_helper_probe_single_connector_modes,
> - .destroy = drm_connector_cleanup,
> + .destroy = hibmc_connector_destroy,
> .reset = drm_atomic_helper_connector_reset,
> .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
> .atomic_d
>
> Signed-off-by: Peilin Ye
Acked-by: Thomas Zimmermann
> ---
> $ # Build-tested (Ubuntu 20.04)
> $ sudo apt install gcc-m68k-linux-gnu
> $ cp arch/m68k/configs/atari_defconfig .config
> $ make ARCH=m68k menuconfig
> $ make ARCH=m68k CROSS_COMPILE=m68k-linux-gnu- -j`
static const struct pci_device_id hibmc_pci_table[] = {
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
OpenPGP_signature
Description: OpenPGP digital signature
Hi
Am 28.12.20 um 08:35 schrieb Tian Tao:
The hibmc driver uses empty implementations for its encoders. Replace
the code with the generic simple encoder.
Signed-off-by: Tian Tao
Reviewed-by: Thomas Zimmermann
Thanks for the patch.
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
MSI failed: %d\n", ret);
} else {
- ret = devm_drm_irq_install(dev, dev->pdev->irq);
+ ret = drm_irq_install(dev, dev->pdev->irq);
if (ret)
drm_warn(dev, "install irq failed: %d\n", ret);
return mga_g200eh_set_plls(mdev, clock);
> - break;
> case G200_ER:
> return mga_g200er_set_plls(mdev, clock);
> + default:
No default case here. If one of the enum values is not handled by the
switch, the compiler should warn about it.
Best regards
Thomas
Hi
On 23.10.20 09:48, Bernard wrote:
>
>
> From: Thomas Zimmermann
> Date: 2020-10-23 15:13:30
> To: Bernard Zhao ,Dave Airlie ,David
> Airlie ,Daniel Vetter
> ,dri-de...@lists.freedesktop.org,linux-kernel@vger.kernel.org
> Cc: opensource.ker...@vivo.com
> S
and alignment slightly
messed up.
5.9.0 was ok.
I'm just guessing the two issues are related.
Sounds likely. But it would be lovely if you could bisect when
exactly the problem(s) started to both verify that, and just to
pinpoint the exact change..
I'm adding Thomas Zimmermann to the cc, because he did
Hi David
Am 18.11.20 um 23:01 schrieb David Laight:
From: Thomas Zimmermann
Sent: 18 November 2020 19:37
Hi
Am 18.11.20 um 19:10 schrieb Linus Torvalds:
On Wed, Nov 18, 2020 at 4:12 AM David Laight wrote:
I've got the 'splat' below during boot.
This is an 8-core C2758 Atom cpu using
void*. I wonder if this change wouldn't
result in a warning from the compiler.
Best regards
Thomas
pr_debug("allocating frame buffer %d * %d, got %p\n",
width, height, fb->fb.screen_base);
--
Thomas Zimmermann
Graphics Driver Devel
provide the output of
dmesg | grep drm
Best regards
Thomas
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT,
UK
Registration No: 1397386 (Wales)
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
}
>
> + pixels = info->screen_size * 8 / var->bits_per_pixel;
> if (var->xres_virtual < var->xres)
> var->xres_virtual = var->xres;
> /* use highest possible virtual resolution */
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
pixel;
> if (var->xres_virtual < var->xres)
> var->xres_virtual = var->xres;
> /* use highest possible virtual resolution */
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
: array subscript -98 is outside array
> bounds of 'struct list_head[1]' [-Warray-bounds]
>
> Use the normal list_for_each_entry instead.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Arnd Bergmann
Acked-by: Thomas Zimmermann
I'll add the pat
Hi
Am 20.11.20 um 11:51 schrieb David Laight:
From: Thomas Zimmermann
Sent: 20 November 2020 10:14
...
Is there any way to bisect through the parts of the
drm merge patch into v5.10-rc1 ?
That ought to be quicker (and less error prone) than
the bisect builds I was doing.
Note
Hi
Am 20.11.20 um 12:45 schrieb David Laight:
From: Thomas Zimmermann
Sent: 20 November 2020 11:27
...
You can use drm-tip for testing, where many of the DRM patches go through.
https://cgit.freedesktop.org/drm/drm-tip/
It's fairly up-to-date.
Any idea of tags either side
Hi
Am 20.11.20 um 13:53 schrieb David Laight:
From: Thomas Zimmermann
Sent: 20 November 2020 12:30
Am 20.11.20 um 12:45 schrieb David Laight:
From: Thomas Zimmermann
Sent: 20 November 2020 11:27
...
You can use drm-tip for testing, where many of the DRM patches go through.
https
/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -889,6 +889,7 @@ static int omap_dmm_probe(struct platform_device *dev)
> _dmm->refill_pa, GFP_KERNEL);
> if (!omap_dmm->refill_va) {
> dev_err(>dev, "could not allocate ref
et = drm_dev_register(drm, 0);
> if (ret)
> goto err_poll_fini;
>
> - drm_fbdev_generic_setup(drm, legacyfb_depth);
> -
This does not work well. fbdev is supposed to be another regular DRM
client. It has to be enabled after registering the DRM device.
I'd
Hi
Am 18.11.20 um 09:59 schrieb Daniel Vetter:
On Wed, Nov 18, 2020 at 9:10 AM Thomas Zimmermann wrote:
Hi
Am 17.11.20 um 16:52 schrieb Mark Jonas:
From: Leo Ruan
The generic fbdev has to be setup before enabling output polling.
Otherwise the fbdev client is not ready to handle delayed
t", not "unsigned long".
>
> Fixes: 222ec45f4c69dfa8 ("drm/fb_helper: Support framebuffers in I/O memory")
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Thomas Zimmermann
Thanks a lot. I'll add the patch to drm-misc-next.
> ---
> Interestingly, the commit lo
m/msm/adreno/adreno_gpu.c | 12 ++--
> 5 files changed, 14 insertions(+), 14 deletions(-)
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
< gpiod_count(dev, "atmel,power-control"); i++) {
> + ret = -ENOMEM;
I think that a better fix would have been to put it into the alloc's
error branch. But anyway
Reviewed-by: Thomas Zimmermann
Thanks for your patch. I'll add it to drm-misc-nex
ux/commits/Thomas-Zimmermann/drm-fb-helper-Various-fixes-and-cleanups/20201120-182750
in testcase: trinity
version: trinity-static-i386-x86_64-f93256fb_2019-08-28
with following parameters:
runtime: 300s
test-description: Trinity is a linux system call fuzz tester.
test
Hi
Am 24.11.20 um 02:58 schrieb Xing Zhengjun:
On 11/23/2020 4:04 PM, Thomas Zimmermann wrote:
Hi
Am 22.11.20 um 15:18 schrieb kernel test robot:
Greeting,
FYI, we noticed the following commit (built with gcc-9):
commit: 6a1b34c0a339fdc75d7932ad5702f2177c9d7a1c ("drm/fb-helper:
Hi
Am 24.11.20 um 02:58 schrieb Xing Zhengjun:
On 11/23/2020 4:04 PM, Thomas Zimmermann wrote:
Hi
Am 22.11.20 um 15:18 schrieb kernel test robot:
Greeting,
FYI, we noticed the following commit (built with gcc-9):
commit: 6a1b34c0a339fdc75d7932ad5702f2177c9d7a1c ("drm/fb-helper:
ibmc->dev->vram_mm)
+ struct drm_device *dev = >dev;
+
+ if (!dev->vram_mm)
return;
- drm_vram_helper_release_mm(hibmc->dev);
+ drm_vram_helper_release_mm(dev);
}
int hibmc_dumb_create(struct drm_file *file, struct drm_device *dev,
--
Thomas Zim
Hi
Am 01.12.20 um 13:26 schrieb tiantao (H):
在 2020/12/1 20:17, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 12:55 schrieb Tian Tao:
Assign local variable to struct drm_device *dev because they are
used multiple times within a function.
Signed-off-by: Tian Tao
---
drivers/gpu/drm/hisilicon
Hi
Am 01.12.20 um 14:05 schrieb tiantao (H):
在 2020/12/1 20:36, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 13:26 schrieb tiantao (H):
在 2020/12/1 20:17, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 12:55 schrieb Tian Tao:
Assign local variable to struct drm_device *dev because they are
used
Hi
Am 02.12.20 um 03:54 schrieb tiantao (H):
在 2020/12/2 10:06, tiantao (H) 写道:
在 2020/12/1 21:44, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 14:05 schrieb tiantao (H):
在 2020/12/1 20:36, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 13:26 schrieb tiantao (H):
在 2020/12/1 20:17, Thomas
q.h
@@ -28,5 +28,5 @@ struct drm_device;
int drm_irq_install(struct drm_device *dev, int irq);
int drm_irq_uninstall(struct drm_device *dev);
-
+int devm_drm_irq_install(struct drm_device *dev, int irq);
#endif
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany G
Am 02.12.20 um 09:47 schrieb Tian Tao:
Use the devm_drm_dev_alloc provided by the drm framework to alloc
a structure hibmc_drm_private.
Signed-off-by: Tian Tao
This looks good now. Thanks for sticking to it.
Acked-by: Thomas Zimmermann
---
drivers/gpu/drm/hisilicon/hibmc
Am 02.12.20 um 10:26 schrieb Tian Tao:
Add new api devm_drm_irq_install() to register interrupts,
no need to call drm_irq_uninstall() when the drm module is removed.
Signed-off-by: Tian Tao
Reviewed-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_irq.c | 32
Hi
Am 03.12.20 um 04:09 schrieb Tian Tao:
updated to use drmm_vram_helper_init()
Signed-off-by: Tian Tao
Reviewed-by: Thomas Zimmermann
As a good follow-up patch, I would suggest to get rig of the entire file
hibmc_ttm.c. drmm_vram_helper_init() can be called directly from
hibmc_load
gcc-9 ARCH=i386 INSTALL_MOD_PATH=
modules_install
cd
find lib/ | cpio -o -H newc --quiet | gzip > modules.cgz
git clone https://github.com/intel/lkp-tests.git
cd lkp-tests
bin/lkp qemu -k -m modules.cgz job-script # job-script is
attached in this email
Hi
Am 03.12.20 um 09:36 schrieb Oliver Sang:
On Thu, Dec 03, 2020 at 08:41:49AM +0100, Thomas Zimmermann wrote:
Hi
there should be a line in the kernel log that says something like "Damage
blitter failed" with an error code. Is there any chance of recovering it?
Hi Thomas,
w
Tao
Code changes look good.
Reviewed-by: Thomas Zimmermann
---
drivers/gpu/drm/hisilicon/hibmc/Makefile| 2 +-
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 21 ++-
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 4 --
drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c |
,
vram_size);
--
2.18.4
_______
dri-devel mailing list
dri-de...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germ
*dev = >dev;
+
+ if (!dev->vram_mm)
return;
- drm_vram_helper_release_mm(hibmc->dev);
+ drm_vram_helper_release_mm(dev);
That's OK for now. A good follow-up patchset is the conversion to
managed DRM helpers. We have these for modesetting, vram helpers and othe
+ ret = devm_add_action(dev->dev, devm_drm_irq_uninstall, dev);
+ if (ret)
+ devm_drm_irq_uninstall(dev);
This pattern can be replaced by devm_add_action_or_reset()
With my comments addressed,
Reviewed-by: Thomas Zimmermann
Best regards
Thomas
+
+
Hi
Am 26.11.20 um 14:05 schrieb Thomas Zimmermann:
Hi
Am 26.11.20 um 13:02 schrieb Tian Tao:
Use the devm_drm_dev_alloc provided by the drm framework to alloc
a struct hibmc_drm_private.
Signed-off-by: Tian Tao
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 +-
drivers/gpu/drm
Hi
Am 26.11.20 um 13:02 schrieb Tian Tao:
Use devm_drm_irq_install to register interrupts so that
drm_irq_uninstall is not called when hibmc is removed.
Signed-off-by: Tian Tao
Reviewed-by: Thomas Zimmermann
Thanks!
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 5 +
1
Hi
Am 24.11.20 um 17:27 schrieb David Laight:
From: David Laight
Sent: 20 November 2020 15:39
From: Thomas Zimmermann
Sent: 20 November 2020 13:42
...
I did a diff from v5.10-rc4 to drm-tip to look for suspicious changes.
Some candidates are
8e3784dfef8a ("drm/ast: Reload gamm
Hi
Am 24.11.20 um 17:27 schrieb David Laight:
From: David Laight
Sent: 20 November 2020 15:39
From: Thomas Zimmermann
Sent: 20 November 2020 13:42
...
I did a diff from v5.10-rc4 to drm-tip to look for suspicious changes.
Some candidates are
8e3784dfef8a ("drm/ast: Reload gamm
t there areno further changes required for AST2600.
>
> Signed-off-by: KuoHsiang Chou
Reviewed-by: Thomas Zimmermann
I'll add the patch to drm-misc-next. Thanks!
Best regards
Thomas
> ---
> drivers/gpu/drm/ast/ast_drv.h | 1 +
> drivers/gpu/drm/ast/ast_main.c | 5 -
> 2 fi
n ret;
> +}
> +EXPORT_SYMBOL(drm_connector_init_with_ddc);
> +
Thanks for including such a function.
Acked-by: Thomas Zimmermann
> /**
> * drm_connector_attach_edid_property - attach edid property.
> * @connector: the connector
> diff --git a/include/drm/drm_connector.
fset;
> - u8 __iomem *dst, __iomem *sig;
> + u8 __iomem *dst;
> + u8 __iomem *sig;
> u8 jreg;
>
> dst = ast->cursor.vaddr[ast->cursor.next_index];
>
> _______
> dri-devel mailing list
> dri-de...@lists
d the patchset, the patches
should contain the tag.
So
Reviewed-by: Thomas Zimmermann
for the whole series. If no one else has comments, it should be fine to
merge the patches by the end of the week.
Best regards
Thomas
>
> Tian Tao (4):
> drm/hisilicon: Use drm_err instead of DRM_
rm/hisilicon: Use drv_err instead of DRM_ERROR in hibmc_drm_de
> drm/hisilicon: Use drv_err instead of DRM_ERROR in hibmc_drm_drv
Series is
Reviewed-by: Thomas Zimmermann
>
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 14 +++---
> drivers/
Hi
Am 27.08.20 um 16:56 schrieb Mike Kravetz:
> On 8/27/20 2:16 AM, Thomas Zimmermann wrote:
>> Hi
>>
>> Am 26.08.20 um 10:58 schrieb kernel test robot:
>>> Greeting,
>>>
>>> FYI, we noticed a 26.2% improvement of vm-scalability.throughput due to
>
> Signed-off-by: Tian Tao
Acked-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
> b/drivers/gpu/drm/hisilicon/hibmc/hibmc_dr
Hi
Am 25.09.20 um 09:02 schrieb Thomas Zimmermann:
> Hi,
>
> just a few nits.
>
> Am 25.09.20 um 08:49 schrieb Tian Tao:
>> drm_framebuffer.h contains drm/drm_device.h and struct drm_device is
>
> contains -> includes
>
>> already declared in this file
Hi
Am 29.10.20 um 08:11 schrieb Tian Tao:
> Some constructs cannot be changed after being assigned a value,
> so add const declarations to invariant constructs.
>
> Signed-off-by: Tian Tao
Reviewed-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/hisilicon/hibmc/h
ctor)
> +{
> + connector->adapter.owner = THIS_MODULE;
> + connector->adapter.class = I2C_CLASS_DDC;
> + snprintf(connector->adapter.name, I2C_NAME_SIZE, "HIS i2c bit bus");
> + connector->adapter.dev.parent = _dev->pdev->dev;
> + i2c_set_adap
Am 22.09.20 um 09:03 schrieb Tian Tao:
> Use drm_get_edid to get the resolution, if that fails, set it to
> a fixed resolution. Rewrite the desrtoy callback function to release
> resources.
>
> Signed-off-by: Tian Tao
Reviewed-by: Thomas Zimmermann
> ---
> drivers/gp
igned-off-by: Tian Tao
Reviewed-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 22 +++---
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 5 ++---
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 4 ++--
> 3 files changed, 15 ins
Am 29.09.20 um 02:45 schrieb Tian Tao:
> The macro PADDING is no longer used. Delete it.
>
> Signed-off-by: Tian Tao
Reviewed-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/d
ct drm_crtc_state *old_state)
> {
> - unsigned int reg;
> + u32 reg;
> struct drm_device *dev = crtc->dev;
> struct hibmc_drm_private *priv = to_hibmc_drm_private(dev);
>
> @@ -446,15 +445,15 @@ static void hibmc_crtc_load_lut(struct drm_crtc *crtc)
>
ivate {
> /* hw */
> void __iomem *mmio;
> void __iomem *fb_map;
> - unsigned long fb_base;
> - unsigned long fb_size;
> + u64 fb_base;
> + u64 fb_size;
resource_size_t would be the correct type here.
With my comments addressed:
Ack
gt; @@ -513,7 +513,8 @@ struct drm_driver {
>
> void *__devm_drm_dev_alloc(struct device *parent, struct drm_driver *driver,
> size_t size, size_t offset);
> -
> +int devm_drm_irq_install(struct device *parent, struct drm_device *dev,
> +
Hi
Am 03.11.20 um 09:57 schrieb tiantao (H):
>
>
> 在 2020/11/3 15:56, Thomas Zimmermann 写道:
>> Hi
>>
>> Thanks, the code looks good already. There just are a few nits below.
>>
> Thanks for the help with the review code.
> Add the new api devm_drm_irq_
ion(parent, devm_drm_dev_irq_uninstall, dev);
>> +if (ret)
>> +devm_drm_dev_irq_uninstall(dev);
>> +
>> +return ret;
>> +}
>> +EXPORT_SYMBOL(devm_drm_irq_install);
>> +
>
> Shouldn't we tie the IRQ to the drm device (so with drmm_add_a
Hi
Am 03.11.20 um 11:55 schrieb Daniel Vetter:
> On Tue, Nov 03, 2020 at 11:38:32AM +0100, Maxime Ripard wrote:
>> On Tue, Nov 03, 2020 at 11:10:27AM +0100, Thomas Zimmermann wrote:
>>> Hi
>>>
>>> Am 03.11.20 um 10:52 schrieb Maxime Ripard:
>>>> On
Hi
Am 02.11.20 um 04:07 schrieb Bernard Zhao:
> In function drm_bridge_connector_get_modes_edid, drm_edid_is_valid
> will check weather (!edid), no need to check again in the if
> branch.
>
> Signed-off-by: Bernard Zhao
Reviewed-by: Thomas Zimmermann
Thanks! I'll add the pa
1 - 100 of 217 matches
Mail list logo
