Re: [PATCH v2 RESEND] ACPI: Add ACPI CPU hot-remove support

2012-10-31 Thread Toshi Kani
On Wed, 2012-10-31 at 23:27 +0100, Rafael J. Wysocki wrote: On Friday, October 19, 2012 01:09:53 PM Toshi Kani wrote: Added CPU hot-remove support through an ACPI eject notification. It calls acpi_bus_hot_remove_device(), which shares the same code path with the sysfs eject operation

[PATCH v3 0/2] ACPI: CPU hot-remove support

2012-11-01 Thread Toshi Kani
, such as the processor driver. The patchset is based on the current Linus's tree. v3: - Added patch 1/2 to export functions for hot-remove v2: - Rebased to the latest baseline --- Toshi Kani (2): ACPI: Export functions for hot-remove ACPI: Add ACPI CPU hot-remove support --- drivers/acpi/osl.c

[PATCH v3 1/2] ACPI: Export functions for hot-remove

2012-11-01 Thread Toshi Kani
Exported acpi_os_hotplug_execute() and acpi_bus_hot_remove_device() so that they can be called from modules for hot-remove operations. Signed-off-by: Toshi Kani toshi.k...@hp.com --- drivers/acpi/osl.c | 1 + drivers/acpi/scan.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/acpi

[PATCH v3 2/2] ACPI: Add ACPI CPU hot-remove support

2012-11-01 Thread Toshi Kani
eject requests. Signed-off-by: Toshi Kani toshi.k...@hp.com Reviewed-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Tested-by: IgorMammedov imamm...@redhat.com Tested-by: Vijay Mohan Pandarathil vijaymohan.pandarat...@hp.com Tested-by: Prarit Bhargava pra...@redhat.com --- drivers/acpi

Re: [PATCH v3 3/3] Improve container_notify_cb() to support container hot-remove.

2012-11-01 Thread Toshi Kani
On Wed, 2012-10-31 at 15:27 +0800, Tang Chen wrote: This patch introduces a new function container_device_remove() to do the container hot-remove job. It works like the following: 1. call acpi_bus_trim(device, 0) to stop the container device, which means to unbind ACPI drivers first

Re: [PATCH v3 3/3] Improve container_notify_cb() to support container hot-remove.

2012-11-01 Thread Toshi Kani
On Thu, 2012-11-01 at 11:28 -0700, Yinghai Lu wrote: On Thu, Nov 1, 2012 at 9:43 AM, Toshi Kani toshi.k...@hp.com wrote: Rafael pointed out in my CPU hot-remove patch that acpi_bus_hot_remove_device() was not exported for modules. Looks like you have the same problem here. FYI, I just

Re: [PATCH v3 3/3] Improve container_notify_cb() to support container hot-remove.

2012-11-01 Thread Toshi Kani
Hi Yinghai, Per the following thread, the code seems to be written in this way to allocate a separate lock_class_key for each work queue. It should have had some comment to explain this, though. https://lkml.org/lkml/2009/12/13/304 The code has evolved since then,

Re: [PATCH v3 0/2] ACPI: CPU hot-remove support

2012-11-02 Thread Toshi Kani
On Fri, 2012-11-02 at 13:46 +0100, Rafael J. Wysocki wrote: On Thursday, November 01, 2012 08:42:11 AM Toshi Kani wrote: This patchset adds support of CPU hot-remove via an ACPI eject notification to the ACPI processor driver. The CPU hot-remove operation shares the same code path

[PATCH v5 RESEND 0/5] ACPI: hotplug messages improvement

2012-11-06 Thread Toshi Kani
in acpi_printk(). - Added more descriptions to the change log of patch 1/4. v2: - Set buffer.pointer to NULL in acpi_printk(). - Added acpi_pr_debug(). --- Toshi Kani (5): ACPI: Add acpi_pr_level() interfaces ACPI: Update CPU hotplug error messages ACPI: Update Memory hotplug error messages ACPI

[PATCH v5 RESEND 2/5] ACPI: Update CPU hotplug error messages

2012-11-06 Thread Toshi Kani
Updated CPU hotplug error messages with acpi_pr_level(), dev_level() and pr_level(). Modified some messages for clarity. Added error status / id info to the messages where needed. Signed-off-by: Toshi Kani toshi.k...@hp.com Tested-by: Vijay Mohan Pandarathil vijaymohan.pandarat...@hp.com

[PATCH v5 RESEND 5/5] ACPI: Update Dock hotplug error messages

2012-11-06 Thread Toshi Kani
Updated Dock hotplug error messages with acpi_pr_level() and pr_level(). Replaced acpi_get_name() kfree() with apci_pr_level(). Added error status to the messages where needed. Signed-off-by: Toshi Kani toshi.k...@hp.com --- drivers/acpi/dock.c | 29 + 1 file

[PATCH v5 RESEND 4/5] ACPI: Update Container hotplug error messages

2012-11-06 Thread Toshi Kani
Updated Container hotplug error messages with acpi_pr_level() and pr_level(). Removed an unnecessary check to device pointer in acpi_container_add(). Signed-off-by: Toshi Kani toshi.k...@hp.com --- drivers/acpi/container.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff

[PATCH v5 RESEND 1/5] ACPI: Add acpi_pr_level() interfaces

2012-11-06 Thread Toshi Kani
]() are intended for the ACPICA and are not associated with the kernel message level. Signed-off-by: Toshi Kani toshi.k...@hp.com Tested-by: Vijay Mohan Pandarathil vijaymohan.pandarat...@hp.com --- drivers/acpi/utils.c| 34 ++ include/acpi/acpi_bus.h | 31

[PATCH v5 RESEND 3/5] ACPI: Update Memory hotplug error messages

2012-11-06 Thread Toshi Kani
Updated Memory hotplug error messages with acpi_pr_level(), dev_level() and pr_level(). Signed-off-by: Toshi Kani toshi.k...@hp.com --- drivers/acpi/acpi_memhotplug.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/acpi/acpi_memhotplug.c b

[PATCH v3 0/4] ACPI: Refactor system notify handling

2012-11-08 Thread Toshi Kani
: - Fixed to free the ID list when releasing a temporary device. v2: - Protected unbound driver from unloading when calling .sys_notify. - Changed acpi_bus_notify() to call acpi_bus_notify_list first for maintaining the original order. --- Toshi Kani (4): ACPI: Support system notify handler via

[PATCH v3 1/4] ACPI: Support system notify handler via .sys_notify

2012-11-08 Thread Toshi Kani
maintain backward compatibility for ACPI drivers. Any drivers registered their hotplug handler through the existing interfaces, such as acpi_install_notify_handler() and register_acpi_bus_notifier(), will continue to work as before. Signed-off-by: Toshi Kani toshi.k...@hp.com --- drivers/acpi/bus.c

[PATCH v3 3/4] ACPI: Update acpi_memhotplug to use .sys_notify

2012-11-08 Thread Toshi Kani
Changed the ACPI memory hotplug driver to use .sys_notify. Removed ACPI namespace walks and their call-back functions that register and unregister the hotplug handler to all memory device objects through acpi_[install|remove]_notify_handler(). Signed-off-by: Toshi Kani toshi.k...@hp.com

[PATCH v3 2/4] ACPI: Update processor_driver to use .sys_notify

2012-11-08 Thread Toshi Kani
Changed the ACPI processor driver to use .sys_notify. Removed ACPI namespace walks and their call-back functions that register and unregister the hotplug handler to all processor objects through acpi_[install|remove]_notify_handler(). Signed-off-by: Toshi Kani toshi.k...@hp.com --- drivers/acpi

[PATCH v3 4/4] ACPI: Update container to use .sys_notify

2012-11-08 Thread Toshi Kani
() for consistency. Signed-off-by: Toshi Kani toshi.k...@hp.com --- drivers/acpi/container.c | 77 ++-- 1 file changed, 3 insertions(+), 74 deletions(-) diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c index 69e2d6b..d4e8b71 100644 --- a/drivers/acpi

[PATCH v2 RESEND] ACPI: Add ACPI CPU hot-remove support

2012-10-19 Thread Toshi Kani
-by: Toshi Kani toshi.k...@hp.com Reviewed-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Tested-by: IgorMammedov imamm...@redhat.com Tested-by: Vijay Mohan Pandarathil vijaymohan.pandarat...@hp.com Tested-by: Prarit Bhargava pra...@redhat.com --- v2: Rebased to the current Linus's tree. --- drivers

Re: [PATCH v2 2/2] Improve container_notify_cb() to support container hot-remove.

2012-10-24 Thread Toshi Kani
On Wed, 2012-10-24 at 14:05 +0800, Tang Chen wrote: This patch introduces a new function container_device_remove() to do the container hot-remove job. It works like the following: 1. call acpi_bus_trim(device, 0) to stop the container device. 2. generate the KOBJ_OFFLINE uevent. (Did I do

Re: [PATCH 1/2] Use kacpi_hotplug_wq to handle container hotplug event.

2012-10-24 Thread Toshi Kani
On Tue, 2012-10-23 at 21:10 +0800, Tang Chen wrote: As the comments in __acpi_os_execute() said: We can't run hotplug code in keventd_wq/kacpid_wq/kacpid_notify_wq because the hotplug code may call driver .remove() functions, which invoke

Re: [PATCH v2] ACPI: Add ACPI CPU hot-remove support

2012-10-09 Thread Toshi Kani
Hi Len, Can you please review this patch? Please let me know if there is anything I need to do for 3.7. Thanks, -Toshi On Fri, 2012-08-24 at 14:54 -0600, Toshi Kani wrote: Added CPU hot-remove support through an ACPI eject notification. It calls acpi_bus_hot_remove_device(), which shares

Re: [PATCH] ACPI: dock: Remove redundant ACPI NS walk

2012-10-09 Thread Toshi Kani
Hi Len, Can you please review this patch? Please let me know if there is anything I need to do for 3.7. Thanks, -Toshi On Wed, 2012-09-12 at 14:30 -0600, Toshi Kani wrote: Combined two ACPI namespace walks, which look for dock stations and then bays separately, into a single walk. Signed

Re: [PATCH v5 0/5] ACPI: hotplug messages improvement

2012-10-09 Thread Toshi Kani
Hi Len, Can you please review this patch? Please let me know if there is anything I need to do for 3.7. Thanks, -Toshi On Tue, 2012-08-28 at 13:02 -0600, Toshi Kani wrote: This patchset improves logging messages for ACPI CPU, Memory, Container and Dock hotplug notify handlers

Re: [PATCH v2 0/4] ACPI: Refactor system notify handling

2012-10-09 Thread Toshi Kani
Hi Len, Can you please review this patchset? Please let me know if you have any concern/question. Thanks, -Toshi On Thu, 2012-09-06 at 17:40 -0600, Toshi Kani wrote: This patchset updates the ACPI system-level (ex. hotplug) notify handling with a new .sys_notify interface. It provides

Re: acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-10-09 Thread Toshi Kani
On Tue, 2012-10-09 at 17:48 +0900, Yasuaki Ishimatsu wrote: acpi_bus_trim() stops removing devices, when acpi_bus_remove() return error number. But acpi_bus_remove() cannot return error number correctly. acpi_bus_remove() only return -EINVAL, when dev argument is NULL. Thus even if device

Re: acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-10-10 Thread Toshi Kani
On Wed, 2012-10-10 at 10:07 +0900, Yasuaki Ishimatsu wrote: : if (acpi_drv) { if (acpi_drv-ops.notify) acpi_device_remove_notify_handler(acpi_dev); THIS CALL - if (acpi_drv-ops.remove) - acpi_drv-ops.remove(acpi_dev,

Re: [PATCH] ACPI: dock: Remove redundant ACPI NS walk

2012-10-10 Thread Toshi Kani
On Wed, 2012-10-10 at 10:14 +0900, Yasuaki Ishimatsu wrote: Hi Toshi, Sorry for late reply. 2012/09/13 5:30, Toshi Kani wrote: Combined two ACPI namespace walks, which look for dock stations and then bays separately, into a single walk. Signed-off-by: Toshi Kani toshi.k...@hp.com

Re: [PATCH v2] acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-10-11 Thread Toshi Kani
. Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Thanks for the update. Looks good. Reviewed-by: Toshi Kani toshi.k...@hp.com -Toshi --- drivers/acpi/scan.c| 21 ++--- drivers/base/dd.c | 22 +- include/linux/device.h |2

Re: [PATCH v2] ACPI: Add ACPI CPU hot-remove support

2012-10-11 Thread Toshi Kani
Hi Len, This patch has been waiting for your review for 4 months. (v2 simply rebased.) Is there any thing I need to do? Thanks, -Toshi On Tue, 2012-10-09 at 07:43 -0600, Toshi Kani wrote: Hi Len, Can you please review this patch? Please let me know if there is anything I need to do

Re: [PATCH v5 0/5] ACPI: hotplug messages improvement

2012-10-11 Thread Toshi Kani
Hi Len, Can you please review this patchset? Thanks, -Toshi On Tue, 2012-10-09 at 07:42 -0600, Toshi Kani wrote: Hi Len, Can you please review this patch? Please let me know if there is anything I need to do for 3.7. Thanks, -Toshi On Tue, 2012-08-28 at 13:02 -0600, Toshi Kani

Re: [PATCH] ACPI: dock: Remove redundant ACPI NS walk

2012-10-11 Thread Toshi Kani
Hi Len, Can you please review this patch? Thanks, -Toshi On Wed, 2012-10-10 at 07:20 -0600, Toshi Kani wrote: On Wed, 2012-10-10 at 10:14 +0900, Yasuaki Ishimatsu wrote: Hi Toshi, Sorry for late reply. 2012/09/13 5:30, Toshi Kani wrote: Combined two ACPI namespace walks, which

Re: [PATCH v2 0/4] ACPI: Refactor system notify handling

2012-10-11 Thread Toshi Kani
Hi Len, Can you please review this patchset? Thanks, -Toshi On Tue, 2012-10-09 at 07:55 -0600, Toshi Kani wrote: Hi Len, Can you please review this patchset? Please let me know if you have any concern/question. Thanks, -Toshi On Thu, 2012-09-06 at 17:40 -0600, Toshi Kani wrote

Re: How to install linux kernel-2.4.18-14 in fedora 7

2012-10-11 Thread Toshi Kani
On Thu, 2012-10-11 at 19:40 +0530, Thirumalesha N wrote: Dear Sir, I'm new to linux, is there any possibility to install kernel-2.4.18-14 in fedora 7?. If not in which fedora version i can install this kernel? and if yes how do i proceed ? I do not know the answer, but you can

Re: [PATCH 2/2] ACPI: Remove unused lockable in acpi_device_flags

2012-10-25 Thread Toshi Kani
On Thu, 2012-10-25 at 00:08 +0200, Rafael J. Wysocki wrote: On Wednesday 17 of October 2012 07:56:49 Toshi Kani wrote: On Wed, 2012-10-17 at 10:26 +0900, Yasuaki Ishimatsu wrote: 2012/10/16 1:34, Toshi Kani wrote: Removed lockable in struct acpi_device_flags since it is no longer

Re: [PATCH v2 2/2] Improve container_notify_cb() to support container hot-remove.

2012-10-25 Thread Toshi Kani
On Thu, 2012-10-25 at 09:47 +0800, Jiang Liu wrote: On 2012-10-25 9:31, Tang Chen wrote: Hi Toshi, On 10/25/2012 01:14 AM, Toshi Kani wrote: On Wed, 2012-10-24 at 14:05 +0800, Tang Chen wrote: +static int container_device_remove(struct acpi_device *device) +{ +int ret

Re: [PATCH v3 3/3] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove()

2012-10-26 Thread Toshi Kani
On Fri, 2012-10-26 at 18:31 +0800, we...@cn.fujitsu.com wrote: From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com The memory device can be removed by 2 ways: 1. send eject request by SCI 2. echo 1 /sys/bus/pci/devices/PNP0C80:XX/eject In the 1st case, acpi_memory_disable_device() will

Re: [PATCH v2 2/2] Improve container_notify_cb() to support container hot-remove.

2012-10-26 Thread Toshi Kani
On Fri, 2012-10-26 at 13:43 +0800, Tang Chen wrote: Hi Toshi, On 10/26/2012 01:20 AM, Toshi Kani wrote: ... Why do you need to call acpi_bus_trim(device,0) to stop the container device first? This issue was introduced by Lu Yinghai, I think he could give a better answer than me

Re: [PATCH v3 3/3] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove()

2012-10-29 Thread Toshi Kani
On Mon, 2012-10-29 at 06:16 +, Wen Congyang wrote: At 10/27/2012 01:14 AM, Toshi Kani Wrote: On Fri, 2012-10-26 at 18:31 +0800, we...@cn.fujitsu.com wrote: From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com The memory device can be removed by 2 ways: 1. send eject request by SCI

Re: [Patch v4 1/7] acpi,memory-hotplug: introduce a mutex lock to protect the list in acpi_memory_device

2012-11-12 Thread Toshi Kani
On Thu, 2012-11-08 at 19:04 +0800, Wen Congyang wrote: The memory device can be removed by 2 ways: 1. send eject request by SCI 2. echo 1 /sys/bus/pci/devices/PNP0C80:XX/eject This 2 events may happen at the same time, so we may touch acpi_memory_device.res_list at the same time. This patch

[PATCH 1/2] ACPI: Fix stale pointer access to flags.lockable

2012-10-15 Thread Toshi Kani
_LCK method. Fix the stable pointer access by replacing it with acpi_get_handle() to check if _LCK is implemented. Signed-off-by: Toshi Kani toshi.k...@hp.com --- drivers/acpi/scan.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c

[PATCH 2/2] ACPI: Remove unused lockable in acpi_device_flags

2012-10-15 Thread Toshi Kani
Removed lockable in struct acpi_device_flags since it is no longer used by any code. acpi_bus_hot_remove_device() cannot use this flag because acpi_bus_trim() frees up its acpi_device object. Furthermore, the dock driver calls _LCK method without using this lockable flag. Signed-off-by: Toshi

Re: [PATCH] [resend] ACPI: Fix memory leak in acpi_bind_one() (fwd)

2012-10-15 Thread Toshi Kani
-by: Jesper Juhl j...@chaosbits.net Looks good. Reviewed-by: Toshi Kani toshi.k...@hp.com -Toshi --- drivers/acpi/glue.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c index d1a2d74..0837308 100644 --- a/drivers/acpi/glue.c

Re: [PATCH 1/2] ACPI: Fix stale pointer access to flags.lockable

2012-10-17 Thread Toshi Kani
On Wed, 2012-10-17 at 10:25 +0900, Yasuaki Ishimatsu wrote: 2012/10/16 1:34, Toshi Kani wrote: During hot-remove, acpi_bus_hot_remove_device() calls ACPI _LCK method when device-flags.lockable is set. However, this device pointer is stale since the target acpi_device object has been

Re: [PATCH 2/2] ACPI: Remove unused lockable in acpi_device_flags

2012-10-17 Thread Toshi Kani
On Wed, 2012-10-17 at 10:26 +0900, Yasuaki Ishimatsu wrote: 2012/10/16 1:34, Toshi Kani wrote: Removed lockable in struct acpi_device_flags since it is no longer used by any code. acpi_bus_hot_remove_device() cannot use this flag because acpi_bus_trim() frees up its acpi_device object

Re: [PATCH v4 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-13 Thread Toshi Kani
, the system may not work well. Reviewed-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Thanks for the update. It looks good. Reviewed-by: Toshi Kani toshi.k...@hp.com --- drivers/acpi/processor_driver.c | 18

Re: [PATCH v4 2/3] acpi : prevent cpu from becoming online

2012-07-13 Thread Toshi Kani
task brought the CPU back online\n, pr-id); Other than that, Reviewed-by: Toshi Kani toshi.k...@hp.com Thanks, -Toshi + return -EAGAIN; + } arch_unregister_cpu(pr-id); acpi_unmap_lsapic(pr-id); + put_online_cpus(); return ret

Re: [PATCH v4 3/3] acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-07-13 Thread Toshi Kani
On Fri, 2012-07-13 at 17:53 +0900, Yasuaki Ishimatsu wrote: acpi_bus_trim() stops removing devices, when acpi_bus_remove() return error number. But acpi_bus_remove() cannot return error number correctly. acpi_bus_remove() only return -EINVAL, when dev argument is NULL. Thus even if device

RE: [PATCH] ACPI: Add ACPI CPU hot-remove support

2012-07-16 Thread Toshi Kani
the same code path with the sysfs eject operation. acpi_os_hotplug_execute() serializes hot-remove operations between ACPI hot-remove and sysfs eject requests. Signed-off-by: Toshi Kani toshi.k...@hp.com --- This patch applies on top of the patchset below. [PATCH v6 0/6] ACPI: Add _OST

Re: [PATCH v6 0/6] ACPI: Add _OST support for ACPI hotplug

2012-07-16 Thread Toshi Kani
. - Reordered patchset to enable _OST support bit of _OSC in the last patch. --- Toshi Kani (6): ACPI: Add an interface to evaluate _OST ACPI: Add _OST support for sysfs eject ACPI: Add _OST support for ACPI CPU hotplug ACPI: Add _OST support for ACPI memory hotplug ACPI: Add

[PATCH 0/4] ACPI: hotplug messages improvement

2012-07-18 Thread Toshi Kani
. This improves diagnostics in hotplug operations since it identifies an object that caused an issue in a log file. --- This patchset applies on top of the patch below. [PATCH] ACPI: Add ACPI CPU hot-remove support http://marc.info/?l=linux-acpim=134098193327362w=2 --- Toshi Kani (4): ACPI: Add

[PATCH 4/4] ACPI: Update Container hotplug messages

2012-07-18 Thread Toshi Kani
Updated Container hotplug log messages with acpi_pr_level() and pr_level(). Signed-off-by: Toshi Kani toshi.k...@hp.com --- drivers/acpi/container.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c index 01a986d

[PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-18 Thread Toshi Kani
acpi_pr_err(handle, Device don't exist, dropping EJECT\n); logs an error message like this: ACPI: \_SB_.SCK4.CPU4: Device don't exist, dropping EJECT Signed-off-by: Toshi Kani toshi.k...@hp.com --- drivers/acpi/utils.c| 32 include/acpi/acpi_bus.h | 18

[PATCH 2/4] ACPI: Update CPU hotplug messages

2012-07-18 Thread Toshi Kani
Updated CPU hotplug log messages with acpi_pr_level(), dev_level() and pr_level(). Some messages are also changed for clarity. Signed-off-by: Toshi Kani toshi.k...@hp.com --- drivers/acpi/processor_driver.c | 36 +--- 1 files changed, 21 insertions(+), 15

[PATCH 3/4] ACPI: Update Memory hotplug messages

2012-07-18 Thread Toshi Kani
Updated Memory hotplug log messages with acpi_pr_level() and pr_level(). Signed-off-by: Toshi Kani toshi.k...@hp.com --- drivers/acpi/acpi_memhotplug.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-18 Thread Toshi Kani
On Wed, 2012-07-18 at 14:21 -0700, Joe Perches wrote: On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: This patch introduces acpi_pr_level(), where level is a message level such as err/warn/info, to support improved logging messages for ACPI, esp. in hotplug operations. acpi_pr_level

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-18 Thread Toshi Kani
On Wed, 2012-07-18 at 14:27 -0700, Joe Perches wrote: On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: This patch introduces acpi_pr_level(), where level is a message level such as err/warn/info, to support improved logging messages for ACPI, esp. in hotplug operations. One more note

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-18 Thread Toshi Kani
On Wed, 2012-07-18 at 14:54 -0700, Joe Perches wrote: On Wed, 2012-07-18 at 15:41 -0600, Toshi Kani wrote: On Wed, 2012-07-18 at 14:21 -0700, Joe Perches wrote: On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: This patch introduces acpi_pr_level(), where level is a message level

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-18 Thread Toshi Kani
On Wed, 2012-07-18 at 15:06 -0700, Joe Perches wrote: On Wed, 2012-07-18 at 15:41 -0600, Toshi Kani wrote: On Wed, 2012-07-18 at 14:27 -0700, Joe Perches wrote: On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: This patch introduces acpi_pr_level(), where level is a message level

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-18 Thread Toshi Kani
On Wed, 2012-07-18 at 15:59 -0600, Shuah Khan wrote: On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: This patch introduces acpi_pr_level(), where level is a message level such as err/warn/info, to support improved logging messages for ACPI, esp. in hotplug operations. acpi_pr_level

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-18 Thread Toshi Kani
On Wed, 2012-07-18 at 16:40 -0600, Shuah Khan wrote: On Wed, 2012-07-18 at 16:26 -0600, Toshi Kani wrote: On Wed, 2012-07-18 at 15:59 -0600, Shuah Khan wrote: On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: This patch introduces acpi_pr_level(), where level is a message level

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-18 Thread Toshi Kani
On Wed, 2012-07-18 at 15:49 -0700, Joe Perches wrote: On Wed, 2012-07-18 at 16:26 -0600, Toshi Kani wrote: On Wed, 2012-07-18 at 15:59 -0600, Shuah Khan wrote: On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: This patch introduces acpi_pr_level(), where level is a message level

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-18 Thread Toshi Kani
On Wed, 2012-07-18 at 17:18 -0600, Shuah Khan wrote: On Wed, 2012-07-18 at 16:52 -0600, Toshi Kani wrote: On Wed, 2012-07-18 at 16:40 -0600, Shuah Khan wrote: On Wed, 2012-07-18 at 16:26 -0600, Toshi Kani wrote: On Wed, 2012-07-18 at 15:59 -0600, Shuah Khan wrote: On Wed, 2012-07-18

RE: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-19 Thread Toshi Kani
think that's very good improvement. Thanks again, -Toshi Bob -Original Message- From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- ow...@vger.kernel.org] On Behalf Of Toshi Kani Sent: Wednesday, July 18, 2012 3:08 PM To: Joe Perches; Lin, Ming M Cc: l...@kernel.org; linux

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-19 Thread Toshi Kani
On Thu, 2012-07-19 at 10:15 -0600, Shuah Khan wrote: On Wed, 2012-07-18 at 18:38 -0600, Toshi Kani wrote: This interface is defined in acpi/acpi_bus.h, which is intended for ACPI drivers which make many ACPI calls to proceed when they are called at run-time today. This interface does

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-19 Thread Toshi Kani
On Thu, 2012-07-19 at 13:25 -0600, Shuah Khan wrote: On Thu, 2012-07-19 at 11:28 -0600, Toshi Kani wrote: On Thu, 2012-07-19 at 10:15 -0600, Shuah Khan wrote: On Wed, 2012-07-18 at 18:38 -0600, Toshi Kani wrote: This interface is defined in acpi/acpi_bus.h, which is intended

Re: [PATCH 1/4] ACPI: Add acpi_pr_level() interfaces

2012-07-19 Thread Toshi Kani
On Thu, 2012-07-19 at 16:32 -0600, Shuah Khan wrote: On Thu, 2012-07-19 at 14:51 -0600, Toshi Kani wrote: If your concern is actually a performance bottleneck in acpi_get_name() you found in the code, you should report it to the ACPI CA team. I have tried my best to get you to understand

Re: [Bug fix PATCH] resource: Reusing a resource structure allocated by bootmem

2013-04-15 Thread Toshi Kani
On Mon, 2013-04-15 at 11:15 +0900, Yasuaki Ishimatsu wrote: When hot removing memory presented at boot time, following messages are shown: : The reason why the messages are shown is to release a resource structure, allocated by bootmem, by kfree(). So when we release a resource structure, we

Re: [PATCH] firmware, memmap: fix firmware_map_entry leak

2013-04-15 Thread Toshi Kani
firmware_map_find_entry() from releae_firmware_map_entry() Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Acked-by: Toshi Kani toshi.k...@hp.com Thanks, -Toshi --- drivers/firmware/memmap.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/firmware

Re: [Bug fix PATCH v2] Reusing a resource structure allocated by bootmem

2013-04-16 Thread Toshi Kani
On Tue, 2013-04-16 at 10:10 +0900, Yasuaki Ishimatsu wrote: When hot removing memory presented at boot time, following messages are shown: : The reason why the messages are shown is to release a resource structure, allocated by bootmem, by kfree(). So when we release a resource structure,

Re: [Bug fix PATCH v4] Reusing a resource structure allocated by bootmem

2013-04-18 Thread Toshi Kani
On Thu, 2013-04-18 at 17:36 +0900, Yasuaki Ishimatsu wrote: When hot removing memory presented at boot time, following messages are shown: : diff --git a/kernel/resource.c b/kernel/resource.c index 4aef886..637e8d2 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -21,6 +21,7 @@

Re: [Bug fix PATCH v4] Reusing a resource structure allocated by bootmem

2013-04-18 Thread Toshi Kani
On Fri, 2013-04-19 at 08:33 +0900, Yasuaki Ishimatsu wrote: : +static struct resource *get_resource(gfp_t flags) +{ + struct resource *res = NULL; + + spin_lock(bootmem_resource_lock); + if (bootmem_resource.sibling) { + res = bootmem_resource.sibling; +

Re: [Bug fix PATCH v4] Reusing a resource structure allocated by bootmem

2013-04-19 Thread Toshi Kani
On Fri, 2013-04-19 at 17:09 +0900, Yasuaki Ishimatsu wrote: Hi Toshi, 2013/04/19 8:33, Yasuaki Ishimatsu wrote: Hi Toshi, 2013/04/18 23:23, Toshi Kani wrote: On Thu, 2013-04-18 at 17:36 +0900, Yasuaki Ishimatsu wrote: When hot removing memory presented at boot time, following

Re: [PATCH 2/3] resource: Add release_mem_region_adjustable()

2013-04-04 Thread Toshi Kani
On Thu, 2013-04-04 at 14:48 +0800, Ram Pai wrote: On Wed, Apr 03, 2013 at 01:55:05PM -0600, Toshi Kani wrote: On Wed, 2013-04-03 at 13:37 +0800, Ram Pai wrote: On Tue, Apr 02, 2013 at 10:17:29AM -0600, Toshi Kani wrote: + while ((res = *p)) { ...snip

Re: [PATCH 2/3] resource: Add release_mem_region_adjustable()

2013-04-08 Thread Toshi Kani
On Sun, 2013-04-07 at 12:01 +0800, Ram Pai wrote: On Thu, Apr 04, 2013 at 08:07:44AM -0600, Toshi Kani wrote: On Thu, 2013-04-04 at 14:48 +0800, Ram Pai wrote: On Wed, Apr 03, 2013 at 01:55:05PM -0600, Toshi Kani wrote: On Wed, 2013-04-03 at 13:37 +0800, Ram Pai wrote: On Tue, Apr

Re: [UPDATE][PATCH 2/3] resource: Add release_mem_region_adjustable()

2013-04-08 Thread Toshi Kani
On Mon, 2013-04-08 at 11:01 +0900, Yasuaki Ishimatsu wrote: Hi Toshi, 2013/04/04 8:23, Toshi Kani wrote: Added release_mem_region_adjustable(), which releases a requested region from a currently busy memory resource. This interface adjusts the matched memory resource accordingly

[PATCH v2 2/3] resource: Add release_mem_region_adjustable()

2013-04-08 Thread Toshi Kani
since their restriction is valid for I/O resources. Signed-off-by: Toshi Kani toshi.k...@hp.com Reviewed-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- include/linux/ioport.h |2 + kernel/resource.c | 93 2 files changed, 95

[PATCH v2 3/3] mm: Change __remove_pages() to call release_mem_region_adjustable()

2013-04-08 Thread Toshi Kani
to __release_region(), logs an error message and returns no error since a void function. Signed-off-by: Toshi Kani toshi.k...@hp.com Reviewed-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- mm/memory_hotplug.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/mm

[PATCH v2 0/3] Support memory hot-delete to boot memory

2013-04-08 Thread Toshi Kani
Yasuaki Ishimatsu, Ram Pai and Gu Zheng. --- Toshi Kani (3): resource: Add __adjust_resource() for internal use resource: Add release_mem_region_adjustable() mm: Change __remove_pages() to call release_mem_region_adjustable() --- include/linux/ioport.h | 2 + kernel/resource.c | 128

[PATCH v2 1/3] resource: Add __adjust_resource() for internal use

2013-04-08 Thread Toshi Kani
Added __adjust_resource(), which is called by adjust_resource() internally after the resource_lock is held. There is no interface change to adjust_resource(). This change allows other functions to call __adjust_resource() internally while the resource_lock is held. Signed-off-by: Toshi Kani

Re: [PATCH v2 0/3] Support memory hot-delete to boot memory

2013-04-08 Thread Toshi Kani
On Mon, 2013-04-08 at 13:44 -0700, Andrew Morton wrote: On Mon, 8 Apr 2013 11:09:53 -0600 Toshi Kani toshi.k...@hp.com wrote: Memory hot-delete to a memory range present at boot causes an error message in __release_region(), such as: Trying to free nonexistent resource

[UPDATE][PATCH v2 2/3] resource: Add release_mem_region_adjustable()

2013-04-08 Thread Toshi Kani
since their restriction is valid for I/O resources. Signed-off-by: Toshi Kani toshi.k...@hp.com Reviewed-by : Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- Added #ifdef CONFIG_MEMORY_HOTPLUG as suggested by Andrew Morton. --- include/linux/ioport.h |4 ++ kernel/resource.c | 96

Re: [UPDATE][PATCH v2 2/3] resource: Add release_mem_region_adjustable()

2013-04-09 Thread Toshi Kani
On Tue, 2013-04-09 at 05:48 +, Ram Pai wrote: On Mon, Apr 08, 2013 at 03:47:35PM -0600, Toshi Kani wrote: Added release_mem_region_adjustable(), which releases a requested region from a currently busy memory resource. This interface adjusts the matched memory resource accordingly even

Re: [UPDATE][PATCH v2 2/3] resource: Add release_mem_region_adjustable()

2013-04-09 Thread Toshi Kani
On Tue, 2013-04-09 at 12:51 -0700, Andrew Morton wrote: On Tue, 09 Apr 2013 13:02:30 -0600 Toshi Kani toshi.k...@hp.com wrote: + /* look for the next resource if it does not fit into */ + if (res-start start || res-end end) { + p

Re: [PATCH v2 1/3] resource: Add __adjust_resource() for internal use

2013-04-10 Thread Toshi Kani
On Tue, 2013-04-09 at 23:10 -0700, David Rientjes wrote: On Mon, 8 Apr 2013, Toshi Kani wrote: Added __adjust_resource(), which is called by adjust_resource() internally after the resource_lock is held. There is no interface change to adjust_resource(). This change allows other

Re: [PATCH v2 2/3] resource: Add release_mem_region_adjustable()

2013-04-10 Thread Toshi Kani
On Tue, 2013-04-09 at 23:16 -0700, David Rientjes wrote: On Mon, 8 Apr 2013, Toshi Kani wrote: Added release_mem_region_adjustable(), which releases a requested region from a currently busy memory resource. This interface adjusts the matched memory resource accordingly even

[PATCH v3 0/3] Support memory hot-delete to boot memory

2013-04-10 Thread Toshi Kani
release_mem_region_adjustable() per code reviews from Yasuaki Ishimatsu, Ram Pai and Gu Zheng. --- Toshi Kani (3): resource: Add __adjust_resource() for internal use resource: Add release_mem_region_adjustable() mm: Change __remove_pages() to call release_mem_region_adjustable() --- include/linux/ioport.h | 4

[PATCH v3 3/3] mm: Change __remove_pages() to call release_mem_region_adjustable()

2013-04-10 Thread Toshi Kani
to __release_region(), emits a warning message and returns no error since a void function. Signed-off-by: Toshi Kani toshi.k...@hp.com Reviewed-by : Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- mm/memory_hotplug.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/mm

[PATCH v3 1/3] resource: Add __adjust_resource() for internal use

2013-04-10 Thread Toshi Kani
Added __adjust_resource(), which is called by adjust_resource() internally after the resource_lock is held. There is no interface change to adjust_resource(). This change allows other functions to call __adjust_resource() internally while the resource_lock is held. Signed-off-by: Toshi Kani

[PATCH v3 2/3] resource: Add release_mem_region_adjustable()

2013-04-10 Thread Toshi Kani
interfaces since their restriction is valid for I/O resources. Signed-off-by: Toshi Kani toshi.k...@hp.com Reviewed-by : Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- include/linux/ioport.h |4 ++ kernel/resource.c | 100 2 files

Re: [patch] mm, hotplug: avoid compiling memory hotremove functions when disabled

2013-04-10 Thread Toshi Kani
Rientjes rient...@google.com Acked-by: Toshi Kani toshi.k...@hp.com Thanks, -Toshi --- arch/powerpc/platforms/pseries/hotplug-memory.c | 12 + drivers/base/memory.c | 44 +++ include/linux/memory.h | 3 +- include/linux

Re: [PATCH v3 2/3] resource: Add release_mem_region_adjustable()

2013-04-10 Thread Toshi Kani
On Wed, 2013-04-10 at 14:44 -0700, Andrew Morton wrote: On Wed, 10 Apr 2013 11:17:00 -0600 Toshi Kani toshi.k...@hp.com wrote: Added release_mem_region_adjustable(), which releases a requested region from a currently busy memory resource. This interface adjusts the matched memory

Re: [PATCH v3 2/3] resource: Add release_mem_region_adjustable()

2013-04-11 Thread Toshi Kani
On Wed, 2013-04-10 at 15:24 -0700, Andrew Morton wrote: On Wed, 10 Apr 2013 15:08:29 -0700 (PDT) David Rientjes rient...@google.com wrote: On Wed, 10 Apr 2013, Toshi Kani wrote: I'll switch it to GFP_ATOMIC. Which is horridly lame but the allocation is small and alternatives

Re: [PATCH v3 3/3] mm: Change __remove_pages() to call release_mem_region_adjustable()

2013-04-11 Thread Toshi Kani
On Wed, 2013-04-10 at 15:13 -0700, David Rientjes wrote: On Wed, 10 Apr 2013, Toshi Kani wrote: Changed __remove_pages() to call release_mem_region_adjustable(). This allows a requested memory range to be released from the iomem_resource table even if it does not match exactly

[PATCH] resource: Update config option of release_mem_region_adjustable()

2013-04-11 Thread Toshi Kani
Changed the config option of release_mem_region_adjustable() from CONFIG_MEMORY_HOTPLUG to CONFIG_MEMORY_HOTREMOVE since this function is only used for memory hot-delete. Signed-off-by: Toshi Kani toshi.k...@hp.com --- This patch applies on top of the two patches below: Re: [PATCH v3 2/3

Re: [PATCH] resource: Update config option of release_mem_region_adjustable()

2013-04-11 Thread Toshi Kani
On Thu, 2013-04-11 at 15:40 -0700, David Rientjes wrote: On Thu, 11 Apr 2013, Toshi Kani wrote: Changed the config option of release_mem_region_adjustable() from CONFIG_MEMORY_HOTPLUG to CONFIG_MEMORY_HOTREMOVE since this function is only used for memory hot-delete. Signed-off

Re: [PATCH] resource: Update config option of release_mem_region_adjustable()

2013-04-11 Thread Toshi Kani
On Fri, 2013-04-12 at 08:50 +0900, Yasuaki Ishimatsu wrote: 2013/04/12 7:26, Toshi Kani wrote: Changed the config option of release_mem_region_adjustable() from CONFIG_MEMORY_HOTPLUG to CONFIG_MEMORY_HOTREMOVE since this function is only used for memory hot-delete. Signed-off-by: Toshi

Re: [PATCH v2] ACPI: Add sysfs links from memory device to memblocks

2013-04-12 Thread Toshi Kani
On Fri, 2013-04-12 at 00:23 +0200, Rafael J. Wysocki wrote: Sorry for the delayed response. No problem. I know you are busy. Thanks for the reply. On Wednesday, March 27, 2013 11:13:49 AM Toshi Kani wrote: On Wed, 2013-03-27 at 00:39 +0100, Rafael J. Wysocki wrote: : What about

[PATCH 0/3] Support memory hot-delete to boot memory

2013-04-02 Thread Toshi Kani
-delete operations, which allows releasing a partial memory range and adjusts remaining resource accordingly. This patchset makes no changes to the existing interfaces since their restriction is still valid for I/O resources. --- Toshi Kani (3): resource: Add __adjust_resource() for internal use

  1   2   3   4   5   6   7   8   9   10   >