here, why not just move to lib flatly without
creating a new directory?
Thanks,
Wanlong Gao
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
Tidy up the goto label in init(), and remove the useless
NULL pointer assignment.
Cc: James E.J. Bottomley jbottom...@parallels.com
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Rusty Russell ru...@rustcorp.com.au
Cc: linux-s...@vger.kernel.org
Cc: k...@vger.kernel.org
Signed-off-by: Wanlong Gao
Create a separate work queue for virtio-scsi to improve the performance.
Cc: James E.J. Bottomley jbottom...@parallels.com
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Rusty Russell ru...@rustcorp.com.au
Cc: linux-s...@vger.kernel.org
Cc: k...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl
Use pr_err() instead of printk() for code cleanups.
Cc: James E.J. Bottomley jbottom...@parallels.com
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Rusty Russell ru...@rustcorp.com.au
Cc: linux-s...@vger.kernel.org
Cc: k...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reassign err is not needed, just a cleanup.
Cc: James E.J. Bottomley jbottom...@parallels.com
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Rusty Russell ru...@rustcorp.com.au
Cc: linux-s...@vger.kernel.org
Cc: k...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers
Just use the macro instead of define a variable.
Cc: James E.J. Bottomley jbottom...@parallels.com
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Rusty Russell ru...@rustcorp.com.au
Cc: linux-s...@vger.kernel.org
Cc: k...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
=4820/3169, in_queue=7991, util=90.62%
sdb: ios=6364/5358, merge=39/53, ticks=3810/2816, in_queue=6615, util=84.63%
sdc: ios=6458/5352, merge=74/47, ticks=4425/3048, in_queue=7459, util=88.41%
Wanlong Gao (5):
virtio-scsi: remove the useless assignment
virtio-scsi: remove the needless
On 11/07/2012 08:23 PM, Asias He wrote:
On Wed, Nov 7, 2012 at 6:18 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote:
patch 1-3,5 are some cleanups.
patch 4: create a separate work queue for virtio-scsi
to improve the performance, I tested with tmpfs backed
disk, the config file is like below
touched (complete_event) shouldn't ever run during a normal benchmark.
It's only used for hotplug/hot-unplug.
Nevertheless, I'll queue the cleanup patches. Thanks for those.
Oops, got it, I will investigate more. Thank you for teaching me.
Regards,
Wanlong Gao
--
To unsubscribe from
] virtio-scsi: split scatterlist per target
Go ahead and make sure that vq-vq_lock is relinquished w/ spin_unlock
first, then release tgt-tgt_lock w/ spin_unlock_irqrestore.
Did you hit any error? I don't think this order is wrong.
Thanks,
Wanlong Gao
Cc: Paolo Bonzini pbonz...@redhat.com
Cc
On 04/18/2013 09:35 PM, Jens Axboe wrote:
On Thu, Apr 18 2013, Wanlong Gao wrote:
A bio is always fully initialized, regardless of which internal
allocator it came from. If people are doing private kmallocs, then they
better be using bio_init() as well.
Wanlong, would it be possible to get
On 04/18/2013 10:30 PM, Jens Axboe wrote:
On Thu, Apr 18 2013, Wanlong Gao wrote:
On 04/18/2013 09:35 PM, Jens Axboe wrote:
On Thu, Apr 18 2013, Wanlong Gao wrote:
A bio is always fully initialized, regardless of which internal
allocator it came from. If people are doing private kmallocs
On 04/18/2013 10:30 PM, Jens Axboe wrote:
On Thu, Apr 18 2013, Wanlong Gao wrote:
On 04/18/2013 09:35 PM, Jens Axboe wrote:
On Thu, Apr 18 2013, Wanlong Gao wrote:
A bio is always fully initialized, regardless of which internal
allocator it came from. If people are doing private kmallocs
for my incompleted panic picture
before that let you detour. :-(
Regards,
Wanlong Gao
Thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/28/2013 10:22 AM, Wanlong Gao wrote:
On 03/23/2013 07:28 PM, Wanlong Gao wrote:
This series implements virtio-scsi queue steering, which gives
performance improvements of up to 50% (measured both with QEMU and
tcm_vhost backends).
This version rebased on Rusty's virtio ring rework
On 04/06/2013 04:40 PM, James Bottomley wrote:
On Fri, 2013-04-05 at 16:55 +0800, Wanlong Gao wrote:
On 03/28/2013 10:22 AM, Wanlong Gao wrote:
On 03/23/2013 07:28 PM, Wanlong Gao wrote:
This series implements virtio-scsi queue steering, which gives
performance improvements of up to 50
Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/scsi/virtio_scsi.c | 40 +++-
1 file changed, 11 insertions(+), 29 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index b53ba9e
Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Asias He as...@redhat.com
---
drivers/scsi/virtio_scsi.c | 269 -
1 file changed, 241 insertions(+), 28 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b
From: Paolo Bonzini pbonz...@redhat.com
Avoid duplicated code in all of the callers.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Asias He as...@redhat.com
---
drivers/scsi/virtio_scsi.c | 22
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Asias He as...@redhat.com
---
drivers/scsi/virtio_scsi.c | 29
From: Paolo Bonzini pbonz...@redhat.com
This will be needed soon in order to retrieve the per-target
struct.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Asias He as...@redhat.com
---
drivers
into virtscsi_vq_done
virtio-scsi: introduce multiqueue support
Wanlong Gao (1):
virtio-scsi: reset virtqueue affinity when doing cpu hotplug
drivers/scsi/virtio_scsi.c | 359 -
1 file changed, 290 insertions(+), 69 deletions(-)
--
1.8.2.rc2
):
virtio-scsi: pass struct virtio_scsi to virtqueue completion function
virtio-scsi: push vq lock/unlock into virtscsi_vq_done
virtio-scsi: introduce multiqueue support
Wanlong Gao (2):
virtio-scsi: redo allocation of target data
virtio-scsi: reset virtqueue affinity when doing cpu hotplug
: James Bottomley james.bottom...@hansenpartnership.com
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/scsi/virtio_scsi.c | 71 --
1 file changed, 25 insertions
From: Paolo Bonzini pbonz...@redhat.com
Avoid duplicated code in all of the callers.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Asias He as...@redhat.com
---
drivers/scsi/virtio_scsi.c | 22
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Asias He as...@redhat.com
---
drivers/scsi/virtio_scsi.c | 29
Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Asias He as...@redhat.com
---
drivers/scsi/virtio_scsi.c | 282 -
1 file changed, 254 insertions(+), 28 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b
From: Paolo Bonzini pbonz...@redhat.com
This will be needed soon in order to retrieve the per-target
struct.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Asias He as...@redhat.com
---
drivers
? */
Could you rephrase that, please?
Thank you, fixed in V6, please review.
Tested on qemu and w/ Google Compute Engine's virtio-scsi device.
Cool.
Reviewed-and-tested-by: Venkatesh Srinivas venkate...@google.com
Do you mind review and test the V6? Thank you.
Regards,
Wanlong Gao
Thanks
On 03/20/2013 03:24 PM, Asias He wrote:
On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote:
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong
On 03/20/2013 03:24 PM, Asias He wrote:
On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote:
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong
your Acked-by?
Paolo Bonzini (3):
virtio-scsi: pass struct virtio_scsi to virtqueue completion function
virtio-scsi: push vq lock/unlock into virtscsi_vq_done
virtio-scsi: introduce multiqueue support
Wanlong Gao (2):
virtio-scsi: redo allocation of target data
virtio-scsi: reset virtqueue
From: Paolo Bonzini pbonz...@redhat.com
Avoid duplicated code in all of the callers.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Asias He as...@redhat.com
---
drivers/scsi/virtio_scsi.c | 22
From: Paolo Bonzini pbonz...@redhat.com
This will be needed soon in order to retrieve the per-target
struct.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Asias He as...@redhat.com
---
drivers
Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Asias He as...@redhat.com
Tested-by: Venkatesh Srinivas venkate...@google.com
---
drivers/scsi/virtio_scsi.c | 282 -
1 file changed, 254 insertions(+), 28 deletions
: James Bottomley james.bottom...@hansenpartnership.com
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Asias He as...@redhat.com
---
drivers/scsi/virtio_scsi.c | 71
On 03/23/2013 02:36 PM, Paolo Bonzini wrote:
Il 20/03/2013 08:56, Wanlong Gao ha scritto:
This one does not apply on top of virtio-next + patch 1-4 in this series.
I'm very sorry.
This fault is because I modified the 4/5 from
/* if the affinity hint is set for virtqueues
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Asias He as...@redhat.com
---
drivers/scsi/virtio_scsi.c | 29
On 03/23/2013 07:28 PM, Wanlong Gao wrote:
This series implements virtio-scsi queue steering, which gives
performance improvements of up to 50% (measured both with QEMU and
tcm_vhost backends).
This version rebased on Rusty's virtio ring rework patches, which
has already gone into virtio
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/scsi/virtio_scsi.c | 29 +
1 file
From: Paolo Bonzini pbonz...@redhat.com
Avoid duplicated code in all of the callers.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/scsi/virtio_scsi.c | 22 +-
1 file changed, 9
Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/scsi/virtio_scsi.c | 269 -
1 file changed, 241 insertions(+), 28 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 3573704
the virtio_scsi_target_state structs in the
flexible array member at the end of struct virtio_scsi, because
we will place the virtqueues there in the next patches.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/scsi
From: Paolo Bonzini pbonz...@redhat.com
This will be needed soon in order to retrieve the per-target
struct.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/scsi/virtio_scsi.c | 17
):
virtio-scsi: redo allocation of target data
virtio-scsi: pass struct virtio_scsi to virtqueue completion function
virtio-scsi: push vq lock/unlock into virtscsi_vq_done
virtio-scsi: introduce multiqueue support
Wanlong Gao (1):
virtio-scsi: reset virtqueue affinity when doing cpu hotplug
,
+},
+ .probe = lp8755_probe,
+ .remove = __devexit_p(lp8755_remove),
Ditto. remove __devexit_p.
Thanks,
Wanlong Gao
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On 01/25/2013 11:28 AM, Jason Wang wrote:
On 01/21/2013 07:25 PM, Wanlong Gao wrote:
Split out the clean affinity function to virtnet_clean_affinity().
Cc: Rusty Russell ru...@rustcorp.com.au
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Jason Wang jasow...@redhat.com
Cc: Eric Dumazet erdnet
On 01/25/2013 01:13 PM, Jason Wang wrote:
On 01/25/2013 12:20 PM, Wanlong Gao wrote:
On 01/25/2013 11:28 AM, Jason Wang wrote:
On 01/21/2013 07:25 PM, Wanlong Gao wrote:
Split out the clean affinity function to virtnet_clean_affinity().
Cc: Rusty Russell ru...@rustcorp.com.au
Cc: Michael S
On 01/25/2013 09:04 AM, K. Y. Srinivasan wrote:
Properly initialize scatterlist before using it.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Cc: Stable sta...@vger.kernel.org
Reviewed-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/scsi/storvsc_drv.c |1 +
1 files
On 01/25/2013 02:12 PM, Jason Wang wrote:
On 01/25/2013 01:40 PM, Wanlong Gao wrote:
On 01/25/2013 01:13 PM, Jason Wang wrote:
On 01/25/2013 12:20 PM, Wanlong Gao wrote:
On 01/25/2013 11:28 AM, Jason Wang wrote:
On 01/21/2013 07:25 PM, Wanlong Gao wrote:
Split out the clean affinity function
On 01/25/2013 03:04 PM, Jason Wang wrote:
On 01/25/2013 02:42 PM, Wanlong Gao wrote:
On 01/25/2013 02:12 PM, Jason Wang wrote:
On 01/25/2013 01:40 PM, Wanlong Gao wrote:
On 01/25/2013 01:13 PM, Jason Wang wrote:
On 01/25/2013 12:20 PM, Wanlong Gao wrote:
On 01/25/2013 11:28 AM, Jason Wang
ru...@rustcorp.com.au
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Jason Wang jasow...@redhat.com
Cc: Eric Dumazet erdnet...@gmail.com
Cc: David S. Miller da...@davemloft.net
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
: Jason Wang jasow...@redhat.com
Cc: Eric Dumazet erdnet...@gmail.com
Cc: David S. Miller da...@davemloft.net
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Acked-by: Michael S. Tsirkin m...@redhat.com
---
V6-V7: no change
V5
-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Acked-by: Michael S. Tsirkin m...@redhat.com
---
V6-V7:
always set vq_index (Jason)
V5-V6: NEW
drivers/net/virtio_net.c | 71 +++-
1 file changed, 40
On 01/25/2013 05:00 PM, Jason Wang wrote:
On 01/25/2013 04:36 PM, Wanlong Gao wrote:
As Michael mentioned, set affinity and select queue will not work very
well when CPU IDs are not consecutive, this can happen with hot unplug.
Fix this bug by traversal the online CPUs, and create a per cpu
, will move the fix from 2/3 to 1/3.
Thanks,
Wanlong Gao
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Acked-by: Michael S. Tsirkin m...@redhat.com
---
V6-V7:
always set vq_index (Jason)
V5-V6: NEW
drivers/net/virtio_net.c | 76 +---
1 file changed, 40
ru...@rustcorp.com.au
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Jason Wang jasow...@redhat.com
Cc: Eric Dumazet erdnet...@gmail.com
Cc: David S. Miller da...@davemloft.net
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
: Jason Wang jasow...@redhat.com
Cc: Eric Dumazet erdnet...@gmail.com
Cc: David S. Miller da...@davemloft.net
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Acked-by: Michael S. Tsirkin m...@redhat.com
---
V5-V6:
deal
failure. Fix this by:
- examing the POLLERR when setting backend and report erros to userspace
- let tun always add to waitqueue in .poll() after the queue is created even
if
it was detached.
Fixed my kernel oops here, thank you.
Tested-by: Wanlong Gao gaowanl...@cn.fujitsu.com
ru...@rustcorp.com.au
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Jason Wang jasow...@redhat.com
Cc: Eric Dumazet erdnet...@gmail.com
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
V5-V6:
remove {get|put
-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
V5-V6: NEW
drivers/net/virtio_net.c | 67 +++-
1 file changed, 38 insertions(+), 29 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 70cd957..1a35a8c 100644
: Jason Wang jasow...@redhat.com
Cc: Eric Dumazet erdnet...@gmail.com
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
V5-V6:
deal with CPU_DOWN_PREPARE separately by just cleaning affinity
V4-V5:
New method
On 01/22/2013 09:12 AM, Rusty Russell wrote:
Wanlong Gao gaowanl...@cn.fujitsu.com writes:
As Michael mentioned, set affinity and select queue will not work very
well when CPU IDs are not consecutive, this can happen with hot unplug.
Fix this bug by traversal the online CPUs, and create
On 01/16/2013 11:31 AM, Rusty Russell wrote:
Wanlong Gao gaowanl...@cn.fujitsu.com writes:
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
You need to be careful to get_online_cpus() and put_online_cpus() here,
so CPUs can't go up and down in the middle
/scm/linux/kernel/git/tj/wq.git for-3.9-remove-gcwq
Forgot to push out this branch?
Thanks,
Wanlong Gao
Thanks.
include/linux/workqueue.h| 17
include/trace/events/workqueue.h |2
kernel/workqueue.c | 897
+++
3 files
ru...@rustcorp.com.au
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Jason Wang jasow...@redhat.com
Cc: Eric Dumazet erdnet...@gmail.com
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
V4-V5:
Add get/put_online_cpus
: Jason Wang jasow...@redhat.com
Cc: Eric Dumazet erdnet...@gmail.com
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
V4-V5:
New method to deal with the cpu hotplug actions (Rusty)
drivers/net/virtio_net.c | 50
On 01/18/2013 02:18 PM, Jason Wang wrote:
On 01/18/2013 01:32 PM, Wanlong Gao wrote:
As Michael mentioned, set affinity and select queue will not work very
well when CPU IDs are not consecutive, this can happen with hot unplug.
Fix this bug by traversal the online CPUs, and create a per cpu
- included Wanlong Gao's CPU hotplug patches
Ok for 3.9? It would probably be easier to get it in via Rusty's tree
because of the prerequisites. James, can I get your Acked-by?
I can't apply this series on top of Rusty's virtio-next, I missed something
or needed rebase them ?
Thanks,
Wanlong Gao
On 02/19/2013 03:56 PM, Rusty Russell wrote:
virtio_scsi can really use this, to avoid the current hack of copying
the whole sg array. Some other things get slightly neater, too.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
I like this simple implementation.
Reviewed-by: Wanlong Gao
Using the new virtqueue_add_sgs function lets us simplify the queueing
path. In particular, all data protected by the tgt_lock is just gone
(multiqueue will find a new use for the lock).
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
On 02/20/2013 05:38 PM, Asias He wrote:
On 02/20/2013 04:37 PM, Wanlong Gao wrote:
Using the new virtqueue_add_sgs function lets us simplify the queueing
path. In particular, all data protected by the tgt_lock is just gone
(multiqueue will find a new use for the lock).
Signed-off-by: Paolo
Using the new virtqueue_add_sgs function lets us simplify the queueing
path. In particular, all data protected by the tgt_lock is just gone
(multiqueue will find a new use for the lock).
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
V1
On 02/19/2013 03:56 PM, Rusty Russell wrote:
Extract the post-counting code into virtqueue_add(), make both callers
use it.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Reviewed-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/virtio/virtio_ring.c | 147
the unclean sglist bit. I had a more
ambitious one which conditionally ignored end markers in the iterator,
but it was ugly and I suspect this is just as fast. Maybe we should
just fix all the drivers?
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Reviewed-by: Wanlong Gao gaowanl
On 02/19/2013 03:56 PM, Rusty Russell wrote:
We never add buffers with input and output parts, so use the new accessors.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Reviewed-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/net/virtio_net.c | 11 +--
1 file changed
On 02/19/2013 03:56 PM, Rusty Russell wrote:
We never add buffers with input and output parts, so use the new accessors.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Reviewed-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/char/hw_random/virtio-rng.c |2 +-
1 file changed
On 02/19/2013 03:56 PM, Rusty Russell wrote:
We never add buffers with input and output parts, so use the new accessors.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Reviewed-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/rpmsg/virtio_rpmsg_bus.c |8
1 file
On 02/19/2013 03:56 PM, Rusty Russell wrote:
We never add buffers with input and output parts, so use the new accessors.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Reviewed-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/virtio/virtio_balloon.c |6 +++---
1 file changed
On 02/19/2013 03:56 PM, Rusty Russell wrote:
We never add buffers with input and output parts, so use the new accessors.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Reviewed-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/net/caif/caif_virtio.c |3 +--
1 file changed, 1
On 02/19/2013 03:56 PM, Rusty Russell wrote:
We never add buffers with input and output parts, so use the new accessors.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Reviewed-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/char/virtio_console.c |6 +++---
1 file changed
header is forgotten?
Thanks,
Wanlong Gao
+ /* Add header */
+ sg_init_one(hdr, ctrl, sizeof(ctrl));
+ sgs[out_num++] = hdr;
- sg_init_table(sg, out + in);
+ if (out)
+ sgs[out_num++] = out;
+ if (in)
+ sgs[out_num + in_num
.
[9.906465] net eth0: Failed to disable allmulti mode.
[9.907234] net eth0: Failed to set MAC fitler table.
Any thoughts?
Thanks,
Wanlong Gao
kfree(buf);
@@ -1001,7 +999,7 @@ static int virtnet_vlan_rx_add_vid(struct net_device
*dev, u16 vid)
sg_init_one(sg, vid, sizeof(vid
On 02/21/2013 05:41 PM, Jason Wang wrote:
On 02/21/2013 04:30 PM, Wanlong Gao wrote:
On 02/19/2013 03:56 PM, Rusty Russell wrote:
It's a bit cleaner to hand multiple sgs, rather than one big one.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/net/virtio_net.c | 50
a
past thread before resend
a patch.
So, what's your opinion about this bug? How to fix it in your mind?
Fix glibc instead of kernel.
OK, I will send a patch to glibc community. Thank you.
Wanlong Gao
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On 09/13/2012 12:03 PM, Laurent Pinchart wrote:
Hi Wanlong,
Thanks for the patch.
On Monday 27 August 2012 15:23:15 Wanlong Gao wrote:
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Laurent Pinchart laurent.pinch
: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
Cc: linux...@kvack.org (open list:MEMORY MANAGEMENT)
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
mm/mmap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index ae18a48..5380764 100644
--- a/mm
-by: Linus Torvalds torva...@linux-foundation.org
Linus pointed out that ENOIOCTLCMD should be translated as ENOTTY to user
mode, and we should fix up the broken drivers then.
Wanlong Gao (5):
drivers:tty:fix up ENOIOCTLCMD error handling
net:atm:fix up ENOIOCTLCMD error handling
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: David S. Miller da...@davemloft.net
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
net/atm/resources.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Martin Schwidefsky schwidef...@de.ibm.com
Cc: Heiko Carstens heiko.carst...@de.ibm.com
Cc: linux...@de.ibm.com
Cc: linux-s...@vger.kernel.org (open list:S390)
Signed-off-by: Wanlong Gao gaowanl
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: linux-me...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: linux-me...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/media/dvb/dvb-core/dvbdev.c | 2 +-
1 file changed
-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/tty/tty_io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index b425c79..720c408f 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -2756,7 +2756,7 @@ long tty_ioctl(struct
about 68%.
Thanks,
Wanlong Gao
Patch 1 adds a new API to add functions for piecewise addition for buffers,
which enables various simplifications in virtio-scsi (patches 2-3) and a
small performance improvement of 2-6%. Patches 4 and 5 add multiqueuing.
I'm mostly looking for comments
under cpu hotplug
We set virtqueue affinity when the num_queues equals to the number
of VCPUs. Register a hotcpu notifier to notifier whether the
VCPU number is changed. If the VCPU number is changed, we
force to set virtqueue affinity again.
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
: Jason Wang jasow...@redhat.com
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/net/virtio_net.c | 39 ++-
1 file changed, 38 insertions(+), 1 deletion(-)
diff --git a/drivers
On 12/26/2012 06:06 PM, Jason Wang wrote:
On 12/26/2012 03:06 PM, Wanlong Gao wrote:
Add a cpu notifier to virtio-net, so that we can reset the
virtqueue affinity if the cpu hotplug happens. It improve
the performance through enabling or disabling the virtqueue
affinity after doing cpu
On 12/27/2012 11:28 AM, Jason Wang wrote:
On 12/26/2012 06:19 PM, Wanlong Gao wrote:
On 12/26/2012 06:06 PM, Jason Wang wrote:
On 12/26/2012 03:06 PM, Wanlong Gao wrote:
Add a cpu notifier to virtio-net, so that we can reset the
virtqueue affinity if the cpu hotplug happens. It improve
On 12/27/2012 02:39 PM, Jason Wang wrote:
Currently, polling error were ignored in vhost. This may lead some issues (e.g
kenrel crash when passing a tap fd to vhost before calling TUNSETIFF). Fix
this
by:
Can this kernel crash be reproduced by hand?
Thanks,
Wanlong Gao
- extend the idea
1 - 100 of 272 matches
Mail list logo
