Re: [PATCH v2] lxt PHY: Support for the buggy LXT973 rev A2

Le 10/09/2012 20:17, Lutz Jaenicke a écrit : On Mon, Sep 10, 2012 at 05:45:49PM +0200, Christophe Leroy wrote: This patch adds proper handling of the buggy revision A2 of LXT973 phy, adding precautions linked to ERRATA Item 4: Item 4: MDIO Interface and Repeated Polling Problem: Repeated

Re: [PATCH v4] lxt PHY: Support for the buggy LXT973 rev A2

Le 24/09/2012 16:13, David Laight a écrit : This patch adds proper handling of the buggy revision A2 of LXT973 phy, adding precautions linked to ERRATA Item 4: Revision A2 of LXT973 chip randomly returns the contents of the previous even register when you read a odd register regularly Does

Re: [PATCH v4] lxt PHY: Support for the buggy LXT973 rev A2

Le 24/09/2012 20:30, Richard Cochran a écrit : On Mon, Sep 24, 2012 at 04:00:58PM +0200, Christophe Leroy wrote: diff -u a/drivers/net/phy/lxt.c b/drivers/net/phy/lxt.c --- a/drivers/net/phy/lxt.c 2012-09-23 03:08:48.0 +0200 +++ b/drivers/net/phy/lxt.c 2012-09-23

Re: [PATCH] Adds support for Open Firmware in MAX730x GPIO Driver

Le 02/03/2013 22:16, Grant Likely a écrit : I would like to know /why/ this specific hunk is necessary. I cannot tell from the context. That's the sort of thing that is very helpful to have in the commit description. Otherwise the patch looks fine. g. Ok, I will resubmit with a note to it

Re: [PATCH v2] IIO ADC support for AD7923

Le 12/02/2013 19:54, Lars-Peter Clausen a écrit : On 02/12/2013 06:10 PM, Christophe Leroy wrote: This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem. Signed-off-by: Patrick Vasseur patrick.vass...@c-s.fr Signed-off-by: Christophe Leroy christophe.le...@c-s.fr Looks

Re: [PATCH] Enhanced support for MPC8xx/8xxx watchdog

Hi Wim, Le 27/02/2013 20:52, Wim Van Sebroeck a écrit : The rest of the code is OK and when above comments are corrected, I will add the patch to improve the userspace experience. Kind regards, Wim. Ok, I'll fix and re-submit my patch according to your comments. Best regards Christophe --

Re: [PATCH] Adds support for Open Firmware in MAX730x GPIO Driver

Le 01/03/2013 01:43, Linus Walleij a écrit : On Fri, Feb 22, 2013 at 10:26 AM, Christophe Leroy christophe.le...@c-s.fr wrote: This patch allows the use of the MAX730x Driver on systems using the Open Firmware platform format Signed-off-by: Patrick Vasseur patrick.vass...@c-s.fr

Re: [PATCH] Unset LANG in setlocalversion script

Le 21/02/2013 22:14, Michal Marek a écrit : Dne 21.2.2013 13:49, Christophe Leroy napsal(a): This patch allows the use of setlocalversion script regardless of the LANG parameter. Otherwise, the `svn info 2/dev/null | grep '^Last Changed Rev'` returns nothing because for instance, in French the

Re: [PATCH] Powerpc 8xx CPM_UART delay in receive

Le 16/08/2012 17:21, Alan Cox a écrit : MAX_IDL: Maximum idle characters. When a character is received, the receiver begins counting idle characters. If MAX_IDL idle characters are received before the next data character, an idle timeout occurs and the buffer is closed, generating a maskable

Re: [PATCH] hwmon/lm70: adding support for NS LM74 chip

Le 26/08/2012 19:47, Guenter Roeck a écrit : On Thu, Aug 23, 2012 at 11:13:17AM -0700, Guenter Roeck wrote: On Thu, Aug 23, 2012 at 05:32:12PM +0200, Christophe Leroy wrote: Hello, Hi Christophe, Hi again, [ ... ] Hi Guenter, - /* 3-wire link (shared SI/SO) for LM70 */ - if

Re: [PATCH] Powerpc 8xx CPM_UART delay in receive

Le 14/08/2012 16:52, Alan Cox a écrit : On Tue, 14 Aug 2012 16:26:28 +0200 Christophe Leroy christophe.le...@c-s.fr wrote: Hello, I'm not sure who to address this Patch to either It fixes a delay issue with CPM UART driver on Powerpc MPC8xx. The problem is that with the actual code, the

Re: [PATCH] Powerpc 8xx CPM_UART delay in receive

Le 16/08/2012 16:29, Alan Cox a écrit : The PowerPC CPM is working differently. It doesn't use a fifo but buffers. Buffers are handed to the microprocessor only when they are full or after a timeout period which is adjustable. In the driver, the Which is different how - remembering we empty the

Huge performance degradation for UDP between 2.4.17 and 2.6

Hi I'm having a big issue with UDP. Using a powerpc board (MPC860). With our board running kernel 2.4.17, I'm able to send 16 voice packets (UDP, 96 bytes per packet) in 11 seconds. With the same board running either Kernel 2.6.35.14 or Kernel 3.4.7, I need 55 seconds to send the same

Re: Huge performance degradation for UDP between 2.4.17 and 2.6

Le 02/08/2012 16:13, Eric Dumazet a écrit : On Thu, 2012-08-02 at 14:27 +0200, leroy christophe wrote: Hi I'm having a big issue with UDP. Using a powerpc board (MPC860). With our board running kernel 2.4.17, I'm able to send 16 voice packets (UDP, 96 bytes per packet) in 11 seconds

Re: Huge performance degradation for UDP between 2.4.17 and 2.6

Le 05/08/2012 10:28, Eric Dumazet a écrit : On Sun, 2012-08-05 at 10:16 +0200, LEROY christophe wrote: Le 02/08/2012 16:13, Eric Dumazet a écrit : On Thu, 2012-08-02 at 14:27 +0200, leroy christophe wrote: Hi I'm having a big issue with UDP. Using a powerpc board (MPC860). With our board

Re: [PATCH] powerpc 8xx: Fixing issue with CONFIG_PIN_TLB

Le 12/09/2013 02:15, Benjamin Herrenschmidt a écrit : On Wed, 2013-09-11 at 17:36 -0500, Scott Wood wrote: I wonder why we don't start from entry 31 so we can actually make use of that autodecrement. What will happen when we load the first normal TLB entry later on? I don't see any setting

Re: [PATCH v2] powerpc 8xx: Fixing issue with CONFIG_PIN_TLB

Le 12/09/2013 20:44, Scott Wood a écrit : On Thu, 2013-09-12 at 20:25 +0200, Christophe Leroy wrote: This is a reorganisation of the setup of the TLB at kernel startup, in order to handle the CONFIG_PIN_TLB case in accordance with chapter 8.10.3 of MPC866 and MPC885 reference manuals.

Re: [PATCH] IIO AD7923 iio_consumer support

Le 05/10/2013 10:41, Lars-Peter Clausen a écrit : On 10/05/2013 10:21 AM, Christophe Leroy wrote: + .consumer_channel = channel_0, + .adc_channel_label = 0, + }, + { + .consumer_dev_name = AD7923_NAME, + .consumer_channel =

Re: [PATCH] IIO AD7923 iio_consumer support

Le 05/10/2013 11:35, Lars-Peter Clausen a écrit : On 10/05/2013 11:18 AM, leroy christophe wrote: Le 05/10/2013 10:41, Lars-Peter Clausen a écrit : On 10/05/2013 10:21 AM, Christophe Leroy wrote: +.consumer_channel = channel_0, +.adc_channel_label = 0

Re: [PATCH v2] powerpc 8xx: Fixing issue with CONFIG_PIN_TLB

Le 16/09/2013 23:02, Scott Wood a écrit : On Fri, 2013-09-13 at 07:04 +0200, leroy christophe wrote: Le 12/09/2013 20:44, Scott Wood a écrit : On Thu, 2013-09-12 at 20:25 +0200, Christophe Leroy wrote: This is a reorganisation of the setup of the TLB at kernel startup, in order to handle

Re: [PATCH] powerpc 8xx: Fixing memory init issue with CONFIG_PIN_TLB

Le 15/10/2013 22:33, Scott Wood a écrit : On Tue, 2013-10-15 at 18:27 +0200, leroy christophe wrote: Le 11/10/2013 17:13, Joakim Tjernlund a écrit : Linuxppc-dev linuxppc-dev-bounces+joakim.tjernlund=transmode...@lists.ozlabs.org wrote on 2013/10/11 14:56:40: Activating CONFIG_PIN_TLB allows

Re: [PATCH] watchdog: mpc8xxx_wdt convert to watchdog core

Le 01/12/2013 20:38, Guenter Roeck a écrit : On 11/30/2013 07:33 AM, Christophe Leroy wrote: Convert mpc8xxx_wdt.c to the new watchdog API. Signed-off-by: Christophe Leroy christophe.le...@c-s.fr diff -ur a/drivers/watchdog/mpc8xxx_wdt.c b/drivers/watchdog/mpc8xxx_wdt.c ---

Re: [PATCH] powerpc 8xx: Fixing memory init issue with CONFIG_PIN_TLB

Le 11/10/2013 17:13, Joakim Tjernlund a écrit : Linuxppc-dev linuxppc-dev-bounces+joakim.tjernlund=transmode...@lists.ozlabs.org wrote on 2013/10/11 14:56:40: Activating CONFIG_PIN_TLB allows access to the 24 first Mbytes of memory at bootup instead of 8. It is needed for big kernels for

BUG: Patch Convert some mftb/mftbu into mfspr breaks MPC885

Scott, The patch Convert some mftb/mftbu into mfspr (beb2dc0a7a84be003ce54e98b95d65cc66e6e536) breaks startup on MPC885. The CPU traps (SoftwareEmulation trap) at sched_clock() when trying to read TBU with mfspr. Reverting the patch solves the issue. What's the prefered way to fix this ?

Re: [PATCH v2] powerpc 8xx: Fixing issue with CONFIG_PIN_TLB

Le 20/09/2013 23:22, Scott Wood a écrit : The hardware wants to decrement; why fight it? I see your point. However it is not clear in the documentation if the decrement is done really after the update, or at xTLB interrupt. So I propose to still set the CTR ourself as described in the

Re: [PATCH v2] powerpc 8xx: Loading kernels over 8Mbytes without CONFIG_PIN_TLB

Le 16/12/2013 23:57, Scott Wood a écrit : On Wed, 2013-12-11 at 00:36 +0100, leroy christophe wrote: Le 11/12/2013 00:18, Scott Wood a écrit : There wasn't previously an ifdef specifically around the setting of SPRN_MD_CTR. That's new. There was an ifdef around the entire block, which has

Re: [PATCH v2] powerpc 8xx: Loading kernels over 8Mbytes without CONFIG_PIN_TLB

Le 10/12/2013 23:24, Scott Wood a écrit : On Tue, 2013-12-10 at 12:29 +0100, Christophe Leroy wrote: Today, the only way to load kernels whose size is greater than 8Mbytes is to activate CONFIG_PIN_TLB. Otherwise, the physical memory initially mapped is limited to 8Mbytes. This patch adds the

Re: [PATCH v2] powerpc 8xx: Loading kernels over 8Mbytes without CONFIG_PIN_TLB

Le 11/12/2013 00:18, Scott Wood a écrit : On Wed, 2013-12-11 at 00:05 +0100, leroy christophe wrote: Le 10/12/2013 23:24, Scott Wood a écrit : On Tue, 2013-12-10 at 12:29 +0100, Christophe Leroy wrote: Today, the only way to load kernels whose size is greater than 8Mbytes is to activate

Re: [v2] Enhanced support for MPC8xx/8xxx watchdog

Le 26/06/2013 01:04, Scott Wood a écrit : On Thu, Feb 28, 2013 at 09:52:22AM +0100, LEROY Christophe wrote: This patch modifies the behaviour of the MPC8xx/8xxx watchdog. On the MPC8xx, at 133Mhz, the maximum timeout of the watchdog timer is 1s, which means it must be pinged twice a second

Issue with commit 33c133cc7598e60976a phy: IRQ cannot be shared

Hello Segei, Florian and David, I have an hardware with two ethernet interfaces, and with the two PHYs inside the same component INTEL LXT973 which has only one interrupt. I also have another hardware with two ethernet interfaces and two independant PHYs. But the two PHYs are wired to the same

Linux 3.16: all my drivers on SPI bus report WARNING: at drivers/base/dd.c:286

Since Linux 3.16, for all drivers tied to SPI bus, I get the following warning on a PowerPC 8xx. It doesn't happen with Linux 3.15 What can be the reason / what should I look at ? [3.086957] device: 'spi32766.1': device_add [3.087179] bus: 'spi': add device spi32766.1 [3.087653]

kernel 3.17 - perf build failure

LINK perf libperf.a(skip-callchain-idx.o): In function `arch_skip_callchain_idx': /root/gen/trunk/knl/tools/perf/arch/powerpc/util/skip-callchain-idx.c:250: undefined reference to `pr_debug' libperf.a(skip-callchain-idx.o): In function `check_return_addr':

Re: Linux 3.16: all my drivers on SPI bus report WARNING: at drivers/base/dd.c:286

-controller_state = cs; -- cgit v0.10.1 Le 19/08/2014 11:21, leroy christophe a écrit : Since Linux 3.16, for all drivers tied to SPI bus, I get the following warning on a PowerPC 8xx. It doesn't happen with Linux 3.15 What can be the reason / what should I look at ? [3.086957] device: 'spi32766.1

Re: [PATCH v2 1/2] spi: fsl-spi: Fix parameter ram offset setup for CPM1

Le 07/10/2014 02:15, Scott Wood a écrit : On Sat, 2014-10-04 at 14:02 +0200, christophe leroy wrote: Le 03/10/2014 22:29, Scott Wood a écrit : On Fri, 2014-10-03 at 18:49 +0200, Christophe Leroy wrote: On CPM1, the SPI parameter RAM has a default location. In fsl_spi_cpm_get_pram() there was

Re: [PATCH 2/2] spi: fsl-spi: Allow dynamic allocation of CPM1 parameter RAM

Le 07/10/2014 02:19, Scott Wood a écrit : On Sat, 2014-10-04 at 12:15 +0200, christophe leroy wrote: Le 03/10/2014 22:24, Scott Wood a écrit : On Fri, 2014-10-03 at 22:15 +0200, christophe leroy wrote: Le 03/10/2014 16:44, Mark Brown a écrit : On Fri, Oct 03, 2014 at 02:56:09PM +0200,

Re: [PATCH 0/2] net: fs_enet: Remove non NAPI RX and add NAPI for TX

Le 08/10/2014 22:03, David Miller a écrit : From: Christophe Leroy christophe.le...@c-s.fr Date: Tue, 7 Oct 2014 15:04:53 +0200 (CEST) When using a MPC8xx as a router, 'perf' shows a significant time spent in fs_enet_interrupt() and fs_enet_start_xmit(). 'perf annotate' shows that the time

Re: [PATCH v3 03/21] powerpc/8xx: exception InstructionAccess does not exist on MPC8xx

Le 18/09/2014 22:02, Joakim Tjernlund a écrit : christophe leroy christophe.le...@c-s.fr wrote on 2014/09/18 21:11:01: Le 18/09/2014 20:12, Joakim Tjernlund a écrit : leroy christophe christophe.le...@c-s.fr wrote on 2014/09/18 18:42:14: Le 18/09/2014 17:15, Joakim Tjernlund a écrit

3.16/3.16.1: Kernel Oops in nft_do_chain

Calling 'iptables-compat -L', first time nothing is listed on the screen. Second try, it generates following Oops. See below the console dump and the disassembled code around the failing address root@vgoip:~# /usr/local/sbin/iptables-compat -L root@vgoip:~# /usr/local/sbin/iptables-compat -L

Re: 3.16/3.16.1: Kernel Oops in nft_do_chain

Le 02/09/2014 12:41, Pablo Neira Ayuso a écrit : On Tue, Sep 02, 2014 at 12:14:27PM +0200, leroy christophe wrote: Calling 'iptables-compat -L', first time nothing is listed on the screen. Second try, it generates following Oops. I'm going to pass this patch to -stable asap: commit

Re: [PATCH v3 03/21] powerpc/8xx: exception InstructionAccess does not exist on MPC8xx

Le 18/09/2014 17:15, Joakim Tjernlund a écrit : Christophe Leroy christophe.le...@c-s.fr wrote on 2014/09/17 18:36:57: Exception InstructionAccess does not exist on MPC8xx. No need to branch there from somewhere else. Handling can be done directly in InstructionTLBError Exception.

Re: algif_hash: splice of data 2**16

Le 20/12/2014 07:37, Stephan Mueller a écrit : Am Donnerstag, 18. Dezember 2014, 13:22:20 schrieb leroy christophe: Hi Christophe, Le 18/12/2014 13:15, Stephan Mueller a écrit : Hi Herbert, While testing the vmsplice/splice interface of algif_hash I was made aware of the problem that data

Re: algif_hash: splice of data 2**16

Le 24/12/2014 10:03, Stephan Mueller a écrit : Am Dienstag, 23. Dezember 2014, 18:16:01 schrieb leroy christophe: Hi leroy, Le 20/12/2014 07:37, Stephan Mueller a écrit : Am Donnerstag, 18. Dezember 2014, 13:22:20 schrieb leroy christophe: Hi Christophe, Le 18/12/2014 13:15, Stephan

Re: [v4,17/21] powerpc/8xx: set PTE bit 22 off TLBmiss

Le 07/11/2014 04:37, Scott Wood a écrit : On Fri, Sep 19, 2014 at 10:36:09AM +0200, LEROY Christophe wrote: No need to re-set this bit at each TLB miss. Let's set it in the PTE. Signed-off-by: Christophe Leroy christophe.le...@c-s.fr --- Changes in v2: - None Changes in v3: - Removed PPC405

Re: [v2 PATCH 1/2] powerpc32: adds handling of _PAGE_RO

Le 18/12/2014 03:14, Scott Wood a écrit : On Wed, 2014-12-17 at 10:14 +0100, Christophe Leroy wrote: Some powerpc like the 8xx don't have a RW bit in PTE bits but a RO (Read Only) bit. This patch implements the handling of a _PAGE_RO flag to be used in place of _PAGE_RW Signed-off-by:

Re: algif_hash: splice of data 2**16

Le 18/12/2014 13:15, Stephan Mueller a écrit : Hi Herbert, While testing the vmsplice/splice interface of algif_hash I was made aware of the problem that data blobs larger than 16 pages do not seem to be hashed properly. For testing, a file is mmap()ed and handed to vmsplice / splice. If the

Re: [v2 PATCH 1/2] powerpc32: adds handling of _PAGE_RO

Le 18/12/2014 03:14, Scott Wood a écrit : On Wed, 2014-12-17 at 10:14 +0100, Christophe Leroy wrote: Some powerpc like the 8xx don't have a RW bit in PTE bits but a RO (Read Only) bit. This patch implements the handling of a _PAGE_RO flag to be used in place of _PAGE_RW Signed-off-by:

Re: [v2 PATCH 2/2] powerpc/8xx: use _PAGE_RO instead of _PAGE_RW

Le 18/12/2014 03:22, Scott Wood a écrit : On Wed, 2014-12-17 at 10:14 +0100, Christophe Leroy wrote: On powerpc 8xx, in TLB entries, 0x400 bit is set to 1 for read-only pages and is set to 0 for RW pages. So we should use _PAGE_RO instead of _PAGE_RW Signed-off-by: Christophe Leroy

Re: [PATCH v3 00/21] powerpc/8xx: Optimise MMU TLB handling and add support of 16k pages

Le 17/09/2014 22:34, Scott Wood a écrit : On Wed, 2014-09-17 at 22:33 +0200, christophe leroy wrote: Le 17/09/2014 18:40, Scott Wood a écrit : On Wed, 2014-09-17 at 18:36 +0200, Christophe Leroy wrote: This patchset: 1) provides several MMU TLB handling optimisation on MPC8xx. 2) adds

Re: [PATCH v2 07/11] powerpc/8xx: macro for handling CPU15 errata

Le 20/01/2015 12:09, David Laight a écrit : From Christophe Leroy Having a macro will help keep clear code. It might remove an #if but it doesn't really help. All it means is that anyone reading the code has to hunt for the definition before proceeding. Some comment about what (and why) the

Re: [PATCH v3 2/2] powerpc/8xx: use _PAGE_RO instead of _PAGE_RW

Le 05/01/2015 19:12, Joakim Tjernlund a écrit : On Mon, 2014-12-22 at 11:14 +0100, Christophe Leroy wrote: On powerpc 8xx, in TLB entries, 0x400 bit is set to 1 for read-only pages and is set to 0 for RW pages. So we should use _PAGE_RO instead of _PAGE_RW Signed-off-by: Christophe Leroy

Re: [PATCH 09/11] powerpc/8xx: dont save CR in SCRATCH registers

Le 05/01/2015 19:30, Joakim Tjernlund a écrit : On Tue, 2014-12-16 at 16:03 +0100, Christophe Leroy wrote: CR only needs to be preserved when checking if we are handling a kernel address. So we can preserve CR in a register: - In ITLBMiss, check is done only when CONFIG_MODULES is defined.

Re: [PATCH 05/11] powerpc/8xx: Optimise access to swapper_pg_dir

Le 06/01/2015 13:08, David Laight a écrit : On Tue, 2014-12-16 at 16:03 +0100, Christophe Leroy wrote: All accessed to PGD entries are done via 0(r11). By using lower part of swapper_pg_dir as load index to r11, we can remove the ori instruction. Signed-off-by: Christophe Leroy

Re: [PATCH 0/17] crypto: talitos - Add support for SEC1

Le 06/03/2015 01:21, Kim Phillips a écrit : On Thu, 5 Mar 2015 17:46:05 +0100 Christophe Leroy christophe.le...@c-s.fr wrote: [15/17] crypto: talitos - Implementation of SEC1 ... [16/17] crypto: talitos - SEC1 bugs on 0 data hash [17/17] crypto: talitos - Update DT bindings with SEC1

Re: [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1

Le 06/03/2015 12:44, Mark Brown a écrit : On Wed, Mar 04, 2015 at 09:00:39AM +0100, leroy christophe wrote: Le 03/03/2015 19:44, Mark Brown a écrit : Why are we using of_iomap() rather than a generic I/O mapping function here? because all drivers for powerpc seems to be using of_iomap

Re: [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1

Le 03/03/2015 19:44, Mark Brown a écrit : On Thu, Feb 26, 2015 at 05:11:42PM +0100, Christophe Leroy wrote: On CPM2, the SPI parameter RAM is dynamically allocated in the dualport RAM whereas in CPM1, it is statically allocated to a default address with capability to relocate it somewhere else

Re: [PATCH 0/17] crypto: talitos - Add support for SEC1

Le 06/03/2015 01:28, Herbert Xu a écrit : On Thu, Mar 05, 2015 at 06:21:01PM -0600, Kim Phillips wrote: On Thu, 5 Mar 2015 17:46:05 +0100 Christophe Leroy christophe.le...@c-s.fr wrote: [15/17] crypto: talitos - Implementation of SEC1 ... [16/17] crypto: talitos - SEC1 bugs on 0 data hash

Re: [v3, 01/11] powerpc/8xx: remove remaining unnecessary code in FixupDAR

Le 13/04/2015 22:26, Scott Wood a écrit : On Sun, 2015-04-12 at 18:16 +0200, leroy christophe wrote: Le 26/03/2015 22:32, Scott Wood a écrit : On Tue, Feb 03, 2015 at 12:38:16PM +0100, LEROY Christophe wrote: Since commit 33fb845a6f01 (powerpc/8xx: Don't use MD_TWC for walk), MD_EPN

Re: [PATCH 07/11] powerpc/8xx: macro for handling CPU15 errata

Le 20/04/2015 13:40, David Laight a écrit : From: Christophe Leroy Sent: 20 April 2015 06:27 Having a macro will help keep clear code. ... * We have to use the MD_xxx registers for the tablewalk because the * equivalent MI_xxx registers only perform the attribute functions. */ +

Re: [PATCH 00/11] powerpc8xx: Further optimisation of TLB handling

Le 20/04/2015 07:26, Christophe Leroy a écrit : This patchset provides a further optimisation of TLB handling in the 8xx. Main changes are based on: - Using processor handling of PGD/PTE Validity bits instead of testing ourselves the entries validity - Aligning PGD address to allow direct bit

Re: [PATCH v2] splice: sendfile() at once fails for big files

Le 06/05/2015 16:23, Jens Axboe a écrit : On 05/05/2015 09:41 PM, Linus Torvalds wrote: Jens, ping? The test results should make this a no-brainer, but I hate how random these flag ops. Missed the original, apparently. I too am confused how this is a correctness fix and not just an

Re: [v2,2/2] powerpc32: add support for csum_add()

Le 05/05/2015 00:10, Segher Boessenkool a écrit : On Fri, May 01, 2015 at 08:00:14PM -0500, Scott Wood wrote: On Tue, 2015-04-28 at 21:01 +0200, christophe leroy wrote: The generated code is most likely different on ppc64. I have no ppc64 compiler For reference: yes you do. Just add -m64.

Re: [PATCH v3 00/17] crypto: talitos - Add support for SEC1

Oops, this is the first time I use directly the output of git format-patch into sendmail, and it looks like the mails are dated with the commit date, not today's date. I will resend now with today's date. Sorry for the noise. Christophe Le 17/04/2015 15:47, Christophe Leroy a écrit : The

Re: [v3, 01/11] powerpc/8xx: remove remaining unnecessary code in FixupDAR

Le 26/03/2015 22:32, Scott Wood a écrit : On Tue, Feb 03, 2015 at 12:38:16PM +0100, LEROY Christophe wrote: Since commit 33fb845a6f01 (powerpc/8xx: Don't use MD_TWC for walk), MD_EPN and MD_TWC are not writen anymore in FixupDAR so saving r3 has become useless. Signed-off-by: Christophe

Re: [PATCH v3 03/17] crypto: talitos - talitos_ptr renamed ptr for more lisibility

Le 17/04/2015 17:14, David Laight a écrit : From: Christophe Leroy Linux CodyingStyle recommends to use short variables for local variables. ptr is just good enough for those 3 lines functions. It helps keep single lines shorter than 80 characters. ... -static void to_talitos_ptr(struct

Re: powerpc32: fix warning from include/linux/mm.h

Le 21/03/2015 00:52, Scott Wood a écrit : On Fri, Dec 05, 2014 at 12:20:20PM +0100, LEROY Christophe wrote: include/linux/mm.h: In function 'is_vmalloc_addr': include/linux/mm.h:367:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] return addr

Re: [PATCH v2 11/11] powerpc/8xx: Add support for TASK_SIZE greater than 0x80000000

Le 21/03/2015 01:47, Scott Wood a écrit : On Tue, 2015-01-20 at 10:57 +0100, Christophe Leroy wrote: By default, TASK_SIZE is set to 0x8000 for PPC_8xx, which is most likely sufficient for most cases. However, kernel configuration allows to set TASK_SIZE to another value, so the 8xx shall

Re: [BUG] mpc8323_rdb platform doesn't boot since kernel 3.16

Le 10/06/2015 20:17, Rob Herring a écrit : On Wed, Jun 10, 2015 at 10:12 AM, leroy christophe christophe.le...@c-s.fr wrote: Le 06/06/2015 17:32, Rob Herring a écrit : On Sat, Jun 6, 2015 at 6:20 AM, christophe leroy christophe.le...@c-s.fr wrote: I've got a MPC8323 RDB evaluation platform

Oops in 3.18.14 in destroy_inode()

[46796.501487] Unable to handle kernel paging request for data at address 0x02dd [46796.514365] Faulting instruction address: 0xc00c5978 [46796.524217] Oops: Kernel access of bad area, sig: 11 [#1] [46796.529351] PREEMPT CMPC885 [46796.532144] CPU: 0 PID: 1107 Comm: snmpd Not tainted 3.18.14

Re: [BUG] mpc8323_rdb platform doesn't boot since kernel 3.16

Le 06/06/2015 17:32, Rob Herring a écrit : On Sat, Jun 6, 2015 at 6:20 AM, christophe leroy christophe.le...@c-s.fr wrote: I've got a MPC8323 RDB evaluation platform from freescale kernel 4.0 doesn't boot kernel 3.16 doesn't boot kernel 3.15 boots ok I disected the issue down to your commit

Re: [HELP/RFC] Moving ppc8xx microcode patch from micropatch.c to firmware

Le 30/06/2015 22:38, christophe leroy a écrit : I'm trying to move the 3 microcode patches included in arch/powerpc/sysdev/micropatch.c into the firmware directory in order to use request_firmware() and then be able to add additional micropatch that I need to relocate SMC2 on my MPC885. I've

Re: [PATCH v2 2/2] powerpc32: optimise csum_partial() loop

Le 17/08/2015 12:56, leroy christophe a écrit : Le 07/08/2015 01:25, Segher Boessenkool a écrit : On Thu, Aug 06, 2015 at 05:45:45PM -0500, Scott Wood wrote: If this makes performance non-negligibly worse on other 32-bit chips, and is an important improvement on 8xx, then we can use

Re: [PATCH v2 2/2] powerpc32: optimise csum_partial() loop

Le 07/08/2015 01:25, Segher Boessenkool a écrit : On Thu, Aug 06, 2015 at 05:45:45PM -0500, Scott Wood wrote: If this makes performance non-negligibly worse on other 32-bit chips, and is an important improvement on 8xx, then we can use an ifdef since 8xx already requires its own kernel build.

Re: [PATCH v2 2/2] powerpc32: optimise csum_partial() loop

Le 17/08/2015 13:00, leroy christophe a écrit : Le 17/08/2015 12:56, leroy christophe a écrit : Le 07/08/2015 01:25, Segher Boessenkool a écrit : On Thu, Aug 06, 2015 at 05:45:45PM -0500, Scott Wood wrote: If this makes performance non-negligibly worse on other 32-bit chips

Strange reports of perf events on powerpc 83xx

Hi, Has anybody already used 'perf' tool on powerpc MPC83xx ? I have been succesfully using perf on MPC8xx, but on MPC83xx I get something strange. perf record/report reports addresses on user stack, as if it was mixing up D accesses and I accesses. Any idea of what the problem can be ?

Re: STRICT_KERNEL_RWX on PPC32 is broken on PowerMac G4

Meelis Roos a écrit : Meelis Roos a écrit : > > > For me, 4.13 worked and 4.14 hangs early during boot. Bisecting led to > > > the following commit. I had STRICT_KERNEL_RWX enabled when I met the > > > option. When I disabled STRICT_KERNEL_RWX, the same kernel

Re: STRICT_KERNEL_RWX on PPC32 is broken on PowerMac G4

Meelis Roos a écrit : > > How early does it hang ? Any oops or trace ? > > Very early - instead oif kernel emssages, I see some repeated gibberish > of some characteers, and the background turns white. > I am booting from yaboot, background is normally black. Ok, could you try

Re: STRICT_KERNEL_RWX on PPC32 is broken on PowerMac G4

Meelis Roos a écrit : > For me, 4.13 worked and 4.14 hangs early during boot. Bisecting led to > the following commit. I had STRICT_KERNEL_RWX enabled when I met the > option. When I disabled STRICT_KERNEL_RWX, the same kernel booted fine. Can you please check that 4.13 boots

Re: STRICT_KERNEL_RWX on PPC32 is broken on PowerMac G4

Meelis Roos a écrit : For me, 4.13 worked and 4.14 hangs early during boot. Bisecting led to the following commit. I had STRICT_KERNEL_RWX enabled when I met the option. When I disabled STRICT_KERNEL_RWX, the same kernel booted fine. Can you please check that 4.13 boots

Re: [PATCH 2/7] powerpc/traps: Return early in show_signal_msg()

Murilo Opsfelder Araujo a écrit : Modify logic of show_signal_msg() to return early, if possible. Replace printk_ratelimited() by printk() and a default rate limit burst to limit displaying unhandled signals messages. Can you explain more the benefits of this change ? Christophe

Re: [PATCH 6/7] powerpc/traps: Print signal name for unhandled signals

Murilo Opsfelder Araujo a écrit : This adds a human-readable name in the unhandled signal message. Before this patch, a page fault looked like: Jul 11 16:04:11 localhost kernel: pandafault[6303]: unhandled signal 11 at 17d0 nip 161c lr 7fff93c55100 code 2

Re: [PATCH 7/7] powerpc/traps: Show instructions on exceptions

Murilo Opsfelder Araujo a écrit : Move show_instructions() declaration to arch/powerpc/include/asm/stacktrace.h and include asm/stracktrace.h in arch/powerpc/kernel/process.c, which contains the implementation. Modify show_instructions() not to call __kernel_text_address(), allowing

Re: [PATCH v2 03/19] powerpc: Mark variables as unused

Michael Ellerman <m...@ellerman.id.au> a écrit : LEROY Christophe <christophe.le...@c-s.fr> writes: Mathieu Malaterre <ma...@debian.org> a écrit : Add gcc attribute unused for two variables. Fix warnings treated as errors with W=1: arch/powerpc/kernel/prom_init.c:1388:

Re: [PATCH v4 03/19] powerpc: Mark variable `l` as unused, remove `path`

Mathieu Malaterre a écrit : Add gcc attribute unused for `l` variable, replace `path` variable directly with prom_scratch. Fix warnings treated as errors with W=1: arch/powerpc/kernel/prom_init.c:607:6: error: variable ‘l’ set but not used

Re: [PATCH 14/19] powerpc/altivec: Add missing prototypes for altivec

Mathieu Malaterre <ma...@debian.org> a écrit : Christophe, On Sat, Mar 24, 2018 at 9:10 PM, LEROY Christophe <christophe.le...@c-s.fr> wrote: Mathieu Malaterre <ma...@debian.org> a écrit : On Fri, Mar 23, 2018 at 1:19 PM, christophe leroy <christophe.le...@c-s.fr>

Re: [PATCH 14/19] powerpc/altivec: Add missing prototypes for altivec

LEROY Christophe <christophe.le...@c-s.fr> a écrit : Mathieu Malaterre <ma...@debian.org> a écrit : Christophe, On Sat, Mar 24, 2018 at 9:10 PM, LEROY Christophe <christophe.le...@c-s.fr> wrote: Mathieu Malaterre <ma...@debian.org> a écrit : On Fri, Mar 23, 201

Re: [PATCH v2 05/19] powerpc/chrp/setup: Add attribute unused and make some functions static

The subject of the patch should be updated as well Christophe Mathieu Malaterre a écrit : Remove variable declaration idu_size and associated code since not used. These functions can all be static, make it so. Fix warnings treated as errors with W=1:

Re: [PATCH 15/19] powerpc: Add missing prototype

Mathieu Malaterre a écrit : On Fri, Mar 23, 2018 at 1:20 PM, christophe leroy wrote: Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit : Add one missing prototype for function rh_dump_blk. Fix warning treated as error in W=1:

Re: [PATCH v2 02/19] powerpc/powermac: Mark variable x as unused

Mathieu Malaterre a écrit : Since the value of x is never intended to be read, remove it. Fix warning treated as error with W=1: arch/powerpc/platforms/powermac/udbg_scc.c:76:9: error: variable ‘x’ set but not used [-Werror=unused-but-set-variable] Suggested-by:

Re: [PATCH v2 03/19] powerpc: Mark variables as unused

Mathieu Malaterre a écrit : Add gcc attribute unused for two variables. Fix warnings treated as errors with W=1: arch/powerpc/kernel/prom_init.c:1388:8: error: variable ‘path’ set but not used [-Werror=unused-but-set-variable] Suggested-by: Christophe Leroy

Re: [PATCH v2 04/19] powerpc/kvm: Prefer fault_in_pages_readable function

Mathieu Malaterre a écrit : Directly use fault_in_pages_readable instead of manual __get_user code. Fix warning treated as error with W=1: arch/powerpc/kernel/kvm.c:675:6: error: variable ‘tmp’ set but not used [-Werror=unused-but-set-variable] Suggested-by: Christophe

Re: [PATCH v2 01/19] powerpc/powermac: Mark variable x as unused

Mathieu Malaterre a écrit : Since the value of x is never intended to be read, declare it with gcc attribute as unused. Fix warning treated as error with W=1: arch/powerpc/platforms/powermac/bootx_init.c:471:21: error: variable ‘x’ set but not used

Re: [PATCH 14/19] powerpc/altivec: Add missing prototypes for altivec

Mathieu Malaterre a écrit : On Fri, Mar 23, 2018 at 1:19 PM, christophe leroy wrote: Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit : Some functions prototypes were missing for the non-altivec code. Add the missing prototypes directly in

Re: [PATCH 01/16] initrd: Add generic code path for common initrd unloading logic.

Shea Levy a écrit : Signed-off-by: Shea Levy --- init/initramfs.c | 7 +++ usr/Kconfig | 4 2 files changed, 11 insertions(+) diff --git a/init/initramfs.c b/init/initramfs.c index 7e99a0038942..de5ce873eb5a 100644 --- a/init/initramfs.c

Re: [PATCH 11/19] powerpc/powermac: Move pmac_pfunc_base_install prototype to header file

Mathieu Malaterre a écrit : On Fri, Mar 23, 2018 at 1:13 PM, christophe leroy wrote: Le 22/03/2018 à 21:19, Mathieu Malaterre a écrit : The pmac_pfunc_base_install prototype was declared in powermac/smp.c since function was used there, move it

Re: [PATCH AUTOSEL 4.14 05/30] powerpc/traps: restore recoverability of machine_check interrupts

Looks like this patch didn't make its way into 4.14 yet. Is there a problem with this patch ? Christophe Sasha Levin a écrit : From: Christophe Leroy [ Upstream commit daf00ae71dad8aa05965713c62558aeebf2df48e ] commit b96672dd840f ("powerpc: Machine check interrupt is a non- maskable

Re: [v2] Enhanced support for MPC8xx/8xxx watchdog

Le 26/06/2013 01:04, Scott Wood a écrit : On Thu, Feb 28, 2013 at 09:52:22AM +0100, LEROY Christophe wrote: This patch modifies the behaviour of the MPC8xx/8xxx watchdog. On the MPC8xx, at 133Mhz, the maximum timeout of the watchdog timer is 1s, which means it must be pinged twice a second

Re: [PATCH] powerpc 8xx: Fixing memory init issue with CONFIG_PIN_TLB

Le 15/10/2013 22:33, Scott Wood a écrit : On Tue, 2013-10-15 at 18:27 +0200, leroy christophe wrote: Le 11/10/2013 17:13, Joakim Tjernlund a écrit : "Linuxppc-dev" wrote on 2013/10/11 14:56:40: Activating CONFIG_PIN_TLB allows access to the 24 first Mbytes of memory at bootup in

Re: [PATCH] watchdog: mpc8xxx_wdt convert to watchdog core

Le 01/12/2013 20:38, Guenter Roeck a écrit : On 11/30/2013 07:33 AM, Christophe Leroy wrote: Convert mpc8xxx_wdt.c to the new watchdog API. Signed-off-by: Christophe Leroy diff -ur a/drivers/watchdog/mpc8xxx_wdt.c b/drivers/watchdog/mpc8xxx_wdt.c --- a/drivers/watchdog/mpc8xxx_wdt.c

BUG: Patch "Convert some mftb/mftbu into mfspr" breaks MPC885

Scott, The patch "Convert some mftb/mftbu into mfspr" (beb2dc0a7a84be003ce54e98b95d65cc66e6e536) breaks startup on MPC885. The CPU traps (SoftwareEmulation trap) at sched_clock() when trying to read TBU with mfspr. Reverting the patch solves the issue. What's the prefered way to fix this

Re: [PATCH] Enhanced support for MPC8xx/8xxx watchdog

Hi Wim, Le 27/02/2013 20:52, Wim Van Sebroeck a écrit : The rest of the code is OK and when above comments are corrected, I will add the patch to improve the userspace experience. Kind regards, Wim. Ok, I'll fix and re-submit my patch according to your comments. Best regards Christophe --

  1   2   3   >