Re: Additional performance data on Pavel's smb3 multi credit patch series

2014-07-13 Thread ronnie sahlberg
Impressive! On Sun, Jul 13, 2014 at 12:23 PM, Steve French smfre...@gmail.com wrote: Performance of Pavel's multicredit i/o SMB3 patches continues to look good. Additional informal performance results below comparing cifs mounts with smb3 mounts (vers=3.0) with and without Pavel's patch set.

Re: [Patch v7 05/22] CIFS: SMBD: Establish SMB Direct connection

2017-11-19 Thread ronnie sahlberg
On Tue, Nov 7, 2017 at 6:54 PM, Long Li wrote: > From: Long Li > > Add code to implement the core functions to establish a SMB Direct connection. > > 1. Establish an RDMA connection to SMB server. > 2. Negotiate and setup SMB Direct protocol.

Re: [PATCHv2][SMB3] Add kernel trace support

2018-05-17 Thread Ronnie Sahlberg
Very nice. Acked-by: Ronnie Sahlberg <lsahl...@redhat.com> Possibly change the output from pid=6633 tid=0x0 sid=0x0 cmd=0 mid=0 to cmd=0 mid=0 pid=6633 tid=0x0 sid=0x0 just to make it easier for human-searching. I think the cmd will be useful much more often than pid/tid/sid and this

Re: [PATCHv2][SMB3] Add kernel trace support

2018-05-18 Thread ronnie sahlberg
17, 2018 at 10:28 PM, Ronnie Sahlberg <lsahl...@redhat.com> wrote: >> Very nice. >> >> Acked-by: Ronnie Sahlberg <lsahl...@redhat.com> >> >> Possibly change the output from >> pid=6633 tid=0x0 sid=0x0 cmd=0 mid=0 >> to >> cmd=0 mid=0 pid=663

Re: linux-next: manual merge of the cifs tree with Linus' tree

2018-06-13 Thread Ronnie Sahlberg
Steve, Looks good. It builds and seems to work in my testing. Thanks. - Original Message - From: "Steve French" To: "Stephen Rothwell" Cc: "CIFS" , "Linux-Next Mailing List" , "Linux Kernel Mailing List" , "Kees Cook" , &q

Re: F_OFD_GETLK implemented wrong with CIFS protocol version 2.0+

2018-06-26 Thread Ronnie Sahlberg
The problem is in fs/cifs/file.c:cifs_find_fid_lock_conflict since it is not aware of OFD locks and thus think there is a conflict. I have an initial patch that fixes the problem for the reproducer but need more time to understand if/what else might need fixin. - Original Message -

Re: [PATCH] cifs: remove redundant duplicated assignment of pointer 'node'

2018-01-17 Thread Ronnie Sahlberg
Reviewed-by: Ronnie Sahlberg <lsahl...@redhat.com> - Original Message - From: "Colin King" <colin.k...@canonical.com> To: "Steve French" <sfre...@samba.org>, linux-c...@vger.kernel.org, samba-techni...@lists.samba.org Cc: kernel-janit...@vger.ke

Re: Overview of performance improvements of recent SMB3 compounding patches

2018-08-22 Thread Ronnie Sahlberg
code but if someone would want to tackle this I think there is opportunity to make a huge impact on directory listing performance. regards ronnie sahlberg - Original Message - > From: "Steve French" > To: "CIFS" , "samba-technical" > , "LKM

Re: [PATCH 1/2] cifs: smbd: avoid reconnect lockup

2018-03-30 Thread ronnie sahlberg
Looks good to me (both patches) Reviewed-by: Ronnie Sahlberg <lsahl...@redhat.com> On Sat, Mar 31, 2018 at 8:16 AM, Long Li <lon...@linuxonhyperv.com> wrote: > From: Long Li <lon...@microsoft.com> > > During transport reconnect, other processes may have regi

Re: config files and how to have persistent Linux kernel Driver/File System configuration info saved

2018-06-28 Thread ronnie sahlberg
On Fri, Jun 29, 2018 at 8:58 AM, Theodore Y. Ts'o via samba-technical wrote: > On Thu, Jun 28, 2018 at 05:37:15PM -0500, Steve French wrote: >> Ronnie brought up an interesting point about the problems consistently >> configuring file systems (or any Linux module for that matter) so that >>

Re: [PATCH v2] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Ronnie Sahlberg
Good catch, but I think it should be : int resp_buftype = CIFS_NO_BUFFER; - Original Message - From: "Gustavo A. R. Silva" To: "Steve French" , "Ronnie Sahlberg" Cc: linux-c...@vger.kernel.org, samba-techni...@lists.samba.org, linux-kernel@vger.kernel.or