Re: [PATCH] kconfig.h: remove config_enabled() macro

2016-10-20 Thread Masahiro Yamada
Hi Paul, 2016-10-20 21:44 GMT+09:00 Paul Bolle : > [Added Nicolas.] > > On Thu, 2016-10-20 at 21:06 +0900, Masahiro Yamada wrote: >> 2016-10-20 19:04 GMT+09:00 Paul Bolle : >> > On Sun, 2016-10-16 at 20:07 +0900, Masahiro Yamada wrote: >> > There are about a dozen instances of IS_ENABLED() that t

Re: [PATCH] kconfig.h: remove config_enabled() macro

2016-10-20 Thread Nicolas Pitre
On Thu, 20 Oct 2016, Paul Bolle wrote: > [Added Nicolas.] > > On Thu, 2016-10-20 at 21:06 +0900, Masahiro Yamada wrote: > > 2016-10-20 19:04 GMT+09:00 Paul Bolle : > > > Is there a reason to keep using the double underscore prefix? > > > > I followed the suggestion in the following message: > >

Re: [PATCH] kconfig.h: remove config_enabled() macro

2016-10-20 Thread Paul Bolle
[Added Nicolas.] On Thu, 2016-10-20 at 21:06 +0900, Masahiro Yamada wrote: > 2016-10-20 19:04 GMT+09:00 Paul Bolle : > > On Sun, 2016-10-16 at 20:07 +0900, Masahiro Yamada wrote: > > There are about a dozen instances of IS_ENABLED() that target something > > other than a kconfig macros. Are you pl

Re: [PATCH] kconfig.h: remove config_enabled() macro

2016-10-20 Thread Masahiro Yamada
Hi Paul, 2016-10-20 19:04 GMT+09:00 Paul Bolle : > Masahiro, > > A few comments regarding, I guess, future work. > > On Sun, 2016-10-16 at 20:07 +0900, Masahiro Yamada wrote: >> The use of config_enabled() is ambiguous. For config options, >> IS_ENABLED(), IS_REACHABLE(), etc. will make intenti

Re: [PATCH] kconfig.h: remove config_enabled() macro

2016-10-20 Thread Paul Bolle
Masahiro, A few comments regarding, I guess, future work. On Sun, 2016-10-16 at 20:07 +0900, Masahiro Yamada wrote: > The use of config_enabled() is ambiguous.  For config options, > IS_ENABLED(), IS_REACHABLE(), etc. will make intention clearer. > Sometimes config_enabled() has been used for non

Re: [PATCH] kconfig.h: remove config_enabled() macro

2016-10-16 Thread Masahiro Yamada
Hi Peter. 2016-10-17 3:44 GMT+09:00 : > > How is __is_defined() different from defined()? defined() can be used only in pre-processor's #if context, like #if defined(FOO) ... #endif __is_defined() can be used more flexibly. -- Best Regards Masahiro Yamada

Re: [PATCH] kconfig.h: remove config_enabled() macro

2016-10-16 Thread hpa
On October 16, 2016 4:07:58 AM PDT, Masahiro Yamada wrote: >The use of config_enabled() is ambiguous. For config options, >IS_ENABLED(), IS_REACHABLE(), etc. will make intention clearer. >Sometimes config_enabled() has been used for non-config options >because it is useful to check whether the g

Re: [PATCH] kconfig.h: remove config_enabled() macro

2016-10-16 Thread Ingo Molnar
* Masahiro Yamada wrote: > The use of config_enabled() is ambiguous. For config options, > IS_ENABLED(), IS_REACHABLE(), etc. will make intention clearer. > Sometimes config_enabled() has been used for non-config options > because it is useful to check whether the given symbol is defined > or n

[PATCH] kconfig.h: remove config_enabled() macro

2016-10-16 Thread Masahiro Yamada
The use of config_enabled() is ambiguous. For config options, IS_ENABLED(), IS_REACHABLE(), etc. will make intention clearer. Sometimes config_enabled() has been used for non-config options because it is useful to check whether the given symbol is defined or not. I have been tackling on deprecati