Re: [PATCH] mtd: spi-nor: Kill check with no effect

2017-10-10 Thread Cyrille Pitchen
Le 17/09/2017 à 16:13, Richard Weinberger a écrit : > header.major is of type u8 and cannot be negative. > > Detected by CoverityScan CID#1417858 ("Integer handling issues") > > Fixes: f384b352cbf0 ("mtd: spi-nor: parse Serial Flash Discoverable > Parameters (SFDP) tables") > Signed-off-by:

Re: [PATCH] mtd: spi-nor: Kill check with no effect

2017-10-10 Thread Cyrille Pitchen
Le 17/09/2017 à 16:13, Richard Weinberger a écrit : > header.major is of type u8 and cannot be negative. > > Detected by CoverityScan CID#1417858 ("Integer handling issues") > > Fixes: f384b352cbf0 ("mtd: spi-nor: parse Serial Flash Discoverable > Parameters (SFDP) tables") > Signed-off-by:

Re: [PATCH] mtd: spi-nor: Kill check with no effect

2017-09-19 Thread Cyrille Pitchen
Hi Richard, Le 18/09/2017 à 11:44, Boris Brezillon a écrit : > On Sun, 17 Sep 2017 16:13:52 +0200 > Richard Weinberger wrote: > >> header.major is of type u8 and cannot be negative. > > I guess you meant header.minor here. > >> >> Detected by CoverityScan CID#1417858 ("Integer

Re: [PATCH] mtd: spi-nor: Kill check with no effect

2017-09-19 Thread Cyrille Pitchen
Hi Richard, Le 18/09/2017 à 11:44, Boris Brezillon a écrit : > On Sun, 17 Sep 2017 16:13:52 +0200 > Richard Weinberger wrote: > >> header.major is of type u8 and cannot be negative. > > I guess you meant header.minor here. > >> >> Detected by CoverityScan CID#1417858 ("Integer handling

Re: [PATCH] mtd: spi-nor: Kill check with no effect

2017-09-18 Thread Richard Weinberger
Am Montag, 18. September 2017, 11:44:51 CEST schrieb Boris Brezillon: > On Sun, 17 Sep 2017 16:13:52 +0200 > > Richard Weinberger wrote: > > header.major is of type u8 and cannot be negative. > > I guess you meant header.minor here. Correct. :) Thanks, //richard

Re: [PATCH] mtd: spi-nor: Kill check with no effect

2017-09-18 Thread Richard Weinberger
Am Montag, 18. September 2017, 11:44:51 CEST schrieb Boris Brezillon: > On Sun, 17 Sep 2017 16:13:52 +0200 > > Richard Weinberger wrote: > > header.major is of type u8 and cannot be negative. > > I guess you meant header.minor here. Correct. :) Thanks, //richard

Re: [PATCH] mtd: spi-nor: Kill check with no effect

2017-09-18 Thread Boris Brezillon
On Sun, 17 Sep 2017 16:13:52 +0200 Richard Weinberger wrote: > header.major is of type u8 and cannot be negative. I guess you meant header.minor here. > > Detected by CoverityScan CID#1417858 ("Integer handling issues") > > Fixes: f384b352cbf0 ("mtd: spi-nor: parse Serial

Re: [PATCH] mtd: spi-nor: Kill check with no effect

2017-09-18 Thread Boris Brezillon
On Sun, 17 Sep 2017 16:13:52 +0200 Richard Weinberger wrote: > header.major is of type u8 and cannot be negative. I guess you meant header.minor here. > > Detected by CoverityScan CID#1417858 ("Integer handling issues") > > Fixes: f384b352cbf0 ("mtd: spi-nor: parse Serial Flash Discoverable

[PATCH] mtd: spi-nor: Kill check with no effect

2017-09-17 Thread Richard Weinberger
header.major is of type u8 and cannot be negative. Detected by CoverityScan CID#1417858 ("Integer handling issues") Fixes: f384b352cbf0 ("mtd: spi-nor: parse Serial Flash Discoverable Parameters (SFDP) tables") Signed-off-by: Richard Weinberger --- Cyrille, I'm not sure what

[PATCH] mtd: spi-nor: Kill check with no effect

2017-09-17 Thread Richard Weinberger
header.major is of type u8 and cannot be negative. Detected by CoverityScan CID#1417858 ("Integer handling issues") Fixes: f384b352cbf0 ("mtd: spi-nor: parse Serial Flash Discoverable Parameters (SFDP) tables") Signed-off-by: Richard Weinberger --- Cyrille, I'm not sure what exactly you wanted