Re: [PATCH BUGFIX 0/6] pkt_sched: fix little service anomalies and possible crashes of qfq+
From: Paolo valente Date: Tue, 5 Mar 2013 19:04:56 +0100 > Split, and inserted a detailed description of both the problem and the fix > in each patch. Series applied, thanks. Although two topics for possibly resolving later: 1) That 1ULL bit mask fix is quite expensive on 32-bit, it would probably be cheaper to test for that case using a helper function that nops out on 64-bit. Although this is not so important. 2) That static inline forward declaration is ugly, better to remove the inline tag (let the compiler handle it) or move the function above all the call sites. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH BUGFIX 0/6] pkt_sched: fix little service anomalies and possible crashes of qfq+
Il 26/02/2013 23:37, David Miller ha scritto: > From: Paolo valente > Date: Tue, 26 Feb 2013 18:02:46 +0100 > >> The portions of the code interested by each fix are small and do not >> overlap with each other, so I decided to provide just one patch >> (I hope that this was the right choice). > > Please split this up into 6 patches, each with an appropriately > verbose analysis and explanation of each bug being fixed, thanks. > > Split, and inserted a detailed description of both the problem and the fix in each patch. Paolo valente (6): pkt_sched: properly cap timestamps in charge_actual_service pkt_sched: fix the update of eligible-group sets pkt_sched: serve activated aggregates immediately if the scheduler is empty pkt_sched: prevent budget from wrapping around after a dequeue pkt_sched: do not allow virtual time to jump if an aggregate is in service pkt_sched: remove a useless invocation of qfq_update_eligible net/sched/sch_qfq.c | 66 +++ 1 file changed, 45 insertions(+), 21 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH BUGFIX 0/6] pkt_sched: fix little service anomalies and possible crashes of qfq+
Il 26/02/2013 23:37, David Miller ha scritto: From: Paolo valente paolo.vale...@unimore.it Date: Tue, 26 Feb 2013 18:02:46 +0100 The portions of the code interested by each fix are small and do not overlap with each other, so I decided to provide just one patch (I hope that this was the right choice). Please split this up into 6 patches, each with an appropriately verbose analysis and explanation of each bug being fixed, thanks. Split, and inserted a detailed description of both the problem and the fix in each patch. Paolo valente (6): pkt_sched: properly cap timestamps in charge_actual_service pkt_sched: fix the update of eligible-group sets pkt_sched: serve activated aggregates immediately if the scheduler is empty pkt_sched: prevent budget from wrapping around after a dequeue pkt_sched: do not allow virtual time to jump if an aggregate is in service pkt_sched: remove a useless invocation of qfq_update_eligible net/sched/sch_qfq.c | 66 +++ 1 file changed, 45 insertions(+), 21 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH BUGFIX 0/6] pkt_sched: fix little service anomalies and possible crashes of qfq+
From: Paolo valente paolo.vale...@unimore.it Date: Tue, 5 Mar 2013 19:04:56 +0100 Split, and inserted a detailed description of both the problem and the fix in each patch. Series applied, thanks. Although two topics for possibly resolving later: 1) That 1ULL bit mask fix is quite expensive on 32-bit, it would probably be cheaper to test for that case using a helper function that nops out on 64-bit. Although this is not so important. 2) That static inline forward declaration is ugly, better to remove the inline tag (let the compiler handle it) or move the function above all the call sites. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
