Re: [PATCH v2] x86: i8237: Register based on FADT legacy boot flag

2018-03-19 Thread Thomas Gleixner
On Mon, 19 Mar 2018, Anshuman Gupta wrote: > On Wed, Mar 14, 2018 at 04:07:43PM +0100, Thomas Gleixner wrote: > > On Wed, 14 Mar 2018, Rajneesh Bhardwaj wrote: > > > + * support 8237 DMA or bus mastering from LPC. Platform firmware > > > + * must announce the support for such legacy devices via

Re: [PATCH v2] x86: i8237: Register based on FADT legacy boot flag

2018-03-19 Thread Thomas Gleixner
On Mon, 19 Mar 2018, Anshuman Gupta wrote: > On Wed, Mar 14, 2018 at 04:07:43PM +0100, Thomas Gleixner wrote: > > On Wed, 14 Mar 2018, Rajneesh Bhardwaj wrote: > > > + * support 8237 DMA or bus mastering from LPC. Platform firmware > > > + * must announce the support for such legacy devices via

Re: [PATCH v2] x86: i8237: Register based on FADT legacy boot flag

2018-03-14 Thread Thomas Gleixner
On Wed, 14 Mar 2018, Rajneesh Bhardwaj wrote: > static int __init i8237A_init_ops(void) > { > + /* > + * From SKL PCH onwards, the port 0x61 bit 4 would stop toggle and s/would stop toggle/stops toggling/ You are describing a fact, right? > + * the legacy DMA device is removed

Re: [PATCH v2] x86: i8237: Register based on FADT legacy boot flag

2018-03-14 Thread Thomas Gleixner
On Wed, 14 Mar 2018, Rajneesh Bhardwaj wrote: > static int __init i8237A_init_ops(void) > { > + /* > + * From SKL PCH onwards, the port 0x61 bit 4 would stop toggle and s/would stop toggle/stops toggling/ You are describing a fact, right? > + * the legacy DMA device is removed

Re: [PATCH v2] x86: i8237: Register based on FADT legacy boot flag

2018-03-14 Thread Andy Shevchenko
On Wed, 2018-03-14 at 10:47 +0530, Rajneesh Bhardwaj wrote: > From Skylake onwards, the platform controller hub (Sunrisepoint PCH) > does > not support legacy DMA operations to IO ports 81h-83h, 87h, 89h-8Bh, > 8Fh. > Currently this driver registers as syscore ops and its resume function > is >

Re: [PATCH v2] x86: i8237: Register based on FADT legacy boot flag

2018-03-14 Thread Andy Shevchenko
On Wed, 2018-03-14 at 10:47 +0530, Rajneesh Bhardwaj wrote: > From Skylake onwards, the platform controller hub (Sunrisepoint PCH) > does > not support legacy DMA operations to IO ports 81h-83h, 87h, 89h-8Bh, > 8Fh. > Currently this driver registers as syscore ops and its resume function > is >

[PATCH v2] x86: i8237: Register based on FADT legacy boot flag

2018-03-13 Thread Rajneesh Bhardwaj
>From Skylake onwards, the platform controller hub (Sunrisepoint PCH) does not support legacy DMA operations to IO ports 81h-83h, 87h, 89h-8Bh, 8Fh. Currently this driver registers as syscore ops and its resume function is called on every resume from S3. On Skylake and Kabylake, this causes a

[PATCH v2] x86: i8237: Register based on FADT legacy boot flag

2018-03-13 Thread Rajneesh Bhardwaj
>From Skylake onwards, the platform controller hub (Sunrisepoint PCH) does not support legacy DMA operations to IO ports 81h-83h, 87h, 89h-8Bh, 8Fh. Currently this driver registers as syscore ops and its resume function is called on every resume from S3. On Skylake and Kabylake, this causes a