Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

On 2018-03-24 17:52, Wolfram Sang wrote: On Mon, Mar 12, 2018 at 06:44:49PM +0530, Abhishek Sahu wrote: * v2: 1. Address review comments in v1 2. Changed the license to SPDX 3. Changed commit messages for some of the patch having more detail 4. Removed event-based completion and changed

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

On 2018-03-24 17:52, Wolfram Sang wrote: On Mon, Mar 12, 2018 at 06:44:49PM +0530, Abhishek Sahu wrote: * v2: 1. Address review comments in v1 2. Changed the license to SPDX 3. Changed commit messages for some of the patch having more detail 4. Removed event-based completion and changed

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

On Mon, Mar 12, 2018 at 06:44:49PM +0530, Abhishek Sahu wrote: > * v2: > > 1. Address review comments in v1 > 2. Changed the license to SPDX > 3. Changed commit messages for some of the patch having more detail > 4. Removed event-based completion and changed transfer completion >detection

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

On Mon, Mar 12, 2018 at 06:44:49PM +0530, Abhishek Sahu wrote: > * v2: > > 1. Address review comments in v1 > 2. Changed the license to SPDX > 3. Changed commit messages for some of the patch having more detail > 4. Removed event-based completion and changed transfer completion >detection

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

I trust the reviews of Andy and Sricharan for this series. From what I looked at, the patches look good to me. Only one question left about copyrights (raised seperately), but we are good to go I think. Thanks for all the review! signature.asc Description: PGP signature

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

I trust the reviews of Andy and Sricharan for this series. From what I looked at, the patches look good to me. Only one question left about copyrights (raised seperately), but we are good to go I think. Thanks for all the review! signature.asc Description: PGP signature

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

On Tue, Mar 13, 2018 at 04:12:19PM -0600, Christ, Austin wrote: > Sorry for the miscommunication. I reviewed the patches and tested them on > the Centriq 2400 platform. > > Perhaps the following is the most appropriate. > > Acked-by: Austin Christ If you are okay with

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

On Tue, Mar 13, 2018 at 04:12:19PM -0600, Christ, Austin wrote: > Sorry for the miscommunication. I reviewed the patches and tested them on > the Centriq 2400 platform. > > Perhaps the following is the most appropriate. > > Acked-by: Austin Christ If you are okay with that, I'll just read it

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

On 2018-03-14 03:42, Christ, Austin wrote: Sorry for the miscommunication. I reviewed the patches and tested them on the Centriq 2400 platform. Perhaps the following is the most appropriate. Acked-by: Austin Christ Thanks Austin for reviewing and testing the code

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

On 2018-03-14 03:42, Christ, Austin wrote: Sorry for the miscommunication. I reviewed the patches and tested them on the Centriq 2400 platform. Perhaps the following is the most appropriate. Acked-by: Austin Christ Thanks Austin for reviewing and testing the code changes. It would be

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

Sorry for the miscommunication. I reviewed the patches and tested them on the Centriq 2400 platform. Perhaps the following is the most appropriate. Acked-by: Austin Christ On 3/13/2018 3:17 PM, Wolfram Sang wrote: On Tue, Mar 13, 2018 at 03:09:00PM -0600, Christ,

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

Sorry for the miscommunication. I reviewed the patches and tested them on the Centriq 2400 platform. Perhaps the following is the most appropriate. Acked-by: Austin Christ On 3/13/2018 3:17 PM, Wolfram Sang wrote: On Tue, Mar 13, 2018 at 03:09:00PM -0600, Christ, Austin wrote: I've tested

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

On Tue, Mar 13, 2018 at 03:09:00PM -0600, Christ, Austin wrote: > I've tested this v2 series on Centriq 2400. Looks good to me. > > Reviewed-by: Austin Christ I am a little confused. Do you mean Tested-by or Reviewed-by? signature.asc Description: PGP signature

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

On Tue, Mar 13, 2018 at 03:09:00PM -0600, Christ, Austin wrote: > I've tested this v2 series on Centriq 2400. Looks good to me. > > Reviewed-by: Austin Christ I am a little confused. Do you mean Tested-by or Reviewed-by? signature.asc Description: PGP signature

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

I've tested this v2 series on Centriq 2400. Looks good to me. Reviewed-by: Austin Christ On 3/12/2018 7:14 AM, Abhishek Sahu wrote: * v2: 1. Address review comments in v1 2. Changed the license to SPDX 3. Changed commit messages for some of the patch having more

Re: [PATCH v2 00/13] Major code reorganization to make all i2c transfers working

I've tested this v2 series on Centriq 2400. Looks good to me. Reviewed-by: Austin Christ On 3/12/2018 7:14 AM, Abhishek Sahu wrote: * v2: 1. Address review comments in v1 2. Changed the license to SPDX 3. Changed commit messages for some of the patch having more detail 4. Removed event-based

[PATCH v2 00/13] Major code reorganization to make all i2c transfers working

* v2: 1. Address review comments in v1 2. Changed the license to SPDX 3. Changed commit messages for some of the patch having more detail 4. Removed event-based completion and changed transfer completion detection logic in interrupt handler 5. Removed dma_threshold and blk_mode_threshold from

[PATCH v2 00/13] Major code reorganization to make all i2c transfers working

* v2: 1. Address review comments in v1 2. Changed the license to SPDX 3. Changed commit messages for some of the patch having more detail 4. Removed event-based completion and changed transfer completion detection logic in interrupt handler 5. Removed dma_threshold and blk_mode_threshold from