Re: [PATCH v2 3/3] perf/buildid-cache: Support --purge-all option

2018-05-08 Thread Ravi Bangoria
On 05/08/2018 09:12 PM, Masami Hiramatsu wrote: > On Thu, 3 May 2018 14:24:04 +0530 > Ravi Bangoria wrote: > >> Hi Masami, >> >> On 04/23/2018 12:32 PM, Masami Hiramatsu wrote: >>> On Tue, 17 Apr 2018 09:43:46 +0530 >>> Ravi Bangoria wrote: >>> + pr_debug("Purged all: %s\n", err ? "FAIL"

Re: [PATCH v2 3/3] perf/buildid-cache: Support --purge-all option

2018-05-08 Thread Masami Hiramatsu
On Thu, 3 May 2018 14:24:04 +0530 Ravi Bangoria wrote: > Hi Masami, > > On 04/23/2018 12:32 PM, Masami Hiramatsu wrote: > > On Tue, 17 Apr 2018 09:43:46 +0530 > > Ravi Bangoria wrote: > > > >> + pr_debug("Purged all: %s\n", err ? "FAIL" : "Ok"); > > Hmm, I think this should use pr_info(or pr_w

Re: [PATCH v2 3/3] perf/buildid-cache: Support --purge-all option

2018-05-03 Thread Ravi Bangoria
Hi Masami, On 04/23/2018 12:32 PM, Masami Hiramatsu wrote: > On Tue, 17 Apr 2018 09:43:46 +0530 > Ravi Bangoria wrote: > >> +pr_debug("Purged all: %s\n", err ? "FAIL" : "Ok"); > Hmm, I think this should use pr_info(or pr_warning), at least for Failure > case. Actually, I followed what is al

Re: [PATCH v2 3/3] perf/buildid-cache: Support --purge-all option

2018-04-23 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 17, 2018 at 09:43:46AM +0530, Ravi Bangoria escreveu: > User can remove files from cache using --remove/--purge options > but both needs list of files as an argument. It's not convenient > when you want to flush out entire cache. Add an option to purge > all files from cache. > > Ex, >

Re: [PATCH v2 3/3] perf/buildid-cache: Support --purge-all option

2018-04-23 Thread Masami Hiramatsu
On Tue, 17 Apr 2018 09:43:46 +0530 Ravi Bangoria wrote: > User can remove files from cache using --remove/--purge options > but both needs list of files as an argument. It's not convenient > when you want to flush out entire cache. Add an option to purge > all files from cache. > > Ex, > # per

[PATCH v2 3/3] perf/buildid-cache: Support --purge-all option

2018-04-16 Thread Ravi Bangoria
User can remove files from cache using --remove/--purge options but both needs list of files as an argument. It's not convenient when you want to flush out entire cache. Add an option to purge all files from cache. Ex, # perf buildid-cache -l 8a86ef73e44067bca52cc3f6cd3e5446c783391c /tmp/a.o