Re: RCU stall in 8250 serial driver Linux 4.15-rc1

On Tue, Jan 23, 2018 at 5:52 PM, Alan Cox wrote: > On Wed, 17 Jan 2018 09:24:32 -0800 > Shankara Pailoor wrote: > >> Hi Greg, >> >> Sorry for that. Here is the stack trace. C Program below > > > >> serial_in drivers/tty/serial/8250/8250.h:111

Re: RCU stall in 8250 serial driver Linux 4.15-rc1

On Tue, Jan 23, 2018 at 5:52 PM, Alan Cox wrote: > On Wed, 17 Jan 2018 09:24:32 -0800 > Shankara Pailoor wrote: > >> Hi Greg, >> >> Sorry for that. Here is the stack trace. C Program below > > > >> serial_in drivers/tty/serial/8250/8250.h:111 [inline] >> wait_for_xmitr+0x8a/0x1d0

Re: RCU stall in 8250 serial driver Linux 4.15-rc1

On Wed, 17 Jan 2018 09:24:32 -0800 Shankara Pailoor wrote: > Hi Greg, > > Sorry for that. Here is the stack trace. C Program below > serial_in drivers/tty/serial/8250/8250.h:111 [inline] > wait_for_xmitr+0x8a/0x1d0 drivers/tty/serial/8250/8250_port.c:2033 >

Re: RCU stall in 8250 serial driver Linux 4.15-rc1

On Wed, 17 Jan 2018 09:24:32 -0800 Shankara Pailoor wrote: > Hi Greg, > > Sorry for that. Here is the stack trace. C Program below > serial_in drivers/tty/serial/8250/8250.h:111 [inline] > wait_for_xmitr+0x8a/0x1d0 drivers/tty/serial/8250/8250_port.c:2033 >

Re: Possible Memory Leak in KCOV Linux 4.15-rc1

On Sun, Jan 21, 2018 at 6:54 PM, Shankara Pailoor wrote: > Below is a reproducer. > > #define _GNU_SOURCE > #include > #include > #include > #include > #include > > #define KCOV_INIT_TRACE _IOR('c', 1, unsigned long) > #define KCOV_ENABLE _IO('c', 100) > #define

Re: Possible Memory Leak in KCOV Linux 4.15-rc1

On Sun, Jan 21, 2018 at 6:54 PM, Shankara Pailoor wrote: > Below is a reproducer. > > #define _GNU_SOURCE > #include > #include > #include > #include > #include > > #define KCOV_INIT_TRACE _IOR('c', 1, unsigned long) > #define KCOV_ENABLE _IO('c', 100) > #define KCOV_DISABLE _IO('c', 101) >

Re: Possible Memory Leak in KCOV Linux 4.15-rc1

Below is a reproducer. #define _GNU_SOURCE #include #include #include #include #include #define KCOV_INIT_TRACE _IOR('c', 1, unsigned long) #define KCOV_ENABLE _IO('c', 100) #define KCOV_DISABLE _IO('c', 101) #define COVER_SIZE (16 << 20) void kcov_setup() { unsigned long *cover;

Re: Possible Memory Leak in KCOV Linux 4.15-rc1

Below is a reproducer. #define _GNU_SOURCE #include #include #include #include #include #define KCOV_INIT_TRACE _IOR('c', 1, unsigned long) #define KCOV_ENABLE _IO('c', 100) #define KCOV_DISABLE _IO('c', 101) #define COVER_SIZE (16 << 20) void kcov_setup() { unsigned long *cover;

Re: Possible Memory Leak in KCOV Linux 4.15-rc1

Hi Dmitry, The leaks went away when I disabled and closed the old file descriptors before opening new ones. The patch you sent wouldn't work because t is not initialized at the line. This seems to work for me diff --git a/kernel/kcov.c b/kernel/kcov.c index 7594c03..1397006 100644 ---

Re: Possible Memory Leak in KCOV Linux 4.15-rc1

Hi Dmitry, The leaks went away when I disabled and closed the old file descriptors before opening new ones. The patch you sent wouldn't work because t is not initialized at the line. This seems to work for me diff --git a/kernel/kcov.c b/kernel/kcov.c index 7594c03..1397006 100644 ---

Re: Possible Memory Leak in KCOV Linux 4.15-rc1

On Sat, Jan 20, 2018 at 4:01 PM, Shankara Pailoor wrote: > Hi Dmitry, > > I will try and get something to you tomorrow. Just wondering, but what > happens to the old struct kcov if a task opens /sys/kernel/debug/kcov > twice? I am looking here >

Re: Possible Memory Leak in KCOV Linux 4.15-rc1

On Sat, Jan 20, 2018 at 4:01 PM, Shankara Pailoor wrote: > Hi Dmitry, > > I will try and get something to you tomorrow. Just wondering, but what > happens to the old struct kcov if a task opens /sys/kernel/debug/kcov > twice? I am looking here >

Re: Possible Memory Leak in KCOV Linux 4.15-rc1

Hi Dmitry, I will try and get something to you tomorrow. Just wondering, but what happens to the old struct kcov if a task opens /sys/kernel/debug/kcov twice? I am looking here https://elixir.free-electrons.com/linux/v4.15-rc8/source/kernel/kcov.c#L381 and I don't see where the previous struct

Re: Possible Memory Leak in KCOV Linux 4.15-rc1

Hi Dmitry, I will try and get something to you tomorrow. Just wondering, but what happens to the old struct kcov if a task opens /sys/kernel/debug/kcov twice? I am looking here https://elixir.free-electrons.com/linux/v4.15-rc8/source/kernel/kcov.c#L381 and I don't see where the previous struct

Re: Possible Memory Leak in KCOV Linux 4.15-rc1

On Fri, Jan 19, 2018 at 8:29 PM, Shankara Pailoor wrote: > Hi Dmitry, > > I added support for kcov in strace and I have been tracing a fairly > large program but after a little while, I notice that when I mmap a > new cover buffer, the call fails with ENOMEM. After killing

Re: Possible Memory Leak in KCOV Linux 4.15-rc1

On Fri, Jan 19, 2018 at 8:29 PM, Shankara Pailoor wrote: > Hi Dmitry, > > I added support for kcov in strace and I have been tracing a fairly > large program but after a little while, I notice that when I mmap a > new cover buffer, the call fails with ENOMEM. After killing the > program, I try

Possible Memory Leak in KCOV Linux 4.15-rc1

Hi Dmitry, I added support for kcov in strace and I have been tracing a fairly large program but after a little while, I notice that when I mmap a new cover buffer, the call fails with ENOMEM. After killing the program, I try and rerun and I notice that there is nearly no memory on the system.

Possible Memory Leak in KCOV Linux 4.15-rc1

Hi Dmitry, I added support for kcov in strace and I have been tracing a fairly large program but after a little while, I notice that when I mmap a new cover buffer, the call fails with ENOMEM. After killing the program, I try and rerun and I notice that there is nearly no memory on the system.

Re: RCU stall in 8250 serial driver Linux 4.15-rc1

e: > On Wed, Jan 17, 2018 at 08:53:06AM -0800, Shankara Pailoor wrote: >> Hi, >> >> Syzkaller found the following rcu stall report in Linux 4.15-rc1: >> https://pastebin.com/NyZ9JdRv >> >> The following C program reproduces it: https://pastebin.com/gqwDWWpA >&g

Re: RCU stall in 8250 serial driver Linux 4.15-rc1

8 at 08:53:06AM -0800, Shankara Pailoor wrote: >> Hi, >> >> Syzkaller found the following rcu stall report in Linux 4.15-rc1: >> https://pastebin.com/NyZ9JdRv >> >> The following C program reproduces it: https://pastebin.com/gqwDWWpA >> >> Configs Here:

Re: RCU stall in 8250 serial driver Linux 4.15-rc1

On Wed, Jan 17, 2018 at 08:53:06AM -0800, Shankara Pailoor wrote: > Hi, > > Syzkaller found the following rcu stall report in Linux 4.15-rc1: > https://pastebin.com/NyZ9JdRv > > The following C program reproduces it: https://pastebin.com/gqwDWWpA > > Configs Here: https

Re: RCU stall in 8250 serial driver Linux 4.15-rc1

On Wed, Jan 17, 2018 at 08:53:06AM -0800, Shankara Pailoor wrote: > Hi, > > Syzkaller found the following rcu stall report in Linux 4.15-rc1: > https://pastebin.com/NyZ9JdRv > > The following C program reproduces it: https://pastebin.com/gqwDWWpA > > Configs Here: https

RCU stall in 8250 serial driver Linux 4.15-rc1

Hi, Syzkaller found the following rcu stall report in Linux 4.15-rc1: https://pastebin.com/NyZ9JdRv The following C program reproduces it: https://pastebin.com/gqwDWWpA Configs Here: https://pastebin.com/v6M3iKi1 Regards, Shankara

RCU stall in 8250 serial driver Linux 4.15-rc1

Hi, Syzkaller found the following rcu stall report in Linux 4.15-rc1: https://pastebin.com/NyZ9JdRv The following C program reproduces it: https://pastebin.com/gqwDWWpA Configs Here: https://pastebin.com/v6M3iKi1 Regards, Shankara

Re: linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282: bad if condition ?

On 11/27/2017 06:32 AM, David Binderman wrote: Hello there, linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282]: (style) Expression is always false because 'else if' condition matches previous condition at line 2279 Source code is if (new_smi->p

Re: linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282: bad if condition ?

On 11/27/2017 06:32 AM, David Binderman wrote: Hello there, linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282]: (style) Expression is always false because 'else if' condition matches previous condition at line 2279 Source code is if (new_smi->p

RE: linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640: poor error checking ?

org; dri-de...@lists.freedesktop.org; linux-kernel@vger.kernel.org Subject: linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640: poor error checking ? Hello there, linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640]: (style) Checking if unsigned variable 'bb_size' is less than zero.

RE: linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640: poor error checking ?

Subject: linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640: poor error checking ? Hello there, linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640]: (style) Checking if unsigned variable 'bb_size' is less than zero. Source code is /* get the size of the batch buffer

Linux 4.15-rc1

So it's been the usual two weeks of merge window, and rc1 is out. And that normal time length is about the only thing usual about this merge window. Because of the indiscriminate mass slaughter of turkeys in the US last week, lots of people - including me - were on vacation. That meant that I had

Linux 4.15-rc1

So it's been the usual two weeks of merge window, and rc1 is out. And that normal time length is about the only thing usual about this merge window. Because of the indiscriminate mass slaughter of turkeys in the US last week, lots of people - including me - were on vacation. That meant that I had