RE: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-17 Thread KY Srinivasan 


> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, July 17, 2012 12:04 PM
> To: KY Srinivasan
> Cc: linux-kernel@vger.kernel.org; de...@linuxdriverproject.org;
> virtualizat...@lists.osdl.org; o...@aepfle.de; a...@canonical.com
> Subject: Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards
> 
> On Sat, Jul 14, 2012 at 01:34:06PM -0700, K. Y. Srinivasan wrote:
> > Format GUIDS as per MSFT standard. This makes interacting with MSFT
> > tool stack easier.
> >
> > Signed-off-by: K. Y. Srinivasan 
> > Reviewed-by: Haiyang Zhang 
> > ---
> >  drivers/hv/vmbus_drv.c |4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> > index a220e57..1f7e54a 100644
> > --- a/drivers/hv/vmbus_drv.c
> > +++ b/drivers/hv/vmbus_drv.c
> > @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device
> *dev,
> >
> > if (!strcmp(dev_attr->attr.name, "class_id")) {
> > ret = sprintf(buf, "{%02x%02x%02x%02x-%02x%02x-%02x%02x-"
> > -  "%02x%02x%02x%02x%02x%02x%02x%02x}\n",
> > +  "%02x%02x-%02x%02x%02x%02x%02x%02x}\n",
> 
> As Joe pointed out, please just use the printk modifier the kernel
> already has for GUIDS, and don't roll your own here.  That will work
> properly for you, right?

Will do. Please drop the patch-set; I will post new patches soon.

K. Y



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-17 Thread Greg KH 
On Tue, Jul 17, 2012 at 09:19:26AM -0700, Joe Perches wrote:
> On Tue, 2012-07-17 at 09:04 -0700, Greg KH wrote:
> > On Sat, Jul 14, 2012 at 01:34:06PM -0700, K. Y. Srinivasan wrote:
> > > Format GUIDS as per MSFT standard. This makes interacting with MSFT
> > > tool stack easier.
> []
> > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> []
> > > @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device 
> > > *dev,
> > >  
> > >   if (!strcmp(dev_attr->attr.name, "class_id")) {
> > >   ret = sprintf(buf, "{%02x%02x%02x%02x-%02x%02x-%02x%02x-"
> > > -"%02x%02x%02x%02x%02x%02x%02x%02x}\n",
> > > +"%02x%02x-%02x%02x%02x%02x%02x%02x}\n",
> > 
> > As Joe pointed out, please just use the printk modifier the kernel
> > already has for GUIDS, and don't roll your own here.  That will work
> > properly for you, right?
> 
> %pU became available in 2.6.33
> 
> I think one of their support targets is RHEL6 which
> I believe is 2.6.32+.

That's nice, but it's nothing that I care about for in-kernel code, nor
should anyone else.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-17 Thread Joe Perches 
On Tue, 2012-07-17 at 09:04 -0700, Greg KH wrote:
> On Sat, Jul 14, 2012 at 01:34:06PM -0700, K. Y. Srinivasan wrote:
> > Format GUIDS as per MSFT standard. This makes interacting with MSFT
> > tool stack easier.
[]
> > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
[]
> > @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device 
> > *dev,
> >  
> > if (!strcmp(dev_attr->attr.name, "class_id")) {
> > ret = sprintf(buf, "{%02x%02x%02x%02x-%02x%02x-%02x%02x-"
> > -  "%02x%02x%02x%02x%02x%02x%02x%02x}\n",
> > +  "%02x%02x-%02x%02x%02x%02x%02x%02x}\n",
> 
> As Joe pointed out, please just use the printk modifier the kernel
> already has for GUIDS, and don't roll your own here.  That will work
> properly for you, right?

%pU became available in 2.6.33

I think one of their support targets is RHEL6 which
I believe is 2.6.32+.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-17 Thread Greg KH 
On Sat, Jul 14, 2012 at 01:34:06PM -0700, K. Y. Srinivasan wrote:
> Format GUIDS as per MSFT standard. This makes interacting with MSFT
> tool stack easier.
> 
> Signed-off-by: K. Y. Srinivasan 
> Reviewed-by: Haiyang Zhang 
> ---
>  drivers/hv/vmbus_drv.c |4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index a220e57..1f7e54a 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device *dev,
>  
>   if (!strcmp(dev_attr->attr.name, "class_id")) {
>   ret = sprintf(buf, "{%02x%02x%02x%02x-%02x%02x-%02x%02x-"
> -"%02x%02x%02x%02x%02x%02x%02x%02x}\n",
> +"%02x%02x-%02x%02x%02x%02x%02x%02x}\n",

As Joe pointed out, please just use the printk modifier the kernel
already has for GUIDS, and don't roll your own here.  That will work
properly for you, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-17 Thread Greg KH 
On Sat, Jul 14, 2012 at 01:34:06PM -0700, K. Y. Srinivasan wrote:
 Format GUIDS as per MSFT standard. This makes interacting with MSFT
 tool stack easier.
 
 Signed-off-by: K. Y. Srinivasan k...@microsoft.com
 Reviewed-by: Haiyang Zhang haiya...@microsoft.com
 ---
  drivers/hv/vmbus_drv.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
 index a220e57..1f7e54a 100644
 --- a/drivers/hv/vmbus_drv.c
 +++ b/drivers/hv/vmbus_drv.c
 @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device *dev,
  
   if (!strcmp(dev_attr-attr.name, class_id)) {
   ret = sprintf(buf, {%02x%02x%02x%02x-%02x%02x-%02x%02x-
 -%02x%02x%02x%02x%02x%02x%02x%02x}\n,
 +%02x%02x-%02x%02x%02x%02x%02x%02x}\n,

As Joe pointed out, please just use the printk modifier the kernel
already has for GUIDS, and don't roll your own here.  That will work
properly for you, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-17 Thread Joe Perches 
On Tue, 2012-07-17 at 09:04 -0700, Greg KH wrote:
 On Sat, Jul 14, 2012 at 01:34:06PM -0700, K. Y. Srinivasan wrote:
  Format GUIDS as per MSFT standard. This makes interacting with MSFT
  tool stack easier.
[]
  diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
[]
  @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device 
  *dev,
   
  if (!strcmp(dev_attr-attr.name, class_id)) {
  ret = sprintf(buf, {%02x%02x%02x%02x-%02x%02x-%02x%02x-
  -  %02x%02x%02x%02x%02x%02x%02x%02x}\n,
  +  %02x%02x-%02x%02x%02x%02x%02x%02x}\n,
 
 As Joe pointed out, please just use the printk modifier the kernel
 already has for GUIDS, and don't roll your own here.  That will work
 properly for you, right?

%pU became available in 2.6.33

I think one of their support targets is RHEL6 which
I believe is 2.6.32+.


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-17 Thread Greg KH 
On Tue, Jul 17, 2012 at 09:19:26AM -0700, Joe Perches wrote:
 On Tue, 2012-07-17 at 09:04 -0700, Greg KH wrote:
  On Sat, Jul 14, 2012 at 01:34:06PM -0700, K. Y. Srinivasan wrote:
   Format GUIDS as per MSFT standard. This makes interacting with MSFT
   tool stack easier.
 []
   diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
 []
   @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device 
   *dev,

 if (!strcmp(dev_attr-attr.name, class_id)) {
 ret = sprintf(buf, {%02x%02x%02x%02x-%02x%02x-%02x%02x-
   -%02x%02x%02x%02x%02x%02x%02x%02x}\n,
   +%02x%02x-%02x%02x%02x%02x%02x%02x}\n,
  
  As Joe pointed out, please just use the printk modifier the kernel
  already has for GUIDS, and don't roll your own here.  That will work
  properly for you, right?
 
 %pU became available in 2.6.33
 
 I think one of their support targets is RHEL6 which
 I believe is 2.6.32+.

That's nice, but it's nothing that I care about for in-kernel code, nor
should anyone else.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-17 Thread KY Srinivasan 


 -Original Message-
 From: Greg KH [mailto:gre...@linuxfoundation.org]
 Sent: Tuesday, July 17, 2012 12:04 PM
 To: KY Srinivasan
 Cc: linux-kernel@vger.kernel.org; de...@linuxdriverproject.org;
 virtualizat...@lists.osdl.org; o...@aepfle.de; a...@canonical.com
 Subject: Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards
 
 On Sat, Jul 14, 2012 at 01:34:06PM -0700, K. Y. Srinivasan wrote:
  Format GUIDS as per MSFT standard. This makes interacting with MSFT
  tool stack easier.
 
  Signed-off-by: K. Y. Srinivasan k...@microsoft.com
  Reviewed-by: Haiyang Zhang haiya...@microsoft.com
  ---
   drivers/hv/vmbus_drv.c |4 ++--
   1 files changed, 2 insertions(+), 2 deletions(-)
 
  diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
  index a220e57..1f7e54a 100644
  --- a/drivers/hv/vmbus_drv.c
  +++ b/drivers/hv/vmbus_drv.c
  @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device
 *dev,
 
  if (!strcmp(dev_attr-attr.name, class_id)) {
  ret = sprintf(buf, {%02x%02x%02x%02x-%02x%02x-%02x%02x-
  -  %02x%02x%02x%02x%02x%02x%02x%02x}\n,
  +  %02x%02x-%02x%02x%02x%02x%02x%02x}\n,
 
 As Joe pointed out, please just use the printk modifier the kernel
 already has for GUIDS, and don't roll your own here.  That will work
 properly for you, right?

Will do. Please drop the patch-set; I will post new patches soon.

K. Y



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-14 Thread Joe Perches 
On Sat, 2012-07-14 at 23:23 +, KY Srinivasan wrote:
> > -Original Message-
> > From: Joe Perches [mailto:j...@perches.com]
> > Sent: Saturday, July 14, 2012 4:25 PM
[]
> > On Sat, 2012-07-14 at 13:34 -0700, K. Y. Srinivasan wrote:
> > > Format GUIDS as per MSFT standard. This makes interacting with MSFT
> > > tool stack easier.
[]
> > > @@ -166,7 +166,7 @@ static ssize_t vmbus_show_device_attr(struct device
> > *dev,
> > >  device_info->chn_type.b[15]);
> > >   } else if (!strcmp(dev_attr->attr.name, "device_id")) {
> > >   ret = sprintf(buf, "{%02x%02x%02x%02x-%02x%02x-%02x%02x-"
> > > -"%02x%02x%02x%02x%02x%02x%02x%02x}\n",
> > > +"%02x%02x-%02x%02x%02x%02x%02x%02x}\n",
> > >  device_info->chn_instance.b[3],
> > >  device_info->chn_instance.b[2],
> > >  device_info->chn_instance.b[1],
> > 
> > ret = sprintf(buf, "{%pUl}\n", device_info->chn_instance.b);
> 
> Thank you Joe. I recall seeing some patches from you a longtime ago on this.
> I was just modifying existing code in this patch; if it is ok with you I will 
> send a
> separate patch using the preferred format string for printing GUIDS.

Hi KY.  It's your code.  Do what you think best.  cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-14 Thread KY Srinivasan 


> -Original Message-
> From: Joe Perches [mailto:j...@perches.com]
> Sent: Saturday, July 14, 2012 4:25 PM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org;
> de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; o...@aepfle.de;
> a...@canonical.com
> Subject: Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards
> 
> On Sat, 2012-07-14 at 13:34 -0700, K. Y. Srinivasan wrote:
> > Format GUIDS as per MSFT standard. This makes interacting with MSFT
> > tool stack easier.
> >
> > Signed-off-by: K. Y. Srinivasan 
> > Reviewed-by: Haiyang Zhang 
> > ---
> >  drivers/hv/vmbus_drv.c |4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> > index a220e57..1f7e54a 100644
> > --- a/drivers/hv/vmbus_drv.c
> > +++ b/drivers/hv/vmbus_drv.c
> > @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device
> *dev,
> >
> > if (!strcmp(dev_attr->attr.name, "class_id")) {
> > ret = sprintf(buf, "{%02x%02x%02x%02x-%02x%02x-%02x%02x-"
> > -  "%02x%02x%02x%02x%02x%02x%02x%02x}\n",
> > +  "%02x%02x-%02x%02x%02x%02x%02x%02x}\n",
> >device_info->chn_type.b[3],
> >device_info->chn_type.b[2],
> >device_info->chn_type.b[1],
> > @@ -166,7 +166,7 @@ static ssize_t vmbus_show_device_attr(struct device
> *dev,
> >device_info->chn_type.b[15]);
> > } else if (!strcmp(dev_attr->attr.name, "device_id")) {
> > ret = sprintf(buf, "{%02x%02x%02x%02x-%02x%02x-%02x%02x-"
> > -  "%02x%02x%02x%02x%02x%02x%02x%02x}\n",
> > +  "%02x%02x-%02x%02x%02x%02x%02x%02x}\n",
> >device_info->chn_instance.b[3],
> >device_info->chn_instance.b[2],
> >device_info->chn_instance.b[1],
> 
>   ret = sprintf(buf, "{%pUl}\n", device_info->chn_instance.b);

Thank you Joe. I recall seeing some patches from you a longtime ago on this.
I was just modifying existing code in this patch; if it is ok with you I will 
send a
separate patch using the preferred format string for printing GUIDS.
 
Regards,

K. Y
N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z��w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i

Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-14 Thread Joe Perches 
On Sat, 2012-07-14 at 13:34 -0700, K. Y. Srinivasan wrote:
> Format GUIDS as per MSFT standard. This makes interacting with MSFT
> tool stack easier.
> 
> Signed-off-by: K. Y. Srinivasan 
> Reviewed-by: Haiyang Zhang 
> ---
>  drivers/hv/vmbus_drv.c |4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index a220e57..1f7e54a 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device *dev,
>  
>   if (!strcmp(dev_attr->attr.name, "class_id")) {
>   ret = sprintf(buf, "{%02x%02x%02x%02x-%02x%02x-%02x%02x-"
> -"%02x%02x%02x%02x%02x%02x%02x%02x}\n",
> +"%02x%02x-%02x%02x%02x%02x%02x%02x}\n",
>  device_info->chn_type.b[3],
>  device_info->chn_type.b[2],
>  device_info->chn_type.b[1],
> @@ -166,7 +166,7 @@ static ssize_t vmbus_show_device_attr(struct device *dev,
>  device_info->chn_type.b[15]);
>   } else if (!strcmp(dev_attr->attr.name, "device_id")) {
>   ret = sprintf(buf, "{%02x%02x%02x%02x-%02x%02x-%02x%02x-"
> -"%02x%02x%02x%02x%02x%02x%02x%02x}\n",
> +"%02x%02x-%02x%02x%02x%02x%02x%02x}\n",
>  device_info->chn_instance.b[3],
>  device_info->chn_instance.b[2],
>  device_info->chn_instance.b[1],

ret = sprintf(buf, "{%pUl}\n", device_info->chn_instance.b);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-14 Thread Joe Perches 
On Sat, 2012-07-14 at 13:34 -0700, K. Y. Srinivasan wrote:
 Format GUIDS as per MSFT standard. This makes interacting with MSFT
 tool stack easier.
 
 Signed-off-by: K. Y. Srinivasan k...@microsoft.com
 Reviewed-by: Haiyang Zhang haiya...@microsoft.com
 ---
  drivers/hv/vmbus_drv.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
 index a220e57..1f7e54a 100644
 --- a/drivers/hv/vmbus_drv.c
 +++ b/drivers/hv/vmbus_drv.c
 @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device *dev,
  
   if (!strcmp(dev_attr-attr.name, class_id)) {
   ret = sprintf(buf, {%02x%02x%02x%02x-%02x%02x-%02x%02x-
 -%02x%02x%02x%02x%02x%02x%02x%02x}\n,
 +%02x%02x-%02x%02x%02x%02x%02x%02x}\n,
  device_info-chn_type.b[3],
  device_info-chn_type.b[2],
  device_info-chn_type.b[1],
 @@ -166,7 +166,7 @@ static ssize_t vmbus_show_device_attr(struct device *dev,
  device_info-chn_type.b[15]);
   } else if (!strcmp(dev_attr-attr.name, device_id)) {
   ret = sprintf(buf, {%02x%02x%02x%02x-%02x%02x-%02x%02x-
 -%02x%02x%02x%02x%02x%02x%02x%02x}\n,
 +%02x%02x-%02x%02x%02x%02x%02x%02x}\n,
  device_info-chn_instance.b[3],
  device_info-chn_instance.b[2],
  device_info-chn_instance.b[1],

ret = sprintf(buf, {%pUl}\n, device_info-chn_instance.b);


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-14 Thread KY Srinivasan 


 -Original Message-
 From: Joe Perches [mailto:j...@perches.com]
 Sent: Saturday, July 14, 2012 4:25 PM
 To: KY Srinivasan
 Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org;
 de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; o...@aepfle.de;
 a...@canonical.com
 Subject: Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards
 
 On Sat, 2012-07-14 at 13:34 -0700, K. Y. Srinivasan wrote:
  Format GUIDS as per MSFT standard. This makes interacting with MSFT
  tool stack easier.
 
  Signed-off-by: K. Y. Srinivasan k...@microsoft.com
  Reviewed-by: Haiyang Zhang haiya...@microsoft.com
  ---
   drivers/hv/vmbus_drv.c |4 ++--
   1 files changed, 2 insertions(+), 2 deletions(-)
 
  diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
  index a220e57..1f7e54a 100644
  --- a/drivers/hv/vmbus_drv.c
  +++ b/drivers/hv/vmbus_drv.c
  @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device
 *dev,
 
  if (!strcmp(dev_attr-attr.name, class_id)) {
  ret = sprintf(buf, {%02x%02x%02x%02x-%02x%02x-%02x%02x-
  -  %02x%02x%02x%02x%02x%02x%02x%02x}\n,
  +  %02x%02x-%02x%02x%02x%02x%02x%02x}\n,
 device_info-chn_type.b[3],
 device_info-chn_type.b[2],
 device_info-chn_type.b[1],
  @@ -166,7 +166,7 @@ static ssize_t vmbus_show_device_attr(struct device
 *dev,
 device_info-chn_type.b[15]);
  } else if (!strcmp(dev_attr-attr.name, device_id)) {
  ret = sprintf(buf, {%02x%02x%02x%02x-%02x%02x-%02x%02x-
  -  %02x%02x%02x%02x%02x%02x%02x%02x}\n,
  +  %02x%02x-%02x%02x%02x%02x%02x%02x}\n,
 device_info-chn_instance.b[3],
 device_info-chn_instance.b[2],
 device_info-chn_instance.b[1],
 
   ret = sprintf(buf, {%pUl}\n, device_info-chn_instance.b);

Thank you Joe. I recall seeing some patches from you a longtime ago on this.
I was just modifying existing code in this patch; if it is ok with you I will 
send a
separate patch using the preferred format string for printing GUIDS.
 
Regards,

K. Y
N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z��w���?��)ߢf��^jǫy�m��@A�a���
0��h���i

RE: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards

2012-07-14 Thread Joe Perches 
On Sat, 2012-07-14 at 23:23 +, KY Srinivasan wrote:
  -Original Message-
  From: Joe Perches [mailto:j...@perches.com]
  Sent: Saturday, July 14, 2012 4:25 PM
[]
  On Sat, 2012-07-14 at 13:34 -0700, K. Y. Srinivasan wrote:
   Format GUIDS as per MSFT standard. This makes interacting with MSFT
   tool stack easier.
[]
   @@ -166,7 +166,7 @@ static ssize_t vmbus_show_device_attr(struct device
  *dev,
device_info-chn_type.b[15]);
 } else if (!strcmp(dev_attr-attr.name, device_id)) {
 ret = sprintf(buf, {%02x%02x%02x%02x-%02x%02x-%02x%02x-
   -%02x%02x%02x%02x%02x%02x%02x%02x}\n,
   +%02x%02x-%02x%02x%02x%02x%02x%02x}\n,
device_info-chn_instance.b[3],
device_info-chn_instance.b[2],
device_info-chn_instance.b[1],
  
  ret = sprintf(buf, {%pUl}\n, device_info-chn_instance.b);
 
 Thank you Joe. I recall seeing some patches from you a longtime ago on this.
 I was just modifying existing code in this patch; if it is ok with you I will 
 send a
 separate patch using the preferred format string for printing GUIDS.

Hi KY.  It's your code.  Do what you think best.  cheers, Joe

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/