RE: [PATCH v6 19/34] xlink-core: Add xlink core device tree bindings

2021-04-20 Thread Gross, Mark 


> -Original Message-
> From: Dave Hansen 
> Sent: Monday, April 12, 2021 2:33 PM
> To: mgr...@linux.intel.com; markgr...@kernel.org; a...@arndb.de; b...@suse.de;
> damien.lem...@wdc.com; dragan.cve...@xilinx.com;
> gre...@linuxfoundation.org; cor...@lwn.net; palmerdabb...@google.com;
> paul.walms...@sifive.com; peng@nxp.com; robh...@kernel.org;
> shawn...@kernel.org; jassisinghb...@gmail.com
> Cc: linux-kernel@vger.kernel.org; Kelly, Seamus ;
> devicet...@vger.kernel.org
> Subject: Re: [PATCH v6 19/34] xlink-core: Add xlink core device tree bindings
> 
> On 2/12/21 2:22 PM, mgr...@linux.intel.com wrote:
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) # Copyright (c)
> > +Intel Corporation. All rights reserved.
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/misc/intel,keembay-xlink.yaml#;
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#;
> > +
> > +title: Intel Keem Bay xlink
> 
> Is there a specific reason this is dual licensed?  If so, can you please 
> include
> information about the license choice in the next post's cover letter?
> 
> If there is no specific reason for this contribution to be dual licensed, 
> please make it
> GPL-2.0 only.
I will.

I'm just waiting on some testing before making the next post.

Thanks,
--mark

Re: [PATCH v6 19/34] xlink-core: Add xlink core device tree bindings

2021-04-12 Thread Dave Hansen 
On 2/12/21 2:22 PM, mgr...@linux.intel.com wrote:
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (c) Intel Corporation. All rights reserved.
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/misc/intel,keembay-xlink.yaml#;
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#;
> +
> +title: Intel Keem Bay xlink

Is there a specific reason this is dual licensed?  If so, can you please
include information about the license choice in the next post's cover
letter?

If there is no specific reason for this contribution to be dual
licensed, please make it GPL-2.0 only.

Re: [PATCH v6 19/34] xlink-core: Add xlink core device tree bindings

2021-03-08 Thread mark gross 
On Fri, Mar 05, 2021 at 03:03:00PM -0600, Rob Herring wrote:
> On Fri, Feb 12, 2021 at 02:22:49PM -0800, mgr...@linux.intel.com wrote:
> > From: Seamus Kelly 
> > 
> > Add device tree bindings for keembay-xlink.
> > 
> > Cc: Rob Herring 
> > Cc: devicet...@vger.kernel.org
> > Reviewed-by: Mark Gross 
> > Signed-off-by: Mark Gross 
> > Signed-off-by: Seamus Kelly 
> > ---
> >  .../bindings/misc/intel,keembay-xlink.yaml| 29 +++
> >  1 file changed, 29 insertions(+)
> >  create mode 100644 
> > Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> > 
> > diff --git 
> > a/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml 
> > b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> > new file mode 100644
> > index ..5ac2e7fa5b5e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> > @@ -0,0 +1,29 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright (c) Intel Corporation. All rights reserved.
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/misc/intel,keembay-xlink.yaml#;
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#;
> > +
> > +title: Intel Keem Bay xlink
> > +
> > +maintainers:
> > +  - Seamus Kelly 
> > +
> > +description: |
> > +  The Keem Bay xlink driver enables the communication/control sub-system
> > +  for internal and external communications to the Intel Keem Bay SoC.
> > +
> > +properties:
> > +  compatible:
> > +oneOf:
> > +  - items:
> > +  - const: intel,keembay-xlink
> > +
> > +additionalProperties: False
> > +
> > +examples:
> > +  - |
> > +xlink {
> > +compatible = "intel,keembay-xlink";
> 
> A node with only a compatible is almost always abusing DT just to 
> instantiate your driver.

Is it normal to make drivers that want to abuse DT in this way platform
devices?

Any advice would be welcome and helful.

thanks!

--mark

Re: [PATCH v6 19/34] xlink-core: Add xlink core device tree bindings

2021-03-05 Thread Rob Herring 
On Fri, Feb 12, 2021 at 02:22:49PM -0800, mgr...@linux.intel.com wrote:
> From: Seamus Kelly 
> 
> Add device tree bindings for keembay-xlink.
> 
> Cc: Rob Herring 
> Cc: devicet...@vger.kernel.org
> Reviewed-by: Mark Gross 
> Signed-off-by: Mark Gross 
> Signed-off-by: Seamus Kelly 
> ---
>  .../bindings/misc/intel,keembay-xlink.yaml| 29 +++
>  1 file changed, 29 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> 
> diff --git a/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml 
> b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> new file mode 100644
> index ..5ac2e7fa5b5e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (c) Intel Corporation. All rights reserved.
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/misc/intel,keembay-xlink.yaml#;
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#;
> +
> +title: Intel Keem Bay xlink
> +
> +maintainers:
> +  - Seamus Kelly 
> +
> +description: |
> +  The Keem Bay xlink driver enables the communication/control sub-system
> +  for internal and external communications to the Intel Keem Bay SoC.
> +
> +properties:
> +  compatible:
> +oneOf:
> +  - items:
> +  - const: intel,keembay-xlink
> +
> +additionalProperties: False
> +
> +examples:
> +  - |
> +xlink {
> +compatible = "intel,keembay-xlink";

A node with only a compatible is almost always abusing DT just to 
instantiate your driver.

Rob