Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2018-01-02 Thread Pavel Machek
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c > index e7bd2e750f69..0858c08b3b89 100644 > --- a/drivers/char/tpm/tpm_tis_core.c > +++ b/drivers/char/tpm/tpm_tis_core.c > @@ -688,7 +688,7 @@ static void tpm_tis_clkrun_enable(struct tpm_chip *chip, > bool value)

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2018-01-02 Thread Pavel Machek
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c > index e7bd2e750f69..0858c08b3b89 100644 > --- a/drivers/char/tpm/tpm_tis_core.c > +++ b/drivers/char/tpm/tpm_tis_core.c > @@ -688,7 +688,7 @@ static void tpm_tis_clkrun_enable(struct tpm_chip *chip, > bool value)

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-22 Thread Jarkko Sakkinen
> I'm OK with that. > > Do you need any more info on the specifics of the machine I'm using? > > (Note: I'm not currently aware of any BIOS updates for it. If this is > ultimately a BIOS problem I wouldn't know what sort of report to file, or how > to file it anyway...) > > Thanks, > James I

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-22 Thread Jarkko Sakkinen
> I'm OK with that. > > Do you need any more info on the specifics of the machine I'm using? > > (Note: I'm not currently aware of any BIOS updates for it. If this is > ultimately a BIOS problem I wouldn't know what sort of report to file, or how > to file it anyway...) > > Thanks, > James I

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jason Gunthorpe
On Tue, Dec 19, 2017 at 03:04:32PM +0200, Jarkko Sakkinen wrote: > > That makes it a BIOS bug, not a chipset bug, and we shouldn't be > > trying to fix it like this in Linux. > > > > Based on the original discussion I always thought this was an Intel > > chipset bug and applies to all cases. >

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jason Gunthorpe
On Tue, Dec 19, 2017 at 03:04:32PM +0200, Jarkko Sakkinen wrote: > > That makes it a BIOS bug, not a chipset bug, and we shouldn't be > > trying to fix it like this in Linux. > > > > Based on the original discussion I always thought this was an Intel > > chipset bug and applies to all cases. >

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread James Ettle
I'm OK with that. Do you need any more info on the specifics of the machine I'm using? (Note: I'm not currently aware of any BIOS updates for it. If this is ultimately a BIOS problem I wouldn't know what sort of report to file, or how to file it anyway...) Thanks, James On 19/12/17 13:00,

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread James Ettle
I'm OK with that. Do you need any more info on the specifics of the machine I'm using? (Note: I'm not currently aware of any BIOS updates for it. If this is ultimately a BIOS problem I wouldn't know what sort of report to file, or how to file it anyway...) Thanks, James On 19/12/17 13:00,

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Javier Martinez Canillas
On 12/19/2017 02:10 PM, Jarkko Sakkinen wrote: > On Tue, Dec 19, 2017 at 12:34:46AM +0100, Javier Martinez Canillas wrote: >> Hello Jason, >> >> On 12/18/2017 09:19 PM, Jason Gunthorpe wrote: >>> On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: >>> > IIUC, if CLKRUN_EN is

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Javier Martinez Canillas
On 12/19/2017 02:10 PM, Jarkko Sakkinen wrote: > On Tue, Dec 19, 2017 at 12:34:46AM +0100, Javier Martinez Canillas wrote: >> Hello Jason, >> >> On 12/18/2017 09:19 PM, Jason Gunthorpe wrote: >>> On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: >>> > IIUC, if CLKRUN_EN is

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Javier Martinez Canillas
Hello Jarkko, On 12/19/2017 01:59 PM, Jarkko Sakkinen wrote: > James, Javier, thank you for sorting this out. I'll just have couple of > minor comments on the patch. > > On Mon, Dec 18, 2017 at 01:22:28PM +0100, Javier Martinez Canillas wrote: >> +u32 vendor, intfcaps, intmask, clkrun_val; >

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Javier Martinez Canillas
Hello Jarkko, On 12/19/2017 01:59 PM, Jarkko Sakkinen wrote: > James, Javier, thank you for sorting this out. I'll just have couple of > minor comments on the patch. > > On Mon, Dec 18, 2017 at 01:22:28PM +0100, Javier Martinez Canillas wrote: >> +u32 vendor, intfcaps, intmask, clkrun_val; >

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
On Tue, Dec 19, 2017 at 12:34:46AM +0100, Javier Martinez Canillas wrote: > Hello Jason, > > On 12/18/2017 09:19 PM, Jason Gunthorpe wrote: > > On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: > > > >>> IIUC, if CLKRUN_EN is enabled, then all the devices attached to the > >>> LPC

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
On Tue, Dec 19, 2017 at 12:34:46AM +0100, Javier Martinez Canillas wrote: > Hello Jason, > > On 12/18/2017 09:19 PM, Jason Gunthorpe wrote: > > On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: > > > >>> IIUC, if CLKRUN_EN is enabled, then all the devices attached to the > >>> LPC

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
On Mon, Dec 18, 2017 at 01:19:02PM -0700, Jason Gunthorpe wrote: > On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: > > > >IIUC, if CLKRUN_EN is enabled, then all the devices attached to the > > >LPC bus have to support the CLKRUN protocol. My guess is that on > > >some Braswell

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
On Mon, Dec 18, 2017 at 01:19:02PM -0700, Jason Gunthorpe wrote: > On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: > > > >IIUC, if CLKRUN_EN is enabled, then all the devices attached to the > > >LPC bus have to support the CLKRUN protocol. My guess is that on > > >some Braswell

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
On Mon, Dec 18, 2017 at 10:55:02AM -0700, Jason Gunthorpe wrote: > On Mon, Dec 18, 2017 at 01:29:01PM +0100, Javier Martinez Canillas wrote: > > On 12/18/2017 01:22 PM, Javier Martinez Canillas wrote: > > > > [snip] > > > > > > > > James, > > > > > > Can you please test the following

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
On Mon, Dec 18, 2017 at 10:55:02AM -0700, Jason Gunthorpe wrote: > On Mon, Dec 18, 2017 at 01:29:01PM +0100, Javier Martinez Canillas wrote: > > On 12/18/2017 01:22 PM, Javier Martinez Canillas wrote: > > > > [snip] > > > > > > > > James, > > > > > > Can you please test the following

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
On Mon, Dec 18, 2017 at 06:26:35PM +, James Ettle wrote: > The keyboard and touchpad work OK with the patch quoted below and the earlier > two applied, i.e. the three patches with signatures: > > 667dcc75be864ff4c17cf58891853b7393bba3e2 > db3248e8a036c39141c8f7e9f1cf5c5ae6815f76 >

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
On Mon, Dec 18, 2017 at 06:26:35PM +, James Ettle wrote: > The keyboard and touchpad work OK with the patch quoted below and the earlier > two applied, i.e. the three patches with signatures: > > 667dcc75be864ff4c17cf58891853b7393bba3e2 > db3248e8a036c39141c8f7e9f1cf5c5ae6815f76 >

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
James, Javier, thank you for sorting this out. I'll just have couple of minor comments on the patch. On Mon, Dec 18, 2017 at 01:22:28PM +0100, Javier Martinez Canillas wrote: > + u32 vendor, intfcaps, intmask, clkrun_val; Could these split into four lines (one declaration per line)? >

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread Jarkko Sakkinen
James, Javier, thank you for sorting this out. I'll just have couple of minor comments on the patch. On Mon, Dec 18, 2017 at 01:22:28PM +0100, Javier Martinez Canillas wrote: > + u32 vendor, intfcaps, intmask, clkrun_val; Could these split into four lines (one declaration per line)? >

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Jason Gunthorpe
On Tue, Dec 19, 2017 at 12:34:46AM +0100, Javier Martinez Canillas wrote: > Hello Jason, > > On 12/18/2017 09:19 PM, Jason Gunthorpe wrote: > > On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: > > > >>> IIUC, if CLKRUN_EN is enabled, then all the devices attached to the > >>> LPC

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Jason Gunthorpe
On Tue, Dec 19, 2017 at 12:34:46AM +0100, Javier Martinez Canillas wrote: > Hello Jason, > > On 12/18/2017 09:19 PM, Jason Gunthorpe wrote: > > On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: > > > >>> IIUC, if CLKRUN_EN is enabled, then all the devices attached to the > >>> LPC

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
Hello Jason, On 12/18/2017 09:19 PM, Jason Gunthorpe wrote: > On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: > >>> IIUC, if CLKRUN_EN is enabled, then all the devices attached to the >>> LPC bus have to support the CLKRUN protocol. My guess is that on >>> some Braswell systems

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
Hello Jason, On 12/18/2017 09:19 PM, Jason Gunthorpe wrote: > On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: > >>> IIUC, if CLKRUN_EN is enabled, then all the devices attached to the >>> LPC bus have to support the CLKRUN protocol. My guess is that on >>> some Braswell systems

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
Sakkinen <jarkko.sakki...@linux.intel.com>; James Ettle >> <ja...@ettle.org.uk>; linux-integr...@vger.kernel.org; Shaikh, Azhar >> <azhar.sha...@intel.com>; linux-kernel@vger.kernel.org; >> james.l.mor...@oracle.com >> Subject: Re: [BISECTED] tpm CLKRUN bre

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
>> ; linux-integr...@vger.kernel.org; Shaikh, Azhar >> ; linux-kernel@vger.kernel.org; >> james.l.mor...@oracle.com >> Subject: Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on >> Braswell system >> >> Hello Jason, >> >> Thanks a l

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Jason Gunthorpe
On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: > >IIUC, if CLKRUN_EN is enabled, then all the devices attached to the > >LPC bus have to support the CLKRUN protocol. My guess is that on > >some Braswell systems LPC power management is enabled but the TPM > >device doesn't have

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Jason Gunthorpe
On Mon, Dec 18, 2017 at 07:34:29PM +, Shaikh, Azhar wrote: > >IIUC, if CLKRUN_EN is enabled, then all the devices attached to the > >LPC bus have to support the CLKRUN protocol. My guess is that on > >some Braswell systems LPC power management is enabled but the TPM > >device doesn't have

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Jason Gunthorpe
On Mon, Dec 18, 2017 at 08:29:30PM +0100, Javier Martinez Canillas wrote: > My knowledge of LPC is near to non-existent so I please forgive me if I'm > wrong, > but my understanding is that it's the opposite of what you said. > > When CLKRUN_EN is SET, power management is ENABLED on the LPC bus

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Jason Gunthorpe
On Mon, Dec 18, 2017 at 08:29:30PM +0100, Javier Martinez Canillas wrote: > My knowledge of LPC is near to non-existent so I please forgive me if I'm > wrong, > but my understanding is that it's the opposite of what you said. > > When CLKRUN_EN is SET, power management is ENABLED on the LPC bus

RE: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Shaikh, Azhar
pe.ca> >Cc: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com>; James Ettle ><ja...@ettle.org.uk>; linux-integr...@vger.kernel.org; linux- >ker...@vger.kernel.org; james.l.mor...@oracle.com >Subject: RE: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on >

RE: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Shaikh, Azhar
Ettle >; linux-integr...@vger.kernel.org; linux- >ker...@vger.kernel.org; james.l.mor...@oracle.com >Subject: RE: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on >Braswell system > > > >>-Original Message- >>From: Javier Martinez Canillas [mailto:javi.

RE: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Shaikh, Azhar
gt;; linux-integr...@vger.kernel.org; Shaikh, Azhar ><azhar.sha...@intel.com>; linux-kernel@vger.kernel.org; >james.l.mor...@oracle.com >Subject: Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on >Braswell system > >Hello Jason, > >Thanks a lot for your feedback

RE: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Shaikh, Azhar
ames.l.mor...@oracle.com >Subject: Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on >Braswell system > >Hello Jason, > >Thanks a lot for your feedback. > >On 12/18/2017 06:55 PM, Jason Gunthorpe wrote: >> On Mon, Dec 18, 2017 at 01:29:01PM +0100, Javi

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
Hello James, On 12/18/2017 07:26 PM, James Ettle wrote: > The keyboard and touchpad work OK with the patch quoted below and the earlier > two applied, i.e. the three patches with signatures: > > 667dcc75be864ff4c17cf58891853b7393bba3e2 > db3248e8a036c39141c8f7e9f1cf5c5ae6815f76 >

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
Hello James, On 12/18/2017 07:26 PM, James Ettle wrote: > The keyboard and touchpad work OK with the patch quoted below and the earlier > two applied, i.e. the three patches with signatures: > > 667dcc75be864ff4c17cf58891853b7393bba3e2 > db3248e8a036c39141c8f7e9f1cf5c5ae6815f76 >

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
Hello Jason, Thanks a lot for your feedback. On 12/18/2017 06:55 PM, Jason Gunthorpe wrote: > On Mon, Dec 18, 2017 at 01:29:01PM +0100, Javier Martinez Canillas wrote: >> On 12/18/2017 01:22 PM, Javier Martinez Canillas wrote: >> >> [snip] >> >>> >>> James, >>> >>> Can you please test the

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
Hello Jason, Thanks a lot for your feedback. On 12/18/2017 06:55 PM, Jason Gunthorpe wrote: > On Mon, Dec 18, 2017 at 01:29:01PM +0100, Javier Martinez Canillas wrote: >> On 12/18/2017 01:22 PM, Javier Martinez Canillas wrote: >> >> [snip] >> >>> >>> James, >>> >>> Can you please test the

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread James Ettle
The keyboard and touchpad work OK with the patch quoted below and the earlier two applied, i.e. the three patches with signatures: 667dcc75be864ff4c17cf58891853b7393bba3e2 db3248e8a036c39141c8f7e9f1cf5c5ae6815f76 370d45a34dc8914066a995a3a6d6df1953ea9f60 I applied these to a vanilla kernel.org

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread James Ettle
The keyboard and touchpad work OK with the patch quoted below and the earlier two applied, i.e. the three patches with signatures: 667dcc75be864ff4c17cf58891853b7393bba3e2 db3248e8a036c39141c8f7e9f1cf5c5ae6815f76 370d45a34dc8914066a995a3a6d6df1953ea9f60 I applied these to a vanilla kernel.org

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Jason Gunthorpe
On Mon, Dec 18, 2017 at 01:29:01PM +0100, Javier Martinez Canillas wrote: > On 12/18/2017 01:22 PM, Javier Martinez Canillas wrote: > > [snip] > > > > > James, > > > > Can you please test the following (untested) patch on top of the other two > > mentioned patches to see if it makes a

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Jason Gunthorpe
On Mon, Dec 18, 2017 at 01:29:01PM +0100, Javier Martinez Canillas wrote: > On 12/18/2017 01:22 PM, Javier Martinez Canillas wrote: > > [snip] > > > > > James, > > > > Can you please test the following (untested) patch on top of the other two > > mentioned patches to see if it makes a

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
On 12/18/2017 01:22 PM, Javier Martinez Canillas wrote: [snip] > > James, > > Can you please test the following (untested) patch on top of the other two > mentioned patches to see if it makes a difference for you? > I should had tried to at least compile the patch :) Updated patch below:

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
On 12/18/2017 01:22 PM, Javier Martinez Canillas wrote: [snip] > > James, > > Can you please test the following (untested) patch on top of the other two > mentioned patches to see if it makes a difference for you? > I should had tried to at least compile the patch :) Updated patch below:

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
On 12/16/2017 06:01 PM, Jarkko Sakkinen wrote: > On Fri, 2017-12-15 at 10:38 -0700, Jason Gunthorpe wrote: >> On Fri, Dec 15, 2017 at 04:56:30PM +0200, Jarkko Sakkinen wrote: >>> On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe wrote: On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
On 12/16/2017 06:01 PM, Jarkko Sakkinen wrote: > On Fri, 2017-12-15 at 10:38 -0700, Jason Gunthorpe wrote: >> On Fri, Dec 15, 2017 at 04:56:30PM +0200, Jarkko Sakkinen wrote: >>> On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe wrote: On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
On 12/16/2017 09:59 PM, Javier Martinez Canillas wrote: > On 12/16/2017 06:01 PM, Jarkko Sakkinen wrote: >> On Fri, 2017-12-15 at 10:38 -0700, Jason Gunthorpe wrote: >>> On Fri, Dec 15, 2017 at 04:56:30PM +0200, Jarkko Sakkinen wrote: On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread Javier Martinez Canillas
On 12/16/2017 09:59 PM, Javier Martinez Canillas wrote: > On 12/16/2017 06:01 PM, Jarkko Sakkinen wrote: >> On Fri, 2017-12-15 at 10:38 -0700, Jason Gunthorpe wrote: >>> On Fri, Dec 15, 2017 at 04:56:30PM +0200, Jarkko Sakkinen wrote: On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-16 Thread Javier Martinez Canillas
On 12/16/2017 06:01 PM, Jarkko Sakkinen wrote: > On Fri, 2017-12-15 at 10:38 -0700, Jason Gunthorpe wrote: >> On Fri, Dec 15, 2017 at 04:56:30PM +0200, Jarkko Sakkinen wrote: >>> On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe wrote: On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-16 Thread Javier Martinez Canillas
On 12/16/2017 06:01 PM, Jarkko Sakkinen wrote: > On Fri, 2017-12-15 at 10:38 -0700, Jason Gunthorpe wrote: >> On Fri, Dec 15, 2017 at 04:56:30PM +0200, Jarkko Sakkinen wrote: >>> On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe wrote: On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-16 Thread Jarkko Sakkinen
On Fri, 2017-12-15 at 10:38 -0700, Jason Gunthorpe wrote: > On Fri, Dec 15, 2017 at 04:56:30PM +0200, Jarkko Sakkinen wrote: > > On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe wrote: > > > On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier Martinez Canillas wrote: > > > > > > > Although

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-16 Thread Jarkko Sakkinen
On Fri, 2017-12-15 at 10:38 -0700, Jason Gunthorpe wrote: > On Fri, Dec 15, 2017 at 04:56:30PM +0200, Jarkko Sakkinen wrote: > > On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe wrote: > > > On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier Martinez Canillas wrote: > > > > > > > Although

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-15 Thread Jason Gunthorpe
On Fri, Dec 15, 2017 at 04:56:30PM +0200, Jarkko Sakkinen wrote: > On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe wrote: > > On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier Martinez Canillas wrote: > > > > > Although probably reverting the offending commits is the right thing to do >

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-15 Thread Jason Gunthorpe
On Fri, Dec 15, 2017 at 04:56:30PM +0200, Jarkko Sakkinen wrote: > On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe wrote: > > On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier Martinez Canillas wrote: > > > > > Although probably reverting the offending commits is the right thing to do >

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-15 Thread Jarkko Sakkinen
On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe wrote: > On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier Martinez Canillas wrote: > > > Although probably reverting the offending commits is the right thing to do > > until a proper solution is proposed. > > Yes, if a fix is not

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-15 Thread Jarkko Sakkinen
On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe wrote: > On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier Martinez Canillas wrote: > > > Although probably reverting the offending commits is the right thing to do > > until a proper solution is proposed. > > Yes, if a fix is not

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-14 Thread Jason Gunthorpe
On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier Martinez Canillas wrote: > Although probably reverting the offending commits is the right thing to do > until a proper solution is proposed. Yes, if a fix is not forthcoming soon Jarkko should revert. Jason

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-14 Thread Jason Gunthorpe
On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier Martinez Canillas wrote: > Although probably reverting the offending commits is the right thing to do > until a proper solution is proposed. Yes, if a fix is not forthcoming soon Jarkko should revert. Jason

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-14 Thread Javier Martinez Canillas
Hello James, On 12/12/2017 10:17 PM, James Ettle wrote: > OK, I built a kernel 4.14.5 from vanilla kernel.org sources using the Fedora > .config (couldn't get the Fedora package to build). > > I see no difference with both [0, 1] patches applied and the tpm modules > loaded -- no keyboard or

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-14 Thread Javier Martinez Canillas
Hello James, On 12/12/2017 10:17 PM, James Ettle wrote: > OK, I built a kernel 4.14.5 from vanilla kernel.org sources using the Fedora > .config (couldn't get the Fedora package to build). > > I see no difference with both [0, 1] patches applied and the tpm modules > loaded -- no keyboard or

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-14 Thread Javier Martinez Canillas
Hello Jarkko, On 12/14/2017 12:21 PM, Jarkko Sakkinen wrote: > On Mon, Dec 11, 2017 at 07:37:29PM +, James Ettle wrote: >> Hello, >> >> [First: Apologies if cross-posting from Kernel.org BZ is bad form; my >> distro BZ advised I post this to your mailing list as well.] >> >> Situation:

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-14 Thread Javier Martinez Canillas
Hello Jarkko, On 12/14/2017 12:21 PM, Jarkko Sakkinen wrote: > On Mon, Dec 11, 2017 at 07:37:29PM +, James Ettle wrote: >> Hello, >> >> [First: Apologies if cross-posting from Kernel.org BZ is bad form; my >> distro BZ advised I post this to your mailing list as well.] >> >> Situation:

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-14 Thread Jarkko Sakkinen
On Mon, Dec 11, 2017 at 07:37:29PM +, James Ettle wrote: > Hello, > > [First: Apologies if cross-posting from Kernel.org BZ is bad form; my > distro BZ advised I post this to your mailing list as well.] > > Situation: enabling TPM on a Clevo W510LU with an Intel N3160 CPU > breaks PS/2

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-14 Thread Jarkko Sakkinen
On Mon, Dec 11, 2017 at 07:37:29PM +, James Ettle wrote: > Hello, > > [First: Apologies if cross-posting from Kernel.org BZ is bad form; my > distro BZ advised I post this to your mailing list as well.] > > Situation: enabling TPM on a Clevo W510LU with an Intel N3160 CPU > breaks PS/2

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-12 Thread James Ettle
OK, I built a kernel 4.14.5 from vanilla kernel.org sources using the Fedora .config (couldn't get the Fedora package to build). I see no difference with both [0, 1] patches applied and the tpm modules loaded -- no keyboard or touchpad. [Note: I'm not *consciously* using the TPM for anything,

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-12 Thread James Ettle
OK, I built a kernel 4.14.5 from vanilla kernel.org sources using the Fedora .config (couldn't get the Fedora package to build). I see no difference with both [0, 1] patches applied and the tpm modules loaded -- no keyboard or touchpad. [Note: I'm not *consciously* using the TPM for anything,

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-12 Thread Javier Martinez Canillas
Hello Jason, On 12/12/2017 07:57 PM, Jason Gunthorpe wrote: > On Tue, Dec 12, 2017 at 12:38:00PM +0100, Javier Martinez Canillas wrote: > >> I'm not familiar with LPC so please let me know if my assumptions are wrong, >> but I find suspicious that a driver for a single device attached to the bus

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-12 Thread Javier Martinez Canillas
Hello Jason, On 12/12/2017 07:57 PM, Jason Gunthorpe wrote: > On Tue, Dec 12, 2017 at 12:38:00PM +0100, Javier Martinez Canillas wrote: > >> I'm not familiar with LPC so please let me know if my assumptions are wrong, >> but I find suspicious that a driver for a single device attached to the bus

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-12 Thread Jason Gunthorpe
On Tue, Dec 12, 2017 at 12:38:00PM +0100, Javier Martinez Canillas wrote: > I'm not familiar with LPC so please let me know if my assumptions are wrong, > but I find suspicious that a driver for a single device attached to the bus > can control the CLKRUN# signal which AFAIU may be needed for

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-12 Thread Jason Gunthorpe
On Tue, Dec 12, 2017 at 12:38:00PM +0100, Javier Martinez Canillas wrote: > I'm not familiar with LPC so please let me know if my assumptions are wrong, > but I find suspicious that a driver for a single device attached to the bus > can control the CLKRUN# signal which AFAIU may be needed for

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-12 Thread Javier Martinez Canillas
Hello James, On 12/11/2017 08:37 PM, James Ettle wrote: > Hello, > > [First: Apologies if cross-posting from Kernel.org BZ is bad form; my distro > BZ advised I post this to your mailing list as well.] > > Situation: enabling TPM on a Clevo W510LU with an Intel N3160 CPU breaks PS/2 >

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-12 Thread Javier Martinez Canillas
Hello James, On 12/11/2017 08:37 PM, James Ettle wrote: > Hello, > > [First: Apologies if cross-posting from Kernel.org BZ is bad form; my distro > BZ advised I post this to your mailing list as well.] > > Situation: enabling TPM on a Clevo W510LU with an Intel N3160 CPU breaks PS/2 >