Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-25 Thread Dennis Chen
On Mon, Aug 25, 2014 at 10:04 PM, Gleb Natapov wrote: > On Mon, Aug 25, 2014 at 11:16:34AM +0800, Dennis Chen wrote: >> On Sun, Aug 24, 2014 at 5:38 PM, Gleb Natapov wrote: >> > On Sun, Aug 24, 2014 at 11:54:32AM +0800, Dennis Chen wrote: >> >> This patch is used to construct the eptp in vmx

Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-25 Thread Gleb Natapov
On Mon, Aug 25, 2014 at 11:16:34AM +0800, Dennis Chen wrote: > On Sun, Aug 24, 2014 at 5:38 PM, Gleb Natapov wrote: > > On Sun, Aug 24, 2014 at 11:54:32AM +0800, Dennis Chen wrote: > >> This patch is used to construct the eptp in vmx mode with values > >> readed from MSR according to the intel

Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-25 Thread Gleb Natapov
On Mon, Aug 25, 2014 at 11:16:34AM +0800, Dennis Chen wrote: On Sun, Aug 24, 2014 at 5:38 PM, Gleb Natapov g...@kernel.org wrote: On Sun, Aug 24, 2014 at 11:54:32AM +0800, Dennis Chen wrote: This patch is used to construct the eptp in vmx mode with values readed from MSR according to the

Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-25 Thread Dennis Chen
On Mon, Aug 25, 2014 at 10:04 PM, Gleb Natapov g...@kernel.org wrote: On Mon, Aug 25, 2014 at 11:16:34AM +0800, Dennis Chen wrote: On Sun, Aug 24, 2014 at 5:38 PM, Gleb Natapov g...@kernel.org wrote: On Sun, Aug 24, 2014 at 11:54:32AM +0800, Dennis Chen wrote: This patch is used to construct

Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-24 Thread Dennis Chen
On Mon, Aug 25, 2014 at 7:14 AM, Wanpeng Li wrote: > Please Cc kvm ml. You've done that for me, thanks. The page-walk length sanity check has been done in the hardware_setup() function, so it's not necessary in this patch, but I still think it does make sense for the memory type check, any

Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-24 Thread Dennis Chen
On Sun, Aug 24, 2014 at 5:38 PM, Gleb Natapov wrote: > On Sun, Aug 24, 2014 at 11:54:32AM +0800, Dennis Chen wrote: >> This patch is used to construct the eptp in vmx mode with values >> readed from MSR according to the intel x86 software developer's >> manual. >> >> static u64

Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-24 Thread Wanpeng Li
Please Cc kvm ml. On Sun, Aug 24, 2014 at 11:54:32AM +0800, Dennis Chen wrote: >This patch is used to construct the eptp in vmx mode with values >readed from MSR according to the intel x86 software developer's >manual. > >Signed-off-by: Dennis Chen >--- > arch/x86/include/asm/vmx.h |1 + >

Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-24 Thread Gleb Natapov
On Sun, Aug 24, 2014 at 11:54:32AM +0800, Dennis Chen wrote: > This patch is used to construct the eptp in vmx mode with values > readed from MSR according to the intel x86 software developer's > manual. > > Signed-off-by: Dennis Chen > --- > arch/x86/include/asm/vmx.h |1 + >

Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-24 Thread Gleb Natapov
On Sun, Aug 24, 2014 at 11:54:32AM +0800, Dennis Chen wrote: This patch is used to construct the eptp in vmx mode with values readed from MSR according to the intel x86 software developer's manual. Signed-off-by: Dennis Chen kernel.org@gmail.com --- arch/x86/include/asm/vmx.h |1 +

Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-24 Thread Wanpeng Li
Please Cc kvm ml. On Sun, Aug 24, 2014 at 11:54:32AM +0800, Dennis Chen wrote: This patch is used to construct the eptp in vmx mode with values readed from MSR according to the intel x86 software developer's manual. Signed-off-by: Dennis Chen kernel.org@gmail.com ---

Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-24 Thread Dennis Chen
On Sun, Aug 24, 2014 at 5:38 PM, Gleb Natapov g...@kernel.org wrote: On Sun, Aug 24, 2014 at 11:54:32AM +0800, Dennis Chen wrote: This patch is used to construct the eptp in vmx mode with values readed from MSR according to the intel x86 software developer's manual. static u64

Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-24 Thread Dennis Chen
On Mon, Aug 25, 2014 at 7:14 AM, Wanpeng Li wanpeng...@linux.intel.com wrote: Please Cc kvm ml. You've done that for me, thanks. The page-walk length sanity check has been done in the hardware_setup() function, so it's not necessary in this patch, but I still think it does make sense for the

Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-23 Thread Dennis Chen
CC'ing Avi and Paolo... Avi/Paolo, any comments?--Den On Sun, Aug 24, 2014 at 11:54 AM, Dennis Chen wrote: > This patch is used to construct the eptp in vmx mode with values > readed from MSR according to the intel x86 software developer's > manual. > > Signed-off-by: Dennis Chen > --- >

Re: [PATCH] KVM-Use value reading from MSR when construct the eptp in VMX mode

2014-08-23 Thread Dennis Chen
CC'ing Avi and Paolo... Avi/Paolo, any comments?--Den On Sun, Aug 24, 2014 at 11:54 AM, Dennis Chen kernel.org@gmail.com wrote: This patch is used to construct the eptp in vmx mode with values readed from MSR according to the intel x86 software developer's manual. Signed-off-by: