Re: [PATCH] Omnikey Cardman 4000 driver

2005-09-07 Thread Harald Welte
On Mon, Sep 05, 2005 at 12:44:37PM -0700, Nish Aravamudan wrote: > It looks like all callers of these functions pass in milliseconds? Any > chance you can get rid of these two and use msleep_interruptible() and > msleep() instead? As long as you are not using these functions around > wait-queues,

Re: [PATCH] Omnikey Cardman 4000 driver

2005-09-07 Thread Harald Welte
On Mon, Sep 05, 2005 at 12:44:37PM -0700, Nish Aravamudan wrote: It looks like all callers of these functions pass in milliseconds? Any chance you can get rid of these two and use msleep_interruptible() and msleep() instead? As long as you are not using these functions around wait-queues, you

Re: [PATCH] Omnikey Cardman 4000 driver

2005-09-06 Thread Harald Welte
On Mon, Sep 05, 2005 at 10:36:57PM +0200, Jesper Juhl wrote: > On 9/6/05, Harald Welte <[EMAIL PROTECTED]> wrote: > > Hi! > > > [snip] > > > > Please consider mergin mainline, thanks. > > > [snip] > > Wouldn't it be better to first merge it in -mm and get some wider > testing before pushing

Re: [PATCH] Omnikey Cardman 4000 driver

2005-09-06 Thread Harald Welte
On Mon, Sep 05, 2005 at 10:36:57PM +0200, Jesper Juhl wrote: On 9/6/05, Harald Welte [EMAIL PROTECTED] wrote: Hi! [snip] Please consider mergin mainline, thanks. [snip] Wouldn't it be better to first merge it in -mm and get some wider testing before pushing for mainline? From

Re: [PATCH] Omnikey Cardman 4000 driver

2005-09-05 Thread Jesper Juhl
On 9/6/05, Harald Welte <[EMAIL PROTECTED]> wrote: > Hi! > [snip] > > Please consider mergin mainline, thanks. > [snip] Wouldn't it be better to first merge it in -mm and get some wider testing before pushing for mainline? -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post

Re: [PATCH] Omnikey Cardman 4000 driver

2005-09-05 Thread Jesper Juhl
On 9/6/05, Harald Welte <[EMAIL PROTECTED]> wrote: > Hi! > > Following-up to the Cardman 4040 driver, I'm now sumitting a driver for > the Cardman 4000 reader. It is, too, a PCMCIA smartcard reader and the > predecessor of the 4040. > > From a technical point of view, the two devices have

Re: [PATCH] Omnikey Cardman 4000 driver

2005-09-05 Thread Nish Aravamudan
On 9/5/05, Harald Welte <[EMAIL PROTECTED]> wrote: > Hi! > > Following-up to the Cardman 4040 driver, I'm now sumitting a driver for > the Cardman 4000 reader. It is, too, a PCMCIA smartcard reader and the > predecessor of the 4040. > > From a technical point of view, the two devices have

Re: [PATCH] Omnikey Cardman 4000 driver

2005-09-05 Thread Nish Aravamudan
On 9/5/05, Harald Welte [EMAIL PROTECTED] wrote: Hi! Following-up to the Cardman 4040 driver, I'm now sumitting a driver for the Cardman 4000 reader. It is, too, a PCMCIA smartcard reader and the predecessor of the 4040. From a technical point of view, the two devices have nothing in

Re: [PATCH] Omnikey Cardman 4000 driver

2005-09-05 Thread Jesper Juhl
On 9/6/05, Harald Welte [EMAIL PROTECTED] wrote: Hi! Following-up to the Cardman 4040 driver, I'm now sumitting a driver for the Cardman 4000 reader. It is, too, a PCMCIA smartcard reader and the predecessor of the 4040. From a technical point of view, the two devices have nothing in

Re: [PATCH] Omnikey Cardman 4000 driver

2005-09-05 Thread Jesper Juhl
On 9/6/05, Harald Welte [EMAIL PROTECTED] wrote: Hi! [snip] Please consider mergin mainline, thanks. [snip] Wouldn't it be better to first merge it in -mm and get some wider testing before pushing for mainline? -- Jesper Juhl [EMAIL PROTECTED] Don't top-post