Re: [PATCH] arm64: Make L1_CACHE_SHIFT configurable

2018-02-19 Thread Jon Masters
On 02/12/2018 07:17 PM, Florian Fainelli wrote: > On 02/12/2018 04:10 PM, Timur Tabi wrote: >> On 02/12/2018 05:57 PM, Florian Fainelli wrote: >>> That is debatable, is there a good publicly available table of what the >>> typical L1 cache line size is on ARMv8 platforms? With a server hat on...

Re: [PATCH] arm64: Make L1_CACHE_SHIFT configurable

2018-02-13 Thread Catalin Marinas
On Mon, Feb 12, 2018 at 03:45:23PM -0800, Florian Fainelli wrote: > On many platforms, including, but not limited to Brahma-B53 platforms, > the L1 cache line size is 64bytes. Increasing the value to 128bytes > appears to be creating performance problems for workloads involving > network drivers an

Re: [PATCH] arm64: Make L1_CACHE_SHIFT configurable

2018-02-12 Thread Florian Fainelli
On 02/12/2018 04:10 PM, Timur Tabi wrote: > On 02/12/2018 05:57 PM, Florian Fainelli wrote: >> That is debatable, is there a good publicly available table of what the >> typical L1 cache line size is on ARMv8 platforms? > > I don't have that, but I was under the impression that we moved from 6 > t

Re: [PATCH] arm64: Make L1_CACHE_SHIFT configurable

2018-02-12 Thread Timur Tabi
On 02/12/2018 05:57 PM, Florian Fainelli wrote: That is debatable, is there a good publicly available table of what the typical L1 cache line size is on ARMv8 platforms? I don't have that, but I was under the impression that we moved from 6 to 7 because more and more ARMv8 platforms have 128-b

Re: [PATCH] arm64: Make L1_CACHE_SHIFT configurable

2018-02-12 Thread Florian Fainelli
On 02/12/2018 03:52 PM, Timur Tabi wrote: > On 02/12/2018 05:45 PM, Florian Fainelli wrote: >> +config ARM64_L1_CACHE_SHIFT >> +    int >> +    default 7 if ARM64_L1_CACHE_SHIFT_7 >> +    default 6 > > Shouldn't this be the other way around?  Everyone is used to 7 now, so > you're changing the def

Re: [PATCH] arm64: Make L1_CACHE_SHIFT configurable

2018-02-12 Thread Timur Tabi
On 02/12/2018 05:45 PM, Florian Fainelli wrote: +config ARM64_L1_CACHE_SHIFT + int + default 7 if ARM64_L1_CACHE_SHIFT_7 + default 6 Shouldn't this be the other way around? Everyone is used to 7 now, so you're changing the default back to 6. I would think that it should be