Re: [PATCH] console: Replace #if 1 with a bool to ignore WARN_CONSOLE_UNLOCKED()

2018-07-12 Thread Sergey Senozhatsky
On (07/12/18 09:53), Petr Mladek wrote: > > > > True, but at the same time nobody complained that we didn't have those > > extra WARN_CONSOLE_UNLOCKED()-s. Just saying. Over all I agree that there > > is probably some value in those extra WARN-s. > > I agree that there is some value in the extra

Re: [PATCH] console: Replace #if 1 with a bool to ignore WARN_CONSOLE_UNLOCKED()

2018-07-12 Thread Petr Mladek
On Thu 2018-07-12 13:25:52, Sergey Senozhatsky wrote: > On (07/11/18 23:09), Steven Rostedt wrote: > > > On (07/11/18 15:17), Steven Rostedt wrote: > > > > +bool ignore_console_lock_warning __read_mostly; > > > > +EXPORT_SYMBOL(ignore_console_lock_warning); > > > > > > OK. So, to recap, > > > We

Re: [PATCH] console: Replace #if 1 with a bool to ignore WARN_CONSOLE_UNLOCKED()

2018-07-11 Thread Sergey Senozhatsky
On (07/11/18 23:09), Steven Rostedt wrote: > > On (07/11/18 15:17), Steven Rostedt wrote: > > > +bool ignore_console_lock_warning __read_mostly; > > > +EXPORT_SYMBOL(ignore_console_lock_warning); > > > > OK. So, to recap, > > We made is_console_locked() EXPORT_SYMBOL recently [it's still in > >

Re: [PATCH] console: Replace #if 1 with a bool to ignore WARN_CONSOLE_UNLOCKED()

2018-07-11 Thread Steven Rostedt
On Thu, 12 Jul 2018 10:58:48 +0900 Sergey Senozhatsky wrote: > On (07/11/18 15:17), Steven Rostedt wrote: > > +bool ignore_console_lock_warning __read_mostly; > > +EXPORT_SYMBOL(ignore_console_lock_warning); > > OK. So, to recap, > We made is_console_locked() EXPORT_SYMBOL recently [it's still

Re: [PATCH] console: Replace #if 1 with a bool to ignore WARN_CONSOLE_UNLOCKED()

2018-07-11 Thread Sergey Senozhatsky
On (07/11/18 15:17), Steven Rostedt wrote: > +bool ignore_console_lock_warning __read_mostly; > +EXPORT_SYMBOL(ignore_console_lock_warning); OK. So, to recap, We made is_console_locked() EXPORT_SYMBOL recently [it's still in linux-next], so people could use WARN_CONSOLE_UNLOCKED in more places; th

Re: [PATCH] console: Replace #if 1 with a bool to ignore WARN_CONSOLE_UNLOCKED()

2018-07-11 Thread Hans de Goede
Hi, On 11-07-18 21:17, Steven Rostedt wrote: From: Steven Rostedt (VMware) There's been discussion on the fb list about the addition of WARN_CONSOLE_UNLOCKED() inside the fb code. The complaint is that when the fb module is loaded with lockless_register_fb the console lock is not taken for de