Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-25 Thread Daniel Vetter
On Fri, Sep 23, 2016 at 03:42:52PM +0100, Brian Starkey wrote: > On Fri, Sep 23, 2016 at 03:13:15PM +0200, Daniel Vetter wrote: > > On Fri, Sep 23, 2016 at 01:52:49PM +0100, Brian Starkey wrote: > > > On Fri, Sep 23, 2016 at 12:58:46PM +0200, Daniel Vetter wrote: > > > > On Fri, Sep 23, 2016 at 11:

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-25 Thread Daniel Vetter
On Fri, Sep 23, 2016 at 03:05:03PM +0100, Russell King - ARM Linux wrote: > On Fri, Sep 23, 2016 at 03:13:15PM +0200, Daniel Vetter wrote: > > Hm, maybe we should simply not call ->lastclose for kms drivers. That is > > kinda only a hack for ums/dri1 drivers. > > Are you sure about that - isn't it

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-23 Thread Brian Starkey
On Fri, Sep 23, 2016 at 03:13:15PM +0200, Daniel Vetter wrote: On Fri, Sep 23, 2016 at 01:52:49PM +0100, Brian Starkey wrote: On Fri, Sep 23, 2016 at 12:58:46PM +0200, Daniel Vetter wrote: > On Fri, Sep 23, 2016 at 11:34 AM, Liviu Dudau wrote: > > rmmod-ing the hdlcd module generates a WARN() s

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-23 Thread Russell King - ARM Linux
On Fri, Sep 23, 2016 at 03:13:15PM +0200, Daniel Vetter wrote: > Hm, maybe we should simply not call ->lastclose for kms drivers. That is > kinda only a hack for ums/dri1 drivers. Are you sure about that - isn't it needed so that the fbdev mode gets restored when the last DRM user exits, so that t

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-23 Thread Daniel Vetter
On Fri, Sep 23, 2016 at 01:52:49PM +0100, Brian Starkey wrote: > On Fri, Sep 23, 2016 at 12:58:46PM +0200, Daniel Vetter wrote: > > On Fri, Sep 23, 2016 at 11:34 AM, Liviu Dudau wrote: > > > rmmod-ing the hdlcd module generates a WARN() splat as the vsync is still > > > enabled, but we never got t

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-23 Thread Brian Starkey
On Fri, Sep 23, 2016 at 12:58:46PM +0200, Daniel Vetter wrote: On Fri, Sep 23, 2016 at 11:34 AM, Liviu Dudau wrote: rmmod-ing the hdlcd module generates a WARN() splat as the vsync is still enabled, but we never got the call to turn off the CRTC. Brian is still tracking through the fbdev emulat

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-23 Thread Lucas Stach
Am Freitag, den 23.09.2016, 12:58 +0200 schrieb Daniel Vetter: > On Fri, Sep 23, 2016 at 11:34 AM, Liviu Dudau > wrote: > > > > rmmod-ing the hdlcd module generates a WARN() splat as the vsync is > > still > > enabled, but we never got the call to turn off the CRTC. Brian is > > still > > trackin

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-23 Thread Daniel Vetter
On Fri, Sep 23, 2016 at 11:34 AM, Liviu Dudau wrote: > rmmod-ing the hdlcd module generates a WARN() splat as the vsync is still > enabled, but we never got the call to turn off the CRTC. Brian is still > tracking through the fbdev emulation to figure out the cause for that. fbdev emulation doesn

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-23 Thread Liviu Dudau
On Fri, Sep 23, 2016 at 09:05:50AM +0200, Daniel Vetter wrote: > On Thu, Sep 22, 2016 at 4:14 PM, Brian Starkey wrote: > > On Thu, Sep 22, 2016 at 04:22:40AM -0700, Sean Paul wrote: > >> > >> On Thu, Sep 22, 2016 at 3:51 AM, Russell King - ARM Linux > >> wrote: > >>> > >>> On Thu, Sep 22, 2016 at

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-23 Thread Daniel Vetter
On Thu, Sep 22, 2016 at 2:40 PM, Russell King - ARM Linux wrote: > Sorry, I thought you were some random person maintaining some random > tree who'd submitted a pull request to be merged into drm-misc. If > you are in fact the drm-misc maintainer, please add yourself to the > MAINTAINERS file so

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-23 Thread Daniel Vetter
On Thu, Sep 22, 2016 at 4:14 PM, Brian Starkey wrote: > On Thu, Sep 22, 2016 at 04:22:40AM -0700, Sean Paul wrote: >> >> On Thu, Sep 22, 2016 at 3:51 AM, Russell King - ARM Linux >> wrote: >>> >>> On Thu, Sep 22, 2016 at 11:39:18AM +0100, Brian Starkey wrote: Actually, could you please

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-22 Thread Russell King - ARM Linux
On Thu, Sep 22, 2016 at 02:38:45PM +0100, Brian Starkey wrote: > However, without patching all three drivers in the same commit, there > would always be some breakage. HDLCD and Mali-DP call > drm_dev_register() before binding the components - this was needed to > work with tda998x, which needed th

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-22 Thread Brian Starkey
Hi Sean, On Thu, Sep 22, 2016 at 04:22:40AM -0700, Sean Paul wrote: On Thu, Sep 22, 2016 at 3:51 AM, Russell King - ARM Linux wrote: On Thu, Sep 22, 2016 at 11:39:18AM +0100, Brian Starkey wrote: Actually, could you please hold off picking this up? We need to make changes in mali-dp and hdlcd

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-22 Thread Brian Starkey
On Thu, Sep 22, 2016 at 01:28:37PM +0200, Daniel Vetter wrote: On Thu, Sep 22, 2016 at 1:22 PM, Sean Paul wrote: On Thu, Sep 22, 2016 at 3:51 AM, Russell King - ARM Linux wrote: On Thu, Sep 22, 2016 at 11:39:18AM +0100, Brian Starkey wrote: Actually, could you please hold off picking this up

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-22 Thread Russell King - ARM Linux
On Thu, Sep 22, 2016 at 05:32:35AM -0700, Sean Paul wrote: > On Thu, Sep 22, 2016 at 5:09 AM, Russell King - ARM Linux > wrote: > > On Thu, Sep 22, 2016 at 04:22:40AM -0700, Sean Paul wrote: > >> On Thu, Sep 22, 2016 at 3:51 AM, Russell King - ARM Linux > >> wrote: > >> > On Thu, Sep 22, 2016 at

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-22 Thread Sean Paul
On Thu, Sep 22, 2016 at 5:09 AM, Russell King - ARM Linux wrote: > On Thu, Sep 22, 2016 at 04:22:40AM -0700, Sean Paul wrote: >> On Thu, Sep 22, 2016 at 3:51 AM, Russell King - ARM Linux >> wrote: >> > On Thu, Sep 22, 2016 at 11:39:18AM +0100, Brian Starkey wrote: >> >> Actually, could you please

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-22 Thread Russell King - ARM Linux
On Thu, Sep 22, 2016 at 04:22:40AM -0700, Sean Paul wrote: > On Thu, Sep 22, 2016 at 3:51 AM, Russell King - ARM Linux > wrote: > > On Thu, Sep 22, 2016 at 11:39:18AM +0100, Brian Starkey wrote: > >> Actually, could you please hold off picking this up? We need to make > >> changes in mali-dp and h

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-22 Thread Daniel Vetter
On Thu, Sep 22, 2016 at 1:22 PM, Sean Paul wrote: > On Thu, Sep 22, 2016 at 3:51 AM, Russell King - ARM Linux > wrote: >> On Thu, Sep 22, 2016 at 11:39:18AM +0100, Brian Starkey wrote: >>> Actually, could you please hold off picking this up? We need to make >>> changes in mali-dp and hdlcd or thi

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-22 Thread Sean Paul
On Thu, Sep 22, 2016 at 3:51 AM, Russell King - ARM Linux wrote: > On Thu, Sep 22, 2016 at 11:39:18AM +0100, Brian Starkey wrote: >> Actually, could you please hold off picking this up? We need to make >> changes in mali-dp and hdlcd or this will mess up their registration. >> I will send those pa

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-22 Thread Russell King - ARM Linux
On Thu, Sep 22, 2016 at 11:39:18AM +0100, Brian Starkey wrote: > Actually, could you please hold off picking this up? We need to make > changes in mali-dp and hdlcd or this will mess up their registration. > I will send those patches later today, but better if this all goes in > together (whenever

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-22 Thread Brian Starkey
Thanks Russell, it's most appreciated. On Wed, Sep 21, 2016 at 05:28:03PM +0100, Russell King - ARM Linux wrote: On Wed, Sep 21, 2016 at 09:57:38AM +0100, Brian Starkey wrote: Hi Russell, Are you in a position to be able to test this now? Normally, I'd say no, because I'd normally wait for 4

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-21 Thread Russell King - ARM Linux
On Wed, Sep 21, 2016 at 09:57:38AM +0100, Brian Starkey wrote: > Hi Russell, > > Are you in a position to be able to test this now? Normally, I'd say no, because I'd normally wait for 4.8 to be out before moving the cubox tree up. However, as we're close to 4.8, I've merged 4.8-rc7 in (and fixed

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-21 Thread Brian Starkey
Hi Russell, Are you in a position to be able to test this now? I believe it should work fine on anything since 4.8-rc1. (specifically, either of commit e28cd4d0a223 or 79190ea2658a) Thanks, Brian On Tue, Aug 09, 2016 at 11:48:12PM +0100, Russell King - ARM Linux wrote: On Tue, Aug 09, 2016 a

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-08-09 Thread Russell King - ARM Linux
On Tue, Aug 09, 2016 at 08:07:24AM +0200, Daniel Vetter wrote: > On Mon, Aug 08, 2016 at 05:04:03PM +0100, Brian Starkey wrote: > > Hi, > > > > On Mon, Jul 25, 2016 at 05:08:21PM +0200, Daniel Vetter wrote: > > > On Mon, Jul 25, 2016 at 01:54:06PM +0100, Brian Starkey wrote: > > > > Hi Russell, >

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-08-08 Thread Daniel Vetter
On Mon, Aug 08, 2016 at 05:04:03PM +0100, Brian Starkey wrote: > Hi, > > On Mon, Jul 25, 2016 at 05:08:21PM +0200, Daniel Vetter wrote: > > On Mon, Jul 25, 2016 at 01:54:06PM +0100, Brian Starkey wrote: > > > Hi Russell, > > > > > > On Mon, Jul 25, 2016 at 01:25:04PM +0100, Russell King - ARM Lin

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-08-08 Thread Brian Starkey
Hi, On Mon, Jul 25, 2016 at 05:08:21PM +0200, Daniel Vetter wrote: On Mon, Jul 25, 2016 at 01:54:06PM +0100, Brian Starkey wrote: Hi Russell, On Mon, Jul 25, 2016 at 01:25:04PM +0100, Russell King - ARM Linux wrote: > On Mon, Jul 25, 2016 at 11:55:48AM +0100, Brian Starkey wrote: > > The conne

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-07-25 Thread Daniel Vetter
On Mon, Jul 25, 2016 at 01:54:06PM +0100, Brian Starkey wrote: > Hi Russell, > > On Mon, Jul 25, 2016 at 01:25:04PM +0100, Russell King - ARM Linux wrote: > > On Mon, Jul 25, 2016 at 11:55:48AM +0100, Brian Starkey wrote: > > > The connector shouldn't be registered until the rest of the whole devi

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-07-25 Thread Brian Starkey
Hi Russell, On Mon, Jul 25, 2016 at 01:25:04PM +0100, Russell King - ARM Linux wrote: On Mon, Jul 25, 2016 at 11:55:48AM +0100, Brian Starkey wrote: The connector shouldn't be registered until the rest of the whole device is set up, so that consistent state is presented to userspace. As drm_de

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-07-25 Thread Russell King - ARM Linux
On Mon, Jul 25, 2016 at 11:55:48AM +0100, Brian Starkey wrote: > The connector shouldn't be registered until the rest of the whole device > is set up, so that consistent state is presented to userspace. > > As drm_dev_register() now registers all of the connectors anyway, > there's no need to expl