Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE_DMA is set in setup.c

2007-03-07 Thread Andres Salomon
Christoph Lameter wrote:
> On Tue, 6 Mar 2007, Andres Salomon wrote:
> 
>> It would've been nice to see the ZONE_DMA removal patches just #define
>> ZONE_DMA regardless, and include less #ifdefs scattered about; but at
>> this point, I'd just as soon prefer to see a proper way to allocate
>> things based on address constraints (as discussed in
>> http://www.gelato.unsw.edu.au/archives/linux-ia64/0609/19036.html).
> 
> Would you be willing to work on that? I can sent you a bunch of unfinished 
> patches if you have the time.

Sure, I'd be willing to work on it.  Whether or not I have the time is
questionable, but it wouldn't hurt to send them..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE_DMA is set in setup.c

2007-03-07 Thread Christoph Lameter
On Tue, 6 Mar 2007, Andres Salomon wrote:

> It would've been nice to see the ZONE_DMA removal patches just #define
> ZONE_DMA regardless, and include less #ifdefs scattered about; but at
> this point, I'd just as soon prefer to see a proper way to allocate
> things based on address constraints (as discussed in
> http://www.gelato.unsw.edu.au/archives/linux-ia64/0609/19036.html).

Would you be willing to work on that? I can sent you a bunch of unfinished 
patches if you have the time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE_DMA is set in setup.c

2007-03-07 Thread Christoph Lameter
On Tue, 6 Mar 2007, Andres Salomon wrote:

 It would've been nice to see the ZONE_DMA removal patches just #define
 ZONE_DMA regardless, and include less #ifdefs scattered about; but at
 this point, I'd just as soon prefer to see a proper way to allocate
 things based on address constraints (as discussed in
 http://www.gelato.unsw.edu.au/archives/linux-ia64/0609/19036.html).

Would you be willing to work on that? I can sent you a bunch of unfinished 
patches if you have the time.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE_DMA is set in setup.c

2007-03-07 Thread Andres Salomon
Christoph Lameter wrote:
 On Tue, 6 Mar 2007, Andres Salomon wrote:
 
 It would've been nice to see the ZONE_DMA removal patches just #define
 ZONE_DMA regardless, and include less #ifdefs scattered about; but at
 this point, I'd just as soon prefer to see a proper way to allocate
 things based on address constraints (as discussed in
 http://www.gelato.unsw.edu.au/archives/linux-ia64/0609/19036.html).
 
 Would you be willing to work on that? I can sent you a bunch of unfinished 
 patches if you have the time.

Sure, I'd be willing to work on it.  Whether or not I have the time is
questionable, but it wouldn't hurt to send them..
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE_DMA is set in setup.c

2007-03-06 Thread Andres Salomon
Dave Jones wrote:
> On Tue, Mar 06, 2007 at 05:52:46PM -0800, Andrew Morton wrote:
>  > On Tue, 06 Mar 2007 18:52:59 -0500
>  > Andres Salomon <[EMAIL PROTECTED]> wrote:
>  > 
>  > > If CONFIG_ZONE_DMA is ever undefined, ZONE_DMA will also not be defined,
>  > > and setup.c won't compile.  This wraps it with an #ifdef.
>  > > 
>  > 
>  > I guess if anyone tries to disable ZONE_DMA on i386 they'll pretty quickly
>  > discover that.  But I don't think we need to "fix" it yet?

Oh, it's certainly not urgent.  I sent it simply for correctness reasons.

It would've been nice to see the ZONE_DMA removal patches just #define
ZONE_DMA regardless, and include less #ifdefs scattered about; but at
this point, I'd just as soon prefer to see a proper way to allocate
things based on address constraints (as discussed in
http://www.gelato.unsw.edu.au/archives/linux-ia64/0609/19036.html).


> 
> CONFIG_ZONE_DMA isn't even optional on i386, so I'm curious how
> you could hit this compile failure.
> 

Why, with custom code of course ;)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE_DMA is set in setup.c

2007-03-06 Thread Dave Jones
On Tue, Mar 06, 2007 at 05:52:46PM -0800, Andrew Morton wrote:
 > On Tue, 06 Mar 2007 18:52:59 -0500
 > Andres Salomon <[EMAIL PROTECTED]> wrote:
 > 
 > > If CONFIG_ZONE_DMA is ever undefined, ZONE_DMA will also not be defined,
 > > and setup.c won't compile.  This wraps it with an #ifdef.
 > > 
 > 
 > I guess if anyone tries to disable ZONE_DMA on i386 they'll pretty quickly
 > discover that.  But I don't think we need to "fix" it yet?

CONFIG_ZONE_DMA isn't even optional on i386, so I'm curious how
you could hit this compile failure.

Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE_DMA is set in setup.c

2007-03-06 Thread Andrew Morton
On Tue, 06 Mar 2007 18:52:59 -0500
Andres Salomon <[EMAIL PROTECTED]> wrote:

> If CONFIG_ZONE_DMA is ever undefined, ZONE_DMA will also not be defined,
> and setup.c won't compile.  This wraps it with an #ifdef.
> 

I guess if anyone tries to disable ZONE_DMA on i386 they'll pretty quickly
discover that.  But I don't think we need to "fix" it yet?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE_DMA is set in setup.c

2007-03-06 Thread Andrew Morton
On Tue, 06 Mar 2007 18:52:59 -0500
Andres Salomon [EMAIL PROTECTED] wrote:

 If CONFIG_ZONE_DMA is ever undefined, ZONE_DMA will also not be defined,
 and setup.c won't compile.  This wraps it with an #ifdef.
 

I guess if anyone tries to disable ZONE_DMA on i386 they'll pretty quickly
discover that.  But I don't think we need to fix it yet?

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE_DMA is set in setup.c

2007-03-06 Thread Dave Jones
On Tue, Mar 06, 2007 at 05:52:46PM -0800, Andrew Morton wrote:
  On Tue, 06 Mar 2007 18:52:59 -0500
  Andres Salomon [EMAIL PROTECTED] wrote:
  
   If CONFIG_ZONE_DMA is ever undefined, ZONE_DMA will also not be defined,
   and setup.c won't compile.  This wraps it with an #ifdef.
   
  
  I guess if anyone tries to disable ZONE_DMA on i386 they'll pretty quickly
  discover that.  But I don't think we need to fix it yet?

CONFIG_ZONE_DMA isn't even optional on i386, so I'm curious how
you could hit this compile failure.

Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE_DMA is set in setup.c

2007-03-06 Thread Andres Salomon
Dave Jones wrote:
 On Tue, Mar 06, 2007 at 05:52:46PM -0800, Andrew Morton wrote:
   On Tue, 06 Mar 2007 18:52:59 -0500
   Andres Salomon [EMAIL PROTECTED] wrote:
   
If CONFIG_ZONE_DMA is ever undefined, ZONE_DMA will also not be defined,
and setup.c won't compile.  This wraps it with an #ifdef.

   
   I guess if anyone tries to disable ZONE_DMA on i386 they'll pretty quickly
   discover that.  But I don't think we need to fix it yet?

Oh, it's certainly not urgent.  I sent it simply for correctness reasons.

It would've been nice to see the ZONE_DMA removal patches just #define
ZONE_DMA regardless, and include less #ifdefs scattered about; but at
this point, I'd just as soon prefer to see a proper way to allocate
things based on address constraints (as discussed in
http://www.gelato.unsw.edu.au/archives/linux-ia64/0609/19036.html).


 
 CONFIG_ZONE_DMA isn't even optional on i386, so I'm curious how
 you could hit this compile failure.
 

Why, with custom code of course ;)

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/