Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2013-01-11 Thread Grant Likely
On Mon, 24 Dec 2012 11:16:52 -0500, Jun Chen wrote: > On Fri, 2012-12-21 at 19:06 +, Grant Likely wrote: > > The problem is that I don't understand why this change is necessary. > > spi_devices should always be children of an spi_master, not siblings. > > What is the problem you're trying to

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2013-01-11 Thread Grant Likely
On Mon, 24 Dec 2012 11:16:52 -0500, Jun Chen jun.d.c...@intel.com wrote: On Fri, 2012-12-21 at 19:06 +, Grant Likely wrote: The problem is that I don't understand why this change is necessary. spi_devices should always be children of an spi_master, not siblings. What is the problem

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-24 Thread Jun Chen
On Fri, 2012-12-21 at 19:06 +, Grant Likely wrote: > On Fri, 21 Dec 2012 12:39:52 -0500, Jun Chen wrote: > > On Wed, 2012-12-19 at 16:21 +, Grant Likely wrote: > > > On Wed, 19 Dec 2012 09:04:16 +, Mark Brown > > > wrote: > > > > On Wed, Dec 19, 2012 at 04:44:03AM -0500, Jun Chen

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-24 Thread Jun Chen
On Fri, 2012-12-21 at 19:06 +, Grant Likely wrote: On Fri, 21 Dec 2012 12:39:52 -0500, Jun Chen jun.d.c...@intel.com wrote: On Wed, 2012-12-19 at 16:21 +, Grant Likely wrote: On Wed, 19 Dec 2012 09:04:16 +, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Dec

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-22 Thread Grant Likely
On Fri, 21 Dec 2012 12:39:52 -0500, Jun Chen wrote: > On Wed, 2012-12-19 at 16:21 +, Grant Likely wrote: > > On Wed, 19 Dec 2012 09:04:16 +, Mark Brown > > wrote: > > > On Wed, Dec 19, 2012 at 04:44:03AM -0500, Jun Chen wrote: > > > > > > > This spi_alloc_device function will be called

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-22 Thread Grant Likely
On Fri, 21 Dec 2012 12:39:52 -0500, Jun Chen jun.d.c...@intel.com wrote: On Wed, 2012-12-19 at 16:21 +, Grant Likely wrote: On Wed, 19 Dec 2012 09:04:16 +, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Dec 19, 2012 at 04:44:03AM -0500, Jun Chen wrote: This

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-21 Thread Jun Chen
On Wed, 2012-12-19 at 16:21 +, Grant Likely wrote: > On Wed, 19 Dec 2012 09:04:16 +, Mark Brown > wrote: > > On Wed, Dec 19, 2012 at 04:44:03AM -0500, Jun Chen wrote: > > > > > This spi_alloc_device function will be called in the spi_new_device > > > function to alloc new device as the

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-21 Thread Jun Chen
On Wed, 2012-12-19 at 16:21 +, Grant Likely wrote: On Wed, 19 Dec 2012 09:04:16 +, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Dec 19, 2012 at 04:44:03AM -0500, Jun Chen wrote: This spi_alloc_device function will be called in the spi_new_device function to

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-19 Thread Grant Likely
On Wed, 19 Dec 2012 09:04:16 +, Mark Brown wrote: > On Wed, Dec 19, 2012 at 04:44:03AM -0500, Jun Chen wrote: > > > This spi_alloc_device function will be called in the spi_new_device > > function to alloc new device as the master. But other way, it is called > > by the

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-19 Thread Mark Brown
On Wed, Dec 19, 2012 at 04:44:03AM -0500, Jun Chen wrote: > This spi_alloc_device function will be called in the spi_new_device > function to alloc new device as the master. But other way, it is called > by the of_register_spi_devices function to register new device as the > children of the

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-19 Thread Mark Brown
On Wed, Dec 19, 2012 at 04:44:03AM -0500, Jun Chen wrote: This spi_alloc_device function will be called in the spi_new_device function to alloc new device as the master. But other way, it is called by the of_register_spi_devices function to register new device as the children of the master. I

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-19 Thread Grant Likely
On Wed, 19 Dec 2012 09:04:16 +, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Dec 19, 2012 at 04:44:03AM -0500, Jun Chen wrote: This spi_alloc_device function will be called in the spi_new_device function to alloc new device as the master. But other way, it is called

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-18 Thread Jun Chen
On Tue, 2012-12-18 at 15:26 +, Mark Brown wrote: > On Tue, Dec 18, 2012 at 11:29:34AM -0500, Jun Chen wrote: > > > * @master: Controller to which device is connected > > + * device_was_children_of_master is flag which the device is registed > > + * as the children of the bus > > This isn't

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-18 Thread Mark Brown
On Tue, Dec 18, 2012 at 11:29:34AM -0500, Jun Chen wrote: > * @master: Controller to which device is connected > + * device_was_children_of_master is flag which the device is registed > + * as the children of the bus This isn't a kerneldoc style comment (it needs the @XXX: format). The name

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-18 Thread Mark Brown
On Tue, Dec 18, 2012 at 11:29:34AM -0500, Jun Chen wrote: * @master: Controller to which device is connected + * device_was_children_of_master is flag which the device is registed + * as the children of the bus This isn't a kerneldoc style comment (it needs the @XXX: format). The name is

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-18 Thread Jun Chen
On Tue, 2012-12-18 at 15:26 +, Mark Brown wrote: On Tue, Dec 18, 2012 at 11:29:34AM -0500, Jun Chen wrote: * @master: Controller to which device is connected + * device_was_children_of_master is flag which the device is registed + * as the children of the bus This isn't a