Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-16 Thread Dan Carpenter
On Fri, Mar 16, 2018 at 07:02:51AM +1100, NeilBrown wrote: > On Thu, Mar 15 2018, Dan Carpenter wrote: > > > On Thu, Mar 15, 2018 at 10:04:33PM +1100, NeilBrown wrote: > >> On Thu, Mar 15 2018, Dan Carpenter wrote: > >> > >> > This all seems fine. Generally the requirements for staging are that

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-15 Thread NeilBrown
On Thu, Mar 15 2018, John Crispin wrote: > On 15/03/18 21:12, NeilBrown wrote: >> On Thu, Mar 15 2018, John Crispin wrote: >> >>> On 15/03/18 11:48, Dan Carpenter wrote: This all seems fine. Generally the requirements for staging are that it has a TODO, someone to work on it, and it doe

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-15 Thread John Crispin
On 15/03/18 21:12, NeilBrown wrote: On Thu, Mar 15 2018, John Crispin wrote: On 15/03/18 11:48, Dan Carpenter wrote: This all seems fine. Generally the requirements for staging are that it has a TODO, someone to work on it, and it doesn't break the build. But some of the patches don't have

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-15 Thread NeilBrown
On Thu, Mar 15 2018, John Crispin wrote: > On 15/03/18 11:48, Dan Carpenter wrote: >> This all seems fine. Generally the requirements for staging are that it >> has a TODO, someone to work on it, and it doesn't break the build. But >> some of the patches don't have commit message and those are r

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-15 Thread NeilBrown
On Thu, Mar 15 2018, Dan Carpenter wrote: > On Thu, Mar 15, 2018 at 10:04:33PM +1100, NeilBrown wrote: >> On Thu, Mar 15 2018, Dan Carpenter wrote: >> >> > This all seems fine. Generally the requirements for staging are that it >> > has a TODO, someone to work on it, and it doesn't break the bui

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-15 Thread Dan Carpenter
On Thu, Mar 15, 2018 at 12:07:26PM +0100, John Crispin wrote: > None of the stuff posted is anywhere near ready to be > upstreamed. Yeah. This is staging so we accept any quality... The rest of the information is very useful. Thanks! regards, dan carpenter

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-15 Thread Dan Carpenter
On Thu, Mar 15, 2018 at 10:04:33PM +1100, NeilBrown wrote: > On Thu, Mar 15 2018, Dan Carpenter wrote: > > > This all seems fine. Generally the requirements for staging are that it > > has a TODO, someone to work on it, and it doesn't break the build. But > > some of the patches don't have commi

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-15 Thread John Crispin
On 15/03/18 11:48, Dan Carpenter wrote: This all seems fine. Generally the requirements for staging are that it has a TODO, someone to work on it, and it doesn't break the build. But some of the patches don't have commit message and those are required and some of the commit messages are just

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-15 Thread NeilBrown
On Thu, Mar 15 2018, Dan Carpenter wrote: > This all seems fine. Generally the requirements for staging are that it > has a TODO, someone to work on it, and it doesn't break the build. But > some of the patches don't have commit message and those are required and > some of the commit messages ar

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-15 Thread Dan Carpenter
This all seems fine. Generally the requirements for staging are that it has a TODO, someone to work on it, and it doesn't break the build. But some of the patches don't have commit message and those are required and some of the commit messages are just the changes you have made not don't describe

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-14 Thread NeilBrown
On Thu, Mar 15 2018, NeilBrown wrote: > Hi Greg, > I'd like to submit the following drivers to staging. They > are all for components of the mt7621 MIPS-based SOC from Mediatek. > I lifted them out of libreCMC and (for the ethernet code) out > of email posts from about 2 years ago. I forward