Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-19 Thread Maxime Ripard
On Wed, Jul 19, 2017 at 04:59:23PM +0800, Chen-Yu Tsai wrote: > On Mon, Jul 17, 2017 at 5:17 PM, Maxime Ripard > wrote: > > Hi, > > > > On Fri, Jul 14, 2017 at 02:42:56PM +0800, Chen-Yu Tsai wrote: > >> On the SoCs that introduced the new timing mode for MMC

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-19 Thread Maxime Ripard
On Wed, Jul 19, 2017 at 04:59:23PM +0800, Chen-Yu Tsai wrote: > On Mon, Jul 17, 2017 at 5:17 PM, Maxime Ripard > wrote: > > Hi, > > > > On Fri, Jul 14, 2017 at 02:42:56PM +0800, Chen-Yu Tsai wrote: > >> On the SoCs that introduced the new timing mode for MMC controllers, > >> both the old (where

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-19 Thread Chen-Yu Tsai
On Mon, Jul 17, 2017 at 5:17 PM, Maxime Ripard wrote: > Hi, > > On Fri, Jul 14, 2017 at 02:42:56PM +0800, Chen-Yu Tsai wrote: >> On the SoCs that introduced the new timing mode for MMC controllers, >> both the old (where the clock delays are set in the CCU) and

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-19 Thread Chen-Yu Tsai
On Mon, Jul 17, 2017 at 5:17 PM, Maxime Ripard wrote: > Hi, > > On Fri, Jul 14, 2017 at 02:42:56PM +0800, Chen-Yu Tsai wrote: >> On the SoCs that introduced the new timing mode for MMC controllers, >> both the old (where the clock delays are set in the CCU) and new >> (where the clock delays are

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-17 Thread kbuild test robot
Hi Chen-Yu, [auto build test ERROR on linus/master] [also build test ERROR on v4.13-rc1] [cannot apply to robh/for-next clk/clk-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-17 Thread kbuild test robot
Hi Chen-Yu, [auto build test ERROR on linus/master] [also build test ERROR on v4.13-rc1] [cannot apply to robh/for-next clk/clk-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-17 Thread Maxime Ripard
On Fri, Jul 14, 2017 at 11:57:35AM +0200, Ulf Hansson wrote: > >>> + if (host->use_new_timings) { > >>> + ret = sunxi_ccu_set_mmc_timing_mode(host->clk_mmc, true); > >> > >> Can't this be solved through some other generic API/interface? > > > > The old discussion is here:

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-17 Thread Maxime Ripard
On Fri, Jul 14, 2017 at 11:57:35AM +0200, Ulf Hansson wrote: > >>> + if (host->use_new_timings) { > >>> + ret = sunxi_ccu_set_mmc_timing_mode(host->clk_mmc, true); > >> > >> Can't this be solved through some other generic API/interface? > > > > The old discussion is here:

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-17 Thread Maxime Ripard
Hi, On Fri, Jul 14, 2017 at 02:42:56PM +0800, Chen-Yu Tsai wrote: > On the SoCs that introduced the new timing mode for MMC controllers, > both the old (where the clock delays are set in the CCU) and new > (where the clock delays are set in the MMC controller) timing modes > are available, and we

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-17 Thread Maxime Ripard
Hi, On Fri, Jul 14, 2017 at 02:42:56PM +0800, Chen-Yu Tsai wrote: > On the SoCs that introduced the new timing mode for MMC controllers, > both the old (where the clock delays are set in the CCU) and new > (where the clock delays are set in the MMC controller) timing modes > are available, and we

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-14 Thread Ulf Hansson
On 14 July 2017 at 11:40, Chen-Yu Tsai wrote: > On Fri, Jul 14, 2017 at 5:26 PM, Ulf Hansson wrote: >> On 14 July 2017 at 08:42, Chen-Yu Tsai wrote: >>> On the SoCs that introduced the new timing mode for MMC controllers, >>> both the old

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-14 Thread Ulf Hansson
On 14 July 2017 at 11:40, Chen-Yu Tsai wrote: > On Fri, Jul 14, 2017 at 5:26 PM, Ulf Hansson wrote: >> On 14 July 2017 at 08:42, Chen-Yu Tsai wrote: >>> On the SoCs that introduced the new timing mode for MMC controllers, >>> both the old (where the clock delays are set in the CCU) and new >>>

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-14 Thread Chen-Yu Tsai
On Fri, Jul 14, 2017 at 5:26 PM, Ulf Hansson wrote: > On 14 July 2017 at 08:42, Chen-Yu Tsai wrote: >> On the SoCs that introduced the new timing mode for MMC controllers, >> both the old (where the clock delays are set in the CCU) and new >> (where the

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-14 Thread Chen-Yu Tsai
On Fri, Jul 14, 2017 at 5:26 PM, Ulf Hansson wrote: > On 14 July 2017 at 08:42, Chen-Yu Tsai wrote: >> On the SoCs that introduced the new timing mode for MMC controllers, >> both the old (where the clock delays are set in the CCU) and new >> (where the clock delays are set in the MMC

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-14 Thread Ulf Hansson
On 14 July 2017 at 08:42, Chen-Yu Tsai wrote: > On the SoCs that introduced the new timing mode for MMC controllers, > both the old (where the clock delays are set in the CCU) and new > (where the clock delays are set in the MMC controller) timing modes > are available, and we have

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-14 Thread Ulf Hansson
On 14 July 2017 at 08:42, Chen-Yu Tsai wrote: > On the SoCs that introduced the new timing mode for MMC controllers, > both the old (where the clock delays are set in the CCU) and new > (where the clock delays are set in the MMC controller) timing modes > are available, and we have to support