Re: [PATCH 1/2] ASoC: fsl-spdif: big-endian support
On Tue, Feb 11, 2014 at 03:39:44PM +0800, Xiubo Li-B47053 wrote: > > > > > + - big-endian : If this property is absent, the native endian mode will > > > + be in use as default, or the big endian mode will be in use for all > > > the > > > + device registers. > > > + > > > > @Shawn > > Does DT have an existing approach to determine if the current SoC this IP > > uses is BE or LE? I am thinking the scenario that if all drivers support > > BE/LE while the SoC is big-endian, all the nodes in the DT would have to > > include a duplicated property (big-endian). > > > > @Nicolin, @Shawn > One special scenario likes the LS1 platform, the CPU and a few devices are in > LE mode and other devices will be in BE mode. Hmm... a bit strange to me. But I think it then should be fine here if it's plausible as you describe. Please revise the patch and send it to see if there's any comment from others. And for both revised patches: Acked-by: Nicolin Chen Thank you -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ASoC: fsl-spdif: big-endian support
On Tue, Feb 11, 2014 at 03:39:44PM +0800, Xiubo Li-B47053 wrote: + - big-endian : If this property is absent, the native endian mode will + be in use as default, or the big endian mode will be in use for all the + device registers. + @Shawn Does DT have an existing approach to determine if the current SoC this IP uses is BE or LE? I am thinking the scenario that if all drivers support BE/LE while the SoC is big-endian, all the nodes in the DT would have to include a duplicated property (big-endian). @Nicolin, @Shawn One special scenario likes the LS1 platform, the CPU and a few devices are in LE mode and other devices will be in BE mode. Hmm... a bit strange to me. But I think it then should be fine here if it's plausible as you describe. Please revise the patch and send it to see if there's any comment from others. And for both revised patches: Acked-by: Nicolin Chen guangyu.c...@freescale.com Thank you -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/2] ASoC: fsl-spdif: big-endian support
> > + - big-endian : If this property is absent, the native endian mode will > > + be in use as default, or the big endian mode will be in use for all the > > + device registers. > > + > > @Shawn > Does DT have an existing approach to determine if the current SoC this IP > uses is BE or LE? I am thinking the scenario that if all drivers support > BE/LE while the SoC is big-endian, all the nodes in the DT would have to > include a duplicated property (big-endian). > @Nicolin, @Shawn One special scenario likes the LS1 platform, the CPU and a few devices are in LE mode and other devices will be in BE mode. Thanks, -- Best Regards, Xiubo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/2] ASoC: fsl-spdif: big-endian support
> > + spdif_priv->big_endian = of_property_read_bool(np, "big-endian"); > > + if (spdif_priv->big_endian) > > + fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; > > Why not just: > if (of_property_read_bool(np, "big-endian")) > fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; > I just think maybe other places of the driver maybe use this. Yes, it could be removed just for now. See the next version please. Thanks very much, -- Best Regards, Xiubo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ASoC: fsl-spdif: big-endian support
On Tue, Feb 11, 2014 at 01:41:15PM +0800, Xiubo Li wrote:
> For most platforms, the CPU and SPDIF device is in the same endianess
> mode. While for the LS1 platform, the CPU is in LE mode and the SPDIF
> is in BE mode.
>
> Signed-off-by: Xiubo Li
> Cc: Nicolin Chen
> ---
> Documentation/devicetree/bindings/sound/fsl,spdif.txt | 4
> sound/soc/fsl/fsl_spdif.c | 8 +++-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.txt
> b/Documentation/devicetree/bindings/sound/fsl,spdif.txt
> index f2ae335..433ad00 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,spdif.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl,spdif.txt
> @@ -29,6 +29,10 @@ Required properties:
> can also be referred to TxClk_Source
> bit of register SPDIF_STC.
>
> + - big-endian : If this property is absent, the native endian mode will
> + be in use as default, or the big endian mode will be in use for all the
> + device registers.
> +
@Shawn
Does DT have an existing approach to determine if the current SoC this IP
uses is BE or LE? I am thinking the scenario that if all drivers support
BE/LE while the SoC is big-endian, all the nodes in the DT would have to
include a duplicated property (big-endian).
> Example:
>
> spdif: spdif@02004000 {
> diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> index 8f36f49..2f8ad75 100644
> --- a/sound/soc/fsl/fsl_spdif.c
> +++ b/sound/soc/fsl/fsl_spdif.c
> @@ -83,6 +83,8 @@ struct fsl_spdif_priv {
> struct snd_dmaengine_dai_dma_data dma_params_tx;
> struct snd_dmaengine_dai_dma_data dma_params_rx;
>
> + bool big_endian;
> +
> /* The name space will be allocated dynamically */
> char name[0];
> };
> @@ -985,7 +987,7 @@ static bool fsl_spdif_writeable_reg(struct device *dev,
> unsigned int reg)
> }
> }
>
> -static const struct regmap_config fsl_spdif_regmap_config = {
> +static struct regmap_config fsl_spdif_regmap_config = {
> .reg_bits = 32,
> .reg_stride = 4,
> .val_bits = 32,
> @@ -1105,6 +1107,10 @@ static int fsl_spdif_probe(struct platform_device
> *pdev)
> memcpy(_priv->cpu_dai_drv, _spdif_dai, sizeof(fsl_spdif_dai));
> spdif_priv->cpu_dai_drv.name = spdif_priv->name;
>
> + spdif_priv->big_endian = of_property_read_bool(np, "big-endian");
> + if (spdif_priv->big_endian)
> + fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
Why not just:
if (of_property_read_bool(np, "big-endian"))
fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
> +
> /* Get the addresses and IRQ */
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> regs = devm_ioremap_resource(>dev, res);
> --
> 1.8.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ASoC: fsl-spdif: big-endian support
On Tue, Feb 11, 2014 at 01:41:15PM +0800, Xiubo Li wrote:
For most platforms, the CPU and SPDIF device is in the same endianess
mode. While for the LS1 platform, the CPU is in LE mode and the SPDIF
is in BE mode.
Signed-off-by: Xiubo Li li.xi...@freescale.com
Cc: Nicolin Chen guangyu.c...@freescale.com
---
Documentation/devicetree/bindings/sound/fsl,spdif.txt | 4
sound/soc/fsl/fsl_spdif.c | 8 +++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.txt
b/Documentation/devicetree/bindings/sound/fsl,spdif.txt
index f2ae335..433ad00 100644
--- a/Documentation/devicetree/bindings/sound/fsl,spdif.txt
+++ b/Documentation/devicetree/bindings/sound/fsl,spdif.txt
@@ -29,6 +29,10 @@ Required properties:
can also be referred to TxClk_Source
bit of register SPDIF_STC.
+ - big-endian : If this property is absent, the native endian mode will
+ be in use as default, or the big endian mode will be in use for all the
+ device registers.
+
@Shawn
Does DT have an existing approach to determine if the current SoC this IP
uses is BE or LE? I am thinking the scenario that if all drivers support
BE/LE while the SoC is big-endian, all the nodes in the DT would have to
include a duplicated property (big-endian).
Example:
spdif: spdif@02004000 {
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index 8f36f49..2f8ad75 100644
--- a/sound/soc/fsl/fsl_spdif.c
+++ b/sound/soc/fsl/fsl_spdif.c
@@ -83,6 +83,8 @@ struct fsl_spdif_priv {
struct snd_dmaengine_dai_dma_data dma_params_tx;
struct snd_dmaengine_dai_dma_data dma_params_rx;
+ bool big_endian;
+
/* The name space will be allocated dynamically */
char name[0];
};
@@ -985,7 +987,7 @@ static bool fsl_spdif_writeable_reg(struct device *dev,
unsigned int reg)
}
}
-static const struct regmap_config fsl_spdif_regmap_config = {
+static struct regmap_config fsl_spdif_regmap_config = {
.reg_bits = 32,
.reg_stride = 4,
.val_bits = 32,
@@ -1105,6 +1107,10 @@ static int fsl_spdif_probe(struct platform_device
*pdev)
memcpy(spdif_priv-cpu_dai_drv, fsl_spdif_dai, sizeof(fsl_spdif_dai));
spdif_priv-cpu_dai_drv.name = spdif_priv-name;
+ spdif_priv-big_endian = of_property_read_bool(np, big-endian);
+ if (spdif_priv-big_endian)
+ fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
Why not just:
if (of_property_read_bool(np, big-endian))
fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
+
/* Get the addresses and IRQ */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
regs = devm_ioremap_resource(pdev-dev, res);
--
1.8.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/2] ASoC: fsl-spdif: big-endian support
+ spdif_priv-big_endian = of_property_read_bool(np, big-endian); + if (spdif_priv-big_endian) + fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; Why not just: if (of_property_read_bool(np, big-endian)) fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; I just think maybe other places of the driver maybe use this. Yes, it could be removed just for now. See the next version please. Thanks very much, -- Best Regards, Xiubo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/2] ASoC: fsl-spdif: big-endian support
+ - big-endian : If this property is absent, the native endian mode will + be in use as default, or the big endian mode will be in use for all the + device registers. + @Shawn Does DT have an existing approach to determine if the current SoC this IP uses is BE or LE? I am thinking the scenario that if all drivers support BE/LE while the SoC is big-endian, all the nodes in the DT would have to include a duplicated property (big-endian). @Nicolin, @Shawn One special scenario likes the LS1 platform, the CPU and a few devices are in LE mode and other devices will be in BE mode. Thanks, -- Best Regards, Xiubo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
