Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

Hi, On Thu, 2017-04-27 at 20:55 +0200, Arnd Bergmann wrote: > On Wed, Apr 26, 2017 at 10:10 AM, Ryder Lee wrote: > > On Tue, 2017-04-25 at 14:38 +0200, Arnd Bergmann wrote: > >> On Sun, Apr 23, 2017 at 10:19 AM, Ryder Lee wrote: > > >> > +static

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

Hi, On Thu, 2017-04-27 at 20:55 +0200, Arnd Bergmann wrote: > On Wed, Apr 26, 2017 at 10:10 AM, Ryder Lee wrote: > > On Tue, 2017-04-25 at 14:38 +0200, Arnd Bergmann wrote: > >> On Sun, Apr 23, 2017 at 10:19 AM, Ryder Lee wrote: > > >> > +static int mtk_pcie_enable_ports(struct mtk_pcie *pcie)

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

On Wed, Apr 26, 2017 at 10:10 AM, Ryder Lee wrote: > On Tue, 2017-04-25 at 14:38 +0200, Arnd Bergmann wrote: >> On Sun, Apr 23, 2017 at 10:19 AM, Ryder Lee wrote: >> > +static int mtk_pcie_enable_ports(struct mtk_pcie *pcie) >> > +{ >> > +

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

On Wed, Apr 26, 2017 at 10:10 AM, Ryder Lee wrote: > On Tue, 2017-04-25 at 14:38 +0200, Arnd Bergmann wrote: >> On Sun, Apr 23, 2017 at 10:19 AM, Ryder Lee wrote: >> > +static int mtk_pcie_enable_ports(struct mtk_pcie *pcie) >> > +{ >> > + struct device *dev = pcie->dev; >> > +

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

Hi, On Tue, 2017-04-25 at 14:38 +0200, Arnd Bergmann wrote: > On Sun, Apr 23, 2017 at 10:19 AM, Ryder Lee wrote: > > > +static inline bool mtk_pcie_link_is_up(struct mtk_pcie_port *port) > > +{ > > + return !!(readl_relaxed(port->base + PCIE_LINK_STATUS) & > > +

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

Hi, On Tue, 2017-04-25 at 14:38 +0200, Arnd Bergmann wrote: > On Sun, Apr 23, 2017 at 10:19 AM, Ryder Lee wrote: > > > +static inline bool mtk_pcie_link_is_up(struct mtk_pcie_port *port) > > +{ > > + return !!(readl_relaxed(port->base + PCIE_LINK_STATUS) & > > +

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

On Sun, Apr 23, 2017 at 10:19 AM, Ryder Lee wrote: > +static inline bool mtk_pcie_link_is_up(struct mtk_pcie_port *port) > +{ > + return !!(readl_relaxed(port->base + PCIE_LINK_STATUS) & > + PCIE_PORT_LINKUP); > +} If this is not performance

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

On Sun, Apr 23, 2017 at 10:19 AM, Ryder Lee wrote: > +static inline bool mtk_pcie_link_is_up(struct mtk_pcie_port *port) > +{ > + return !!(readl_relaxed(port->base + PCIE_LINK_STATUS) & > + PCIE_PORT_LINKUP); > +} If this is not performance critical, please use the

Re: Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

Hi, On Mon, 2017-04-24 at 17:02 -0500, Bjorn Helgaas wrote: > Hi Ryder, > > Looks good, but I have a few questions below. > > On Sun, Apr 23, 2017 at 04:19:02PM +0800, Ryder Lee wrote: > > Add support for the Mediatek PCIe controller which can be found > > on MT7623A/N, MT2701 and MT8521p

Re: Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

Hi, On Mon, 2017-04-24 at 17:02 -0500, Bjorn Helgaas wrote: > Hi Ryder, > > Looks good, but I have a few questions below. > > On Sun, Apr 23, 2017 at 04:19:02PM +0800, Ryder Lee wrote: > > Add support for the Mediatek PCIe controller which can be found > > on MT7623A/N, MT2701 and MT8521p

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

Hi Ryder, Looks good, but I have a few questions below. On Sun, Apr 23, 2017 at 04:19:02PM +0800, Ryder Lee wrote: > Add support for the Mediatek PCIe controller which can be found > on MT7623A/N, MT2701 and MT8521p platforms. > > Signed-off-by: Ryder Lee > --- >

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

Hi Ryder, Looks good, but I have a few questions below. On Sun, Apr 23, 2017 at 04:19:02PM +0800, Ryder Lee wrote: > Add support for the Mediatek PCIe controller which can be found > on MT7623A/N, MT2701 and MT8521p platforms. > > Signed-off-by: Ryder Lee > --- > drivers/pci/host/Kconfig

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

Hi Ryder, [auto build test WARNING on pci/next] [also build test WARNING on v4.11-rc7 next-20170421] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

Hi Ryder, [auto build test WARNING on pci/next] [also build test WARNING on v4.11-rc7 next-20170421] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: