Re: [PATCH 1/3] clocksource: drivers: set clockevent device cpumask to cpu_possible_mask

[Thomas Gleixner]

On Wed, 11 Jul 2018, Daniel Lezcano wrote:

> On 11/07/2018 15:42, Sudeep Holla wrote:
> > Hi Daniel,
> > 
> > On 11/07/18 12:36, Daniel Lezcano wrote:
> >> On 11/07/2018 13:24, Sudeep Holla wrote:
> >>> Currently, quite a few clockevent devices have cpumask set to
> >>> cpu_all_mask which should be fine. However, cpu_possible_mask is more
> >>> accurate and if there are any other clockevent devices in the system
> >>> which have cpumask set to cpu_possible_mask, then having cpu_all_mask
> >>> may result in issues (mostly boot hang with forever loops in
> >>> clockevents_notify_released).
> >>>
> >>> So, lets replace all the clockevent device cpu_all_mask to
> >>> cpu_possible_mask in order to prevent above mentioned possible issue.
> >>>
> >>> Cc: Daniel Lezcano 
> >>> Cc: Thomas Gleixner 
> >>> Cc: Thierry Reding 
> >>> Cc: Jonathan Hunter 
> >>> Cc: Santosh Shilimkar 
> >>> Signed-off-by: Sudeep Holla 
> >>> ---
> >>
> >> Applied, thanks for the fix.
> >>
> > 
> > Thomas was planning to take this, see [1]
> 
> Thomas ?
> 
> Do you want to take all the series ? Or shall I take this one ?

Take it, it's ok for this to go into 4.19

Thanks,

tglx

Re: [PATCH 1/3] clocksource: drivers: set clockevent device cpumask to cpu_possible_mask

[Daniel Lezcano]

On 11/07/2018 15:42, Sudeep Holla wrote:
> Hi Daniel,
> 
> On 11/07/18 12:36, Daniel Lezcano wrote:
>> On 11/07/2018 13:24, Sudeep Holla wrote:
>>> Currently, quite a few clockevent devices have cpumask set to
>>> cpu_all_mask which should be fine. However, cpu_possible_mask is more
>>> accurate and if there are any other clockevent devices in the system
>>> which have cpumask set to cpu_possible_mask, then having cpu_all_mask
>>> may result in issues (mostly boot hang with forever loops in
>>> clockevents_notify_released).
>>>
>>> So, lets replace all the clockevent device cpu_all_mask to
>>> cpu_possible_mask in order to prevent above mentioned possible issue.
>>>
>>> Cc: Daniel Lezcano 
>>> Cc: Thomas Gleixner 
>>> Cc: Thierry Reding 
>>> Cc: Jonathan Hunter 
>>> Cc: Santosh Shilimkar 
>>> Signed-off-by: Sudeep Holla 
>>> ---
>>
>> Applied, thanks for the fix.
>>
> 
> Thomas was planning to take this, see [1]

Thomas ?

Do you want to take all the series ? Or shall I take this one ?


-- 
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

Re: [PATCH 1/3] clocksource: drivers: set clockevent device cpumask to cpu_possible_mask

[Sudeep Holla]

Hi Daniel,

On 11/07/18 12:36, Daniel Lezcano wrote:
> On 11/07/2018 13:24, Sudeep Holla wrote:
>> Currently, quite a few clockevent devices have cpumask set to
>> cpu_all_mask which should be fine. However, cpu_possible_mask is more
>> accurate and if there are any other clockevent devices in the system
>> which have cpumask set to cpu_possible_mask, then having cpu_all_mask
>> may result in issues (mostly boot hang with forever loops in
>> clockevents_notify_released).
>>
>> So, lets replace all the clockevent device cpu_all_mask to
>> cpu_possible_mask in order to prevent above mentioned possible issue.
>>
>> Cc: Daniel Lezcano 
>> Cc: Thomas Gleixner 
>> Cc: Thierry Reding 
>> Cc: Jonathan Hunter 
>> Cc: Santosh Shilimkar 
>> Signed-off-by: Sudeep Holla 
>> ---
> 
> Applied, thanks for the fix.
> 

Thomas was planning to take this, see [1]
-- 
Regards,
Sudeep

[1]
https://lore.kernel.org/lkml/alpine.deb.2.21.1807102220320.1...@nanos.tec.linutronix.de/

Re: [PATCH 1/3] clocksource: drivers: set clockevent device cpumask to cpu_possible_mask

[Daniel Lezcano]

On 11/07/2018 13:24, Sudeep Holla wrote:
> Currently, quite a few clockevent devices have cpumask set to
> cpu_all_mask which should be fine. However, cpu_possible_mask is more
> accurate and if there are any other clockevent devices in the system
> which have cpumask set to cpu_possible_mask, then having cpu_all_mask
> may result in issues (mostly boot hang with forever loops in
> clockevents_notify_released).
> 
> So, lets replace all the clockevent device cpu_all_mask to
> cpu_possible_mask in order to prevent above mentioned possible issue.
> 
> Cc: Daniel Lezcano 
> Cc: Thomas Gleixner 
> Cc: Thierry Reding 
> Cc: Jonathan Hunter 
> Cc: Santosh Shilimkar 
> Signed-off-by: Sudeep Holla 
> ---

Applied, thanks for the fix.


-- 
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog