Re: [PATCH 2/2] drm/sun4i: add lvds mode_valid function

2018-03-02 Thread Giulio Benetti
Hi, Il 02/03/2018 15:37, Maxime Ripard ha scritto: On Fri, Mar 02, 2018 at 12:42:14PM +0100, Giulio Benetti wrote: Hi, Il 01/03/2018 10:57, Maxime Ripard ha scritto: On Wed, Feb 28, 2018 at 06:53:52PM +0100, Giulio Benetti wrote: static struct drm_connector_helper_funcs

Re: [PATCH 2/2] drm/sun4i: add lvds mode_valid function

2018-03-02 Thread Maxime Ripard
On Fri, Mar 02, 2018 at 12:42:14PM +0100, Giulio Benetti wrote: > Hi, > > Il 01/03/2018 10:57, Maxime Ripard ha scritto: > > On Wed, Feb 28, 2018 at 06:53:52PM +0100, Giulio Benetti wrote: > > > static struct drm_connector_helper_funcs sun4i_lvds_con_helper_funcs = { > > > .get_modes

Re: [PATCH 2/2] drm/sun4i: add lvds mode_valid function

2018-03-02 Thread Giulio Benetti
Hi, Il 01/03/2018 10:57, Maxime Ripard ha scritto: On Wed, Feb 28, 2018 at 06:53:52PM +0100, Giulio Benetti wrote: static struct drm_connector_helper_funcs sun4i_lvds_con_helper_funcs = { .get_modes = sun4i_lvds_get_modes, + .mode_valid = sun4i_lvds_mode_valid, };

Re: [PATCH 2/2] drm/sun4i: add lvds mode_valid function

2018-03-01 Thread Maxime Ripard
On Wed, Feb 28, 2018 at 06:53:52PM +0100, Giulio Benetti wrote: > static struct drm_connector_helper_funcs sun4i_lvds_con_helper_funcs = { > .get_modes = sun4i_lvds_get_modes, > + .mode_valid = sun4i_lvds_mode_valid, > }; This should be on the encoder, not the connector.