Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-12-21 Thread lihanhui
在 2012-9-5,下午4:11,Minchan Kim 写道: > This patch introudes MIGRATE_DISCARD mode in migration. > It drops *clean cache pages* instead of migration so that > migration latency could be reduced by avoiding (memcpy + page remapping). > It's useful for CMA because latency of migration is very

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-12-21 Thread lihanhui
在 2012-9-5,下午4:11,Minchan Kim minc...@kernel.org 写道: This patch introudes MIGRATE_DISCARD mode in migration. It drops *clean cache pages* instead of migration so that migration latency could be reduced by avoiding (memcpy + page remapping). It's useful for CMA because latency of migration is

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Minchan Kim
On Fri, Sep 07, 2012 at 10:32:03AM +0100, Mel Gorman wrote: > On Fri, Sep 07, 2012 at 09:21:45AM +0100, Mel Gorman wrote: > > > > So other than the mix up of order parameters I think this should work. > > > > But I'd be wrong, isolated page accounting is not fixed up so it will > eventually

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Mel Gorman
On Fri, Sep 07, 2012 at 09:21:45AM +0100, Mel Gorman wrote: > > So other than the mix up of order parameters I think this should work. > But I'd be wrong, isolated page accounting is not fixed up so it will eventually hang on too_many_isolated. It turns out it is necessary to pass in zone after

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Kyungmin Park
On 9/7/12, Minchan Kim wrote: > Hi Kyungmin, > > On Fri, Sep 07, 2012 at 04:31:17PM +0900, Kyungmin Park wrote: >> On 9/7/12, Kyungmin Park wrote: >> > Hi Minchan, >> > >> > I tested Mel patch again with ClearPageActive(page). but after some >> > testing, it's stall and can't return from >> >

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Mel Gorman
On Fri, Sep 07, 2012 at 11:24:34AM +0900, Minchan Kim wrote: > > +unsigned long reclaim_clean_pages_from_list(struct list_head *page_list) > > +{ > > + struct scan_control sc = { > > + .gfp_mask = GFP_KERNEL, > > + .priority = DEF_PRIORITY, > > + }; > > + unsigned long

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Minchan Kim
Hi Kyungmin, On Fri, Sep 07, 2012 at 04:31:17PM +0900, Kyungmin Park wrote: > On 9/7/12, Kyungmin Park wrote: > > Hi Minchan, > > > > I tested Mel patch again with ClearPageActive(page). but after some > > testing, it's stall and can't return from > > reclaim_clean_pages_from_list(). > > > >

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Mel Gorman
On Fri, Sep 07, 2012 at 11:26:01AM +0900, Minchan Kim wrote: > On Fri, Sep 07, 2012 at 09:57:12AM +0900, Kyungmin Park wrote: > > Hi Mel, > > > > After apply your patch, It got the below message. > > Please note that it's not the latest kernel. it's kernel v3.0.31 + CMA > > + your patch. > > It

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Kyungmin Park
On 9/7/12, Kyungmin Park wrote: > Hi Minchan, > > I tested Mel patch again with ClearPageActive(page). but after some > testing, it's stall and can't return from > reclaim_clean_pages_from_list(). > > Maybe it's related with unmap feature from yours? > stall is not happened from your codes until

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Kyungmin Park
On 9/7/12, Kyungmin Park kmp...@infradead.org wrote: Hi Minchan, I tested Mel patch again with ClearPageActive(page). but after some testing, it's stall and can't return from reclaim_clean_pages_from_list(cc.migratepages). Maybe it's related with unmap feature from yours? stall is not

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Mel Gorman
On Fri, Sep 07, 2012 at 11:26:01AM +0900, Minchan Kim wrote: On Fri, Sep 07, 2012 at 09:57:12AM +0900, Kyungmin Park wrote: Hi Mel, After apply your patch, It got the below message. Please note that it's not the latest kernel. it's kernel v3.0.31 + CMA + your patch. It seems it

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Minchan Kim
Hi Kyungmin, On Fri, Sep 07, 2012 at 04:31:17PM +0900, Kyungmin Park wrote: On 9/7/12, Kyungmin Park kmp...@infradead.org wrote: Hi Minchan, I tested Mel patch again with ClearPageActive(page). but after some testing, it's stall and can't return from

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Mel Gorman
On Fri, Sep 07, 2012 at 11:24:34AM +0900, Minchan Kim wrote: +unsigned long reclaim_clean_pages_from_list(struct list_head *page_list) +{ + struct scan_control sc = { + .gfp_mask = GFP_KERNEL, + .priority = DEF_PRIORITY, + }; + unsigned long ret; +

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Kyungmin Park
On 9/7/12, Minchan Kim minc...@kernel.org wrote: Hi Kyungmin, On Fri, Sep 07, 2012 at 04:31:17PM +0900, Kyungmin Park wrote: On 9/7/12, Kyungmin Park kmp...@infradead.org wrote: Hi Minchan, I tested Mel patch again with ClearPageActive(page). but after some testing, it's stall and

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Mel Gorman
On Fri, Sep 07, 2012 at 09:21:45AM +0100, Mel Gorman wrote: So other than the mix up of order parameters I think this should work. But I'd be wrong, isolated page accounting is not fixed up so it will eventually hang on too_many_isolated. It turns out it is necessary to pass in zone after

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Minchan Kim
On Fri, Sep 07, 2012 at 10:32:03AM +0100, Mel Gorman wrote: On Fri, Sep 07, 2012 at 09:21:45AM +0100, Mel Gorman wrote: So other than the mix up of order parameters I think this should work. But I'd be wrong, isolated page accounting is not fixed up so it will eventually hang on

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-06 Thread Kyungmin Park
Hi Minchan, I tested Mel patch again with ClearPageActive(page). but after some testing, it's stall and can't return from reclaim_clean_pages_from_list(). Maybe it's related with unmap feature from yours? stall is not happened from your codes until now. I'll test it more and report any issue if

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-06 Thread Minchan Kim
On Fri, Sep 07, 2012 at 09:57:12AM +0900, Kyungmin Park wrote: > Hi Mel, > > After apply your patch, It got the below message. > Please note that it's not the latest kernel. it's kernel v3.0.31 + CMA > + your patch. > It seems it should not be active but it contains active field. Yeb. At the

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-06 Thread Minchan Kim
On Thu, Sep 06, 2012 at 10:03:25AM +0100, Mel Gorman wrote: > On Thu, Sep 06, 2012 at 09:29:35AM +0100, Mel Gorman wrote: > > On Thu, Sep 06, 2012 at 02:31:12PM +0900, Minchan Kim wrote: > > > Hi Mel, > > > > > > On Wed, Sep 05, 2012 at 11:56:11AM +0100, Mel Gorman wrote: > > > > On Wed, Sep 05,

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-06 Thread Kyungmin Park
Hi Mel, After apply your patch, It got the below message. Please note that it's not the latest kernel. it's kernel v3.0.31 + CMA + your patch. It seems it should not be active but it contains active field. Thank you, Kyungmin Park [ 79.160394] c1 BUG: Bad page state in process mediaserver

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-06 Thread Mel Gorman
On Thu, Sep 06, 2012 at 09:29:35AM +0100, Mel Gorman wrote: > On Thu, Sep 06, 2012 at 02:31:12PM +0900, Minchan Kim wrote: > > Hi Mel, > > > > On Wed, Sep 05, 2012 at 11:56:11AM +0100, Mel Gorman wrote: > > > On Wed, Sep 05, 2012 at 05:11:13PM +0900, Minchan Kim wrote: > > > > This patch

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-06 Thread Mel Gorman
On Thu, Sep 06, 2012 at 02:31:12PM +0900, Minchan Kim wrote: > Hi Mel, > > On Wed, Sep 05, 2012 at 11:56:11AM +0100, Mel Gorman wrote: > > On Wed, Sep 05, 2012 at 05:11:13PM +0900, Minchan Kim wrote: > > > This patch introudes MIGRATE_DISCARD mode in migration. > > > It drops *clean cache pages*

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-06 Thread Mel Gorman
On Thu, Sep 06, 2012 at 02:31:12PM +0900, Minchan Kim wrote: Hi Mel, On Wed, Sep 05, 2012 at 11:56:11AM +0100, Mel Gorman wrote: On Wed, Sep 05, 2012 at 05:11:13PM +0900, Minchan Kim wrote: This patch introudes MIGRATE_DISCARD mode in migration. It drops *clean cache pages* instead of

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-06 Thread Mel Gorman
On Thu, Sep 06, 2012 at 09:29:35AM +0100, Mel Gorman wrote: On Thu, Sep 06, 2012 at 02:31:12PM +0900, Minchan Kim wrote: Hi Mel, On Wed, Sep 05, 2012 at 11:56:11AM +0100, Mel Gorman wrote: On Wed, Sep 05, 2012 at 05:11:13PM +0900, Minchan Kim wrote: This patch introudes

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-06 Thread Kyungmin Park
Hi Mel, After apply your patch, It got the below message. Please note that it's not the latest kernel. it's kernel v3.0.31 + CMA + your patch. It seems it should not be active but it contains active field. Thank you, Kyungmin Park [ 79.160394] c1 BUG: Bad page state in process mediaserver

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-06 Thread Minchan Kim
On Thu, Sep 06, 2012 at 10:03:25AM +0100, Mel Gorman wrote: On Thu, Sep 06, 2012 at 09:29:35AM +0100, Mel Gorman wrote: On Thu, Sep 06, 2012 at 02:31:12PM +0900, Minchan Kim wrote: Hi Mel, On Wed, Sep 05, 2012 at 11:56:11AM +0100, Mel Gorman wrote: On Wed, Sep 05, 2012 at

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-06 Thread Minchan Kim
On Fri, Sep 07, 2012 at 09:57:12AM +0900, Kyungmin Park wrote: Hi Mel, After apply your patch, It got the below message. Please note that it's not the latest kernel. it's kernel v3.0.31 + CMA + your patch. It seems it should not be active but it contains active field. Yeb. At the moment,

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-06 Thread Kyungmin Park
Hi Minchan, I tested Mel patch again with ClearPageActive(page). but after some testing, it's stall and can't return from reclaim_clean_pages_from_list(cc.migratepages). Maybe it's related with unmap feature from yours? stall is not happened from your codes until now. I'll test it more and

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-05 Thread Minchan Kim
Hi Mel, On Wed, Sep 05, 2012 at 11:56:11AM +0100, Mel Gorman wrote: > On Wed, Sep 05, 2012 at 05:11:13PM +0900, Minchan Kim wrote: > > This patch introudes MIGRATE_DISCARD mode in migration. > > It drops *clean cache pages* instead of migration so that > > migration latency could be reduced by

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-05 Thread Michal Nazarewicz
On Wed, Sep 05 2012, Minchan Kim wrote: > This patch introudes MIGRATE_DISCARD mode in migration. > It drops *clean cache pages* instead of migration so that > migration latency could be reduced by avoiding (memcpy + page remapping). > It's useful for CMA because latency of migration is very

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-05 Thread Mel Gorman
On Wed, Sep 05, 2012 at 05:11:13PM +0900, Minchan Kim wrote: > This patch introudes MIGRATE_DISCARD mode in migration. > It drops *clean cache pages* instead of migration so that > migration latency could be reduced by avoiding (memcpy + page remapping). > It's useful for CMA because latency of

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-05 Thread Minchan Kim
Hi Mel, On Wed, Sep 05, 2012 at 11:56:11AM +0100, Mel Gorman wrote: On Wed, Sep 05, 2012 at 05:11:13PM +0900, Minchan Kim wrote: This patch introudes MIGRATE_DISCARD mode in migration. It drops *clean cache pages* instead of migration so that migration latency could be reduced by avoiding

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-05 Thread Mel Gorman
On Wed, Sep 05, 2012 at 05:11:13PM +0900, Minchan Kim wrote: This patch introudes MIGRATE_DISCARD mode in migration. It drops *clean cache pages* instead of migration so that migration latency could be reduced by avoiding (memcpy + page remapping). It's useful for CMA because latency of

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-05 Thread Michal Nazarewicz
On Wed, Sep 05 2012, Minchan Kim wrote: This patch introudes MIGRATE_DISCARD mode in migration. It drops *clean cache pages* instead of migration so that migration latency could be reduced by avoiding (memcpy + page remapping). It's useful for CMA because latency of migration is very important