Re: [PATCH 3/9] mfd: intel_soc_pmic: remove unnecessary CONFIG_PM_SLEEP

2020-11-02 Thread Lee Jones
On Mon, 02 Nov 2020, Andy Shevchenko wrote: > On Mon, Nov 2, 2020 at 10:39 AM Lee Jones wrote: > > On Thu, 29 Oct 2020, Andy Shevchenko wrote: > > > On Thu, Oct 29, 2020 at 5:27 PM Lee Jones wrote: > > > > On Thu, 29 Oct 2020, Coiby Xu wrote: > > > > > On Thu, Oct 29, 2020 at 01:00:29PM +0200,

Re: [PATCH 3/9] mfd: intel_soc_pmic: remove unnecessary CONFIG_PM_SLEEP

2020-11-02 Thread Andy Shevchenko
On Mon, Nov 2, 2020 at 10:39 AM Lee Jones wrote: > On Thu, 29 Oct 2020, Andy Shevchenko wrote: > > On Thu, Oct 29, 2020 at 5:27 PM Lee Jones wrote: > > > On Thu, 29 Oct 2020, Coiby Xu wrote: > > > > On Thu, Oct 29, 2020 at 01:00:29PM +0200, Andy Shevchenko wrote: > > > > > On Thu, Oct 29, 2020

Re: [PATCH 3/9] mfd: intel_soc_pmic: remove unnecessary CONFIG_PM_SLEEP

2020-11-02 Thread Lee Jones
On Thu, 29 Oct 2020, Andy Shevchenko wrote: > On Thu, Oct 29, 2020 at 5:27 PM Lee Jones wrote: > > On Thu, 29 Oct 2020, Coiby Xu wrote: > > > On Thu, Oct 29, 2020 at 01:00:29PM +0200, Andy Shevchenko wrote: > > > > On Thu, Oct 29, 2020 at 06:06:41PM +0800, Coiby Xu wrote: > > > > >

Re: [PATCH 3/9] mfd: intel_soc_pmic: remove unnecessary CONFIG_PM_SLEEP

2020-10-30 Thread Andy Shevchenko
On Fri, Oct 30, 2020 at 4:23 PM Coiby Xu wrote: > On Thu, Oct 29, 2020 at 07:04:44PM +0200, Andy Shevchenko wrote: > >On Thu, Oct 29, 2020 at 5:27 PM Lee Jones wrote: ... > >There are pros and cons of each approach, but not above. > > > Can you elaborate on the pros and cons of each approach?

Re: [PATCH 3/9] mfd: intel_soc_pmic: remove unnecessary CONFIG_PM_SLEEP

2020-10-30 Thread Coiby Xu
On Thu, Oct 29, 2020 at 07:04:44PM +0200, Andy Shevchenko wrote: On Thu, Oct 29, 2020 at 5:27 PM Lee Jones wrote: On Thu, 29 Oct 2020, Coiby Xu wrote: > On Thu, Oct 29, 2020 at 01:00:29PM +0200, Andy Shevchenko wrote: > > On Thu, Oct 29, 2020 at 06:06:41PM +0800, Coiby Xu wrote: > > >

Re: [PATCH 3/9] mfd: intel_soc_pmic: remove unnecessary CONFIG_PM_SLEEP

2020-10-29 Thread Andy Shevchenko
On Thu, Oct 29, 2020 at 5:27 PM Lee Jones wrote: > On Thu, 29 Oct 2020, Coiby Xu wrote: > > On Thu, Oct 29, 2020 at 01:00:29PM +0200, Andy Shevchenko wrote: > > > On Thu, Oct 29, 2020 at 06:06:41PM +0800, Coiby Xu wrote: > > > > SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. >

Re: [PATCH 3/9] mfd: intel_soc_pmic: remove unnecessary CONFIG_PM_SLEEP

2020-10-29 Thread Lee Jones
On Thu, 29 Oct 2020, Coiby Xu wrote: > On Thu, Oct 29, 2020 at 01:00:29PM +0200, Andy Shevchenko wrote: > > On Thu, Oct 29, 2020 at 06:06:41PM +0800, Coiby Xu wrote: > > > SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. > > > > Have you compiled this with > > % make W=1 ...

Re: [PATCH 3/9] mfd: intel_soc_pmic: remove unnecessary CONFIG_PM_SLEEP

2020-10-29 Thread Coiby Xu
On Thu, Oct 29, 2020 at 01:00:29PM +0200, Andy Shevchenko wrote: On Thu, Oct 29, 2020 at 06:06:41PM +0800, Coiby Xu wrote: SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. Have you compiled this with % make W=1 ... ? Sorry my bad. I thought I had run "make modules"

Re: [PATCH 3/9] mfd: intel_soc_pmic: remove unnecessary CONFIG_PM_SLEEP

2020-10-29 Thread Andy Shevchenko
On Thu, Oct 29, 2020 at 06:06:41PM +0800, Coiby Xu wrote: > SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. Have you compiled this with % make W=1 ... ? -- With Best Regards, Andy Shevchenko