Re: [PATCH NAND v3] mtd: nand: Replace printk() with appropriate pr_*() macro

2018-02-22 Thread Boris Brezillon
On Thu, 22 Feb 2018 20:15:58 +0530 Shreeya Patel wrote: > On Thu, 2018-02-22 at 15:30 +0100, Richard Weinberger wrote: > > Am Donnerstag, 22. Februar 2018, 14:10:14 CET schrieb Shreeya Patel: > > > > > > @@ -438,7 +438,7 @@ static void __init doc2000_count_chips(struct > > > mtd_info > > > *mt

Re: [PATCH NAND v3] mtd: nand: Replace printk() with appropriate pr_*() macro

2018-02-22 Thread Boris Brezillon
On Thu, 22 Feb 2018 18:40:14 +0530 Shreeya Patel wrote: > The log levels embedded with the name are more concise than > printk. > Replace printks having a log level with the appropriate > pr_*macro. pr_*() macros. > Define pr_fmt() and remove other additional macros from > some of the replace

Re: [PATCH NAND v3] mtd: nand: Replace printk() with appropriate pr_*() macro

2018-02-22 Thread Boris Brezillon
On Thu, 22 Feb 2018 20:15:58 +0530 Shreeya Patel wrote: > On Thu, 2018-02-22 at 15:30 +0100, Richard Weinberger wrote: > > Am Donnerstag, 22. Februar 2018, 14:10:14 CET schrieb Shreeya Patel: > > > > > > @@ -438,7 +438,7 @@ static void __init doc2000_count_chips(struct > > > mtd_info > > > *mt

Re: [PATCH NAND v3] mtd: nand: Replace printk() with appropriate pr_*() macro

2018-02-22 Thread Shreeya Patel
On Thu, 2018-02-22 at 15:30 +0100, Richard Weinberger wrote: > Am Donnerstag, 22. Februar 2018, 14:10:14 CET schrieb Shreeya Patel: > > > > @@ -438,7 +438,7 @@ static void __init doc2000_count_chips(struct > > mtd_info > > *mtd) break; > >   } > >   doc->chips_per_floor = i; > > - printk(KER

Re: [PATCH NAND v3] mtd: nand: Replace printk() with appropriate pr_*() macro

2018-02-22 Thread Boris Brezillon
Hi Shreeya, On Thu, 22 Feb 2018 18:40:14 +0530 Shreeya Patel wrote: > diff --git a/drivers/mtd/nand/diskonchip.c b/drivers/mtd/nand/diskonchip.c > index c3aa53c..8643512 100644 > --- a/drivers/mtd/nand/diskonchip.c > +++ b/drivers/mtd/nand/diskonchip.c [...] > @@ -438,7 +438,7 @@ static void

Re: [PATCH NAND v3] mtd: nand: Replace printk() with appropriate pr_*() macro

2018-02-22 Thread Richard Weinberger
Am Donnerstag, 22. Februar 2018, 14:10:14 CET schrieb Shreeya Patel: > @@ -438,7 +438,7 @@ static void __init doc2000_count_chips(struct mtd_info > *mtd) break; > } > doc->chips_per_floor = i; > - printk(KERN_DEBUG "Detected %d chips per floor.\n", i); > + pr_debug("Detected %d

Re: [PATCH NAND v3] mtd: nand: Replace printk() with appropriate pr_*() macro

2018-02-22 Thread Shreeya Patel
On Thu, 2018-02-22 at 18:40 +0530, Shreeya Patel wrote: > The log levels embedded with the name are more concise than > printk. > Replace printks having a log level with the appropriate > pr_*macro. > Define pr_fmt() and remove other additional macros from > some of the replaced printks. > > Signe