On 18 March 2015 at 11:25, Dan Carpenter wrote:
> Could you read your patches again and find other similar white space
> issues.
Done.
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
On 18 March 2015 at 10:59, Dan Carpenter wrote:
> Call it a v2 patch. Put a note under the --- cut off line:
> v2: updated to apply to latest linux-next
>
> http://kernelnewbies.org/PatchTipsAndTricks
Since each changed patch in the resend already incorporates changes to
update to apply to the
On Wed, Mar 18, 2015 at 04:23:39PM +0300, Dan Carpenter wrote:
> > https://lkml.org/lkml/2015/3/10/685
> >
>
> You were making random white space changes and not on the same line. It
> was hard to review because you had to count how many u32 arguments there
> were (a million) and really look at
On Wed, Mar 18, 2015 at 06:36:07PM +0530, Sudip Mukherjee wrote:
> On Wed, Mar 18, 2015 at 02:25:09PM +0300, Dan Carpenter wrote:
> > On Wed, Mar 18, 2015 at 11:12:20AM +, Lorenzo Stoakes wrote:
> > > On 18 March 2015 at 10:50, Vitaly Kuznetsov wrote:
> > If it's a white space thing on the
On Wed, Mar 18, 2015 at 02:25:09PM +0300, Dan Carpenter wrote:
> On Wed, Mar 18, 2015 at 11:12:20AM +, Lorenzo Stoakes wrote:
> > On 18 March 2015 at 10:50, Vitaly Kuznetsov wrote:
> If it's a white space thing on the same line then it's generally ok to
> fix it. The "one thing per patch" is
On Wed, Mar 18, 2015 at 11:12:20AM +, Lorenzo Stoakes wrote:
> On 18 March 2015 at 10:50, Vitaly Kuznetsov wrote:
> > ERROR is reported by scripts/checkpatch.pl (spaces are missing after
> > ','). This coding style problem was there before your patch but I don't
> > think it makes sense to
On 18 March 2015 at 10:59, Dan Carpenter wrote:
> Btw, sorry for coming down hard on you. You're a newbie and expected to
> make these mistakes. Your patches are good and appreciated.
Thanks and no problem, I expect to receive robust criticism given the
high standards in the kernel and see it
On 18 March 2015 at 10:50, Vitaly Kuznetsov wrote:
> ERROR is reported by scripts/checkpatch.pl (spaces are missing after
> ','). This coding style problem was there before your patch but I don't
> think it makes sense to preserve it.
[snip]
> WARNING: please, no spaces at the start of a line
>
On Wed, Mar 18, 2015 at 10:46:52AM +, Lorenzo Stoakes wrote:
> On 18 March 2015 at 10:17, Dan Carpenter wrote:
> > Why is there a RESEND in the subject.
>
> To avoid confusion (and Sudip explicitly mentioned there might be
> some), and in addition I had to update my patch series to take into
On 18 March 2015 at 10:52, Dan Carpenter wrote:
> I often say "don't resend" because something is minor and I don't want
> to slow you down but since you were resending it anyway then please fix
> it. Also changelogs are really easy to fix. In mutt, you can do it
> without leaving your email
On Wed, Mar 18, 2015 at 10:44:53AM +, Lorenzo Stoakes wrote:
> On 18 March 2015 at 10:18, Dan Carpenter wrote:
> >>
> >> This changelog still sucks. It doesn't describe the effect of this
> >> behavior change for the user. It doesn't even make it clear that you
> >> are aware that this is a
Lorenzo Stoakes writes:
> This patch uses memset_io instead of memset when using memset on __iomem
> qualified pointers. This fixes the following sparse warnings:-
>
> drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1
> (different address spaces)
>
On 18 March 2015 at 10:17, Dan Carpenter wrote:
> Why is there a RESEND in the subject.
To avoid confusion (and Sudip explicitly mentioned there might be
some), and in addition I had to update my patch series to take into
account that it no longer applied due to another patch which applies
the
On 18 March 2015 at 10:18, Dan Carpenter wrote:
>>
>> This changelog still sucks. It doesn't describe the effect of this
>> behavior change for the user. It doesn't even make it clear that you
>> are aware that this is a behavior change.
>
> It doesn't say to me that you have asked yourself if
On Wed, Mar 18, 2015 at 01:17:17PM +0300, Dan Carpenter wrote:
> Why is there a RESEND in the subject.
>
> On Wed, Mar 18, 2015 at 08:57:22AM +, Lorenzo Stoakes wrote:
> > This patch uses memset_io instead of memset when using memset on __iomem
> > qualified pointers. This fixes the following
Why is there a RESEND in the subject.
On Wed, Mar 18, 2015 at 08:57:22AM +, Lorenzo Stoakes wrote:
> This patch uses memset_io instead of memset when using memset on __iomem
> qualified pointers. This fixes the following sparse warnings:-
>
> drivers/staging/sm750fb/sm750.c:489:17: warning:
On Wed, Mar 18, 2015 at 01:17:17PM +0300, Dan Carpenter wrote:
Why is there a RESEND in the subject.
On Wed, Mar 18, 2015 at 08:57:22AM +, Lorenzo Stoakes wrote:
This patch uses memset_io instead of memset when using memset on __iomem
qualified pointers. This fixes the following sparse
On Wed, Mar 18, 2015 at 10:46:52AM +, Lorenzo Stoakes wrote:
On 18 March 2015 at 10:17, Dan Carpenter dan.carpen...@oracle.com wrote:
Why is there a RESEND in the subject.
To avoid confusion (and Sudip explicitly mentioned there might be
some), and in addition I had to update my patch
On 18 March 2015 at 10:59, Dan Carpenter dan.carpen...@oracle.com wrote:
Btw, sorry for coming down hard on you. You're a newbie and expected to
make these mistakes. Your patches are good and appreciated.
Thanks and no problem, I expect to receive robust criticism given the
high standards in
Lorenzo Stoakes lstoa...@gmail.com writes:
This patch uses memset_io instead of memset when using memset on __iomem
qualified pointers. This fixes the following sparse warnings:-
drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1
(different address spaces)
On 18 March 2015 at 10:50, Vitaly Kuznetsov vkuzn...@redhat.com wrote:
ERROR is reported by scripts/checkpatch.pl (spaces are missing after
','). This coding style problem was there before your patch but I don't
think it makes sense to preserve it.
[snip]
WARNING: please, no spaces at the
On Wed, Mar 18, 2015 at 11:12:20AM +, Lorenzo Stoakes wrote:
On 18 March 2015 at 10:50, Vitaly Kuznetsov vkuzn...@redhat.com wrote:
ERROR is reported by scripts/checkpatch.pl (spaces are missing after
','). This coding style problem was there before your patch but I don't
think it makes
On 18 March 2015 at 10:17, Dan Carpenter dan.carpen...@oracle.com wrote:
Why is there a RESEND in the subject.
To avoid confusion (and Sudip explicitly mentioned there might be
some), and in addition I had to update my patch series to take into
account that it no longer applied due to another
On 18 March 2015 at 10:52, Dan Carpenter dan.carpen...@oracle.com wrote:
I often say don't resend because something is minor and I don't want
to slow you down but since you were resending it anyway then please fix
it. Also changelogs are really easy to fix. In mutt, you can do it
without
Why is there a RESEND in the subject.
On Wed, Mar 18, 2015 at 08:57:22AM +, Lorenzo Stoakes wrote:
This patch uses memset_io instead of memset when using memset on __iomem
qualified pointers. This fixes the following sparse warnings:-
drivers/staging/sm750fb/sm750.c:489:17: warning:
On 18 March 2015 at 10:18, Dan Carpenter dan.carpen...@oracle.com wrote:
This changelog still sucks. It doesn't describe the effect of this
behavior change for the user. It doesn't even make it clear that you
are aware that this is a behavior change.
It doesn't say to me that you have
On Wed, Mar 18, 2015 at 10:44:53AM +, Lorenzo Stoakes wrote:
On 18 March 2015 at 10:18, Dan Carpenter dan.carpen...@oracle.com wrote:
This changelog still sucks. It doesn't describe the effect of this
behavior change for the user. It doesn't even make it clear that you
are aware
On Wed, Mar 18, 2015 at 06:36:07PM +0530, Sudip Mukherjee wrote:
On Wed, Mar 18, 2015 at 02:25:09PM +0300, Dan Carpenter wrote:
On Wed, Mar 18, 2015 at 11:12:20AM +, Lorenzo Stoakes wrote:
On 18 March 2015 at 10:50, Vitaly Kuznetsov vkuzn...@redhat.com wrote:
If it's a white space
On Wed, Mar 18, 2015 at 04:23:39PM +0300, Dan Carpenter wrote:
https://lkml.org/lkml/2015/3/10/685
You were making random white space changes and not on the same line. It
was hard to review because you had to count how many u32 arguments there
were (a million) and really look at it to
On Wed, Mar 18, 2015 at 02:25:09PM +0300, Dan Carpenter wrote:
On Wed, Mar 18, 2015 at 11:12:20AM +, Lorenzo Stoakes wrote:
On 18 March 2015 at 10:50, Vitaly Kuznetsov vkuzn...@redhat.com wrote:
If it's a white space thing on the same line then it's generally ok to
fix it. The one thing
On 18 March 2015 at 10:59, Dan Carpenter dan.carpen...@oracle.com wrote:
Call it a v2 patch. Put a note under the --- cut off line:
v2: updated to apply to latest linux-next
http://kernelnewbies.org/PatchTipsAndTricks
Since each changed patch in the resend already incorporates changes to
On 18 March 2015 at 11:25, Dan Carpenter dan.carpen...@oracle.com wrote:
Could you read your patches again and find other similar white space
issues.
Done.
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
32 matches
Mail list logo
