Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions
If necessary to send patch v3 for it, please let me know (I guess not). Next, I shall try to find and make another patches for our kernel. Thanks. On 9/7/16 23:39, Chen Gang wrote: > > Thank you all for your work. Commonly, I should send patch v3 for it. > > And very sorry for replying too late. During these days I have no > enough time on it (working, buying house, and catching a cold, but I am > lucky enough that my father's health is OK). > > Thanks. > > On 9/7/16 09:52, Fengguang Wu wrote: >> Hi Andrew, >> >> On Tue, Sep 06, 2016 at 12:27:32PM -0700, Andrew Morton wrote: >>> On Sun, 4 Sep 2016 08:27:36 +0800 kbuild test robot wrote: >>> [auto build test ERROR on linus/master] [also build test ERROR on v4.8-rc4 next-20160825] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301 config: s390-default_defconfig (attached as .config) compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=s390 All errors (new ones prefixed by >>): In file included from include/linux/bitops.h:36:0, from fs/btrfs/extent_io.c:1: >> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool' static inline bool ^ arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool' static inline bool >>> >>> My s390 cross compiler doesn't like that config. Can someone test this? >> >> Tested-by: Fengguang Wu >> >> It works fine with Debian's gcc-6-s390x-linux-gnu and crosstool gcc: >> >> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/x86_64-gcc-4.9.0-nolibc_s390x-linux.tar.xz >> >>> --- a/arch/s390/include/asm/bitops.h~a >>> +++ a/arch/s390/include/asm/bitops.h >>> @@ -40,6 +40,7 @@ >>> #error only can be included directly >>> #endif >>> >>> +#include >>> #include >>> #include >>> #include >> >> Regards, >> Fengguang > -- Chen Gang (陈刚) Managing Natural Environments is the Duty of Human Beings.
Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions
Thank you all for your work. Commonly, I should send patch v3 for it. And very sorry for replying too late. During these days I have no enough time on it (working, buying house, and catching a cold, but I am lucky enough that my father's health is OK). Thanks. On 9/7/16 09:52, Fengguang Wu wrote: > Hi Andrew, > > On Tue, Sep 06, 2016 at 12:27:32PM -0700, Andrew Morton wrote: >> On Sun, 4 Sep 2016 08:27:36 +0800 kbuild test robot wrote: >> >>> [auto build test ERROR on linus/master] >>> [also build test ERROR on v4.8-rc4 next-20160825] >>> [if your patch is applied to the wrong git tree, please drop us a note to >>> help improve the system] >>> [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto >>> for convenience) to record what (public, well-known) commit your patch >>> series was built on] >>> [Check https://git-scm.com/docs/git-format-patch for more information] >>> >>> url: >>> https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301 >>> config: s390-default_defconfig (attached as .config) >>> compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609 >>> reproduce: >>> wget >>> https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross >>> -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> # save the attached .config to linux build tree >>> make.cross ARCH=s390 >>> >>> All errors (new ones prefixed by >>): >>> >>>In file included from include/linux/bitops.h:36:0, >>> from fs/btrfs/extent_io.c:1: >>> >> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool' >>> static inline bool >>> ^ >>>arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool' >>> static inline bool >> >> My s390 cross compiler doesn't like that config. Can someone test this? > > Tested-by: Fengguang Wu > > It works fine with Debian's gcc-6-s390x-linux-gnu and crosstool gcc: > > https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/x86_64-gcc-4.9.0-nolibc_s390x-linux.tar.xz > >> --- a/arch/s390/include/asm/bitops.h~a >> +++ a/arch/s390/include/asm/bitops.h >> @@ -40,6 +40,7 @@ >> #error only can be included directly >> #endif >> >> +#include >> #include >> #include >> #include > > Regards, > Fengguang -- Chen Gang (陈刚) Managing Natural Environments is the Duty of Human Beings. -- Chen Gang (陈刚) Managing Natural Environments is the Duty of Human Beings.
Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions
Hi Andrew, On Tue, Sep 06, 2016 at 12:27:32PM -0700, Andrew Morton wrote: On Sun, 4 Sep 2016 08:27:36 +0800 kbuild test robot wrote: [auto build test ERROR on linus/master] [also build test ERROR on v4.8-rc4 next-20160825] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301 config: s390-default_defconfig (attached as .config) compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=s390 All errors (new ones prefixed by >>): In file included from include/linux/bitops.h:36:0, from fs/btrfs/extent_io.c:1: >> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool' static inline bool ^ arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool' static inline bool My s390 cross compiler doesn't like that config. Can someone test this? Tested-by: Fengguang Wu It works fine with Debian's gcc-6-s390x-linux-gnu and crosstool gcc: https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/x86_64-gcc-4.9.0-nolibc_s390x-linux.tar.xz --- a/arch/s390/include/asm/bitops.h~a +++ a/arch/s390/include/asm/bitops.h @@ -40,6 +40,7 @@ #error only can be included directly #endif +#include #include #include #include Regards, Fengguang
Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions
On Sun, 4 Sep 2016 08:27:36 +0800 kbuild test robot wrote: > [auto build test ERROR on linus/master] > [also build test ERROR on v4.8-rc4 next-20160825] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for > convenience) to record what (public, well-known) commit your patch series was > built on] > [Check https://git-scm.com/docs/git-format-patch for more information] > > url: > https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301 > config: s390-default_defconfig (attached as .config) > compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609 > reproduce: > wget > https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross > -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=s390 > > All errors (new ones prefixed by >>): > >In file included from include/linux/bitops.h:36:0, > from fs/btrfs/extent_io.c:1: > >> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool' > static inline bool > ^ >arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool' > static inline bool My s390 cross compiler doesn't like that config. Can someone test this? --- a/arch/s390/include/asm/bitops.h~a +++ a/arch/s390/include/asm/bitops.h @@ -40,6 +40,7 @@ #error only can be included directly #endif +#include #include #include #include _
Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions
Hi Chen,
[auto build test ERROR on linus/master]
[also build test ERROR on v4.8-rc4 next-20160825]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
[Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for
convenience) to record what (public, well-known) commit your patch series was
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url:
https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301
config: s390-default_defconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=s390
All errors (new ones prefixed by >>):
In file included from include/linux/bitops.h:36:0,
from fs/btrfs/extent_io.c:1:
>> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool'
static inline bool
^
arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool'
static inline bool
^
arch/s390/include/asm/bitops.h:198:15: error: unknown type name 'bool'
static inline bool
^
arch/s390/include/asm/bitops.h:231:15: error: unknown type name 'bool'
static inline bool
^
arch/s390/include/asm/bitops.h:242:15: error: unknown type name 'bool'
static inline bool
^
arch/s390/include/asm/bitops.h:253:15: error: unknown type name 'bool'
static inline bool
^
arch/s390/include/asm/bitops.h:264:15: error: unknown type name 'bool'
static inline bool test_bit(unsigned long nr, const volatile unsigned long
*ptr)
^
arch/s390/include/asm/bitops.h:273:15: error: unknown type name 'bool'
static inline bool test_and_set_bit_lock(unsigned long nr,
^
arch/s390/include/asm/bitops.h:324:15: error: unknown type name 'bool'
static inline bool test_bit_inv(unsigned long nr,
^
vim +/bool +176 arch/s390/include/asm/bitops.h
170 }
171 #endif
172 mask = 1UL << (nr & (BITS_PER_LONG - 1));
173 __BITOPS_LOOP(addr, mask, __BITOPS_XOR, __BITOPS_NO_BARRIER);
174 }
175
> 176 static inline bool
177 test_and_set_bit(unsigned long nr, volatile unsigned long *ptr)
178 {
179 unsigned long *addr = __bitops_word(nr, ptr);
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: Binary data
Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions
Hi Chen,
[auto build test ERROR on linus/master]
[also build test ERROR on v4.8-rc4 next-20160825]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
[Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for
convenience) to record what (public, well-known) commit your patch series was
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url:
https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301
config: powerpc-makalu_defconfig (attached as .config)
compiler: powerpc-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
In file included from include/linux/bitops.h:36:0,
from include/linux/radix-tree.h:24,
from kernel/memremap.c:13:
>> arch/powerpc/include/asm/bitops.h:103:19: error: unknown type name 'bool'
static __inline__ bool fn(\
^
arch/powerpc/include/asm/bitops.h:123:1: note: in expansion of macro
'DEFINE_TESTOP'
DEFINE_TESTOP(test_and_set_bits, or, PPC_ATOMIC_ENTRY_BARRIER,
^
>> arch/powerpc/include/asm/bitops.h:103:19: error: unknown type name 'bool'
static __inline__ bool fn(\
^
arch/powerpc/include/asm/bitops.h:125:1: note: in expansion of macro
'DEFINE_TESTOP'
DEFINE_TESTOP(test_and_set_bits_lock, or, "",
^
>> arch/powerpc/include/asm/bitops.h:103:19: error: unknown type name 'bool'
static __inline__ bool fn(\
^
arch/powerpc/include/asm/bitops.h:127:1: note: in expansion of macro
'DEFINE_TESTOP'
DEFINE_TESTOP(test_and_clear_bits, andc, PPC_ATOMIC_ENTRY_BARRIER,
^
>> arch/powerpc/include/asm/bitops.h:103:19: error: unknown type name 'bool'
static __inline__ bool fn(\
^
arch/powerpc/include/asm/bitops.h:129:1: note: in expansion of macro
'DEFINE_TESTOP'
DEFINE_TESTOP(test_and_change_bits, xor, PPC_ATOMIC_ENTRY_BARRIER,
^
arch/powerpc/include/asm/bitops.h:132:19: error: unknown type name 'bool'
static __inline__ bool test_and_set_bit(unsigned long nr,
^
arch/powerpc/include/asm/bitops.h:138:19: error: unknown type name 'bool'
static __inline__ bool test_and_set_bit_lock(unsigned long nr,
^
arch/powerpc/include/asm/bitops.h:145:19: error: unknown type name 'bool'
static __inline__ bool test_and_clear_bit(unsigned long nr,
^
arch/powerpc/include/asm/bitops.h:151:19: error: unknown type name 'bool'
static __inline__ bool test_and_change_bit(unsigned long nr,
^
In file included from arch/powerpc/include/asm/bitops.h:157:0,
from include/linux/bitops.h:36,
from include/linux/radix-tree.h:24,
from kernel/memremap.c:13:
>> include/asm-generic/bitops/non-atomic.h:57:15: error: unknown type name
>> 'bool'
static inline bool __test_and_set_bit(int nr, volatile unsigned long *addr)
^
include/asm-generic/bitops/non-atomic.h:76:15: error: unknown type name
'bool'
static inline bool __test_and_clear_bit(int nr, volatile unsigned long
*addr)
^
include/asm-generic/bitops/non-atomic.h:87:15: error: unknown type name
'bool'
static inline bool __test_and_change_bit(int nr,
^
include/asm-generic/bitops/non-atomic.h:103:15: error: unknown type name
'bool'
static inline bool test_bit(int nr, const volatile unsigned long *addr)
^
vim +/bool +103 arch/powerpc/include/asm/bitops.h
97 change_bits(BIT_MASK(nr), addr + BIT_WORD(nr));
98 }
99
100 /* Like DEFINE_BITOP(), with changes to the arguments to 'op' and the
output
101 * operands. */
102 #define DEFINE_TESTOP(fn, op, prefix, postfix, eh) \
> 103 static __inline__ bool fn( \
104 unsigned long mask, \
105 volatile unsigned long *_p) \
106 { \
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: Binary data
Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions
Hi Chen, [auto build test WARNING on linus/master] [also build test WARNING on v4.8-rc3 next-20160825] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 4.9.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=m68k All warnings (new ones prefixed by >>): In file included from include/linux/bitops.h:36:0, from include/linux/kernel.h:10, from include/linux/list.h:8, from include/linux/module.h:9, from drivers/isdn/hardware/mISDN/hfcsusb.c:33: drivers/isdn/hardware/mISDN/hfcsusb.c: In function 'hfcusb_l2l1D': arch/m68k/include/asm/bitops.h:201:43: warning: value computed is not used [-Wunused-value] bset_mem_test_and_set_bit(nr, vaddr) : \ ^ >> drivers/isdn/hardware/mISDN/hfcsusb.c:324:5: note: in expansion of macro >> 'test_and_set_bit' test_and_set_bit(FLG_L2_ACTIVATED, ^ arch/m68k/include/asm/bitops.h:251:45: warning: value computed is not used [-Wunused-value] bclr_mem_test_and_clear_bit(nr, vaddr) : \ ^ >> drivers/isdn/hardware/mISDN/hfcsusb.c:337:3: note: in expansion of macro >> 'test_and_clear_bit' test_and_clear_bit(FLG_L2_ACTIVATED, &dch->Flags); ^ arch/m68k/include/asm/bitops.h:251:45: warning: value computed is not used [-Wunused-value] bclr_mem_test_and_clear_bit(nr, vaddr) : \ ^ drivers/isdn/hardware/mISDN/hfcsusb.c:352:4: note: in expansion of macro 'test_and_clear_bit' test_and_clear_bit(FLG_TX_BUSY, &dch->Flags); ^ drivers/isdn/hardware/mISDN/hfcsusb.c: In function 'hfc_l1callback': arch/m68k/include/asm/bitops.h:251:45: warning: value computed is not used [-Wunused-value] bclr_mem_test_and_clear_bit(nr, vaddr) : \ ^ drivers/isdn/hardware/mISDN/hfcsusb.c:401:3: note: in expansion of macro 'test_and_clear_bit' test_and_clear_bit(FLG_TX_BUSY, &dch->Flags); ^ arch/m68k/include/asm/bitops.h:201:43: warning: value computed is not used [-Wunused-value] bset_mem_test_and_set_bit(nr, vaddr) : \ ^ drivers/isdn/hardware/mISDN/hfcsusb.c:404:3: note: in expansion of macro 'test_and_set_bit' test_and_set_bit(FLG_ACTIVE, &dch->Flags); ^ arch/m68k/include/asm/bitops.h:251:45: warning: value computed is not used [-Wunused-value] bclr_mem_test_and_clear_bit(nr, vaddr) : \ ^ drivers/isdn/hardware/mISDN/hfcsusb.c:409:3: note: in expansion of macro 'test_and_clear_bit' test_and_clear_bit(FLG_ACTIVE, &dch->Flags); ^ drivers/isdn/hardware/mISDN/hfcsusb.c: In function 'open_dchannel': arch/m68k/include/asm/bitops.h:251:45: warning: value computed is not used [-Wunused-value] bclr_mem_test_and_clear_bit(nr, vaddr) : \ ^ drivers/isdn/hardware/mISDN/hfcsusb.c:436:2: note: in expansion of macro 'test_and_clear_bit' test_and_clear_bit(FLG_ACTIVE, &hw->dch.Flags); ^ arch/m68k/include/asm/bitops.h:251:45: warning: value computed is not used [-Wunused-value] bclr_mem_test_and_clear_bit(nr, vaddr) : \ ^ drivers/isdn/hardware/mISDN/hfcsusb.c:437:2: note: in expansion of macro 'test_and_clear_bit' test_and_clear_bit(FLG_ACTIVE, &hw->ech.Flags); ^ drivers/isdn/hardware/mISDN/hfcsusb.c: In function 'ph_state_nt': arch/m68k/include/asm/bitops.h:251:45: warning: value computed is not used [-Wunused-value] bclr_mem_test_and_clear_bit(nr, vaddr) : \ ^ drivers/isdn/hardware/mISDN/hfcsusb.c:641:3: note: in expansion of macro 'test_and_clear_bit' test_and_clear_bit(FLG_ACTIVE, &dch->Flags); ^ arch/m68k/include/asm/bitops.h:251:45: warning: value computed is not used [-Wunused-value] bclr_mem_test_and_clear_bit(nr, vaddr) : \ ^ drivers/isdn/hardware/mISDN/hfcsusb.c:642:3: note: in expansion o
