Re: [PATCH v2] power: supply: bq24190_charger: add support for bq24196 variant
Hi,
On Tue, Nov 13, 2018 at 01:47:53PM +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner
>
> The bq24196 is another variant of the bq24190 charger ic.
> Its register set is identical to the bq24192 and it even reuses
> the same part number (0x5).
>
> Signed-off-by: Heiko Stuebner
> ---
Thanks, queued.
-- Sebastian
> This should go on top of the bq24192 support patches from Brian Masney /
> Jonathan Marek [0]
>
> [0] https://patchwork.kernel.org/patch/10663409/
>
> changes in v2:
> - add missing compatible to dt-binding
>
> Documentation/devicetree/bindings/power/supply/bq24190.txt | 1 +
> drivers/power/supply/bq24190_charger.c | 4 +++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq24190.txt
> b/Documentation/devicetree/bindings/power/supply/bq24190.txt
> index c8ac028bd3c7..ffe2be408bb6 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq24190.txt
> +++ b/Documentation/devicetree/bindings/power/supply/bq24190.txt
> @@ -5,6 +5,7 @@ Required properties:
> * "ti,bq24190"
> * "ti,bq24192"
> * "ti,bq24192i"
> +* "ti,bq24196"
> - reg: integer, I2C address of the charger.
> - interrupts[-extended]: configuration for charger INT pin.
>
> diff --git a/drivers/power/supply/bq24190_charger.c
> b/drivers/power/supply/bq24190_charger.c
> index 4e64e6ac95c5..effa7c3c21e6 100644
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -143,7 +143,7 @@
> #define BQ24190_REG_VPRS_PN_MASK (BIT(5) | BIT(4) | BIT(3))
> #define BQ24190_REG_VPRS_PN_SHIFT3
> #define BQ24190_REG_VPRS_PN_241900x4
> -#define BQ24190_REG_VPRS_PN_241920x5 /* Also 24193 */
> +#define BQ24190_REG_VPRS_PN_241920x5 /* Also 24193,
> 24196 */
> #define BQ24190_REG_VPRS_PN_24192I 0x3
> #define BQ24190_REG_VPRS_TS_PROFILE_MASK BIT(2)
> #define BQ24190_REG_VPRS_TS_PROFILE_SHIFT2
> @@ -1973,6 +1973,7 @@ static const struct i2c_device_id bq24190_i2c_ids[] = {
> { "bq24190" },
> { "bq24192" },
> { "bq24192i" },
> + { "bq24196" },
> { },
> };
> MODULE_DEVICE_TABLE(i2c, bq24190_i2c_ids);
> @@ -1982,6 +1983,7 @@ static const struct of_device_id bq24190_of_match[] = {
> { .compatible = "ti,bq24190", },
> { .compatible = "ti,bq24192", },
> { .compatible = "ti,bq24192i", },
> + { .compatible = "ti,bq24196", },
> { },
> };
> MODULE_DEVICE_TABLE(of, bq24190_of_match);
> --
> 2.18.0
>
signature.asc
Description: PGP signature
Re: [PATCH v2] power: supply: bq24190_charger: add support for bq24196 variant
Hi,
On Tue, Nov 13, 2018 at 01:47:53PM +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner
>
> The bq24196 is another variant of the bq24190 charger ic.
> Its register set is identical to the bq24192 and it even reuses
> the same part number (0x5).
>
> Signed-off-by: Heiko Stuebner
> ---
Thanks, queued.
-- Sebastian
> This should go on top of the bq24192 support patches from Brian Masney /
> Jonathan Marek [0]
>
> [0] https://patchwork.kernel.org/patch/10663409/
>
> changes in v2:
> - add missing compatible to dt-binding
>
> Documentation/devicetree/bindings/power/supply/bq24190.txt | 1 +
> drivers/power/supply/bq24190_charger.c | 4 +++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq24190.txt
> b/Documentation/devicetree/bindings/power/supply/bq24190.txt
> index c8ac028bd3c7..ffe2be408bb6 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq24190.txt
> +++ b/Documentation/devicetree/bindings/power/supply/bq24190.txt
> @@ -5,6 +5,7 @@ Required properties:
> * "ti,bq24190"
> * "ti,bq24192"
> * "ti,bq24192i"
> +* "ti,bq24196"
> - reg: integer, I2C address of the charger.
> - interrupts[-extended]: configuration for charger INT pin.
>
> diff --git a/drivers/power/supply/bq24190_charger.c
> b/drivers/power/supply/bq24190_charger.c
> index 4e64e6ac95c5..effa7c3c21e6 100644
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -143,7 +143,7 @@
> #define BQ24190_REG_VPRS_PN_MASK (BIT(5) | BIT(4) | BIT(3))
> #define BQ24190_REG_VPRS_PN_SHIFT3
> #define BQ24190_REG_VPRS_PN_241900x4
> -#define BQ24190_REG_VPRS_PN_241920x5 /* Also 24193 */
> +#define BQ24190_REG_VPRS_PN_241920x5 /* Also 24193,
> 24196 */
> #define BQ24190_REG_VPRS_PN_24192I 0x3
> #define BQ24190_REG_VPRS_TS_PROFILE_MASK BIT(2)
> #define BQ24190_REG_VPRS_TS_PROFILE_SHIFT2
> @@ -1973,6 +1973,7 @@ static const struct i2c_device_id bq24190_i2c_ids[] = {
> { "bq24190" },
> { "bq24192" },
> { "bq24192i" },
> + { "bq24196" },
> { },
> };
> MODULE_DEVICE_TABLE(i2c, bq24190_i2c_ids);
> @@ -1982,6 +1983,7 @@ static const struct of_device_id bq24190_of_match[] = {
> { .compatible = "ti,bq24190", },
> { .compatible = "ti,bq24192", },
> { .compatible = "ti,bq24192i", },
> + { .compatible = "ti,bq24196", },
> { },
> };
> MODULE_DEVICE_TABLE(of, bq24190_of_match);
> --
> 2.18.0
>
signature.asc
Description: PGP signature
Re: [PATCH v2] power: supply: bq24190_charger: add support for bq24196 variant
Hi Sebastian,
Am Dienstag, 13. November 2018, 13:47:53 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner
>
> The bq24196 is another variant of the bq24190 charger ic.
> Its register set is identical to the bq24192 and it even reuses
> the same part number (0x5).
>
> Signed-off-by: Heiko Stuebner
any opinion on the underlying bq24192 and this bq24196 support?
It's a month now for Brian's patches and 2 weeks for my small bq24196
addition, so it would be cool to know if there needs to be done more
to get it included.
Thanks
Heiko
> ---
> This should go on top of the bq24192 support patches from Brian Masney /
> Jonathan Marek [0]
>
> [0] https://patchwork.kernel.org/patch/10663409/
>
> changes in v2:
> - add missing compatible to dt-binding
>
> Documentation/devicetree/bindings/power/supply/bq24190.txt | 1 +
> drivers/power/supply/bq24190_charger.c | 4 +++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq24190.txt
> b/Documentation/devicetree/bindings/power/supply/bq24190.txt
> index c8ac028bd3c7..ffe2be408bb6 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq24190.txt
> +++ b/Documentation/devicetree/bindings/power/supply/bq24190.txt
> @@ -5,6 +5,7 @@ Required properties:
> * "ti,bq24190"
> * "ti,bq24192"
> * "ti,bq24192i"
> +* "ti,bq24196"
> - reg: integer, I2C address of the charger.
> - interrupts[-extended]: configuration for charger INT pin.
>
> diff --git a/drivers/power/supply/bq24190_charger.c
> b/drivers/power/supply/bq24190_charger.c
> index 4e64e6ac95c5..effa7c3c21e6 100644
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -143,7 +143,7 @@
> #define BQ24190_REG_VPRS_PN_MASK (BIT(5) | BIT(4) | BIT(3))
> #define BQ24190_REG_VPRS_PN_SHIFT3
> #define BQ24190_REG_VPRS_PN_241900x4
> -#define BQ24190_REG_VPRS_PN_241920x5 /* Also 24193 */
> +#define BQ24190_REG_VPRS_PN_241920x5 /* Also 24193,
> 24196 */
> #define BQ24190_REG_VPRS_PN_24192I 0x3
> #define BQ24190_REG_VPRS_TS_PROFILE_MASK BIT(2)
> #define BQ24190_REG_VPRS_TS_PROFILE_SHIFT2
> @@ -1973,6 +1973,7 @@ static const struct i2c_device_id bq24190_i2c_ids[] = {
> { "bq24190" },
> { "bq24192" },
> { "bq24192i" },
> + { "bq24196" },
> { },
> };
> MODULE_DEVICE_TABLE(i2c, bq24190_i2c_ids);
> @@ -1982,6 +1983,7 @@ static const struct of_device_id bq24190_of_match[] = {
> { .compatible = "ti,bq24190", },
> { .compatible = "ti,bq24192", },
> { .compatible = "ti,bq24192i", },
> + { .compatible = "ti,bq24196", },
> { },
> };
> MODULE_DEVICE_TABLE(of, bq24190_of_match);
>
Re: [PATCH v2] power: supply: bq24190_charger: add support for bq24196 variant
Hi Sebastian,
Am Dienstag, 13. November 2018, 13:47:53 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner
>
> The bq24196 is another variant of the bq24190 charger ic.
> Its register set is identical to the bq24192 and it even reuses
> the same part number (0x5).
>
> Signed-off-by: Heiko Stuebner
any opinion on the underlying bq24192 and this bq24196 support?
It's a month now for Brian's patches and 2 weeks for my small bq24196
addition, so it would be cool to know if there needs to be done more
to get it included.
Thanks
Heiko
> ---
> This should go on top of the bq24192 support patches from Brian Masney /
> Jonathan Marek [0]
>
> [0] https://patchwork.kernel.org/patch/10663409/
>
> changes in v2:
> - add missing compatible to dt-binding
>
> Documentation/devicetree/bindings/power/supply/bq24190.txt | 1 +
> drivers/power/supply/bq24190_charger.c | 4 +++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq24190.txt
> b/Documentation/devicetree/bindings/power/supply/bq24190.txt
> index c8ac028bd3c7..ffe2be408bb6 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq24190.txt
> +++ b/Documentation/devicetree/bindings/power/supply/bq24190.txt
> @@ -5,6 +5,7 @@ Required properties:
> * "ti,bq24190"
> * "ti,bq24192"
> * "ti,bq24192i"
> +* "ti,bq24196"
> - reg: integer, I2C address of the charger.
> - interrupts[-extended]: configuration for charger INT pin.
>
> diff --git a/drivers/power/supply/bq24190_charger.c
> b/drivers/power/supply/bq24190_charger.c
> index 4e64e6ac95c5..effa7c3c21e6 100644
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -143,7 +143,7 @@
> #define BQ24190_REG_VPRS_PN_MASK (BIT(5) | BIT(4) | BIT(3))
> #define BQ24190_REG_VPRS_PN_SHIFT3
> #define BQ24190_REG_VPRS_PN_241900x4
> -#define BQ24190_REG_VPRS_PN_241920x5 /* Also 24193 */
> +#define BQ24190_REG_VPRS_PN_241920x5 /* Also 24193,
> 24196 */
> #define BQ24190_REG_VPRS_PN_24192I 0x3
> #define BQ24190_REG_VPRS_TS_PROFILE_MASK BIT(2)
> #define BQ24190_REG_VPRS_TS_PROFILE_SHIFT2
> @@ -1973,6 +1973,7 @@ static const struct i2c_device_id bq24190_i2c_ids[] = {
> { "bq24190" },
> { "bq24192" },
> { "bq24192i" },
> + { "bq24196" },
> { },
> };
> MODULE_DEVICE_TABLE(i2c, bq24190_i2c_ids);
> @@ -1982,6 +1983,7 @@ static const struct of_device_id bq24190_of_match[] = {
> { .compatible = "ti,bq24190", },
> { .compatible = "ti,bq24192", },
> { .compatible = "ti,bq24192i", },
> + { .compatible = "ti,bq24196", },
> { },
> };
> MODULE_DEVICE_TABLE(of, bq24190_of_match);
>
Re: [PATCH v2] power: supply: bq24190_charger: add support for bq24196 variant
On Tue, 13 Nov 2018 13:47:53 +0100, Heiko Stuebner wrote: > From: Heiko Stuebner > > The bq24196 is another variant of the bq24190 charger ic. > Its register set is identical to the bq24192 and it even reuses > the same part number (0x5). > > Signed-off-by: Heiko Stuebner > --- > This should go on top of the bq24192 support patches from Brian Masney / > Jonathan Marek [0] > > [0] https://patchwork.kernel.org/patch/10663409/ > > changes in v2: > - add missing compatible to dt-binding > > Documentation/devicetree/bindings/power/supply/bq24190.txt | 1 + > drivers/power/supply/bq24190_charger.c | 4 +++- > 2 files changed, 4 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring
Re: [PATCH v2] power: supply: bq24190_charger: add support for bq24196 variant
On Tue, 13 Nov 2018 13:47:53 +0100, Heiko Stuebner wrote: > From: Heiko Stuebner > > The bq24196 is another variant of the bq24190 charger ic. > Its register set is identical to the bq24192 and it even reuses > the same part number (0x5). > > Signed-off-by: Heiko Stuebner > --- > This should go on top of the bq24192 support patches from Brian Masney / > Jonathan Marek [0] > > [0] https://patchwork.kernel.org/patch/10663409/ > > changes in v2: > - add missing compatible to dt-binding > > Documentation/devicetree/bindings/power/supply/bq24190.txt | 1 + > drivers/power/supply/bq24190_charger.c | 4 +++- > 2 files changed, 4 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring
