Re: [PATCH v2 1/2] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel

2018-02-08 Thread Baoquan He
On 02/07/18 at 01:48pm, Eric W. Biederman wrote: > ebied...@xmission.com (Eric W. Biederman) writes: > > Now that I see that I agree in essence with this patch series. > > I don't agree with the implemenation details. > > > > Can you please split disable_IO_APIC and switch_to_legacy_irq_mode > >

Re: [PATCH v2 1/2] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel

2018-02-08 Thread Baoquan He
On 02/07/18 at 01:48pm, Eric W. Biederman wrote: > ebied...@xmission.com (Eric W. Biederman) writes: > > Now that I see that I agree in essence with this patch series. > > I don't agree with the implemenation details. > > > > Can you please split disable_IO_APIC and switch_to_legacy_irq_mode > >

Re: [PATCH v2 1/2] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel

2018-02-07 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: > ebied...@xmission.com (Eric W. Biederman) writes: > >> Baoquan He writes: >> >>> On kvm guest, kernel always prints warning during kdump kernel boots as >>> below. >>> >>> [0.001000] WARNING: CPU: 0 PID: 0 at

Re: [PATCH v2 1/2] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel

2018-02-07 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: > ebied...@xmission.com (Eric W. Biederman) writes: > >> Baoquan He writes: >> >>> On kvm guest, kernel always prints warning during kdump kernel boots as >>> below. >>> >>> [0.001000] WARNING: CPU: 0 PID: 0 at

Re: [PATCH v2 1/2] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel

2018-02-07 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: > Baoquan He writes: > >> On kvm guest, kernel always prints warning during kdump kernel boots as >> below. >> >> [0.001000] WARNING: CPU: 0 PID: 0 at arch/x86/kernel/apic/apic.c:1467 >> setup_local_APIC+0x228/0x330 >> [

Re: [PATCH v2 1/2] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel

2018-02-07 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: > Baoquan He writes: > >> On kvm guest, kernel always prints warning during kdump kernel boots as >> below. >> >> [0.001000] WARNING: CPU: 0 PID: 0 at arch/x86/kernel/apic/apic.c:1467 >> setup_local_APIC+0x228/0x330 >> [0.001000] Modules

Re: [PATCH v2 1/2] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel

2018-02-07 Thread Eric W. Biederman
Baoquan He writes: > On kvm guest, kernel always prints warning during kdump kernel boots as > below. > > [0.001000] WARNING: CPU: 0 PID: 0 at arch/x86/kernel/apic/apic.c:1467 > setup_local_APIC+0x228/0x330 > [0.001000] Modules linked in: > [0.001000] CPU: 0 PID: 0

Re: [PATCH v2 1/2] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel

2018-02-07 Thread Eric W. Biederman
Baoquan He writes: > On kvm guest, kernel always prints warning during kdump kernel boots as > below. > > [0.001000] WARNING: CPU: 0 PID: 0 at arch/x86/kernel/apic/apic.c:1467 > setup_local_APIC+0x228/0x330 > [0.001000] Modules linked in: > [0.001000] CPU: 0 PID: 0 Comm: swapper/0