Re: [PATCH v2 1/5] iommu/amd - Add debugfs support

2018-03-14 Thread Gary R Hook
On 03/14/2018 10:29 AM, Andy Shevchenko wrote: On Wed, Mar 14, 2018 at 5:24 PM, Gary R Hook wrote: On 03/13/2018 03:23 PM, Andy Shevchenko wrote: +#include +#include +#include Keep in order? What order would that be? These few needed files are listed in the same order as which they

Re: [PATCH v2 1/5] iommu/amd - Add debugfs support

2018-03-14 Thread Andy Shevchenko
On Wed, Mar 14, 2018 at 5:24 PM, Gary R Hook wrote: > On 03/13/2018 03:23 PM, Andy Shevchenko wrote: > +#include > +#include > +#include Keep in order? >>> What order would that be? These few needed files are listed in the same >>> order as which they appear in amd_iommu.c.

Re: [PATCH v2 1/5] iommu/amd - Add debugfs support

2018-03-14 Thread Gary R Hook
On 03/13/2018 03:23 PM, Andy Shevchenko wrote: On Tue, Mar 13, 2018 at 8:54 PM, Gary R Hook wrote: On 03/13/2018 12:16 PM, Andy Shevchenko wrote: On Fri, Mar 9, 2018 at 2:50 AM, Gary R Hook wrote: +#include +#include +#include Keep in order? What order would that be? These few nee

Re: [PATCH v2 1/5] iommu/amd - Add debugfs support

2018-03-13 Thread Andy Shevchenko
On Tue, Mar 13, 2018 at 8:54 PM, Gary R Hook wrote: > On 03/13/2018 12:16 PM, Andy Shevchenko wrote: >> On Fri, Mar 9, 2018 at 2:50 AM, Gary R Hook wrote: >>> +#include >>> +#include >>> +#include >> >> >> Keep in order? > What order would that be? These few needed files are listed in the sa

Re: [PATCH v2 1/5] iommu/amd - Add debugfs support

2018-03-13 Thread Gary R Hook
On 03/13/2018 12:16 PM, Andy Shevchenko wrote: On Fri, Mar 9, 2018 at 2:50 AM, Gary R Hook wrote: + default n Redundant Roger that. +#include +#include +#include Keep in order? What order would that be? These few needed files are listed in the same order as which they appear

Re: [PATCH v2 1/5] iommu/amd - Add debugfs support

2018-03-13 Thread Andy Shevchenko
On Fri, Mar 9, 2018 at 2:50 AM, Gary R Hook wrote: > + default n Redundant > +#include > +#include > +#include Keep in order? > +#include "amd_iommu_proto.h" > +#include "amd_iommu_types.h" > +/* DebugFS helpers */ > +#defineOBUFP (obuf + oboff) > +#define