Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-08-02 Thread Maxime Ripard
On Sat, Aug 02, 2014 at 10:02:08AM +0200, Wim Van Sebroeck wrote: > Maxime, All, > > > > 1) For me the discussion was not ended and needs further > > > thinking. (And I just read some good ideas about it). > > > > It would have been great for you to mention it then. > > > > > 2) You never

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-08-02 Thread Guenter Roeck
On Sat, Aug 02, 2014 at 10:02:08AM +0200, Wim Van Sebroeck wrote: > Maxime, All, > > > > 1) For me the discussion was not ended and needs further > > > thinking. (And I just read some good ideas about it). > > > > It would have been great for you to mention it then. > > > > > 2) You never

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-08-02 Thread Wim Van Sebroeck
Maxime, All, > > 1) For me the discussion was not ended and needs further > > thinking. (And I just read some good ideas about it). > > It would have been great for you to mention it then. > > > 2) You never mentioned you needed this in for 3.16 and that things > > would break because of it. >

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-08-02 Thread Wim Van Sebroeck
Maxime, All, 1) For me the discussion was not ended and needs further thinking. (And I just read some good ideas about it). It would have been great for you to mention it then. 2) You never mentioned you needed this in for 3.16 and that things would break because of it.

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-08-02 Thread Guenter Roeck
On Sat, Aug 02, 2014 at 10:02:08AM +0200, Wim Van Sebroeck wrote: Maxime, All, 1) For me the discussion was not ended and needs further thinking. (And I just read some good ideas about it). It would have been great for you to mention it then. 2) You never mentioned you needed

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-08-02 Thread Maxime Ripard
On Sat, Aug 02, 2014 at 10:02:08AM +0200, Wim Van Sebroeck wrote: Maxime, All, 1) For me the discussion was not ended and needs further thinking. (And I just read some good ideas about it). It would have been great for you to mention it then. 2) You never mentioned you needed

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-24 Thread Guenter Roeck
On 06/24/2014 07:49 AM, Maxime Ripard wrote: On Mon, Jun 23, 2014 at 11:13:24PM +0200, Wim Van Sebroeck wrote: Hi Maxime, Guenter, since you seem to be the only responsive, may I suggest that you start merging patches and do a pull request to either Wim or Linus directly during the merge

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-24 Thread Maxime Ripard
On Mon, Jun 23, 2014 at 11:13:24PM +0200, Wim Van Sebroeck wrote: > Hi Maxime, > > > > > Guenter, since you seem to be the only responsive, may I suggest that > > > > you start merging patches and do a pull request to either Wim or Linus > > > > directly during the merge window? > > > > > > > I

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-24 Thread Arnd Bergmann
On Monday 23 June 2014 14:47:48 Guenter Roeck wrote: > > To continue the discussion: I would like to add an excerpt from > > drivers/watchdog/alim7101_wdt.c > > /* > > * Notifier for system down > > */ > > > > static int wdt_notify_sys(struct notifier_block *this, > >

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-24 Thread Arnd Bergmann
On Monday 23 June 2014 14:47:48 Guenter Roeck wrote: To continue the discussion: I would like to add an excerpt from drivers/watchdog/alim7101_wdt.c /* * Notifier for system down */ static int wdt_notify_sys(struct notifier_block *this,

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-24 Thread Maxime Ripard
On Mon, Jun 23, 2014 at 11:13:24PM +0200, Wim Van Sebroeck wrote: Hi Maxime, Guenter, since you seem to be the only responsive, may I suggest that you start merging patches and do a pull request to either Wim or Linus directly during the merge window? I had prepared a pull

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-24 Thread Guenter Roeck
On 06/24/2014 07:49 AM, Maxime Ripard wrote: On Mon, Jun 23, 2014 at 11:13:24PM +0200, Wim Van Sebroeck wrote: Hi Maxime, Guenter, since you seem to be the only responsive, may I suggest that you start merging patches and do a pull request to either Wim or Linus directly during the merge

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Guenter Roeck
On 06/23/2014 02:30 PM, Wim Van Sebroeck wrote: Hi All, On Mon, Jun 23, 2014 at 07:30:56AM -0700, Guenter Roeck wrote: The patches _are_ in my watchdog-next branch and get some coverage from both my auto-builders and from Fenguang's build robots, so while they are not in linux-next, they are

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Wim Van Sebroeck
Hi All, > On Mon, Jun 23, 2014 at 07:30:56AM -0700, Guenter Roeck wrote: > > >>The patches _are_ in my watchdog-next branch and get some coverage from > > >>both my auto-builders and from Fenguang's build robots, so while they are > > >>not in linux-next, they are not completely in the dark

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Wim Van Sebroeck
Hi Alan, > On Thu, 22 May 2014 22:34:44 +0200 > Maxime Ripard wrote: > > > On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: > > > On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: > > > > On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: > > > > > On Tue,

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Wim Van Sebroeck
Hi Maxime, > > > Guenter, since you seem to be the only responsive, may I suggest that > > > you start merging patches and do a pull request to either Wim or Linus > > > directly during the merge window? > > > > > I had prepared a pull request for Wim last weekend or so, but then there > > were

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Maxime Ripard
On Mon, Jun 23, 2014 at 07:30:56AM -0700, Guenter Roeck wrote: > >>The patches _are_ in my watchdog-next branch and get some coverage from > >>both my auto-builders and from Fenguang's build robots, so while they are > >>not in linux-next, they are not completely in the dark either. > > > >So,

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Guenter Roeck
On 06/23/2014 08:35 AM, Arnd Bergmann wrote: On Monday 23 June 2014 08:16:18 Guenter Roeck wrote: Moved to where? I certainly don't want it in the platform directories, and for arm64 we intentionally don't have a place to put this stuff. I have no idea, but setting the arm reset function

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Arnd Bergmann
On Monday 23 June 2014 08:16:18 Guenter Roeck wrote: > > Moved to where? > > > > I certainly don't want it in the platform directories, and for arm64 we > > intentionally don't have a place to put this stuff. > > > > I have no idea, but setting the arm reset function pointer from a watchdog >

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Guenter Roeck
On 06/23/2014 07:42 AM, Arnd Bergmann wrote: On Monday 23 June 2014 07:30:56 Guenter Roeck wrote: On 06/23/2014 03:31 AM, Maxime Ripard wrote: On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: On Mon, May 19, 2014 at

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Arnd Bergmann
On Monday 23 June 2014 07:30:56 Guenter Roeck wrote: > On 06/23/2014 03:31 AM, Maxime Ripard wrote: > > On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: > >> On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: > >>> On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Guenter Roeck
On 06/23/2014 03:31 AM, Maxime Ripard wrote: On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Maxime Ripard
On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: > On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: > > On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: > > > On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: > > > > On Wed, May 07, 2014 at

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Guenter Roeck
On 06/23/2014 03:31 AM, Maxime Ripard wrote: On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Arnd Bergmann
On Monday 23 June 2014 07:30:56 Guenter Roeck wrote: On 06/23/2014 03:31 AM, Maxime Ripard wrote: On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote:

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Guenter Roeck
On 06/23/2014 07:42 AM, Arnd Bergmann wrote: On Monday 23 June 2014 07:30:56 Guenter Roeck wrote: On 06/23/2014 03:31 AM, Maxime Ripard wrote: On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: On Mon, May 19, 2014 at

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Arnd Bergmann
On Monday 23 June 2014 08:16:18 Guenter Roeck wrote: Moved to where? I certainly don't want it in the platform directories, and for arm64 we intentionally don't have a place to put this stuff. I have no idea, but setting the arm reset function pointer from a watchdog driver doesn't

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Guenter Roeck
On 06/23/2014 08:35 AM, Arnd Bergmann wrote: On Monday 23 June 2014 08:16:18 Guenter Roeck wrote: Moved to where? I certainly don't want it in the platform directories, and for arm64 we intentionally don't have a place to put this stuff. I have no idea, but setting the arm reset function

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Maxime Ripard
On Mon, Jun 23, 2014 at 07:30:56AM -0700, Guenter Roeck wrote: The patches _are_ in my watchdog-next branch and get some coverage from both my auto-builders and from Fenguang's build robots, so while they are not in linux-next, they are not completely in the dark either. So, this patch

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Wim Van Sebroeck
Hi Maxime, Guenter, since you seem to be the only responsive, may I suggest that you start merging patches and do a pull request to either Wim or Linus directly during the merge window? I had prepared a pull request for Wim last weekend or so, but then there were more patches

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Wim Van Sebroeck
Hi Alan, On Thu, 22 May 2014 22:34:44 +0200 Maxime Ripard maxime.rip...@free-electrons.com wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Wim Van Sebroeck
Hi All, On Mon, Jun 23, 2014 at 07:30:56AM -0700, Guenter Roeck wrote: The patches _are_ in my watchdog-next branch and get some coverage from both my auto-builders and from Fenguang's build robots, so while they are not in linux-next, they are not completely in the dark either. So,

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Guenter Roeck
On 06/23/2014 02:30 PM, Wim Van Sebroeck wrote: Hi All, On Mon, Jun 23, 2014 at 07:30:56AM -0700, Guenter Roeck wrote: The patches _are_ in my watchdog-next branch and get some coverage from both my auto-builders and from Fenguang's build robots, so while they are not in linux-next, they are

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Maxime Ripard
On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: On Wed, May 07, 2014 at 02:33:18PM

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-23 Thread Maxime Ripard
On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: > On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: > > On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: > > > On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: > > > > On Wed, May 07, 2014 at

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-23 Thread Maxime Ripard
On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: On Wed, May 07, 2014 at 02:33:18PM

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-22 Thread Guenter Roeck
On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: > On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: > > On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: > > > On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: > > > > On Tue, May 06, 2014 at

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-22 Thread Maxime Ripard
On Thu, May 22, 2014 at 09:39:43PM +0100, One Thousand Gnomes wrote: > On Thu, 22 May 2014 22:34:44 +0200 > Maxime Ripard wrote: > > > On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: > > > On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: > > > > On Wed, May 07, 2014

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-22 Thread One Thousand Gnomes
On Thu, 22 May 2014 22:34:44 +0200 Maxime Ripard wrote: > On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: > > On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: > > > On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: > > > > On Tue, May 06, 2014 at

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-22 Thread Maxime Ripard
On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: > On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: > > On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: > > > On Tue, May 06, 2014 at 09:44:19PM -0500, Maxime Ripard wrote: > > > > Most of the watchdog code

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-22 Thread Maxime Ripard
On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: On Tue, May 06, 2014 at 09:44:19PM -0500, Maxime Ripard wrote: Most of the watchdog code is

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-22 Thread One Thousand Gnomes
On Thu, 22 May 2014 22:34:44 +0200 Maxime Ripard maxime.rip...@free-electrons.com wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: On Tue,

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-22 Thread Maxime Ripard
On Thu, May 22, 2014 at 09:39:43PM +0100, One Thousand Gnomes wrote: On Thu, 22 May 2014 22:34:44 +0200 Maxime Ripard maxime.rip...@free-electrons.com wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote:

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-22 Thread Guenter Roeck
On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: On Tue, May 06, 2014 at 09:44:19PM

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-19 Thread Maxime Ripard
On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: > On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: > > On Tue, May 06, 2014 at 09:44:19PM -0500, Maxime Ripard wrote: > > > Most of the watchdog code is duplicated between the machine restart code > > > and > > > the

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-19 Thread Maxime Ripard
On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: On Tue, May 06, 2014 at 09:44:19PM -0500, Maxime Ripard wrote: Most of the watchdog code is duplicated between the machine restart code and the watchdog

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-15 Thread Maxime Ripard
On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: > On Tue, May 06, 2014 at 09:44:19PM -0500, Maxime Ripard wrote: > > Most of the watchdog code is duplicated between the machine restart code and > > the watchdog driver. Add the restart hook to the watchdog driver, to be > > able to

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-15 Thread Maxime Ripard
On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: On Tue, May 06, 2014 at 09:44:19PM -0500, Maxime Ripard wrote: Most of the watchdog code is duplicated between the machine restart code and the watchdog driver. Add the restart hook to the watchdog driver, to be able to

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-07 Thread Guenter Roeck
On Tue, May 06, 2014 at 09:44:19PM -0500, Maxime Ripard wrote: > Most of the watchdog code is duplicated between the machine restart code and > the watchdog driver. Add the restart hook to the watchdog driver, to be able > to > remove it from the machine code eventually. > > Signed-off-by:

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-07 Thread Guenter Roeck
On Tue, May 06, 2014 at 09:44:19PM -0500, Maxime Ripard wrote: Most of the watchdog code is duplicated between the machine restart code and the watchdog driver. Add the restart hook to the watchdog driver, to be able to remove it from the machine code eventually. Signed-off-by: Maxime